Commit graph

8726 commits

Author SHA1 Message Date
Benjamin Doherty
c0d77be491 Updates to archive module based on code review (#2699)
* Use common file arguments on destination file
* Rename 'compression' to 'format' h/t @abadger
* Add support for plain 'tar' format
* Ensure check_mode is respected
2016-09-13 12:40:07 -04:00
Peter Sprygada
c07516bd4b Merge pull request #2905 from privateip/asa_config
updates to asa_config module for Ansible 2.2
2016-09-13 12:07:02 -04:00
Peter Sprygada
6d56ce5120 updates to asa_config module for Ansible 2.2
* clean up functions and remove unneeded code
* config difference now includes keyword argument
* module reports changed when save argument is yes with or without check_mode
* updated fail_json return with exc kwargs
* fixed up import statements
2016-09-13 12:02:15 -04:00
Peter Sprygada
b0ae17f2c7 Merge pull request #2904 from privateip/asa_acl
fixes a number of nagging issues in asa_acl due to refactoring
2016-09-13 11:19:17 -04:00
Peter Sprygada
961d461f7b fixes a number of nagging issues in asa_acl due to refactoring
* fixes issues with import error
* removes need for filter attribute in Cli instance
* now filters config either from device or provided via config argument

ref: #2890
2016-09-13 11:03:08 -04:00
René Moser
afd0b23836 Merge pull request #2892 from resmo/fix/streamline_jenkins_job
streamline jenkins job module
2016-09-13 16:02:57 +02:00
Will Thames
1f6f3b72db firewalld should fail nicely when service is stopped (#2871)
Ensure the HAVE_FIREWALLD checks check only for the
presence of the python dependencies, and not the age
of the library or the state of the service, which
are checked later.
2016-09-12 23:57:10 +02:00
Peter Sprygada
e44376eda8 Merge pull request #2902 from privateip/asa_acl
bug fix in asa_acl module for missing candidate config
2016-09-12 17:07:28 -04:00
Peter Sprygada
0e5837a2e9 bug fix in asa_acl module for missing candidate config
This bug was introduced accidentally when refactoring to 2.2.  The instance
of the candidate config was deleted.  This adds the candidate config
instance back

fixes #2890
2016-09-12 16:48:47 -04:00
Robin Schneider
67a1bebbd3 Use addresses and names reserved for documentation (#2894)
Trying to preserve the meaning of the examples.

Related to: https://github.com/ansible/ansible/issues/17479
2016-09-12 11:27:45 +02:00
Tobias Wolf
061c6517eb Fix one character typo in my previous PR for debconf module (#2899)
Small oops in the previous PR #2530 commit.

Instead of `diff_dict` it slipped through as `diffdict`.

Please merge and sorry.
2016-09-12 10:25:28 +02:00
Rene Moser
79efc2c70f jenkins_job: refactoring 2016-09-11 00:07:38 +02:00
Rene Moser
66e69b3ad3 jenkins_job: implement diff support 2016-09-11 00:07:02 +02:00
Rene Moser
407e19fe4f jenkins_job: rename enable to enabled and mutually exclusive with config
Jenkins stores the information about the state (disabled/enabled) in the config, which result in a race condition between `config` and `enabled` and we loose idempotency. It makes sense to define them mutually exclusive.

Renamed `enable` to `enabled`. Ansible uses the name `enabled` in many modules, e.g. service as it indicates a state not an action.
2016-09-11 00:06:52 +02:00
Rene Moser
472f174693 jenkins_job: default state to present 2016-09-10 09:07:09 +02:00
Alex
eb6e0069e9 Start zypper in non-interactive mode (#2854) 2016-09-10 08:36:59 +02:00
sgujic
ac0e6d2c4d Create temporary file in a secure manner. (#2887) 2016-09-09 14:47:49 -04:00
Nils Pascal Illenseer
6c6da8f86e Delete lxd container in state stopped (#2885)
If a lxd container is stopped, do not stop it before deleting it.
2016-09-09 14:57:36 +02:00
Gilles Gagniard
f83aa9fff3 GCE : Fix image family handling with libcloud > 0.20.1 (#2289)
* fix image family handling with libcloud > 0.20.1

* add missing import
2016-09-08 15:12:20 -04:00
Robyn Bergeron
780e196c2f Updating GUIDELINES.md
Updating info on how issues are routed via bot.
2016-09-08 09:39:52 -07:00
Greg DeKoenigsberg
43860de5c6 Update MAINTAINERS.md
We could have deleted this, but just in case there are links to it from elsewhere, providing a redirect to the now authoritative GUIDELINES.md.
2016-09-08 12:36:30 -04:00
Greg DeKoenigsberg
771e438bc6 Point to GUIDELINES.md 2016-09-08 12:32:30 -04:00
johanwiren
b88fdde22c Fix share aliases logic (#2862) (#2875)
Fixes #2862
2016-09-08 18:01:27 +02:00
John R Barker
9a338b05eb Document a10_server new options (#2876)
* Document write_config and validate_certs
2016-09-08 10:54:21 +01:00
Steve Gargan
64ace27be3 correctly iterate and return results of any service checks. (#2878)
current implementation was breaking making the module unusable, changing to the list comprehension fixes this. Also default to seconds instead of throwing a exception when no duration units are supplied as this causes tests to fail
2016-09-08 07:17:56 +02:00
Matt Clay
6a7358b14e Remove stderr=False from calls to exit_json. (#2879) 2016-09-07 15:40:17 -07:00
Tim Rupp
faf8f2192d Adds bigip_ssl_certificate module (#2831)
Adds bigip_ssl_certificate module

This module is another in the ongoing "bootstrapping saga" that is
being undertaken. With this module you can manage the lifecycle of
the SSL certificates on a BIG-IP. This includes those used for
SSL offloading.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_ssl_certificate/tasks/main.yaml

Platforms this was tested on are

12.0.0
12.1.0
2016-09-07 15:34:00 +01:00
Ryan S. Brown
8bfdcfcab2 Normalize variable naming in cloudformation_facts module using camel2snake 2016-09-06 17:15:13 -04:00
Ryan S. Brown
b1a25291b5 cloudformation_facts: Connect boto3 using the module_utils AWS connection instead of calling boto3 directly 2016-09-06 17:14:54 -04:00
jmenga
1f79c357da New module cloudformation_facts (#2329) 2016-09-06 17:13:51 -04:00
Michael Scherer
1474bde864 Do not crash if the system do not have required modules (#2852) 2016-09-06 09:11:36 -04:00
Tobias Wolf
39972fa697 Add diff mode output to debconf module (#2530)
Support diff such that the previous and current settings are visible
without debug output and just with `--diff` if requested.
2016-09-05 22:06:18 +02:00
sermilrod
c848957792 adding jenkins_job module (#2521) 2016-09-05 22:04:33 +02:00
Werner Dijkerman
2214203ce0 Added new module opendj_backendprop for updating backend settings opendj (#2855)
Add opendj_backendprop
2016-09-05 19:31:09 +01:00
Peter Sprygada
d3dd754a40 Merge pull request #2848 from privateip/asa_config
update asa_config module
2016-09-04 21:00:15 -04:00
Peter Sprygada
84953d9d42 Merge pull request #2849 from privateip/asa_template
roll up of updates to asa_template
2016-09-04 20:59:58 -04:00
Peter Sprygada
1f138b6567 Merge pull request #2850 from privateip/asa_command
added new functionality to asa_command
2016-09-04 20:59:45 -04:00
Peter Sprygada
3079d6ff29 Merge pull request #2851 from privateip/asa_acl
roll up updates to asa_acl module
2016-09-04 20:59:32 -04:00
Peter Sprygada
10e8cdc93a roll up updates to asa_acl module
* remove get_module() in favor of NetworkModule
* fix up import statements
* roll up fixes for NetworkConfig object handling
2016-09-04 08:25:17 -04:00
Peter Sprygada
dc0290a067 added new functionality to asa_command
* commands argument now accepts a dict arguments
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all
2016-09-04 08:14:05 -04:00
Peter Sprygada
db5dd8516c update asa_config module
* removes get_module() factory method for NetworkModule
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge or check
* add backup argument to backup current running config to control host
* add defaults argument to control collection of config with or withoutdefaults
* add save argument to save current running config to startup config
2016-09-04 08:10:44 -04:00
Peter Sprygada
44733e3798 roll up of updates to asa_template
This updates the asa_template module with updates for Ansible 2.2.

* removes get_module() in favor of NetworkModule
* fixes up import statements
2016-09-04 07:46:28 -04:00
René Moser
7b4f78798e Merge pull request #2365 from filipenf/fix-ec2_eni
Fix the eni creation/modification logic thus making it idempotent
2016-09-04 09:56:03 +02:00
Thierno IB. BARRY
5c3be5ea28 elasticsearch_plugin: Fix bug when using proxy (#2603) (#2838) 2016-09-04 09:47:02 +02:00
Nadir
e6678a7496 Added redrive policy options (#2245) 2016-09-04 09:45:35 +02:00
Robin Roth
06bd2a5ce2 Zypper repo autoimport keys (#2132)
* zypper_repository add auto_import_keys options

* also give more output on failure (rc, stdout, stderr)

* be more specific in the doc for auto_import_keys

* add runrefresh option to zypper_repository

* this comes out of ansible/ansible-modules-extras#2411, where AnderEnder adds refresh to the zypper module
* adds a way to force zypper to refresh a repository
* can be used to refresh independently of auto_import_keys
* add option to run name=* runrefresh=yes
* name runrefresh to not break existing use to refresh (now alias to autorefresh)
* add version_added flag to autorefresh

* remove wrong version_added comment
2016-09-04 08:20:10 +02:00
EarlAbides
9278cce7d2 Fix ec2_asg_facts module when using name parameter (#2840) (#2841) 2016-09-03 09:23:09 +02:00
Tim Rupp
e81bbf9b8f Bugfix bigip_facts that was trying to check the length of an iterator (#2842)
Recently, a user reported that the bigip_facts module was failing with the error

    received exception: object of type 'itertools.imap' has no len()

This reported was occurring at line 1657 of the bigip_facts module

bug report is here

https://github.com/F5Networks/f5-ansible/issues/25

Upon further investigation, the map function for returning the specified
includes was returning an iterator, and calling len() on an iterator does
not work.

I believe this problem was caused by part of the Python 3.x effort insofar
as the inclusion of this line

https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/basic.py#L143

seems to affect our usage of map(), probably for the better anyway, and we need
to change our expectations in our module's code to no longer assume a list, but
instead assume an iterator.

After trawling through the module_utils/basic code, I think a list
comprehension is more appropriate here anyway, so I'm changing it to be
that. The affected user reported it works this way, and my own testing
on 2.2.0 supports that.
2016-09-02 23:07:32 -07:00
Kevin Hulquest
ab7391ff14 Add facts and storage system modules. (#2748)
* Add facts and storage system modules.

* Update version metadata.

* Add facts and storage system modules.

Update version metadata.

Add init files.

* Fixes for review comments.

* Fixes for review comments.

* Update document fragments for api_* options to indicate they are required.

* Correct bad string concatenation.

* Add option description for validate_certs since basic_auth arg_spec is no longer extended.

* Add default value for validate_certs in docstring.

* Rename directory name so it applies to netapp and not simply eseries platform.

* Rename modules to differentiate other netapp modules.
2016-09-02 07:34:04 -07:00
Robin Roth
64879e5eb5 Ensure the return value for changed is bool (#2830)
fixes #2827
2016-09-02 07:08:08 +02:00