Commit graph

5840 commits

Author SHA1 Message Date
Will Thames
c956c65731 Usage is not a valid database or table privilege
Remove `USAGE` from the `VALID_PRIVS` dict for both database and
table because it is not a valid privilege for either (and
breaks the implementation of `has_table_privilege` and
`has_database_privilege`

See http://www.postgresql.org/docs/9.0/static/sql-grant.html
2015-04-08 13:00:50 +10:00
Will Thames
7d66da35a7 Perform privilege grants/revokes only when required
Use `has_table_privileges` and `has_database_privileges`
to test whether a user already has a privilege before
granting it, or whether a user doesn't have  a privilege
before revoking it.
2015-04-08 12:48:45 +10:00
Will Thames
b4515c8909 Update postgresql users only when necessary
For read-only databases, users should not change when no changes
are required.

Don't issue ALTER ROLE when role attribute flags, users password
or expiry time is not changing.

In certain cases (hashed passwords in the DB, but the password
argument is not hashed) passlib.hash is required to avoid
running ALTER ROLE.
2015-04-08 11:17:11 +10:00
Brian Coca
5f58240d17 Merge pull request #1093 from kylejohnson/rds-subnet-group-typo-1092
Fix typo in rds_subnet_group.py.  Fixes #1092
2015-04-06 21:17:29 -04:00
James Cammarata
4558cb71f4 Merge branch 'osx_user_fix' of https://github.com/bambou42/ansible-modules-core into bambou42-osx_user_fix
Includes commits for:
* Don't return change if the password is not set
* Set the group to nogroup if none is specified
* Set an uid if none is specified
* Test if SHADOWFILE is set (for Darwin)
* remove unused uid
2015-04-06 13:05:11 -05:00
James Cammarata
d09d78e7be Merge pull request #1070 from ktdreyer/rhsm/activationkey-args
redhat_subscription: fix activationkeys argument
2015-04-06 10:03:46 -05:00
Kyle Johnson
86ed1cd0a9 Fix typo in rds_subnet_group.py
aws_connection_kwargs should be aws_connect_kwargs
2015-04-06 10:00:17 -04:00
Sam Kottler
7e1d63136f Merge pull request #998 from linefeedse/digitalocean-user-data
DigitalOcean API version 2 with user_data option
2015-04-05 15:26:54 -04:00
Brian Coca
4d9ce9cf2c Merge pull request #1032 from jder/fix-rds-vpc-groups
Update rds module for RDS2 parameter name change.
2015-04-03 20:24:33 -04:00
Brian Coca
9b5e8e36a9 Merge pull request #1079 from sivel/gc-storage-no-dict-comp
gc_storage: Don't use a dict comprehension
2015-04-03 17:44:34 -04:00
Matt Martz
1e94fc5ab5 Don't use a dict comprehension, be more verbose 2015-04-03 16:35:16 -05:00
Brian Coca
de4c7f8ba6 switched to use python's built in os.separator vs using / 2015-04-03 09:06:58 -04:00
Brian Coca
c01a18d5ca minor docfixes 2015-04-02 21:07:41 -04:00
Brian Coca
eed47383e4 Merge pull request #1040 from emonty/feature/os_auth
Add OpenStack Auth module
2015-04-02 20:51:53 -04:00
Ken Dreyer
bd617353cb redhat_subscription: fix activationkeys argument
Prior to this commit, Ansible would pass '--activationkeys <value>' as a
literal string, which the remote server would interpret as a single
argument to subscription-manager.

This led to the following failure message when using an activation key:

  subscription-manager: error: no such option: --activationkey "mykey"

Update the arguments so that the remote server will properly interpret
them as two separate values.
2015-04-02 14:21:20 -06:00
Jesse Rusak
030703f4ca Update rds module for RDS2 parameter name change.
boto's rds2 renamed `vpc_security_groups` to `vpc_security_group_ids`
and changed from a list of `VPCSecurityGroupMembership` to just a
list of ids. This accommodates that change when rds2 is being used.
2015-04-02 15:32:12 -04:00
Toshio Kuratomi
04c34cfa02 Merge pull request #1062 from steenzout/devel
issue #994: use HAS_BOTO to determine if import was successful
2015-04-02 10:07:12 -07:00
steenzout
d960dc1584 issue #994: use HAS_BOTO to determine if import was successful:
- removed import of sys module.
- HAS_BOTO constant to check if import was successful.
- trigger a failure when import fails.
- removed unnecessary imports.
2015-04-01 17:31:10 -06:00
Eric Johnson
07a694647b Merge pull request #1010 from richtier/gc_storage_upload_headers
gc_storage allow setting headers
2015-04-01 13:32:22 -07:00
Richard Tier
9aa8879f0f added version to docstring 2015-04-01 21:01:00 +01:00
Toshio Kuratomi
16ece8f87c Merge pull request #1039 from smashwilson/docker-facts
[docker] Record facts containing each changed container.
2015-04-01 10:23:30 -07:00
Monty Taylor
faf5106b7e Merge pull request #1050 from ansible/revert-1049-feature/os_router_gateway
Revert "Add OpenStack Router Gateway module"
2015-03-31 19:48:43 -04:00
Monty Taylor
5f40922505 Revert "Add OpenStack Router Gateway module" 2015-03-31 19:47:56 -04:00
Monty Taylor
e6be0aa0f6 Merge pull request #1049 from emonty/feature/os_router_gateway
Add OpenStack Router Gateway module
2015-03-31 19:47:48 -04:00
Monty Taylor
385869e86a Add OpenStack Router Gateway module
Also deprecate old quantum_router_gateway module
2015-03-31 19:39:09 -04:00
Monty Taylor
c9f1e441f5 Add OpenStack Auth module
Use this to pre-auth or to get a copy of the service catalog.
2015-03-31 19:32:05 -04:00
Ash Wilson
45b067f097 Record facts for each changed container. 2015-03-31 16:14:16 -04:00
Brian Coca
6e373ace86 corrected version added 2015-03-31 15:31:54 -04:00
Brian Coca
c4a22478c4 Merge pull request #830 from BlackMesh/devel
mysql_user #829: add update_password to mysql_user
2015-03-31 15:28:31 -04:00
Brian Coca
e6e3ade6fa added support for postgres9.4 which is now available from amazon 2015-03-31 11:46:54 -04:00
Brian Coca
613961c592 really fixed docs this time 2015-03-31 09:15:20 -04:00
Brian Coca
99391f861d fixed doc issues on cloudformation 2015-03-31 09:09:43 -04:00
Brian Coca
bdef699596 Merge pull request #999 from DavidWittman/service-upstart-bug
[service] Fix bug with upstart detection
2015-03-30 19:14:35 -04:00
Brian Coca
bbb0a38fa3 Merge pull request #957 from stansonhealth/devel
postgres_user: skip password changes so pg_authid isn't needed
2015-03-30 18:53:11 -04:00
tedder
bffd137edd code review fixes per #957 2015-03-30 15:51:54 -07:00
tedder
472331a53b skip password changes so pg_authid isn't needed
Some places ([AWS RDS](https://forums.aws.amazon.com/thread.jspa?threadID=151248)) don't have, or don't allow, access to the `pg_authid` table. The only reason that is necessary is to check for a password change.

This flag is a workaround so passwords can only be set at creation time. It isn't as elegant as changing the password down the line, but it fixes the longstanding issue #297 that prevented this from being useful on AWS RDS.
2015-03-30 13:35:54 -07:00
Brian Coca
3738339b90 Merge pull request #366 from Rob-Johnson/cloudformation-url
cloudformation: allow template_url parameter
2015-03-30 10:28:36 -04:00
Rob Johnson
ea1ffc6d19 allow both template and template_url parameters 2015-03-30 15:27:03 +01:00
Brian Coca
d27df0cdb4 Merge pull request #334 from adamchainz/cloudformation_dont_always_need_template
Make cloudformation module's template argument not required in case of stack deletion
2015-03-30 08:56:56 -04:00
Brian Coca
1865ddbbdf Merge pull request #339 from lorin/instance_id
ec2 module: add instance_id alias
2015-03-30 08:49:07 -04:00
Brian Coca
e94956d39d Merge pull request #1029 from 47lining/sts_support_s3_fix_v3
clean rebase of https://github.com/ansible/ansible-modules-core/pull/102...
2015-03-30 08:48:20 -04:00
Brian Coca
66a996184e Merge pull request #1011 from zecrazytux/bugreport_265
Add body_format for handling of JSON and YAML body
2015-03-30 07:35:17 -04:00
Sébastien Bocahu
b2d570e991 Removes YAML body_format option
It would require adding a dependency to the YAML module while it might
not provide much benefit (has anybody seen a HTTP API taking YAML as
input ?)
2015-03-30 10:23:46 +02:00
Mick Bass
7de97864be clean rebase of https://github.com/ansible/ansible-modules-core/pull/1024 on a new branch 2015-03-29 21:56:44 -06:00
Brian Coca
8c80900fef removed requirements/boto as it broke documentation as it is duplicated in shared aws fragements 2015-03-29 17:08:08 -04:00
Brian Coca
e8f56bb627 Merge pull request #1027 from apollo13/patch-1
Added os.path.expanduser when searching for pip executable.
2015-03-29 16:14:00 -04:00
Florian Apolloner
afd0b3fcaa Added os.path.expanduser to app_path in django_manage 2015-03-29 21:34:29 +02:00
Florian Apolloner
7f4f89abda Added os.path.expanduser when searching for pip executable. 2015-03-29 21:06:36 +02:00
Brian Coca
adfcfa4b58 Merge pull request #318 from preo/ec2-group-empty-rules
Allow empty EC2 Security Group rules.
2015-03-29 10:26:33 -04:00
Brian Coca
feb5144c71 Merge pull request #1021 from defionscode/s3_conn
allow boto profile use with s3
2015-03-29 10:08:54 -04:00