Commit graph

5206 commits

Author SHA1 Message Date
Michael DeHaan
ce142be1e0 Merge pull request #3027 from sergevanginderachter/verbose_always_tag_cli
hide magic variables used bin/ansible output
2013-05-27 08:05:25 -07:00
Serge van Ginderachter
dd9919342b hide magic variables used bin/ansible output
'verbose_override' and 'verbose_always'
2013-05-27 14:42:55 +02:00
Michael DeHaan
3a635d2d26 Lots of formatting fixes 2013-05-24 23:46:23 -04:00
Michael DeHaan
9c5d6f11f0 Fix tabs and spaces in OpenStack modules. 2013-05-24 23:34:48 -04:00
Michael DeHaan
e5c2d0b247 update changelog 2013-05-24 23:19:59 -04:00
Michael DeHaan
11792a9daa Merge pull request #2987 from kentfrazier/sudo_user
Fix bug with include-level vars and sudo_user.
2013-05-24 20:08:04 -07:00
Michael DeHaan
b499f0754e Merge pull request #2986 from wbowling/devel
Fixes apt_repository always reporting file uri repos as changed
2013-05-24 20:07:03 -07:00
Michael DeHaan
82909179a0 Merge pull request #2976 from stoned/pip-virtualenv_command-pathname
Allow virtualenv_command argument of the pip module to be a pathname
2013-05-24 20:01:12 -07:00
Michael DeHaan
698b2fe9c5 Merge pull request #2992 from SirScott/service_pattern
Fixes #2991: Service module pattern argument ignored.
2013-05-24 19:58:42 -07:00
Michael DeHaan
84623441e1 Merge pull request #2945 from jsmartin/new_fetch
Fetch destination path can now be overriden.
2013-05-24 19:57:19 -07:00
Michael DeHaan
4fc6be8579 Merge pull request #2993 from SirScott/pkgng
Make pkgng and with_items result in a single module call.
2013-05-24 19:55:56 -07:00
Michael DeHaan
e68894ea45 Merge pull request #2975 from stoned/doc-pip-fix
Fix pip module documentation (YAML quoting)
2013-05-24 19:55:14 -07:00
Michael DeHaan
4b988dbd43 Merge pull request #2978 from bryanlarsen/basename
add basename and dirname to the core jinja2 filters
2013-05-24 19:54:36 -07:00
Michael DeHaan
27236cf598 Merge pull request #2998 from SirScott/runner-permissions
Ensure the tmp_path is sufficiently open.
2013-05-24 19:52:23 -07:00
Michael DeHaan
e3af9258ae Merge pull request #2995 from SirScott/pip-sudo-user
pip module -- sudo_user permission problem fix
2013-05-24 19:51:38 -07:00
Michael DeHaan
c397969ca3 Merge pull request #3001 from SirScott/user-always-changing
Fixes #2924: User creation always reports 'changed'
2013-05-24 19:50:48 -07:00
Michael DeHaan
159ba7d68a Merge pull request #2956 from akerl/unicodefix
ignore unicode errors in stdout
2013-05-24 19:46:25 -07:00
Michael DeHaan
9d92125a93 Merge pull request #2989 from lorin/keystone_user
OpenStack Identity (keystone) user module
2013-05-24 19:39:52 -07:00
Michael DeHaan
6ed01d2d9c Merge pull request #2985 from bennojoy/devel
OpenStack Modules
2013-05-24 19:38:19 -07:00
Michael DeHaan
2459255739 Merge pull request #3016 from bpennypacker/airbrake_deployment
new airbrake_deployment module
2013-05-24 19:37:49 -07:00
Michael DeHaan
98a4331107 Merge pull request #2999 from ngrilly/python
Python
2013-05-24 19:36:47 -07:00
Michael DeHaan
5fdca267ac Merge pull request #3018 from dsedivec/devel
Plug-ins loaded from top-level plug-in directory
2013-05-24 18:58:00 -07:00
Michael DeHaan
fd9bbeb4f3 Merge pull request #3019 from sergevanginderachter/debug-allways-verbose
Make debug module always verbose in playbooks
2013-05-24 18:55:10 -07:00
Serge van Ginderachter
94028852d9 Make debug module always verbose in playbooks
Created a new flag 'verbose_always' handled by
on_ok callback, similar to the 'verbose_override'
flag used by the setup module.
2013-05-25 00:27:23 +02:00
Dale Sedivec
611d56dc4c Plug-ins loaded from top-level plug-in directory
PluginLoader._get_paths, as of 391fb98e, was only finding plug-ins that
were in a subdirectory of one of the basedirs (i.e. in a category
directory).  For example, action_plugins/foo.py would never be loaded,
but action_plugins/bar/foo.py would work.

This makes it so that "uncategorized" plug-ins in the top level of a
directory such as action_plugins will be loaded, though plug-ins in a
"category" subdirectory will still be preferred.  For example,
action_plugins/bar/foo.py would be preferred over action_plugins/foo.py.
2013-05-24 17:05:28 -05:00
Bruce Pennypacker
fceaca4a53 new airbrake_deployment module 2013-05-24 14:40:37 -04:00
Michael DeHaan
1d3782cfc7 Merge pull request #3006 from stoned/doc-fix-npm
Fix typo in npm module documentation preventing it to be processed by an...
2013-05-23 18:08:58 -07:00
Michael DeHaan
5c5b2204ac Merge pull request #3007 from stoned/doc-fix-git
Fix typo in git module documentation preventing it to be processed by an...
2013-05-23 18:08:15 -07:00
Stoned Elipot
c9f268ac48 Fix typo in git module documentation preventing it to be processed by ansible-doc 2013-05-24 01:33:47 +02:00
Stoned Elipot
81e0a7adcc Fix typo in npm module documentation preventing it to be processed by ansible-doc 2013-05-24 01:27:46 +02:00
Scott Sturdivant
922a1efbc0 Fixes #2924: User creation always reports 'changed' 2013-05-23 13:43:23 -06:00
Scott Sturdivant
5516ece859 Ensure the tmp_path is sufficiently open. 2013-05-23 12:13:09 -06:00
Nicolas Grilly
7aee588918 Idiomatic Python: use in operator instead of method find 2013-05-23 20:12:43 +02:00
Nicolas Grilly
7babd30cf7 Idiomatic Python: use isinstance instead of type 2013-05-23 20:12:43 +02:00
James Martin
3c131dbd2b Initial Commit. 2013-05-23 13:33:36 -04:00
Scott Sturdivant
b2542bff72 Chdir to tempdir to prevent permissions problems. 2013-05-23 10:56:52 -06:00
Scott Sturdivant
d91bc1692e Make pkgng and with_items result in a single module call. 2013-05-23 09:43:38 -06:00
Scott Sturdivant
b274fb9774 Fixes #2991: Service module pattern argument ignored. 2013-05-23 09:39:26 -06:00
Lorin Hochstein
dbd9d92861 OpenStack Identity (keystone) user module
Module for managing users, tenants, and roles within OpenStack.
2013-05-23 10:35:27 -04:00
Kent Frazier
4c6583bd00 Fix bug with include-level vars and sudo_user.
If a variable was provided for an include, in either of these ways:

    ---
    - hosts: all
      tasks:
      - include: included.yml param=www-data
      - include: included.yml
        vars:
          param: www-data

and then that param was used as the value of sudo_user in the included
tasks:

    ---
    - name: do something as a parameterized sudo_user
      command: whoami
      sudo: yes
      sudo_user: $param

you would receive a "failed to parse: usage: sudo" error back and the
command would not execute.

This seemed to be due to a missing call to template.template somewhere,
because the final value being passed through ssh was still `$param`.
After some digging, the issue seems to instead have been a problem with
providing the wrong context to the template for expansion. Inside the
`Task` logic, it was passing `play.vars` as the context, where
`module_vars` seemed more appropriate. After replacing it, my test case
above ran without issue. There was a comment above suggesting that the
template call might be unnecessary, but removing it made the original
error return, since it is not getting escaped later down the line. I
removed the comment since it was inaccurate.

I tried to actually incorporate my test case above into the test suite
as a regression test, but was unable to figure out how to structure it.
The existing test infrastructure seemed to only be testing for correct
number of counts in things (ok vs. changed, etc.), without regard for
whether the content generated by the command is correct. If there is an
example of a test similar to this one (where I would want to check the
JSON generated to make sure sudo_user had been converted), please let me
know and I will be happy to submit an additional patch.
2013-05-23 00:05:11 -05:00
William Bowling
222f004bfa Fixes apt_repository always reporting file uri repos as changed 2013-05-23 12:39:22 +10:00
bennojoy
b16e2a1d48 OpenStack Modules 2013-05-23 07:55:05 +05:30
Bryan Larsen
f629baef11 add basename and dirname to the core jinja2 filters 2013-05-22 14:06:18 -04:00
Stoned Elipot
d4d0753e03 Allow virtualenv_command argument of the pip module to be a pathname 2013-05-22 18:15:21 +02:00
Stoned Elipot
83cce7d2e0 Fix pip module documentation (YAML quoting) 2013-05-22 18:09:01 +02:00
Michael DeHaan
8f3b2b281f Merge pull request #2967 from jonEbird/devel
Inventory script for Spacewalk servers based on the spacewalk-reports pa...
2013-05-22 05:34:26 -07:00
Jon Miller
dc8feb799c Do not need to chmod cache file each time
This is particularly important if you've manually ensured you have write
access via group permissions and not by owner.
2013-05-21 14:44:00 -07:00
Michael DeHaan
aecc954aa4 Merge pull request #2965 from bpennypacker/devel
newrelic_deployment bug fix to support both python 2.4 and 2.6
2013-05-21 13:59:06 -07:00
Jon Miller
5111e0c2f7 Inventory script for Spacewalk servers based on the spacewalk-reports package 2013-05-21 12:40:26 -07:00
Bruce Pennypacker
d4429fcb91 Fixed handling of urlopen result to work properly under both python 2.4 and python 2.6 2013-05-21 13:59:42 -04:00