Commit graph

29369 commits

Author SHA1 Message Date
Martin Nečas
aa0d4ef4ab ovirt_template remove unnecessary ret (#63382) 2019-10-14 07:16:34 -04:00
Andrey Klychkov
0ca682384d mysql_variables: add seealso, add return value (#63442) 2019-10-14 09:28:00 +01:00
Felix Fontein
d753168e9d
docker_node_info: improve error handling (#63418)
* Improve error handling for get_service_inspect().

* Add changelog fragment.
2019-10-13 14:16:02 +02:00
Felix Fontein
7f643690c7 docker modules: improve return value list documentation (#63145)
* Improve type documentation.

* Also improve return values.
2019-10-12 15:08:20 -04:00
zhongjun2
6170f3a6f6 Add route module (#60189)
* Add route module

* Update hwc_vpc_route.py

* Update hwc_vpc_route.py

* Update hwc_vpc_route.py

* Update main.yml

* Update hwc_vpc_route.py

* Update hwc_vpc_route.py

* Update hwc.py

* Update hwc_vpc_route.py
2019-10-12 18:15:02 +02:00
Felix Fontein
61b3784131 docker_image: fix option parameter so that warnings are issued (#63345)
* Fix option parameter so that warnings are issued.

* Add changelog.
2019-10-12 08:09:03 -04:00
yanzhangi
d4bbb8e2b8 Update ce_facts to fix bugs (#63331) 2019-10-11 21:11:22 -04:00
Felix Fontein
054285c34c crypto modules: improve return value list documentation (#62929)
* Improve return value documentation by allowing entry for return values.
* Add docs formatting, adjust styling.
* Fix sample return value. (Taken from https://tools.ietf.org/html/rfc7517#appendix-A.1.)
* Work around abuse of .
2019-10-11 13:59:15 -05:00
Roman
504d76e956 acl: fix module failure if there're spaces in a path (#63280)
* Make acl module to work with whitespaces in path

* Added a changelog fragment

* Add quotes to changelog fragment
2019-10-11 10:40:19 -07:00
Benjamin Brabant
29939383e6 Improve ecs_ecr module to handle image_tag_mutability feature (#62871)
Since 2019 jul. 26, AWS Elastic Container Registry can be configured to be immutable that prevent overwritting of an existing tag in the registry.
https://aws.amazon.com/fr/about-aws/whats-new/2019/07/amazon-ecr-now-supports-immutable-image-tags/
https://docs.aws.amazon.com/AmazonECR/latest/userguide/image-tag-mutability.html

By default, ecr is created MUTABLE, as this was the only option before this feature.
This module leverage new capabilities of boto3 to configure image_tag_mutability option.
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ecr.html#ECR.Client.put_image_tag_mutability

The image_tag_mutability option definition was inspired by existing terraform module.
https://www.terraform.io/docs/providers/aws/r/ecr_repository.html
2019-10-11 09:13:13 -07:00
tacatac
df283788e5 Nosh module documentation update (#63303)
* detail the 'status' dictionary
* did not add individual descriptions, see nosh documentation for those
* sample: False not being rendered unless 'False' is quoted
2019-10-11 11:07:53 -05:00
Matt Martz
7f4befdea7
Wrap CLI Passwords with AnsibleUnsafeText, ensure unsafe context is not lost during encode/decode (#63351)
* Wrap .encode and .decode on AnsibleUnsafe objects

* runme.sh needs to be executable

* ci_complete

* Update changelog with CVE
2019-10-11 09:17:10 -05:00
Xu Yuandong
b7f12f9ff3 ce_netstream_global: bugs fix(list index out of range) (#63332)
* update to fix bugs:index out of range

* list index out of range

* list index out of range

* update for bad-whitespace

* Update ce_netstream_aging.py

* Update ce_netstream_aging.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_template.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_template.py

* Update ce_netstream_aging.py
2019-10-11 07:09:53 -04:00
Jacob Snapp
79ab8cb48d enabled check mode on nxos bgp modules (#57360)
* enabled check mode on nxos bgp modules

* fixed indentation

* spaces instead of tabs
2019-10-11 11:50:40 +05:30
Adam Miller
aaef214a26 adapt to firewalld 0.7.0 for RHEL 8.1 Beta, Fedora 31+ (#63357)
Fixes #63254

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-10-10 18:33:18 -04:00
James Cassell
bfd32c9b00 clean "changed" only after it has been processed (#59958)
* clean "changed" after it has been processed

without this change, a loop of `debug` tasks with `changed_when`
causes the "changed" status to get lost before output

* runme.sh tests for debug loop status
2019-10-10 18:24:31 -04:00
Abhijeet Kasurde
35cc228b3b VMware: name is not required parameter for vmware_guest_custom_attributes
Fixes: #63222

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-10-10 17:25:20 -04:00
ocarli
b3deab4319 Update sros_config.py (#63132) 2019-10-10 16:56:08 -04:00
ののし
6ff5968781 fix aruba_config examples (#63136) 2019-10-10 16:41:03 -04:00
Prasad Katti
32980f214a [ec2_launch_template] Update examples (#63152)
- Update tasks names for existing examples
- Add a new example showing how to delete a launch template
2019-10-10 16:36:56 -04:00
Jian Fang
719170e5c1 Update ec2.py (#63260)
Change the explanation of spot_wait_timeout
2019-10-10 16:34:22 -04:00
Matt Davis
6d52bdf4db
fix default collection resolution in adhoc (#63298)
* fix default collection resolution in adhoc

* if an adhoc command is run with a playbook-dir under a configured collection, default collection resolution is used to resolve unqualified module/action names

* Set ANSIBLE_PLAYBOOK_DIR in integration tests.

* Fix config conflict in ansible integration test.

* add adhoc default collection test

* text-ify warning string
2019-10-10 12:42:03 -07:00
Matt Davis
b20a0f4831
text-ify config warning message (#63349) 2019-10-10 11:31:54 -07:00
Pavan Bidkar
904e8434db VMware: Add support to delete vm from inventory (#62903)
Fixes: #55572
2019-10-10 17:07:23 +05:30
Andrey Klychkov
3e87429365 mysql_replication: add support of resetmaster choice to mode parameter (#63321) 2019-10-10 13:02:57 +02:00
René Moser
64a66f566d
doc: mysql_info: add changelog and version_added for global_status (#63328) 2019-10-10 13:01:02 +02:00
JayalakshmiV
45acdb41d2 Added Exos vlan resource module (#61865)
* EXOS_VLAN resource module

* EXOS_VLAN resource module

* EXOS_VLAN resource module

* EXOS_VLAN resource module

* EXOS_VLAN resource module

* Fix exos_vlans resource module and integration test

* Move exos_vlan folder to exos_vlans folder

* Fix exos->config->vlans and exos->utils

* Fix version_added

* Improve exos_vlans module and integration tests

* Fix exos_vlans.py

* exos_vlan resource module
2019-10-10 06:50:04 -04:00
Yap Sok Ann
eca33b80f0 mysql_info: add support for global status (#63189)
Signed-off-by: Yap Sok Ann <sokann@gmail.com>
2019-10-10 12:14:49 +02:00
Ondra Machacek
f2e5e6de23 ovirt_vm: Fix getting console parameter (#63325)
Previously if the ovirt_vm module was executed without graphical_console
parameter, the task failed with "NoneType has no attribute 'get'". The
problem was that we obtained the graphical_console by
self.param('graphical_console', dict()), which returned None, in case
graphical_console is not passed instead of empty dict. So we must
change the line to self.param('graphical_console') or dict().
2019-10-10 04:32:00 -04:00
Andrey Klychkov
38d1025d58 mysql_replication: add mutually_excl block, new maintainer, seealso, change doc formatting (#63295) 2019-10-10 03:06:45 -04:00
Matt Davis
77de663879
config encode errors should not be fatal (#63311)
* fixes #63310
* subset of fixes from #58638
* added warning on error
2019-10-09 17:08:29 -07:00
Sam Doran
9d014778ad
cronvar - use correct binary name (#63279)
Fixes regression introduced by #62554
Add integration tests for cronvar
2019-10-09 18:33:25 -04:00
Adrian Likins
ed203c5902 Fix galaxy url use everywhere when url is set in config. (#63286)
In addition to trying the configured url (for ex, a migrated
'https://galaxy.ansible.com/') there is an attempt at that
URL with '/api' postpended.

If the extended URL works, update GalaxyAPI.api_server to
use the extended URL. Previously it only used it for finding
the API root info ('available_versions', etc)
2019-10-09 16:24:46 -04:00
Felix Fontein
5349b3ae4c
docker_* modules: docs improvements (#63165)
* Improve docker_container docs.

* Fix usage of C(...) and I(...).

* Fix abuses of I(...).

* tls_verify has been made an alias of validate_certs some time ago.

* Fix YAML problems.

* Update lib/ansible/modules/cloud/docker/docker_container.py

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Update lib/ansible/modules/cloud/docker/docker_container.py

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Fix order.

* Split long description.

* Improve formatting.

* Rewrite state docs.

* Make proper sentences.
2019-10-09 22:21:28 +02:00
Saleh Batati
1d5206f53e Pass a JSON file to the Lambda's payload (#63261)
* Add an example of passing a JSON file to the Lambda's payload
Events passed to Lambda are commonly in JSON format, the change provides an example of using JSON file as an alternative to the inline YAML payload in the other examples.
2019-10-09 15:10:32 -05:00
Jian Fang
5ed163ce3f Spot instance code error (#63246)
##### SUMMARY
Adds 'instance_initiated_shutdown_behavior: terminate' to spot instance example for greater efficiency.
2019-10-09 14:57:13 -05:00
Kev Pearce
81a614684a Typo on line 161 (#63133)
fix module name for azure_rm_manageddisk in one example
2019-10-09 14:38:32 -05:00
m3gat0nn4ge
ce1c8c24f7 Update win_disk_facts.py example (#63266)
Fix incorrect index for second disk (should be `disks[1]` not `disks[0]`)
2019-10-09 14:21:37 -05:00
Felix Fontein
aa04e61c89 docker_* modules: add docker module defaults group (#63164)
* Add docker module defaults group.
* Add footnote about docker_stack not being included (instead of remarks column)
2019-10-09 14:12:02 -05:00
memotype
b46299ff86 Update stat.py (#63289)
Reword awkward documentation language.
2019-10-09 14:07:56 -05:00
Martin Nečas
0fcb6574dd Ovirt: add ovirt_vnic_profile_info (#62396) 2019-10-10 00:20:12 +05:30
Alexander Kapshuna
3ad602bfa6 Add aliases to path parameter of stat module (#61270) 2019-10-09 11:24:59 -04:00
James Powis
d4ad541eee dest lives in 4 different places depending on exeuction type (#62444) 2019-10-09 19:50:08 +05:30
Nathaniel Case
d336a14da6 Fix junos unicode errors. (#63046) 2019-10-09 19:26:27 +05:30
Andrey Klychkov
71bcce5db5 mysql_replication: add channel parameter (#63271)
* mysql_replication: add channel parameter

* mysql_replication: add channel parameter, add changelog
2019-10-09 14:27:01 +01:00
Martin Krizek
f72d4d2339
Do not use fully qualified module_utils imports (#63101) 2019-10-09 11:30:43 +02:00
Andrey Klychkov
9f9afcb203 mysql_replication: add connection_name param for MariaDB multi source replication support (#63229)
* mysql_replication: add connection_name param for MariaDB multi source support

* mysql_replication: add connection_name param for MariaDB multi source support, add changelog
2019-10-09 10:05:55 +02:00
Matt Davis
fd229dcbb5
add ANSIBLE_PLAYBOOK_DIR envvar support (#63220)
* add ANSIBLE_PLAYBOOK_DIR envvar support

* allows `ANSIBLE_PLAYBOOK_DIR` envvar as a fallback on CLI types that support `--playbook-dir`. This should have been implemented with #59464, but was missed due to an oversight.
* added basic integration test

* make first-class PLAYBOOK_DIR config entry

* update changelog
2019-10-08 17:34:15 -07:00
Adrian Likins
bad72693e4 Stop appending '/api' to galaxy server url (#63238)
* Stop appending '/api' to configured galaxy server url

Since not all galaxy REST api server URLs live
at '/api', stop always appending it to the
'url' value loaded from config.

* Add note about manually migrated galaxy configs and /api

* Add '/api/' to galaxy url and guessing if galaxy API

* Fix most unit tests (update to expect /api/)

* Fix test_initialise_unknown unit test

Since we retry now with an added /api/, mock it as well.

* Update fallback default avail_ver to new format
2019-10-08 15:09:19 -07:00
Mark Chappell
dbc9444572 ec2_vpc_nacl and ec2_vpc_nacl_info migrate to AnsibleAWSModule and add tests (#63163)
* Move EC2 networking objects into network-policy.json

* ec2_vpc_nacl: Add integration tests

* ec2_vpc_nacl: Migrate tests to use module_defaults

* ec2_vpc_nacl: (integration tests) Add missing AWS permissions

* ec2_vpc_nacl: (integration tests) Update tests for ipv6 support

* ec2_vpc_nacl: Migrate to AnsibleAWSModule

* Fix sanity tests for ec2_vpc_nacl and ec2_vpc_nacl_info

* ec2_vpc_nacl_info: Migrate to AnsibleAWSModule

* ec2_vpc_nacl_info: (integration tests) Rename from ec2_vpc_nacl_facts to ec2_vpc_nacl_info and add a test using a filter (by tag)

* Pick availability zones dynamically

Rather than assuming that AZa and AZb always exist (they don't), query to find out which AZs we have available first

* Test that the NACLs we get back are actually the *saml* NACL rather than duplicates/delete remove

* Cleanup IPv6 tests a little.

Note: IPv6 support for ec2_vpc_nacl not complete yet.

This provides the initial framework, and should ensure things don't start exploding when support is added.

* Removing subnets by name from a NACL *is* now supported

* Fix ec2_vpc_nacl return documentation
2019-10-08 13:27:24 -07:00
Sebastian Gumprich
da1a945088 fix typo in collection/plugins/readme (#63162) 2019-10-08 11:12:34 -04:00
Ondra Machacek
35c3d831fb ovirt_vm: Add new suboptions to graphical_console (#63230)
Fixes: https://github.com/ansible/ansible/issues/63225

This PR add following new suboptions to graphical_console param:

  - keyboard_layout
  - monitors
  - disconnect_action
2019-10-08 11:12:14 -04:00
Pedro Magalhães
67d9cc45bd maven_artifact.py - add support for version ranges by using spec (#54309) (#61813) 2019-10-08 15:24:50 +01:00
Martin Nečas
65fd331cb5 Ovirt add template timeout error (#63199)
* Ovirt add template timeout error

* correct example syntax
2019-10-08 10:03:44 -04:00
Andrey Klychkov
3b18337cac lineinfile - fix bug with insertbefore/insertafter and firstmatch (#63194) 2019-10-08 10:01:36 -04:00
Robert de Bock
b7a9d99cef Add spaces around {{ indicators. (#63125)
##### SUMMARY
The example looked a little less readable by not having spaces after `{{` and before `}}`. This commit should make the examples match [ansible-lint rule 206](https://github.com/ansible/ansible-lint/blob/master/lib/ansiblelint/rules/VariableHasSpacesRule.py)

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-08 13:41:54 +01:00
Andrey Klychkov
5fcaefc012 mysql_replication: small fix of master_delay parameter (#63221) 2019-10-08 13:06:54 +05:30
Pavan Bidkar
314f9fbd5c Support latest version while upgrading VM hardware. (#62188)
Support for the `latest` version during an VM hardware upgrade.
2019-10-07 16:41:57 -04:00
Abhijeet Kasurde
deda9d4cc5 VMware: Add module defaults for VMware modules (#63197)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-10-07 14:24:58 -04:00
The Magician
4959ab5004 Bug fixes for GCP modules (#63153) 2019-10-07 13:22:41 -04:00
The Magician
1522603078 New Module: gcp_compute_region_backend_service (#63154) 2019-10-07 13:22:26 -04:00
The Magician
94433dc65e New Module: gcp_compute_region_backend_service_info (#63155) 2019-10-07 13:22:19 -04:00
Nik Reiman
785ba62867 vmware: Only add configured network interfaces to facts (#28552)
This change effectively filters out any network interfaces which were
not explicitly configured for the guest. This fixes some unexpected behaviour where a machine with multiple IP addresses (for example, when Docker is installed, an internal IPv4 interface is added to
communicate with the container) would show one of the internal
addresses in the 'ipv4' field, but then no other information about the
corresponding hardware interface.
2019-10-07 21:41:50 +05:30
Andrey Klychkov
e48202838c mysql_replication: add master_delay parameter (#63130) 2019-10-07 15:23:56 +02:00
Andrey Klychkov
30c2d21f17 mysql: add elements for list params to the modules' documentation (#63187) 2019-10-07 07:58:15 -04:00
Andrey Klychkov
8a37a2440e postgresql: add elements for list params to the module's documentation (#63186) 2019-10-07 04:44:57 -04:00
Joshua Miller
0554b50eed Misc typo in nxos_config documentation (#62629)
* Changed 'exit' to 'exist'
* Removed unnecessary word 'first'
2019-10-07 11:23:31 +05:30
sky-joker
7b7d266a39 VMware: add properties option to vmware_host_facts module (#62916)
* add properties option to vmware_host_facts
2019-10-07 10:27:57 +05:30
Martin Schweyen
e977e0af74 VMware: Update maintenance notes on vmware_cfg_backup (#62853)
Maintenance mode seems only to be required for load or restet, not for save_configuration.
2019-10-07 10:19:37 +05:30
Ryan MacLean
b5cc0872e7 Typo fix in mssql_db (#63184)
Changed from 'then' to 'than'
2019-10-06 21:13:23 -04:00
Adrian Likins
239d639fee Add support for automation-hub authentication to ansible-galaxy (#63031)
Adds support for token authentication in Automation Hub. Fixes: ansible/galaxy-dev#96
2019-10-04 17:57:37 -04:00
Felix Fontein
24b80848dc
openssl_dhparam: add cryptography backend (#62991)
* Separate OpenSSL-specific code from generic code.

* Make sure absent works without OpenSSL.

* Add cryptography backend.

* Add tests.

* Add changelog.

* Duplicate disclaimer.

* Add dependency on setup_openssl.

* Forgot to adjust something.

* Fix version tuple.
2019-10-04 21:53:04 +02:00
Felix Fontein
a59b9d4269
Improve type documentation. (#62179) 2019-10-04 21:50:41 +02:00
Felix Fontein
41eafc2051
docker_container: improve image finding / change detection (#62971)
* Improve image finding / change detection.

* Checked wrong object.

* Improve behavior. (Let docker daemon sort this out.)

* Add changelog.

* Add simple test.

* Fix image name.

* Use new docker_image params.

* Rewrite.
2019-10-04 21:50:09 +02:00
The Magician
bb9b2e87bc New Module: gcp_compute_node_group (#63080) 2019-10-04 13:10:53 -04:00
The Magician
18237d78e4 New Module: gcp_compute_node_group_info (#63081) 2019-10-04 13:10:44 -04:00
The Magician
d19b1da1e1 New Module: gcp_compute_network_endpoint_group (#63121) 2019-10-04 13:09:34 -04:00
The Magician
7b7fff3d84 New Module: gcp_compute_network_endpoint_group_info (#63122) 2019-10-04 13:09:25 -04:00
GomathiselviS
7ac4756bf6 ios_bgp : Fix for bug #59083 (#63055)
* Fix for the bug 59083

* Bug fix #59083 - corrected linting errors
2019-10-04 10:56:08 -04:00
Jan Meerkamp
10ed3d0ec8 updated python-oca to pyone (#62867) 2019-10-04 09:23:25 -04:00
kamleshdudani
82a6f9d198 Update xml.py (#63128)
##### SUMMARY
Update example to remove escape characters in front of special characters as it is not needed to add explicitly anymore with latest ansible version


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-04 14:56:39 +02:00
Nilashish Chakraborty
fc5358cea0
Fix traceback for empty config (#62515)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-10-03 19:45:52 +05:30
Nathaniel Case
7ae46329f2
This should never have been "support:network" (#63068) 2019-10-03 08:58:05 -04:00
Andrey Klychkov
ad5200a7c0 postgresql_lang: add owner parameter (#62999)
* postgresql_lang: add owner parameter

* postgresql_lang: add owner parameter, add changelog fragment
2019-10-03 18:03:06 +05:30
Andrey Klychkov
ea86b2c2f7 mysql_replication: add master_use_gtid parameter (#62648)
* mysql_replication: add master_use_gtid parameter

* mysql_replication: add master_use_gtid parameter, improve tests
2019-10-03 18:02:41 +05:30
Eliah Rebstock
6ad6fde424 datadog_monitor - Add api_host parameter (#62608) 2019-10-03 05:41:17 -04:00
tchernomax
25ac7042b0 pacman: remove 'recurse' deprecated option (#61961)
* pacman: remove 'recurse' deprecated option

* pacman: remove recurse deprecated option

* pacman: remove recurse deprecated option
2019-10-03 00:02:06 +02:00
Chris Trufan
e55f46f302 Doc updates to openssl_certificate and ecs_certificate (#63006)
* Doc updates to openssl_Certificate

* Doc updates to openssl_certificate and ecs_certificate.

* Update lib/ansible/modules/crypto/entrust/ecs_certificate.py

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-10-02 23:06:48 +02:00
sky-joker
ff933be7e6 VMware: new module vmware_guest_register_operation (#54647)
Added vmware module vmware_guest_register_operation

This module can do the following.

    Register VM to inventory
    Unregister VM from inventory

This is useful when you want to unregister a VM from inventory and register it again.
2019-10-02 16:57:03 -04:00
Dag Wieers
4bfa3b2bf8
aci_contract_subject: Remove missing entry (#63044)
This fixes a `KeyError: 'filter'` exception.
2019-10-02 21:46:48 +02:00
The Magician
93f851b698 Bug fixes for GCP modules (#61915) 2019-10-02 14:31:45 -04:00
The Magician
c2b8f64e83 New Module: gcp_compute_node_template (#63064) 2019-10-02 14:30:10 -04:00
The Magician
dc7dbc7aa8 New Module: gcp_compute_node_template_info (#63065) 2019-10-02 14:29:51 -04:00
Olli Helenius
c724aa22bf hcloud_volume: add linux_device to return values (#62865) 2019-10-02 20:19:10 +02:00
Olli Helenius
88a2778c60 hcloud_floating_ip_info.name: add version_added 2019-10-02 20:17:20 +02:00
Olli Helenius
596f80586b hcloud_floating_ip_info: add name to return values 2019-10-02 20:17:20 +02:00
Matt Martz
594a0fa9ae Add new truthy and falsy jinja2 tests (#62602) 2019-10-02 13:58:28 -04:00
Mike Wiebe
918f768890 [stable-2.9] Fix nxos_l3_interfaces module and tests (#62545)
* Fix nxos_l3_interfaces module and tests

* Use get_interface_type

* get_interface_type in utils lib
2019-10-02 13:43:17 -04:00
Vishnu Priya Ananthu Sundaram
926e423690 Add Azure Stack supported API profiles (#62675)
* Add Azure Stack supported API profiles

* Bug fix

* add enum package to requirements

* Revert bacl latest profile changes

* Bug fixes

* Bug fix
2019-10-02 13:04:28 -04:00
Nilashish Chakraborty
69317a9d3e IOS-XR: Fix iosxr_lag_interfaces intermittent failures (#62998)
* Fix iosxr_lag_interfaces intermittent failures

*  If the dictionary is read out of order from member
   the current logic in `diff_list_of_dicts` returns
   unwanted diff. Hence use `dict_diff` utils
   function instead of sets.

Remove zip() to make existing tests happy

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Address review comments

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-10-02 11:43:29 -04:00
Adam Miller
8bcf11fee9 dnf - properly handle idempotent removal of wildcard globs (#63034)
Signed-off-by: Adam Miller <admiller@redhat.com>
2019-10-02 11:05:12 -04:00
Chris Houseknecht
911aa6aab9
Default collection install path to first path in COLLECTIONS_PATHS (#62870) 2019-10-02 10:22:00 -04:00
Gonéri Le Bouder
1fd79240db vmware_httpapi: version_added==2.10
`vmware_httpapi` hierachy will actually be released with Ansible 2.10, not
2.9. This commit fixes the `version_added` field.
2019-10-02 09:38:19 -04:00
Andrey Klychkov
0706782e4e mysql_replication: add return value, remove extra argument from function (#63036) 2019-10-02 13:33:53 +02:00
The Magician
d6781a2a5a Bug fixes for GCP modules (#61590) 2019-10-01 18:27:51 -04:00
The Magician
2b535cc59a Bug fixes for GCP modules (#61829) 2019-10-01 18:27:42 -04:00
The Magician
53cd75bee6 Bug fixes for GCP modules (#61916) 2019-10-01 18:27:19 -04:00
The Magician
b4d15b3040 Bug fixes for GCP modules (#61917) 2019-10-01 18:27:03 -04:00
The Magician
ecc47b653b Bug fixes for GCP modules (#61918) 2019-10-01 18:26:56 -04:00
Felix Fontein
8bfc39e231 ACME module defaults (#62719)
* Add module defaults group 'acme'.

* Start YAML document.
2019-10-01 17:14:22 -04:00
Will Smith
50d1cbd30a fix issue #60237 when non-ascii is returned from the WLC (#60243)
* fix issue #60237 when non-ascii is returned from the WLC

* update test to work with python3 through use of six library

* remove trailing white space
2019-10-01 16:52:35 -04:00
Sander
f102705c95 changed capitals vSphere (#62975) 2019-10-01 16:41:50 +02:00
Jeff Geerling
1e6fd6f54d Adjust documentation for yum clean to use best practices (#62898)
The yum module docs suggested using `shell: yum clean all`, which gives an `ansible-lint` error. Plus, you should use the `command` module unless you need more advanced features than just passing in an arbitrary command. Fixes that problem by using the `command` module in the example instead.
2019-09-30 18:33:53 -04:00
Ningú
87a6f8397e Concise file module example description (#62932)
A file won't be created by the example, the execution would fail unless the file already exists as specified by the module options
2019-09-30 18:30:33 -04:00
Mario Lenz
d01035ef25 VMware: Move helper functions from vmware_host_config_manager to module util. 2019-09-30 16:55:36 -04:00
Alex Ratner
ad580a71c4 fix minor typos (#62950) 2019-09-30 15:31:35 -04:00
pgbidkar
c6c13b5626 Fixing typo mistake in testbed with section. Deploy template from content library is supported from 67U3 2019-09-30 11:54:15 -04:00
Nilashish Chakraborty
67213ccb4d
Fix traceback for empty config (#62520)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-09-30 20:37:28 +05:30
Martin Nečas
9aff5f6007 ovirt_vm add reboot state (#62785)
* ovirt_vm add reboot state

* update pep8 syntax

* update docs

* correct whitespace
2019-09-30 10:46:19 -04:00
Paul Belanger
44a6c69562
Remove unused variables from nxos_ping / nxos_snapshot (#62933)
This was caught by our network collections lint jobs.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-30 10:12:31 -04:00
Jan Zmeskal
50dc41cca2 ovirt: Fixing typo in ovirt_disk examples (#62962) 2019-09-30 08:25:34 -04:00
Rene Moser
c24a85c793 lookup: lmdb_kv: fix for py3 2019-09-30 11:00:00 +02:00
Jan-Piet Mens
a2270ead2f new lookup plugin: LMDB - allow wildcard searches - make dbname configurable for with_lmdb_kv: - added built-in documentation - incorporate suggested changes by dw - comment spaces - outdent for the bot 2019-09-30 11:00:00 +02:00
Felix Fontein
62c0cae29a
docker_container: fix idempotency for network IP addresses (#62928)
* Specifying IP addresses needs API version 1.22 or newer.

* Simplify code.

* Use IPAMConfig.IPv*Address instead of IPAddress and GlobalIPv6Address.

* Add changelog.

* Fix syntax errors.

* Add integration test.

* Don't rely on netaddr.

* Normalize IPv6 addresses before comparison.

* Install netaddr, and use it.
2019-09-30 10:47:02 +02:00
Michael Scherer
75c4e9ec05 Fix _validate_csr_subject and _validate_csr_signature (#62790)
On python 3, if there is no explicit "return True", the
function call will be seen as "False", thus failling the module
2019-09-29 16:17:38 +02:00
Felix Fontein
fd627e3b78
docker_container: document some of the unexpected behaviors. (#62325) 2019-09-29 14:52:47 +02:00
Andreas Olsson
75dfe6c88a nsupdate: Use authoritative server for zone lookup (#62329)
Using a regular recursive resolver to lookup the zone name might not
work when the zone in question belong to a private/internal
domain. The authoritative server being used on the other hand will
definitely know about the zone(s) it's serving.

This approach is also consistent with the nsupdate module already
querying the specified authoritative server for TTL values.

The reason for the implementation having to loop until finding a
direct match is to account for different SOA responses triggered by
CNAMEs and DNAMEs. The previously used `dns.resolver.zone_for_name()`
function does the same.

Resolves #62052
2019-09-28 19:34:28 +02:00
psharkey
ee91714eb2 New module: Add module to collect Amazon AWS IAM user info (cloud/amazon/iam_user_info) (#23382)
* AWS: new module iam_user_info

Signed-off-by: psharkey <psharkey@cleo.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Rename from iam_user_facts to iam_user_info.

Rename and target 2.10.

Fixing docs.

* Adding iam_user_info integration test.

Removing unnecessary tasks.

Fixing yamllint failure test/integration/targets/iam_user_info/defaults/main.yml:5:1: empty-lines: too many blank lines (1 > 0).

* name paramter is optional

* Switch to use AnsibleAWSModule.

* Convert to using fail_json_aws

* Rework asserts to inspect ARN.

* Move integration tests from iam_user_info to iam_user.

* Fix pep8 problems.

* ec2_argument_spec not needed with AnsibleAWSModule.

* Switch to use helper in AnsibleAWSModule.

* Add iam_user_info to the aws group.

* Add support for pagination and backoff.

* Check improper parameter usage first.

* Adding test cases for multiple users.

* Rmoving unneeded line.

* Remove unneeded imports.

* Switch to catch BotoCoreError.

* Adding tests for exception coverage.

* Compare user info directly with values from created user.
2019-09-28 22:00:59 +10:00
bverschueren
c3eceb3a0d support creating an image from a volume (#59574)
* support creating an image from a volume

* leave filename/volume optional

* enforce volume/filename mutual exclusivity

* bump version_added to 2.10 for volume option

* add changelog fragment
2019-09-27 14:29:34 +02:00
Nathaniel Case
8b9c2533b5
Remove check_args from nxos (#62625)
* Remove check_args from nxos

* Clean up check_args from nxos
2019-09-26 15:02:09 -04:00
Nathaniel Case
89abfcdb18
Remove check_args from eos & ios (#62623)
* Remove check_args from eos & ios

* Clean up check_args from eos & ios

* Missed ios_vrf
2019-09-26 15:01:53 -04:00
Pablo Escobar Lopez
de515522b6 allow option docker_storage_driver=overlay2 (#62874) 2019-09-26 11:34:49 -04:00
Sam Doran
2375fd0990 find - clarify description of 'contains' (#62445) 2019-09-26 11:33:14 -04:00
Nicholas Amorim
d4064a965b Improved docs on docker_swarm_service (#62712)
* Improved docs on docker_swarm_service

Co-Authored-By: Piotr Wojciechowski <23406016+WojciechowskiPiotr@users.noreply.github.com>

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-09-26 11:30:59 -04:00
JonnyG365
798c5a55fa Update win_dsc.py (#62863) 2019-09-26 10:38:14 -04:00
leManu
f8fcf7fcbb facts: detect FreeBSD jails guest (#62857)
* facts: detect FreeBSD jails

* PEP8 fix
2019-09-26 10:08:33 -04:00
John F Leach
992b81e8fc Added suffix note to process_name_exact parameter (#62849)
##### SUMMARY
<!--- Your description here -->


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-09-25 22:49:41 +01:00
Bill Dinger
cae4255a16 Fix broken link to powershell resources (#62845)
##### SUMMARY
The previous link (https://docs.microsoft.com/en-us/powershell/dsc/builtinresource ) is a 404 . MS has a new link https://docs.microsoft.com/en-us/powershell/dsc/resources/resources  with the same content

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-09-25 21:19:11 +01:00
Dag Wieers
2995ae4ffd
Fix MSO examples (#62835)
Fix reported issues with the examples.
2019-09-25 18:29:36 +02:00
Varun Chopra
7dfd994a7e win_partition - Fix handling of maximum partition size (#58225)
* Fix handling of maximum partition size

* Added changelog fragment
2019-09-25 11:51:26 -04:00
Varun Chopra
3b409f2f50 win_format - Add allocation_unit_size (#56966)
* Fix allocation_unit_size

* Some final changes and added tests

* Cleanup...

* Fixes issues on 2012/R2

* Update tests for 2012/R2

* Suggested changes
2019-09-25 08:58:30 -04:00
Jordan Borean
322e225830
Fix issue when setting an empty pass to no_log param (#62804)
* Fix issue when setting an empty pass to no_log param

* Fix typo
2019-09-24 21:45:53 -04:00
Simon Dodsley
8a4c8ae20a Add checks for Cloud Block Store (#62068) 2019-09-24 15:11:15 -04:00
Majeed Mirza
28d30a04aa SoftLayer: Added flavor option (#56036)
* Added flavor option

Added flavor option to allow for use of SoftLayer flavor templates when creating new virtual machines.

See here for examples of ordering a vm with the flavor parameter:
https://softlayer-python.readthedocs.io/en/latest/api/managers/vs.html

To see flavor options use:
`slcli vs create-options`

* Update sl_vm.py

* Update sl_vm.py

* fixed version
2019-09-24 11:18:49 -04:00
sky-joker
3299f29f7c update example document for zabbix_action module (#62667) 2019-09-24 11:15:33 -04:00
Felix Fontein
1520eba0a7 package_facts: improve return value documentation (#62725)
* Improve documentation for package_facts.

* Add sample return value.
2019-09-24 11:14:49 -04:00
Martin Nečas
3b2b418aad ovirt_host update force doc (#62491)
* ovirt_host update force doc

* update doc message
2019-09-24 11:06:49 -04:00
Olli Helenius
190b8fcd1c hcloud_volume: clarify volume size units (#62771) 2019-09-24 10:52:14 -04:00
Dag Wieers
7fa1e4f70f Fix sanity checks (#62782)
This PR fixes all new ACI sanity issues.
2019-09-24 09:00:00 -04:00
Jordan Borean
d4ec9422a3
Add proper error when trying to run on older PS versions (#62634) 2019-09-24 08:43:14 -04:00