Commit graph

48338 commits

Author SHA1 Message Date
Abhijeet Kasurde
d7039b6633
VMware: Fix typo in fail_json in vmware_guest_powerstate ()
Fixed typo from "chanaged" to "changed"

Fixes: 

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-22 10:27:41 +05:30
DaveD
dc59880c31 vmware_deploy_ovf: Use correct datastore in multi-datacenter environment
Fixes:  

Need to pass the datacenter to assure we get the correct datastore managed object Id.
2019-11-22 09:52:45 +05:30
Jie (Link) Zheng
41b199a936 Fortinet's new module for fortios_system_global () 2019-11-22 09:32:48 +05:30
Prasad Katti
95bd92da04 Add integration tests for aws lightsail ()
* Add integration tests for aws lightsail

* lightsail - use module_defaults instead of aws_connection_info

* lightsail tests - assert instance state on create

* Fix yaml syntax error

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* [lightsail] create keypair as part of the testsuite

* Fix lightsail actions in compute-policy

* Add ability to delete keypair in lightsail_keypair
2019-11-21 16:53:36 -07:00
Mark Chappell
6e652ae6df Improve consistency of IAM_{role,user,group} behaviour ()
* iam_user: use AnsibleAWSModule.client to fetch connection rather than C&P code

* iam_role: Add deprecation warning so we can switch purge_polices default behaviour from true to false

* iam_user/role/group: Rename 'managed_policy' and 'purge_policy'

Rename from singluar to plural (we accept a *list* of policies), and add aliases for the old values.

* Cleanup documentation

* Changelog
2019-11-21 14:38:44 -07:00
Felix Fontein
784e507671 module sanity checks: improve alias handling ()
* add_file_common_args is only of interest on top-level.
* Handle undocumented arguments in one place.
* Update ignore.txt
* Add changelog
2019-11-21 15:33:27 -05:00
Egor Zaitsev
f3575c5025 docs: add solution to timeout errors to docs () 2019-11-21 15:05:07 -05:00
Alicia Cozine
b0c8e7926f link from quickstart page to Network Getting Started () 2019-11-21 11:42:57 -05:00
Michael Mayer
d52af75c68 Add aws elb multiple host header support ()
* Add support for aws elbv2 multiple host header actions

* Add example of multiple host header

* Add test for multiple host headers

* Add missing quote

* Update test/integration/targets/elb_application_lb/tasks/test_modifying_alb_listeners.yml

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* Update test/integration/targets/elb_application_lb/tasks/test_modifying_alb_listeners.yml

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* Remove debug statements
2019-11-21 09:42:37 -07:00
Felix Fontein
d1c58bc942
: adjust messages ()
* Adjust messages.

* Fix one more.
2019-11-21 17:20:38 +01:00
Maxime Guyot
c08f536260 Add support for all_projects in OpenStack inventory module () 2019-11-21 10:35:44 -05:00
Gregory Schevchenko
c6301a9fc7 fix utils.color.stringc: enclosure non printable sequences in SOH,STX ()
* ansible.utils.color.stringc: add wrap_nonvisible_chars flag in stringc
* add exaplanation for `wrap_nonvisible_chars` case in utils.stringc
* add changelog entry
2019-11-21 09:41:42 -05:00
Dusan Matejka
1a7823af03 Added missing logout to zabbix_user_info module () 2019-11-21 18:11:28 +05:30
nillvitor
ede62b8ad4 Update influxdb_write.py ()
Remove duplicated line
2019-11-21 09:48:07 +05:30
Mark Chappell
f1311d3e98 Rewrite iam_policy using boto3 ()
* reworked iam_policy

* Deprecate policy_document option

* deprecate defaulting skip_duplicates to true

* No longer explicitly catch ParamValidationError.

ParamValidationErrror is already caught by ClientError

* Work with complex policy objects rather than json documents

comparisons can better cope with the special cases (eg True vs "True" )

* Enable check_mode tests and fix related 'changed' bug

* changelog

* doc cleanup based on review
2019-11-20 16:59:02 -07:00
Sam Doran
426e37ea92
postgresql_privs - fix sort comparison ()
The result of .sort() is None, not the sorted object. The comparison was comparing the result of the .sort() method and not the sorted values.
2019-11-20 18:26:30 -05:00
Mads Jensen
6a763d7133 Remove uneeded Python version compatibility checks. () 2019-11-20 18:08:30 -05:00
Xu Yuandong
da8ec327cc Update plugins/netconf/ce.py to fix a bug(failed to get veriosn information via neocnf). ()
* fix version fail.

* add a changelog fragment.

* Update ce.py

* Rename plugins-netconf-ce-fix.yaml to 65065-plugins-netconf-ce-fix.yaml

* Update ce.py
2019-11-20 22:18:24 +01:00
Reid Wahl
e16e6fac92 Fixes : Add ansible_ssh_host_key_<algorithm>_public_subtype fact for each public host key algorithm () 2019-11-20 20:09:45 +00:00
John Imison
5bd06ee16e rabbitmq_publish SSL certificate implementation ()
* Implementing ability to specify certificates.

* Changelog fragment for rabbitmq_publish certificate checking

* Fixing version_added

* Reducing line size.

* Minor documentation updates.

* Update to add missing space.

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-11-20 20:09:06 +00:00
sky-joker
60d49c410d Zabbix: new module zabbix_template_info ()
Remove unnecessary module import(LooseVersion)
2019-11-20 20:05:26 +00:00
panyy3
a7716ae7a9 add new command SetManagerNic in redfish_config module ()
* add new command SetManagerNic in redfish_config module

* use a more explicit/rigorous way to select the EthernetInterface, split port for default nic_addr if root_uri has port, update variable name to lower_case_with_underscores instead of CamelCase

* add missing whitespace around arithmetic operator, fix inline comment should start with '# '
2019-11-20 20:04:24 +00:00
Bill Dodd
f51f87a986 DeleteUser: do not disable user if already disabled ()
* DeleteUser: do not disable user if already disabled

* add changelog fragment
2019-11-20 20:03:19 +00:00
Felix Fontein
b36f572256 openssh_keypair: fix idempotence issue ()
* Fix idempotence issue.

* Add changelog.
2019-11-20 20:02:26 +00:00
Andrey Klychkov
509b989a9a postgresql_lang: use query parameters with cursor.execute() ()
* postgresql_lang: use query parameters with cursor.execute()

* add changelog fragment
2019-11-20 20:00:07 +00:00
Xu Yuandong
cc5132a8ba add a new module to configure isis on isis-view. ()
* add a new module.

* update docs.

* update docs.

* update again.

* add __future__

* update docs, some args type

* update docs, some args type

* add integration test.

* add unittest.

* update for shippabel.

* update for syntax error.

* Update setup.yaml

* Update setup.yaml

* Update cleanup.yaml

* update for review.

* add notes.
2019-11-20 14:37:13 +00:00
Kevin Breit
2cf079bc8f Meraki - Remove integration tests which work with HTTP respons… ()
- These are modular level and I'm not catching these anyways
- More appropriate for unit tests, at least for HTTPS
2019-11-20 09:24:12 -05:00
Ganesh Nalawade
502fc2087e
Add support for jumphost setting in junos_scp and junos_package ()
* Add support for jumphost setting in junos_scp and junos_package

* Since junos_scp and junos_package module uses junos-eznc library
  to transfer file and load package respectively to a remote device
  it does not read the jumphost related configuration in netconf
  connection plugin unlike other junos modules which uses the
  Ansible persistent.
* Add `ssh_config` and `ssh_private_key_file` to add support to
  read custom ssh config file and mention ssh private key file
  for junos_scp and junos_package module

* Fix CI issue and update note section
2019-11-20 17:29:41 +05:30
rchikatw
38d6421425 Handle gfid tag when producing ansible facts in gluster_heal_info ()
we ignore lines beginning with / or < which will produce the requires json format.

Fixes: 
2019-11-20 14:59:22 +05:30
Abhijeet Kasurde
35cc26f8c0
VMware: Find unique tag using category id ()
If two tags with same name and different category exists, vmware_tag_manager
used to take first found tag.

This commit use combination of tag and category to identify the category.

Fixes: 

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-20 14:43:04 +05:30
chkp-orso
b1e6667664 fix all modules to be able to get parameter with value false (very important fix) ()
* add import of future and __metaclass__

* fix all modules to be able to get parameter with value false (very importent fix)

* Update ignore.txt
2019-11-20 12:09:40 +05:30
tcraxs
bc92170242 fix module that it reports the correct status of a change () 2019-11-20 00:43:20 -05:00
Ben Porter
4270df1fa2 Fix typo in docs for lvol module()
Changed activate to active
2019-11-20 10:26:40 +05:30
Jordan Borean
7092c196ed
config manager str type vault source ()
* config manager str type vault source

* Convert vault text to_text earlier and add tests
2019-11-20 12:02:28 +10:00
Jordan Borean
200fb00310
Windows coverage - output temp files with UTF-8 BOM ()
* Windows coverage - output temp files with UTF-8 BOM
ci_complete ci_coverage

* Remove testing changes to get ready for merge
2019-11-20 11:07:07 +10:00
Shachaf92
96a422a6fc win_firewall- Change req check from wmf version to cmdlets presence () 2019-11-20 11:00:56 +10:00
Jordan Borean
f5133bec22
Fix up broken Windows test when run with coverage () 2019-11-20 08:53:38 +10:00
Sandra McCann
765b054f15 fix net_system domain_search examples () 2019-11-19 15:21:55 -06:00
Baptiste Mille-Mathias
e65be0beee Put all files and Path filters under a specific section ()
Many of the filters in the "other useful filters" list manipulate filenames and paths; add a heading and put them together.
2019-11-19 12:30:56 -06:00
Matt Clay
ba273c72d8
Fix ansible-test handling of git submodules. ()
* Revert most of PR  commit e218c9814c

This removes the git error handling that converted all git errors into warnings.

* Fix ansible-test handling of git submodules.
2019-11-19 10:19:03 -08:00
Nelson Lago
3f3d1d8f2d Fix text in import_role module description ()
Docs: Remove unnecessary "it" in description.
2019-11-19 11:37:33 -06:00
Mark Chappell
9e92668d4f Amazon modules - Yet more minor documentation cleanup () 2019-11-19 10:10:18 -07:00
Björn
7dac93254e Fixes error in regex example () 2019-11-19 11:30:52 -05:00
Sam Doran
1588ad77e2 Update ansible.cfg ()
- clean out old options that are now deprecated
- clean up formatting of comments a bit
- add become plugin examples
2019-11-19 09:36:35 -06:00
Felix Fontein
b6f0f14dd3 Document diff. () 2019-11-19 09:46:59 -05:00
Xu Yuandong
09aebf33e4 Add doc to ce for user guide. () 2019-11-19 09:45:07 -05:00
Abhijeet Kasurde
a6bc43ba47
vmware_guest: Revert custom value customization in guest ()
Due to confusion between 'Custom Attributes' and 'Advanced options',
this change got in devel. Revert to original behavior i.e. customizing
custom values using vmware_guest is done in this PR.

Fixes: 

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-19 18:49:02 +05:30
Abhijeet Kasurde
9ef266778f Add missing version_added in checkpoint documentation ()
Domain is newly added in 2.10 release, specify this in the
documentation section in Checkpoint httpapi connection plugin.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-19 16:55:19 +05:30
Guillaume Martinez
4e6fa59ec1 gitlab modules: unify authentication method ()
* gitlab modules: unify authentication method
* gitlab module utils: remove useless import
* gitlab module utils: add documentation
* gitlab module utils: use distutil to compare version
* gitlab modules: sanity
* gitlab modules: remove useless import
* gitlab module utils: add missing import
* add changelog
2019-11-19 15:30:34 +05:30
Jie (Link) Zheng
bc479fcafc Fix py2/py3 compability issue for httpapi plugin fortios () 2019-11-19 14:51:56 +05:30