Commit graph

23265 commits

Author SHA1 Message Date
Tobias Gesellchen
db14b544a5 add env_file support (original code from @vpetersson) 2016-12-08 11:24:09 -05:00
Matt Clay
53b0fd65ee Split shell command to avoid use_unsafe_shell.
This mirrors a nearly identical change made to apt_repository.py.

Also removes the use of apt-get --force-yes as it can be dangerous
and should not be necessary (apt_repository.py does not use it).

Repeating the explanation from the apt_respository change below:

Since use_unsafe_shell is suspicious from a security point
of view (or it wouldn't be unsafe), the less we have, the less
code we have to thoroughly inspect for a security audit.

In this case, the '&&' can be replaced by doing 2 calls to run_command.
2016-12-08 11:24:09 -05:00
Tobias Wolf
75e8b365b4 Add supports_check_mode=True to mysql_db module
The most important cases are state=present and state=absent.

Future work: import and dump could be simulated and hence checked.
2016-12-08 11:24:09 -05:00
Kanwei Li
a2a3d2fc06 Add new Dv2 Azure instances 2016-12-08 11:24:09 -05:00
Bert Van Vreckem
4a10eeb196 Also show stdout when validation fails. This fixes #2498 2016-12-08 11:24:09 -05:00
Jonathan Mainguy
44bde46097 Add ability to download deb from url
if :// in deb, will try to download from url.
2016-12-08 11:24:09 -05:00
nitzmahone
3abdfb1712 mark failed async_status as finished
Running async_status in an "until: result.finished" loop will mask a module failure (eg, traceback) with a
template failure, because the fail dict doesn't include "finished" (eg, you'll see "ERROR! The conditional check 'bogus_out.finished' failed. The error was: ERROR! error while evaluating conditional: bogus_out.finished ({% if bogus_out.finished %} True {% else %} False {% endif %}"). Because the failure dict still includes "failed: true",
this change has no effect on stoppage/failure reporting, it just prevents the common usage pattern from masking the underlying error message.
2016-12-08 11:24:09 -05:00
Will Thames
52accd7d1f Use connect_to_aws where possible
`connect_to_aws` fixes a bug with security tokens in AWS.
Modules should use that rather than calling
`boto.x.connect_to_region`
2016-12-08 11:24:09 -05:00
Tim Alkemade
be19982313 GCE module does not fetch disk images if not necessary 2016-12-08 11:24:09 -05:00
Matt Martz
b85d3f32da Add get_checksum option to win_stat to work with new use of the stat module for checksumming 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
9551e51607 At least for now, set body to raw as it can be either a dict or jsonified-str
Since our validation does conversion as well as validation, I'm not sure
this is entirely correct.  May need to take a look at our conversion
code and re-examine to be sure we're doing it right.
2016-12-08 11:24:08 -05:00
Toshio Kuratomi
0400efa3f8 Change parameter to type=path
Read as binary for python3 preparedness
2016-12-08 11:24:08 -05:00
Toshio Kuratomi
390dbe5090 Change one param to be of type path 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
8b711c1c77 change a parameter to type=path 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
ecafdeeaa5 Set some module parameters to type=path 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
cea1125d02 Correct dest_port to be of type int 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
646d0e406d Set one parameter to be type path 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
249b9511a5 Set name to type path so that tilde and env vars are expanded 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
47e9a06784 Specify types in argument_spec instead of code so that checking type vs default value does not trigger 2016-12-08 11:24:08 -05:00
Michael Scherer
776d079e6b Fix non RFC 2606 domain name in doc 2016-12-08 11:24:08 -05:00
Jonathan Davila
7f338e13ff Updated ec2_lc docs 2016-12-08 11:24:08 -05:00
Peter Sprygada
24fc4dbeab fixes issue with return docstring
This commit fixes an issue with the return doc string.  The old line
was removed that would prevent the docs form being built correctly
2016-12-08 11:24:08 -05:00
Leonardo Giordani
344c976141 Added some documentation for the shell return values 2016-12-08 11:24:08 -05:00
Brian Coca
a148dbe5b4 updated with html comments to avoid posting hints
also simplified form, had too much from issue template
2016-12-08 11:24:08 -05:00
Brian Coca
f7597f916c added html comments so hints are not posted
also added verbostiy instruction
2016-12-08 11:24:08 -05:00
Constantin07
3dde5196aa Added explicit type for 'tags' option 2016-12-08 11:24:08 -05:00
Matt Martz
fada638d88 Indicate in notes that the dependency on httplib2 was removed for v2.1 2016-12-08 11:24:07 -05:00
Brian Coca
7a804fd17c tolerate environment not being set
default will be the same as before, None/null
2016-12-08 11:24:07 -05:00
Constantin07
94345349a6 Fixing issue #3057 - AttributeError: 'str' object has no attribute 'items' 2016-12-08 11:24:07 -05:00
Pete Travis
b504625f72 quote fail 2016-12-08 11:24:07 -05:00
Pete Travis
f6efa9aaa5 expand when opening too 2016-12-08 11:24:07 -05:00
Pete Travis
57703450f5 use expanduser() before testing user_data as file
I like to use ~/somepath instead of absolute paths because
that's more shareable.  Without expansion, the path wasn't
considered a file, and the resulting cloud-config user_data
contained a string for the file path instead of the file context.
So, expand it.
2016-12-08 11:24:07 -05:00
Konstantin Suvorov
762bd3a801 Fix docker container restart
restart_containers(containers.running) may try to restart containers
that are deleted when looping through get_differing_containers()
fix this by refreshing list after first loop
2016-12-08 11:24:07 -05:00
Daan Oosterveld
6b4fbe62de Adds ulimit to the docker module
The ulimit will be specified as a list and separated by colons. The
hard limit is optional, in which case it is equal to the soft limit.

The ulimits are compared to the ulimits of the container and added
or adjusted accordingly on by a reload.

The module ensures that ulimits are available in the capabilities
iff ulimits is passes as a parameter.
2016-12-08 11:24:07 -05:00
Scott Brown
ba2bc1dbfe Fixing missing interpolation variable 2016-12-08 11:24:07 -05:00
Matt Martz
a18206355a Drop dependency on httplib2 in the uri module, instead using ansible.module_utils.urls 2016-12-08 11:24:07 -05:00
Brian Coca
a546775172 fixed typo, now correctly check isdir
fixes #3089
2016-12-08 11:24:07 -05:00
Brian Coca
69b0e39220 added missing checksum alias 2016-12-08 11:24:07 -05:00
Peter Sprygada
0b49f956ce minor bugfixes for junos_config return values
The junos_config now properly returns updates and reponses
2016-12-08 11:24:07 -05:00
Brian Coca
ab6242bace fixed rax_cdb argument spec
now we pull the actual arguments and added aliases to be nice
fixes #3075
2016-12-08 11:24:07 -05:00
Ton Kersten
b58e16ed3d Fix facter path
In Puppet 4 and in the PE edition, the Puppet tree is installed in
`/opt/puppetlabs/...` and all commands can be reached from
`/opt/puppetlabs/bin`.
2016-12-08 11:24:07 -05:00
Daniel Petty
f26199d962 replaced sudo with become 2016-12-08 11:24:06 -05:00
Brian Coca
bd54067287 point to local issue temmplate 2016-12-08 11:24:06 -05:00
Brian Coca
c2a3b16155 initial add of issue/pr templates 2016-12-08 11:24:06 -05:00
Brian Coca
453d267489 documented new verbosity option 2016-12-08 11:24:06 -05:00
Peter Sprygada
025bc70acd initial add of ops_template module
This adds a new module ops_template used for configuring OpenSwitch
using local declarative config modules
2016-12-08 11:24:06 -05:00
Peter Sprygada
0f7279b967 bugfix for missing function name in ios_command
This provides a minor bugfix for a missing function name in the ios_command
network module
2016-12-08 11:24:06 -05:00
Matt Martz
aaf762573e Various simple linting type cleanups on modules 2016-12-08 11:24:06 -05:00
Brian Coca
4ec0ccd5ac fixed option name mismatch, added aliases
also removed empty aliases
2016-12-08 11:24:06 -05:00
Brian Coca
b357f4dd72 added follow to specific modules that support it
was removed from common file docs
2016-12-08 11:24:06 -05:00