Commit graph

708 commits

Author SHA1 Message Date
Shaun Brady
de29bafc1e Make ec2_elb_lb respect VPCs when resolving groups
AWS security groups are unique by name only by VPC (Restated, the VPC
and group name form a unique key).

When attaching security groups to an ELB, the ec2_elb_lb module would
erroneously find security groups of the same name in other VPCs thus
causing an error stating as such.

To eliminate the error, we check that we are attaching subnets (implying
that we are in a VPC), grab the vpc_id of the 0th subnet, and filtering
the list of security groups on this VPC.  In other cases, no such filter
is applied (filters=None).
2016-07-28 18:49:11 -04:00
Shaun Brady
8fa56c16ee Remove trailing white space 2016-07-28 13:43:40 -04:00
Ryan Brown
d288ef2abc Merge pull request #4163 from kaikousa/improve-ec2_lc-documentation
Improve `ec2_lc` documentation on security_groups option
2016-07-25 14:06:33 -04:00
Ryan Brown
a960f01bf3 Merge pull request #4234 from chrisweaver/patch-1
Enforce `bool` type for dup_ok option on AWS `iam_cert` module
2016-07-25 12:35:18 -04:00
Ryan Brown
95c67dc72a Merge pull request #4231 from phy1729/cfn-iam-capabilities
Support CAPABILITY_NAMED_IAM in AWS CloudFormation module
2016-07-25 12:34:01 -04:00
chrisweaver
8879931f0c Enforce boolean type for dup_ok
Stop "choices" from being interpreted as strings.
2016-07-21 15:02:49 -04:00
Matthew Martin
34d48eb89b Add CAPABILITY_NAMED_IAM to cloudformation capabilities
While from the documentation[1] one would assume that replacing
CAPABILITY_IAM with CAPABILITY_NAMED_IAM; this as empirically been shown
to not be the case.

1: "If you have IAM resources, you can specify either capability. If you
have IAM resources with custom names, you must specify
CAPABILITY_NAMED_IAM."
http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html
2016-07-21 10:54:40 -05:00
Michael Baydoun
07383c40d7
fixes issues where iam_policy incorrected reported changed 2016-07-18 13:43:28 +00:00
Ryan Brown
f61ddbc8a9 Merge pull request #3863 from ryansb/iam-pass-module
Bugfix: IAM group modules need `module` passed
2016-07-14 13:34:46 -04:00
Kai Kousa
7632bc1ecb Improve documentation on security_groups-option 2016-07-12 15:52:58 +03:00
Adrian Moisey
74285d6a53 Add default port for aurora (#4102)
If a port isn't specified, it's looked up. The lookup breaks without
this.

Related: https://github.com/ansible/ansible-modules-core/pull/3414
2016-07-11 01:20:12 +02:00
Matt Davis
0ee7b9896d Merge pull request #4080 from talonx/devel
Fix for #16518 - added missing regions
2016-06-30 13:23:10 -07:00
Ryan Brown
4845c96b00 Remove double-assignment of EC2 parameters (#4081)
The `source_dest_check` and `termination_protection` variables are being
assigned twice in ec2.py, likely due to an incorrect merge somewhere
along the line.
2016-06-30 09:47:06 -04:00
Hrishikesh Barua
718471e302 Fix for #16518 - added missing regions 2016-06-30 17:53:15 +05:30
Javier M. Mellid
a88d6d9a53 Add s3_url requirement in doc when rgw support is enabled in s3.py
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2016-06-21 10:53:47 +02:00
Javier M. Mellid
a52ff221f7 Add proper version_added for rgw option in s3.py
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2016-06-21 10:53:41 +02:00
Javier M. Mellid
b1724344d5 Add Ceph RGW S3 compatibility
Ceph Object Gateway (Ceph RGW) is an object storage interface built on top of
librados to provide applications with a RESTful gateway to Ceph Storage
Clusters:

http://docs.ceph.com/docs/master/radosgw/

This patch adds the required bits to use the RGW S3 RESTful API properly.

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2016-06-21 10:53:36 +02:00
Adam Butler
1c41b6fdb2 Fixes incorrect key name protocols -> protocol (#3963) 2016-06-16 10:04:05 -04:00
Toshio Kuratomi
1d0f408897 Finish python3 syntax compilation fixing for core repo 2016-06-13 12:00:31 -07:00
Bradley Phipps
4a8930f886 added missing colons to documentation (#3913) 2016-06-10 09:44:57 -04:00
Matt Davis
a8e5f27b2c Iam trust policy (#3885)
* added support for trust policies

* added version_added to new params in DOC string

* update version_added on new iam args to 2.2
2016-06-08 09:23:55 -04:00
mansunkuo
91e9223a76 Add an example to delete Route53 alias record set (#3834) 2016-06-06 22:51:25 +02:00
Ryan Brown
878cdb10f9 Merge pull request #3847 from washingtoneg/postgres9.5-rds-param-group-support
Add support for PostgreSQL 9.5 in rds_param_group (fix for #3846)
2016-06-03 13:37:34 -04:00
Ryan Brown
f54e39450c Merge pull request #2555 from jsternberg/paginate-iam-results
Paginate the results from `boto.iam`
2016-06-03 13:26:55 -04:00
Ryan S. Brown
1b9e28cc68 IAM group modules need module passed
The IAM group modules were not receiving the `module` object, but they
use `module.fail_json()` in their exception handlers. This patch passes
through the module object so the real errors from boto are exposed,
rather than errors about "NoneType has no method `fail_json`".
2016-06-03 13:15:15 -04:00
Michael Pappas
d26bb2eb41 Prevent ec2group from deleting sgs during check_mode runs 2016-06-03 10:58:56 -04:00
Jonathan A. Sternberg
969471f2ab Paginate the results from boto.iam
The default pagination is every 100 items with a maximum of 1000 from
Amazon. This properly uses the marker returned by Amazon to concatenate
the various pages from the results.

This fixes #2440.
2016-06-02 22:30:40 -05:00
Elena Washington
e1d7d78fcc Add support for PostgreSQL 9.5 in rds_param_group (fix for #3846) 2016-06-02 18:07:00 -04:00
codemeup @ Work
7314cc3867 Fixing error exception handling for python3. Does not need to be compa… (#3840)
* Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above.

* Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above.

* Fixing compile time errors IRT error exception handling for Python 3.5.
This does not need to be compatible with Python2.4 b/c Boto is Python 2.6 and above.
2016-06-02 12:56:48 -07:00
codemeup @ Work
5b1ab46265 Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above. (#3839) 2016-06-02 11:20:04 -07:00
Chris Houseknecht
90e8a36d4c Merge pull request #3347 from dougluce/fix-s3-region-error
Fix S3 unavailable region error
2016-05-27 13:41:29 -04:00
David Fischer
d8ad80ae0f Add MariaDB to valid RDS engines (#3337)
* Add MariaDB to valid RDS engines

* Update RDS module documentation
2016-05-27 11:49:42 +02:00
Roberto Bampi
423209d187 Add an example for SRV record in route53 (#3749) 2016-05-26 10:45:02 -04:00
Doug Luce
ec0f2113e0 Fix S3 unavailable region error
This is to address this error:

  fatal: [site]: FAILED! => {"changed": false, "failed": true, "msg": "Failed to connect to S3: Region  does not seem to be available for awsmodule boto.s3. If the region definitely exists, you may need to upgrade boto or extend with endpoints_path"}

Commit 0dd58e9 changed the logic so an exception is thrown (by
`connect_to_aws`) before the `s3 is None` check is performed. This
changes the `None` check to a catch so the old logic can compensate.
2016-05-24 20:37:12 -07:00
Ryan Brown
aa995806b9 Merge pull request #3320 from hyperized/patch-1
Added restart functionality to ec2.py
2016-05-24 10:49:16 -04:00
Kenny Woodson
5474da09bc Unindenting the delete to user (#3147) 2016-05-20 10:26:19 -04:00
Ryan Brown
58bb2fc4f6 Allow users to pick AWS Aurora as an RDS engine (#3414)
Per the [RDS docs](http://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBInstance.html),
add `aurora` as a valid DB engine.
2016-05-20 10:25:27 -04:00
Nathan Brown
97f6daa854 Do not expect the elb to have policies or instances. Fixes #3593 (#3595) 2016-05-20 09:47:13 -04:00
kwerey
1bfc33728b Add option to make RDS param groups for the MySQL 5.7 engine family. (#3695) 2016-05-20 09:45:11 -04:00
Lloyd Hazlett
3cf40d9596 Add path type to argument_spec where applicable (#3040) 2016-05-20 07:36:40 +02:00
Kaz Cheng
f87f0ec277 Allow create_iam_role to return an additional value of role_result and (#2418)
instance_profile_result, in addition to the existing role list and change value
2016-05-18 09:06:11 -04:00
hyperized
507d083d08 Added restart functionality to ec2.py 2016-05-04 09:12:02 +02:00
John R Barker
bb9572ca86 ansible-validate-modules part 4: Enable check on ansible-modules-core (#3526)
* Call ansible-validate-modules

* Correct quotes + add newline
2016-05-03 07:51:12 -07:00
cspollar
df0adafe66 Add missing periods to description items.
Current theme used by docs.ansible.com displays description items on one line. Adding periods helps readability.
2016-04-30 18:34:28 +02:00
Brian Coca
3381e8f76e clarified docs on overwrite 2016-04-28 17:13:56 -04:00
Ryan Brown
f14953f479 Fix capitalization of AWS in ec2_lc module documentation 2016-04-26 22:15:45 +02:00
Bill W
0f26d71715 Add more example on how to use module ec2_tags to list tags on an ins… (#3530)
* Add more example on how to use module ec2_tags to list tags on an instance

* Add more example on how to use module ec2_tags to list tags on an instance
2016-04-26 10:51:36 -04:00
deyvsh
522fb9b2cd Extend example to demonstrate usage of ephemeral disks. (#3550) 2016-04-26 09:07:27 -04:00
Sumit Roy
7fb0605824 Support tagging ELBs using boto 2.0. (#2844) 2016-04-22 15:34:58 -04:00
Brian Coca
3c009bd04f corrected return docs sample 2016-04-21 16:07:44 -04:00