Commit graph

708 commits

Author SHA1 Message Date
Constantin
b3bcd5a433 Added improvements and documented return structure (#2320) 2016-04-19 18:01:27 -04:00
jjshoe
bfa0a94c27 Fix an issue where by a call to ec2.get_image wasn't wrapped in a try/except, and would occasionally throw an exception in the wild. Also greatly simplifies two of the ugliest known loops to man down into a single loop. (#2554) 2016-04-19 18:00:16 -04:00
Dennis Conrad
c1787da7ff Fix UnboundLocalError if 'access_key_ids' not supplied
'key_ids' is referenced before it is assigned, causing the module to fail with a UnboundLocalError instead of failing gracefully with a helpful error message.  This very small patch moves the assignment of 'key_ids' to before the variable is referenced.
2016-04-19 19:53:21 +02:00
Marcin
5312627091 rebase for #2477, ready_for_review (#2581) 2016-04-16 21:50:53 +02:00
Joel Thompson
a39d11e8f5 Add exponential backoff retries to ec2_elb_lb (#3379)
ec2_elb_lb doesn't react well to AWS API throttling errors. This
implements an exponential backoff operation around some of the AWS API
calls (with random jitter, in line with AWS recommendations) to make
this more resilient.
2016-04-16 21:43:03 +02:00
Michael Moussa
ff414b79f2 Fixes read replica create BC break (#3365) 2016-04-12 23:32:12 +02:00
William Holroyd
4837b04668 Added ap-northeast-2 region (#2849) 2016-04-12 23:29:04 +02:00
Rob
68c8669200 Fix to ensure youngest snapshot is retrieved rather than oldest (#3115) 2016-04-12 23:21:58 +02:00
jjshoe
52823bdb5b Speed up AMI code by not attempting to create the AMI without checkin… (#2551)
* Speed up AMI code by not attempting to create the AMI without checking on the name first. Also simplifies code for reporting errors from AMI creation, greatly.

* remove sys.exit
2016-04-12 23:17:01 +02:00
Marcin
2e20e548f8 Check if identifier is specified for geo,weighted or failover routing. Don't fail if record set already exist. Set choices for failover - capital PRIMARY and SECONDARY. (#2470) 2016-04-12 22:06:41 +02:00
Kalle Lehtonen
5aa652c6fd Fix and add more error handling for role policies
In case role policy was deleted, we did not handle at all if there

was authorization issue to do the deletion. Also add message when

role is not found and the policy is skipped.
2016-04-05 09:55:49 -04:00
Brian Coca
2ddeb5cdec fixed doc quoting 2016-04-01 17:48:39 -04:00
Brian Coca
20e4ad0eef corrected required docs as only boolean is allowed
these complex values were not displayed and would always show the fields as requried
2016-04-01 16:59:12 -04:00
René Moser
bd2924b8ff Merge pull request #3133 from alachaum/fix-elasticache-idempotency
Fix aws elasticache idempotency
2016-03-31 19:27:15 +02:00
Jonathan Davila
8b13f2a693 Merge pull request #2278 from wimnat/feature/iam_doc_fix
IAM doc fix
2016-03-30 08:27:32 -04:00
René Moser
fa8cb762ed Merge pull request #3161 from somechris/fix-boto-version-requirement
Guard against too old boto library
2016-03-30 07:23:52 +02:00
René Moser
7e879eca32 Merge pull request #2968 from ashwanthkumar/exponential-backoff-in-route53
add retry with exponential backoff on route53
2016-03-27 23:54:37 +02:00
Brian Coca
cf03730fa2 added version added 2016-03-21 11:34:56 -07:00
Brian Coca
73586f7ddb Merge pull request #3124 from nbrownus/elb_proxy_protocol
ELB Proxy Protocol support for backends
2016-03-21 11:25:56 -07:00
Brian Coca
62310c8954 Merge pull request #3077 from jjshoe/devel
Allow us to sort by all available datatypes
2016-03-21 11:23:23 -07:00
René Moser
faf2bea527 Merge pull request #3261 from fabfuel/bugfix-ec2-elb-stickiness-without-expiration
Fixes #2039 Convert None to 0 when checking ELB cookie expiration
2016-03-19 19:09:51 +01:00
Ted Timmons
a87171e280 fix typo in documentation
let's -> lets
2016-03-18 12:03:14 -07:00
René Moser
37d978fa1c Merge pull request #3117 from beamly/fix-ec2-group
Fixes #3109: Executing ec2_group with rules fails with "Inval…
2016-03-17 08:41:54 +01:00
Taras Lipatov
5299279b0b Fixed typo json_fail to fail_json 2016-03-16 11:06:22 -04:00
Fabian Fülling
a34dae58cf Fixes #2039 Convert None to 0 when checking if ELB cookie expiration has changed 2016-03-16 14:14:37 +01:00
Jonathan Davila
9c286f35be Clarified IAM module doc 2016-03-15 10:15:41 -04:00
Brian Coca
6a48f2207a corrected typo on aws connection arguments var 2016-03-07 10:39:24 -05:00
Toshio Kuratomi
1c4da434c7 Merge pull request #2421 from willthames/ec2_fix_vpc_security_token
Use connect_to_aws where possible
2016-03-04 11:06:22 -08:00
Brian Coca
79564c5aa7 Merge pull request #3054 from atplanet/route53-soa-record-type
Bugfix: Permit SOA record type
2016-03-03 18:34:30 -05:00
Brian Coca
55932201a9 Merge pull request #2931 from ryannealmes/ec2-vpc-subnet-fix
ec2_vpc creating/updating incorrect subnets
2016-03-03 18:33:29 -05:00
Constantin07
86a4026f48 Treat 'is_public' option as a bool 2016-03-03 10:31:30 +00:00
Christian Aistleitner
ffeff8053b Guard against too old boto library
route53 creates Record objects using `health check` and `failover`
parameters. Those parameters only became available in boto 2.28.0.
As some prominent LTS Linux releases (e.g.: Ubuntu 14.04) only ship
older boto versions (e.g.: 2.20.1 for Ubuntu 14.04), users are getting
unhelpful error messages like

  TypeError: __init__() got an unexpected keyword argument 'health_check'

when running Ansible 2 against their LTS install's default boto.
We improve upon this error message by checking the boto version
beforehand.

Fixes ansible/ansible#13646
2016-03-01 18:55:58 +01:00
Brian Coca
e50a674190 Merge pull request #2977 from scottbrown/bugfix-missing-interpolation-var
BUGFIX: Fixing missing interpolation variable
2016-03-01 00:00:33 -05:00
Toshio Kuratomi
876b91eb3d Merge pull request #3113 from Constantin07/update_cloudformation
cloudformation.py - Added explicit type for 'tags' option
2016-02-28 22:35:34 -08:00
Arnaud Lachaume
b2c4731bd3 fix aws elasticache idempotency 2016-02-29 01:08:18 +11:00
Brian Coca
edf3aa336f Merge pull request #3129 from defionscode/lc_doc
Updated ec2_lc docs
2016-02-26 17:34:18 -05:00
Jonathan Davila
51d2f49ae0 Updated ec2_lc docs 2016-02-26 16:21:33 -06:00
Nate Brown
72da61ba83 ELB Proxy Protocol support for backends 2016-02-25 11:12:58 -08:00
Neil Saunders
6aa0cd4457 Fix for issue #3109: Executing ec2_group with rules fails with "Invalid rule parameter '['" 2016-02-25 14:18:02 +00:00
Constantin07
bc94e691e8 Added explicit type for 'tags' option 2016-02-24 23:33:42 +00:00
Toshio Kuratomi
e9454fa44f Merge pull request #2352 from bermudezjd/feature/iam_policy_present_state_includes_policy_changes
Feature/iam policy present state includes policy changes
2016-02-24 08:50:50 -08:00
James Cammarata
4bc2a189ba Merge pull request #3058 from Constantin07/update_ec2_tag1
ec2_tag.py - Fixing issue #3057 - AttributeError: 'str' object has no attribute 'i…
2016-02-24 11:16:55 -05:00
Joel
147b724f5d Allow us to sort by all available datatypes 2016-02-22 10:48:14 -06:00
Daniel Petty
e256ae0683 replaced sudo with become 2016-02-18 16:18:59 -07:00
Constantin07
9e42b2a684 Fixing issue #3057 - AttributeError: 'str' object has no attribute 'items' 2016-02-17 22:09:02 +00:00
Tom Bamford
5749454723 Bugfix: Permit SOA record type 2016-02-17 06:29:53 +02:00
Matt Martz
c7845456a6 Various simple linting type cleanups on modules 2016-02-16 15:58:44 -06:00
jjshoe
b0cbae51b5 Less engrish 2016-02-08 19:03:35 -06:00
Michael Baydoun
98c16a4f1f Update ec2.py
Documentation is not clear that tag used in count_tags must be an existing instance_tag
2016-02-08 19:14:19 -05:00
James Cammarata
e2f8ed1609 Merge pull request #2735 from noqcks/no-default-sec-groups
Elasticache Module: changing default cache_security_group to none
2016-02-07 21:43:35 -05:00
Scott Brown
2f329f832e Fixing missing interpolation variable 2016-02-05 14:35:50 -08:00
Ashwanth Kumar
3150c094b5 Doing exponential backoff on route53 upon AWS throttling 2016-02-05 13:27:55 +05:30
Toshio Kuratomi
29b81a4153 Merge pull request #2826 from shawnsilva/cloudformation-req-params
The parameters 'template' and 'template_url' are incorrectly required in all cases in the cloudformation module
2016-02-02 13:27:30 -08:00
Ryan-Neal Mes
c30bca6808 Indented code so it only executes tag comparison for matching cird values 2016-02-01 13:58:12 +02:00
Toshio Kuratomi
93d02189f6 Remove duplicate documentation fields 2016-01-28 09:24:20 -08:00
Brian Coca
cdfb578b60 Merge pull request #2646 from h1ppo/patch-2
updating choices for rds parameter engines
2016-01-25 23:46:12 -05:00
Brian Coca
382ae8f15f Merge pull request #2800 from noqcks/iam-grammar-issue
IAM Module: fixed grammatical issue in iam.py. exit -> exist.
2016-01-25 23:39:57 -05:00
techraf
2016d3d822 Fixed typo in example playbook 2016-01-19 20:45:50 +09:00
Brian Coca
08135a9cf8 Merge pull request #2778 from sunnyone/fix-iam-policy-pdoc-treatment
Fix iam_policy pdoc variable assignment
2016-01-18 21:21:19 -05:00
Brian Coca
ffea58ee86 Merge pull request #2817 from atplanet/ec2-ami-find-fix-region
Remove explicit region parameter from ec2_ami_find
2016-01-18 20:48:29 -05:00
Brian Coca
18bad1f691 tabs are bad 2016-01-18 17:10:29 -05:00
Henrique Rodrigues
b8d2a3d3b4 Fix misspelling of the word 'certificate' 2016-01-18 16:41:44 +00:00
Brian Coca
fbaf4fb628 Merge pull request #2746 from ferrants/patch-2
updated s3 module documentation
2016-01-18 11:17:09 -05:00
Brian Coca
618f74f35f added version_added 2016-01-18 08:25:32 -05:00
Brian Coca
ce8da38364 Merge pull request #2324 from Constantin07/update_ec2_vol
ec2_vol.py - Added 'delete_on_termination" option for volume attachment action
2016-01-18 08:20:26 -05:00
Shawn Silva
f410f44c28 The parameters 'template' and 'template_url' are incorrectly required in all cases.
If the state is 'absent' they should not be required. A few lines below the correct check is already in place.
2016-01-16 13:09:58 -05:00
Ben Visser
18fdea8aba changing default of cache_security_groups to none, removing the ['default']
OCD is making me fix the inconsistency with how None is typed. First Letter Capitalized All Over Now.

cleaning up the default object that was created for the cache_security_groups and removing checks dealing with it.

clean up space

Changing default cache_security_groups from [default] to None.
2016-01-15 13:56:07 -05:00
Brian Coca
1a298f7948 updated s3 docs to reflect mode choices
fixes #2318
2016-01-15 00:44:29 -05:00
autotune
f769305bd4 1113 fix ec2 subnet tags 2016-01-14 16:17:36 -08:00
Tom Bamford
14377c9857 Remove explicit region parameter from ec2_ami_find 2016-01-14 23:30:27 +00:00
Brian Coca
34aa679f41 Merge pull request #2734 from noqcks/elasticache-engine-choices
Elasticache Module: cache engine choices
2016-01-14 09:21:25 -05:00
Ben Visser
04d1c63358 two choices for cache engine. adding them.
revert spacing

undoing quotes around default. will do another pull requests

Making documentation more explicit for elasticache engine choices.
2016-01-12 23:07:55 -08:00
Ben Visser
593e74cfc5 fixed grammatical issue in iam.py. exit -> exist. 2016-01-12 15:18:30 -08:00
Brian Coca
4d60f963be Merge pull request #2543 from krdlab/fix-ec2_elb_lb-status
Fix `self.changed` value in `ElbManager` (ec2_elb_lb)
2016-01-12 10:48:15 -05:00
Brian Coca
e277a9b1b9 Merge pull request #2375 from bcoca/rds_port_defaults
made port default depending on db engine
2016-01-12 10:46:55 -05:00
Brian Coca
afdd4c3a20 updated version_added 2016-01-12 09:33:58 -05:00
Joost Cassee
4a6d323b9e Add wait_timeout option to route53 module
This option is used to make sure the module does not block forever.
2016-01-12 13:49:20 +01:00
Joost Cassee
1bcb90e785 Add wait option to route53 module
This option makes the module wait for the changes to replicate to all
Amazon DNS servers.
2016-01-12 13:47:05 +01:00
Brian Coca
1b8487ffce Merge pull request #2753 from jonhadfield/return_allocation_id
return allocation id for address created in vpc
2016-01-11 18:49:31 -05:00
Brian Coca
4d19ee903c crrected version added 2016-01-11 18:27:37 -05:00
Brian Coca
316749c653 Merge pull request #2548 from Etherdaemon/propose_wait_for_removed_ec2_elb_lb
wait_for to ensure ELB has been removed from AWS
2016-01-11 18:22:16 -05:00
Brian Coca
b2c94d0eab corrected version added 2016-01-11 18:16:07 -05:00
Brian Coca
18284d18a3 Merge pull request #2489 from jimbydamonk/evaluate_targe_health
Add evaluate taget health for alias based records
2016-01-11 18:11:27 -05:00
Bermudez, Jaime
2ad0be9425 Merge branch 'devel' into feature/iam_policy_present_state_includes_policy_changes
Conflicts:
	cloud/amazon/iam_policy.py
2016-01-11 13:13:33 -05:00
Yoichi Imai
00376af7d6 Fix iam_policy pdoc variable 2016-01-08 13:05:31 +09:00
Constantin07
56fa475dcb Added delete_on_termination option for volume attachment 2016-01-07 12:14:10 +00:00
Brian Coca
b08cf6b94f Merge pull request #2730 from bcoca/iam_policy_json
be smarter when dealing with policy_json input
2016-01-04 10:19:38 -05:00
Jon Hadfield
0320411d03 return allocation id for vpc address. 2016-01-02 11:16:46 +00:00
Matt Ferrante
2c75e72e83 updated s3 module documentation 2015-12-30 20:04:41 -05:00
Ben Visser
410ee32770 staging that num_nodes is required when state=present 2015-12-25 23:14:04 -07:00
Brian Coca
1fe6479617 be smarter when dealing with policy_json input
Now module will assume that if the argument is a string it is already formated as json
and will only try to convert non strings into json string.
Also removed unused 'msg' var declarations and the ifs that set them
fixes #2009
2015-12-24 00:18:21 -05:00
Toshio Kuratomi
d6d3a8b21c Merge pull request #1903 from andynelson/extra-route-targets
ec2_vpc module update (eni and vpc peering connections & return state on termination)
2015-12-18 17:36:13 -08:00
Toshio Kuratomi
5fe0fbbf20 Merge pull request #1883 from haad/ec2_elb_fixes
Two fixes for ec2_elb_lb module to make stickiness work with undefined expiration period
2015-12-18 17:33:05 -08:00
Brian Coca
6b13da738b updated module docs, added choices to state 2015-12-15 08:43:49 -05:00
Michel Alexandre Salim
18f4f5dcc6 Set the argument type for ec2_vol's encrypted parameter
If this is not set, Ansible parses the parameter as a string.
This is fine if the parameter is not provided by the caller, but
if it is set to False or True explicitly, ec2_vol receives this as
the string 'False' or the string 'True', both of which are truthy.

Thus, without this fix, setting the parameter results in encryption
always enabled.
2015-12-09 10:14:06 +07:00
Jason Paige
cc0ee4ad40 updating choices for rds parameter engines 2015-12-08 10:31:53 +00:00
Etherdaemon
a56ffff51b Update to wait and wait_timeout with a maximum of 10 minutes timeout 2015-12-07 20:27:31 +10:00
Brian Coca
15dcabe012 Merge pull request #2541 from joshuaeke/patch-1
Update ec2.py remove state tag
2015-12-05 10:12:55 -05:00
Arthur Clement
bfcdb05597 Example of single instance with ssd gp2 root volume creation 2015-12-03 22:48:13 +01:00
Brian Coca
43d2ecda06 Merge pull request #2546 from traveloka/fix-ec2-snapshot-info
Fix ec2_snapshot documentation
2015-12-01 09:46:48 -08:00