Commit graph

41104 commits

Author SHA1 Message Date
Tim Rupp
e6d586f703
Change port to allow strings too (#48899)
The port technically supports an asterisk, but the argument spec was
requiring integers only.
2018-11-19 13:44:20 -08:00
Tim Rupp
03f448f329
Adds documentation to make note of tower/awx restrictions (#48900)
When using modules that download files, you need to be aware of tower/awx
restrictions to use those modules correctly.
2018-11-19 13:40:37 -08:00
Andreas Krüger
15c58cf35f In the Makefile useful target list, mention "clean" and "webdocs". (#48843) 2018-11-19 14:44:26 -06:00
Brian Coca
68301f890a fix cache 'update' method to be 'mapping' compatible
- also simplify the update functions
 - fix methods and allwow backwards compat with plugins overriding 'update'
2018-11-19 14:18:18 -05:00
Matt Davis
9973bea504 fix failing tests
* removal of deprecated win_get_url arg `skip_certificate_validation` broke win_unzip tests
2018-11-19 11:09:53 -08:00
Scott Barvick
0f0e976183 updated .decode('utf-8') to to_text() 2018-11-19 13:34:04 -05:00
Scott Barvick
1ff7b258f4 make compatible with both python 2 and 3 by setting the encoding 2018-11-19 13:34:04 -05:00
Adam Miller
41176b5e0f fix group-missing/invalid-group detection
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-19 10:13:07 -08:00
Adam Miller
2b878546d3 fix yamllint sanity
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-19 10:13:07 -08:00
Adam Miller
23b60035a1 fix up sanity tests and with_modules conditional
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-19 10:13:07 -08:00
Adam Miller
4a06e95671 dnf to support modularity module appstream specs
Fixes #48743

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-19 10:13:07 -08:00
Abhijeet Kasurde
b4542e429f Add ckotte as VMware maintainer (#48884)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-19 17:18:04 +00:00
Abhijeet Kasurde
a32902427c linode_v4: correct usage of module.fail_json (#48882)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-19 12:16:41 -05:00
Brian Coca
652da82558 fix bug in config mgr
- use function that creates config slots as needed
2018-11-19 11:46:17 -05:00
Brian Coca
87e44a7ed1
better handling of bad type in config (#48821)
* better handling of bad type in config

 fixes #22468, fixes #22476
2018-11-19 11:45:45 -05:00
dionben
a796299651 Added support for L2 external domain association (l2dom). (#48670)
* Added support for L2 external domain association (l2dom).

Added support for L2 external domain association (l2dom).

* Update lib/ansible/modules/network/aci/aci_epg_to_domain.py

* Fix a few small items, restore earlier changes

Performed the necessary updates to fix this PR.

* Fix spaces

* One more miss
2018-11-19 17:22:04 +01:00
Abhijeet Kasurde
2faddfc1fe Misc typo in msc_* modules (#48716)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-19 16:50:39 +01:00
tchernomax
943edb3319 apt: add policy_rc_d option (#47191) 2018-11-19 14:45:48 +00:00
Chris Archibald
50808ffa8f Add common files for ONTAP and SOLIDFIRE unit tests (#48739)
* And unit test files

* Changes to netapp.py

* Matt's changed, and pep8 change for test_netapp.py
2018-11-19 14:43:32 +00:00
Maciej Delmanowski
c7e2226035 Do not require TTY for 'apt-key' operations (#48580)
The 'gpg' command supports the '--no-tty' option, which disables any use
of a TTY during its execution. This parameter is sometimes required for
non-interactive operation to avoid any questions for the user.

The 'apt-key adv' command can pass additional parameters to the
underlying 'gpg' command. This patch adds the '--no-tty' option to avoid
issues with APT key imports when Ansible pipelining active, which
disables the use of a dedicated TTY.
2018-11-19 12:40:06 +00:00
duritong
475d69da69 Make puppet module useable on puppet 6 (#46044)
The unused ignorecache setting has been removed and so you
can't run puppet through this module anymore.

See PUP-8533 / https://tickets.puppetlabs.com/browse/PUP-8533
2018-11-19 12:12:25 +00:00
Pilou
7f98a8db12 BOTMETA.yml and module metadata: fix case authors (#46051)
* botmeta: fix GitHub ID case

* module authors: fix GitHub ID case

* replace CloudEngine-Ansible by submitter GitHub ID
2018-11-19 11:47:14 +00:00
John R Barker
690b990fb5 plugins/loader is core (#48868) 2018-11-19 06:09:09 -05:00
Pit Kyzn
c79a9e2287 add example for flusing [tables] chains (#48858)
<!--- Your description here -->
add examples for:
- iptables flush filter
- iptables flush nat
+label: docsite_pr
2018-11-19 10:02:59 +00:00
Felix Fontein
3bb41ccb8e docker_* tests: check API version (#48620)
* Check minimal API and docker-py versions for all docker_* tests.

* Improve docker_swarm creation/destruction for tests.

* Fail when conditions aren't met.

* Don't hardcode address for advertise_addr.
2018-11-19 10:01:40 +00:00
Felix Fontein
891687284f docker_* modules: improve diff (#48546)
* Add difference tracking tool

* Improve --diff mode for docker_container.

* Improve diffs of sets by ordering the sets.

* Rewrite imports, get rid of HAS_DOCKER_PY_x variables and use docker_version instead.

* Rename container -> active (more generic).

* Add --diff for docker_volume. Change old diff output.

* Add --diff for docker_network. Change old diff output.

* Add --diff for docker_swarm_service.

* Add changelog.

* Add entry for porting guide on docker_network and docker_volume.
2018-11-19 09:59:54 +00:00
Miguel Angel Muñoz González
a67e9f89e7 Initial commit for fortios_firewall_policy (#48815) 2018-11-19 09:58:31 +00:00
Miguel Angel Muñoz González
f775d3b3ea Initial commit for fortios_webfilter_ips_urlfilter_setting (#48806) 2018-11-19 09:58:07 +00:00
Miguel Angel Muñoz González
66ceea910a Initial commit for fortios_webfilter_ips_urlfilter_setting6 (#48807) 2018-11-19 09:57:27 +00:00
Miguel Angel Muñoz González
5c2ef75424 Initial commit for fortios_webfilter_ips_urlfilter_cache_setting (#48799) 2018-11-19 09:56:48 +00:00
Miguel Angel Muñoz González
6d0c770c8c Initial commit for fortios_webfilter_override (#48295) 2018-11-19 09:55:55 +00:00
Miguel Angel Muñoz González
d25becb64e Initial commit for fortios_webfilter_ftgd_local_rating (#48293) 2018-11-19 09:55:32 +00:00
Miguel Angel Muñoz González
bad16ed641 Initial commit for fortios_webfilter_ftgd_local_cat (#48181) 2018-11-19 09:55:04 +00:00
Miguel Angel Muñoz González
f421212810 Initial commit for fortios_webfilter_profile (#48177) 2018-11-19 09:54:44 +00:00
Eric P
6800559d61 Fix a part of the example (#48851)
<!--- Your description here -->

+label: docsite_pr
2018-11-19 09:33:20 +01:00
Bojan Vitnik
b0cc240665 New module: xenserver_guest - manages XenServer VMs (#41041)
* XenServer related modules - initial commit

 - New module_util: xenserver. Contains common module arguments, functions
   and classes useful for future XenServer related modules.
 - New module_docs_fragment: xenserver. Describes common module arguments.
 - New module: xenserver_guest. Supports VM deployment, reconfiguration,
   removal, detection of changes, state management, fact gathering and
   Ansible check mode. Module is fully documented.
 - Updated: developing_module_utilities.rst.
 - Module params, workflow and some functions are based on or taken from
   vmware_guest module.

* Implemented support for configuring custom VM params in xenserver_guest module

* Compatibility fixes and documentation update

 - xenserver module_util: implemented support for XenAPI.py version older
   than 7.2.
 - xenserver module_util: PEP8 fixes.
 - xenserver module_util: Added missing imports.
 - xenserver module_util: Copyright notice fixes.
 - xenserver_guest module: updated module documentation with notes regarding
   module requirements and compatibility.
 - xenserver_guest module: bumped version_added to 2.7.
 - xenserver_guest module: minor fixes.

* VM power state management refactoring, subargument specs in xenserver_guest module, other fixes

 - VM power state management code moved from xenserver_guest module to xenserver
   module_util (set_vm_power_state function).
 - Code for waiting for VM IP address moved from xenserver_guest module to
   xenserver module_util (wait_for_vm_ip_address function).
 - xenserver module_util: implemented get_object_ref function to clean up
   a lot of repeated code in xenserver_guest module.
 - xenserver module_util: added additional aliases 'host' and 'pool' for
   'hostname' common module argument. They are more in line with what
   XenServer users are familiar with.
 - xenserver module_util: minor fixes.
 - xenserver_guest module: removed VM state management other than 'present',
   'absent' and 'poweredon'. Other states are to be managed by separate module.
 - xenserver_guest module: added subargument specs and cleaned up custom code
   for subargument validation.
 - xenserver_guest module: reorganized code for disk and network reconfiguation
   to minimize code duplication.
 - xenserver_guest module: renamed 'cdrom.iso' module argument to
   'cdrom.iso_name', avoids cryptic error message when parameter is
   missing.
 - xenserver_guest module: documentation update.
 - xenserver_guest module: changes in error messages.
 - xenserver_guest module: minor fixes.

* Implemented guest OS network parameter configuration and other

 - xenserver module_util: moved code for validating MAC addresses from
   xenserver_guest module and implemented a range of functions for validating
   IP addresses and related entities and converting prefixes to netmasks and
   vice versa.
 - xenserver module_util: updated fact gathering code to support guest OS
   network parameters.
 - xenserver module_util: added docstrings.
 - xenserver module_util: minor changes.
 - xenserver_guest module: implemented support for guest OS network parameter
   configuration.
 - xenserver_guest module: changed CD-ROM handling code.
 - xenserver_guest module: changed so that user friendly version of changes
   list is always returned in module result.
 - xenserver_guest module: error message changes.
 - xenserver_guest module: added docstrings.
 - xenserver_guest module: documentation update.
 - xenserver_guest module: minor changes and fixes.

* Various fixes and code cleanup

 - xenserver module_util: implemented get_xenserver_version function.
 - xenserver module_util: moved customization agent detection code to
   gather_vm_params function. customization_agent variable is now part of
   vm_params. An exception in customization agent detection code that prevented
   deployment of new VMs is also fixed.
 - xenserver module_util: added support for alternative VM state names with
   dash and underscore in set_power_state function.
 - xenserver_guest module: removed customization agent detection code
   as it is now implemented in xenserver module_util.
 - xenserver_guest module: fixed a bug in xenserver_data update code that
   occured when "networks.mac" was not specified in module params and
   other fixes.
 - xenserver_guest module: some code cleanup.
 - xenserver_guest module: bumped version_added to 2.8.
2018-11-19 01:50:20 -05:00
Dag Wieers
5f6a350b3a Fix a possible issue with comparing values with $null (#37763)
This PR includes:
- Fix $null comparison.
- Simplify Get-AnsibleParam in the same effort
2018-11-19 09:28:04 +10:00
Dag Wieers
f69e3e1cec win_get_url: Rewrite using AnsibleModule (#48390)
* win_get_url: Rewrite using AnsibleModule

* Fix sanity issue

* Implemented review suggestions

* Try something else

* fix circular dependency issues
2018-11-19 08:17:13 +10:00
jhawkesworth
361acd3547 win_say: Port to use CSharpUtil AnsibleBasic (#48361)
* port win-say to use CSharpUtil AnsibleBasic and add warning when requested voice not found

* win_say: fixes following code review: use C# style properties consistently; prefix changelog fragments

* fix invalid yaml in change log fragment

* win_say: fixes following code review: use generic module parameter validation where possible

* remove redundant setting of Result.changed to false, simplified some logic for readability.

* fix serialisation issue when message text is drawn from a file; allows tests to be run not in check mode and fix up some test descriptions
2018-11-19 07:07:12 +10:00
Anton Alekseyev
7eebec59b3 zabbix_map: Add module to create Zabbix maps based on data written in DOT language (#23026)
* Add zabbix_map module

* Fix PEP8 complainments

* Fix dict comprehension incompatible with python 2.6

* Support Zabbix 3.4 API changes

* Fix documentation

* Minor fixes

* Move zabbix_map to zabbix namespace

* Fix compatibility issue with Zabbix >= 3.4

* Support maps and triggers as map elements
2018-11-18 15:57:51 +01:00
Jordan Borean
fd4b282f6f
Ansible.Basic.cs - fix check mode run with nested spec (#48838) 2018-11-17 18:15:36 +10:00
Matt Clay
a41c0405a7
Add CI platform: rhel/8.0 (#48835) 2018-11-16 22:06:19 -08:00
Susant Sahani
88dcb11695 nmcli: Introduce IPIP Tunnel (#45933)
This work enables to add ipip tunnel via nmcli module

```
  - nmcli:
       state: present
       type: ipip
       conn_name: ipip_test1
       autoconnect: yes
       ip_tunnel_dev: enp0s8
       ip_tunnel_local: 192.168.1.2
       ip_tunnel_remote: 192.168.1.5
```

version2: Added tests
Signed-off-by: Susant Sahani <susant@redhat.com>

Rebase
2018-11-16 23:57:11 -05:00
Tim Rupp
a4921cd5d9
Removes more f5-sdk references from f5 modules (#48771) 2018-11-16 20:43:46 -08:00
Adam Miller
4771ccc24b enable rhel8 beta for testing in ec2 (#48831) 2018-11-16 19:09:27 -08:00
Matt Clay
0826a00803 Add --raw option to ansible-test shell command.
It is currently supported only with the `--remote` option.

This makes it easier to troubleshoot new instances which are not
yet supported by the setup scripts used by ansible-test.
2018-11-16 17:38:15 -08:00
Dag Wieers
9436ce5d85
win_wait_for_process: Rewrite using AnsibleModule (#48388)
* win_wait_for_process: Rewrite using AnsibleModule

* Add mutually_exclusive and required_one_of
2018-11-17 02:15:49 +01:00
Matthew Hellmer
854e607535 Update win_wait_for_process.py (#48816)
<!--- Your description here -->
Corrected pattern example.
+label: docsite_pr
2018-11-17 02:04:56 +01:00
Matt Clay
8066acc90c
Support skip of platforms by version in tests. (#48826)
* Support skip of platforms by version in tests.

Previously a remote platform could be skipped completely using the alias:

`skip/{platform}` such as `skip/rhel`

Now a specific platform version can be skipped using the alias:

`skip/{platform}{version}` such as `skip/rhel7.6`

This feature is available for platforms specified with the `--remote` option.

* Add skip by version to the docs.
2018-11-16 16:38:47 -08:00
Tim Rupp
9af5724bd4
Remove the f5-sdk from bigip_remote_syslog (#48539) 2018-11-16 15:13:08 -08:00