Commit graph

8672 commits

Author SHA1 Message Date
Tim Rupp
e81bbf9b8f Bugfix bigip_facts that was trying to check the length of an iterator (#2842)
Recently, a user reported that the bigip_facts module was failing with the error

    received exception: object of type 'itertools.imap' has no len()

This reported was occurring at line 1657 of the bigip_facts module

bug report is here

https://github.com/F5Networks/f5-ansible/issues/25

Upon further investigation, the map function for returning the specified
includes was returning an iterator, and calling len() on an iterator does
not work.

I believe this problem was caused by part of the Python 3.x effort insofar
as the inclusion of this line

https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/basic.py#L143

seems to affect our usage of map(), probably for the better anyway, and we need
to change our expectations in our module's code to no longer assume a list, but
instead assume an iterator.

After trawling through the module_utils/basic code, I think a list
comprehension is more appropriate here anyway, so I'm changing it to be
that. The affected user reported it works this way, and my own testing
on 2.2.0 supports that.
2016-09-02 23:07:32 -07:00
Kevin Hulquest
ab7391ff14 Add facts and storage system modules. (#2748)
* Add facts and storage system modules.

* Update version metadata.

* Add facts and storage system modules.

Update version metadata.

Add init files.

* Fixes for review comments.

* Fixes for review comments.

* Update document fragments for api_* options to indicate they are required.

* Correct bad string concatenation.

* Add option description for validate_certs since basic_auth arg_spec is no longer extended.

* Add default value for validate_certs in docstring.

* Rename directory name so it applies to netapp and not simply eseries platform.

* Rename modules to differentiate other netapp modules.
2016-09-02 07:34:04 -07:00
Robin Roth
64879e5eb5 Ensure the return value for changed is bool (#2830)
fixes #2827
2016-09-02 07:08:08 +02:00
Michael Grandjean
f38fbaefc6 Fix typo in EXAMPLE section (#2833) 2016-09-01 16:47:38 -04:00
John R Barker
f13d376f0c Minor tidyup (#2828) 2016-09-01 20:46:08 +01:00
Matt Clay
e8a5442345 Add python3 testing for module PRs. (#2825) 2016-08-31 17:04:25 -07:00
Ryan Brown
aedaca55ac New module: execute_lambda (AWS) (#2558)
First version of execute_lambda module

Supports:
- Synchronous or asynchronous invocation
- Tailing log of execution (sync execution only)
- check mode
2016-08-31 15:42:15 -04:00
Monty Taylor
ae5852449c Error if shade is too old for domain_id on os_project (#2806)
* Error if shade is too old for domain_id on os_project

os_project's domain_id parameter requires shade >= 1.8.1 to work. Be
explicit.

Fixes #2805 os_project requires python-shade 1.8.1 or higher

* What I really meant was 1.8.0
2016-08-31 15:41:12 -04:00
Matt Martz
3867cc71a6 Make sure we don't catch rc=0 as a timeout (#2823) 2016-08-31 10:29:41 -05:00
Toshio Kuratomi
b576e116f0 Style cleanups:
* Don't use iterkeys
* Don't use wildcard imports
2016-08-31 07:48:10 -07:00
Michael Scherer
a2d3aac8cc Use six for iteration, to make it run on python3 (#2800) 2016-08-31 07:15:38 -07:00
Tim Rupp
ef6eb80c12 Adds allow_service parameter to bigip_selfip (#2808)
This parameter can be used to open up access to (among other things)
the mgmt address of a BIG-IP. It is necessary for configuring bigips
in an HA configuration.
2016-08-31 14:49:03 +02:00
René Moser
638e25bead Merge pull request #2821 from adfinis-forks/udm_user_pwhistory
univention udm_user: override password history.
2016-08-31 14:46:48 +02:00
Tobias Rueetschi
ec2cc904e2 udm_user: change overridePWHistory and overridePWLength to snake_case 2016-08-31 14:42:11 +02:00
Tobias Rueetschi
81c2fb46f1 univention udm_user: override password history. 2016-08-31 14:41:07 +02:00
René Moser
48eba12d23 Merge pull request #2822 from adfinis-forks/fix_udm_user
univention udm_user: pep8
2016-08-31 14:29:34 +02:00
John R Barker
bd2d487c6a Feature udm share (#2439)
Add univention/udm_share.py

* UCS udm_share: fix creating of new shares

* univention udm_share: adapt to library univention_umc

* univention udm_share: fix shebang

* univention udm_share: add required_if to the API

* univention udm_share: add license information

* univention udm_share: import only AnsibleModule from ansible.module_utils.basic

* univention udm_share: add documenation

* univention udm_share: reorder documentation parameters

* univention udm_share: change some parameters to type bool

* univention udm_share: add example

* univention udm_share: pep8

* univention udm_share: change documentation, use camel_case for parameters, old parameter names as alias

* univention udm_share: add aliases as documented
2016-08-31 10:53:02 +01:00
Tobias Rueetschi
a370a8c8f6 udm_user: change code to fit documentation with snake_case instead of camelCase 2016-08-31 11:30:45 +02:00
Tobias Rueetschi
caba5d1715 udm_user: change camelCase to snake_case in documentation 2016-08-31 11:20:52 +02:00
Tobias Rueetschi
d179938952 univention udm_user: pep8 2016-08-31 10:25:01 +02:00
René Moser
8d1ce3f2fd Additional provider features added and fixed some bugs (#2769)
* Additional provider features added and fixed some bugs.
* Added support for SSH keys, image passwords, SSD disk type, and CPU family.
* Adjusted server create so that IP address is returned in response.
* Restructured remove server method(s) to handle change status properly, gracefully handle missing servers, and improve overall performance.
* Prevent duplicate server names from being provisioned so removals can be handled appropriately.
* Fixed a bug in the count increment being a string rather than an integer.
* Fixed issue with create_volume returning invalid response.
* Fixed type bug in volume instance_ids for volume removal and improved volume management.
* Fixed type bug in instance_ids for proper server removal and moved boot volume creation into composite server build request.
* General clean up.

* Removed us/lasdev datacenter which the cloud provider no longer maintains.

* Included version_added for new options.

* Added support for firewall rules, consolidated resource UUID retrieval methods for server and NIC modules, and set LAN type to int.

* Minor documentation corrections.

* Some further documentation updates including version.

* Added RETURN documentation.

* Reverting recent commits back to initial PR and will move the new profitbricks_firewall_rule module and other recent changes to a new branch.

Revert "Added support for firewall rules, consolidated resource UUID retrieval methods for server and NIC modules, and set LAN type to int."

This reverts commit 464cbb89f2.

* Set variable types, defined choices, and cleaned up whitespace.

* Added parameter choices for bus.
2016-08-31 09:55:04 +02:00
Ethan Devenport
1eb5745f49 Added parameter choices for bus. 2016-08-31 07:46:12 +00:00
Ethan Devenport
86285e8824 Set variable types, defined choices, and cleaned up whitespace. 2016-08-31 06:24:55 +00:00
Wong Hoi Sing Edison
9cd681a841 Fix ansible/ansible-modules-extras#1682: add dispersed volume support for gluster_volume (#2708) 2016-08-31 07:34:31 +02:00
afunix
f69d32ec44 gluster_volume module parses out additional hostnames provided by "gluster peer status" command [#1405] (#2811) 2016-08-31 07:27:07 +02:00
René Moser
1c4f346691 ec2_vpc_dhcp_options_facts: fix exception handling, fixes build (#2819) 2016-08-30 23:38:07 +02:00
Fabio Alessandro Locati
2c78dea646 Require domain in rocketchat (#2803)
* Set the domain as required

* Add domain in the examples as well
2016-08-30 23:04:48 +02:00
Joe Smith
44c86245ff Set explicit type for timeout (#2809)
vmware_maintenancemode.py needs explicit type for timeout, otherwise it reads timeout as string and breaks.
2016-08-30 21:55:41 +02:00
John R Barker
38b4263531 ec2_vpc_dhcp_options_facts.py no py3
Old PR was merged that hadn't been updated since we added the py3 checks
2016-08-30 20:37:05 +01:00
Tobias Rüetschi
a39da41bb2 Feature udm dns zone (#2382)
* UCS udm_dns_zone: added

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_zone: updated, add supports check mode

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_zone: updated, add support to modify dns zones

* UCS udm_dns_zone: change string formating

* UCS udm_dns_zone: add a function to convert the time to the biggest unit

* UCS udm_dns_zone: add type definitions to the argument specification

* UCS udm_dns_zone: update function convert_time

* UCS udm_dns_zone: only modify object if it has changed

* UCS udm_dns_zone: add documentation

* UCS udm_dns_zone: fix checks

* UCS udm_dns_zone: if dns zone not exists, changed is always true

* UCS udm_dns_zone: documentation, add version_added

* UCS udm_dns_zone: add license and fix travis for python 3

* UCS udm_dns_zone: import common code for univention from ansible.module_utils.univention

* univention udm_dns_zone: adapt to library univention_umc

* univention udm_dns_zone: lint

* univention udm_dns_zone: add requirement python >= 2.6 to documentation

* univention udm_dns_zone: dont import time, its unused
2016-08-30 19:47:30 +01:00
Adam Števko
2fda8831bd Add modules to configure Solaris/illumos networking (1st batch) (#2416)
* Add modules to configure Solaris/illumos networking (1st batch)

* Add choices to temporary flags
2016-08-30 19:46:53 +01:00
Olivier Boukili
ae2fdd5b57 new module: apache2_mod_proxy (#2148)
* module apache2_mod_proxy

* Moved state notes to state description.
2016-08-30 19:44:39 +01:00
TimothyVandenbrande
b9b781c370 This is an ansible module to control/create/adapt/remove VMs on a RHEV/oVirt environment. (#2202) 2016-08-30 19:43:23 +01:00
René Moser
4b7b70b35f new modules for managing exoscale DNS (#2788) 2016-08-30 19:40:06 +01:00
Tobias Rüetschi
fc18b967f2 Feature udm group (#2396)
* UCS udm_group: added

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_group: updated

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_group: add key description

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* python styling

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_group: updated, add supports check mode

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_group: updated, add support to modify groups

* UCS udm_group: change string formating

* UCS udm_group: add type definitions to the argument specification

* UCS udm_group: import common code for univention from ansible.module_utils.univention

* univention udm_group: add documentation

* UCS udm_group: add requirement python >= 2.6

* univention udm_group: add more examples
2016-08-30 19:38:16 +01:00
Tobias Rüetschi
cd446baf39 Feature udm dns record (#2394)
* UCS udm_dns: added

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_record: fix multiple entries in different zones

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns -> udm_dns_record: renamed

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_record: updated, add supports check mode

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_record: updated, add support to modify dns records

* UCS udm_dns_record: change string formating

* UCS udm_dns_record: add type definitions to the argument specification

* UCS udm_dns_record: import common code for univention from ansible.module_utils.univention_umc

* UCS udm_dns_record: add documentation

* UCS udm_dns_record: update documenation

* univention udm_dns_record: pylint

* univention udm_dns_record: fix reverse zone entries
2016-08-30 19:34:11 +01:00
naslanidis
be9a0f9854 new AWS module for ec2 dhcp option facts (#2001)
new ec2 dhcp option facts module
2016-08-30 19:32:21 +01:00
Tobias Rueetschi
deb5975a8a univention udm_share: add aliases as documented 2016-08-30 19:12:24 +02:00
Tobias Rueetschi
44e5f4bb17 univention udm_share: change documentation, use camel_case for parameters, old parameter names as alias 2016-08-30 19:04:42 +02:00
Tobias Rueetschi
8f48370dac univention udm_share: pep8 2016-08-30 18:04:41 +02:00
James Higgins
58c6ad6c9e Just use netloc to identify bucket name for s3 locations (#2713) 2016-08-30 16:42:14 +02:00
René Moser
b58bd264e8 vmware_local_user_manager: fix global name 'module' is not defined (#2818) 2016-08-30 16:39:58 +02:00
alxsey
035367170c Implement template storage selection (#2755) 2016-08-30 16:17:30 +02:00
Mike Liu
582e36aef9 Iptables enhancements (#2789)
* Add the flush parameter.

When specified the flush parameter indicates that this module should remove all
rules from the specified table. If no table parameter is specified then the
default filter table is flushed.

* Add support for setting chain policies.

The module supports setting the policy of a given chain and table to the
following target values, ACCEPT, DROP, QUEUE, and RETURN. This parameter ignores
all other unrelated parameters.

* Fix pep8 issues.

* Fix missing quotation.

* Make 'flush' and 'policy' parameters mutually exclusive.

This combination is not supported by the wrapped iptables command. 'flush' and
'policy' however, can both take the 'chain' argument.
2016-08-30 16:16:10 +02:00
bbooysen
5767885ae5 typo fix (#2816)
Changed 'memroy' to 'memory'.
2016-08-30 14:06:32 +02:00
Ethan Devenport
e9fd5ad5dc Reverting recent commits back to initial PR and will move the new profitbricks_firewall_rule module and other recent changes to a new branch.
Revert "Added support for firewall rules, consolidated resource UUID retrieval methods for server and NIC modules, and set LAN type to int."

This reverts commit 464cbb89f2.
2016-08-29 19:45:57 +00:00
Tim Rupp
2ef4a34eee Fixes documentation bugs in bigip_irule (#2797)
The return docs were incorrect for this module. This patch fixes them
and adds some additional return values
2016-08-29 18:29:47 +02:00
Toshio Kuratomi
b5beed7e34 We've decided that python-3.5 is our minimum pyhton3 version (#2798) 2016-08-29 09:13:08 -07:00
Tobias Rueetschi
644b3efd87 univention udm_share: add example 2016-08-29 09:11:56 +02:00
Tobias Rueetschi
ac5182db2d univention udm_share: change some parameters to type bool 2016-08-29 09:11:56 +02:00