Commit graph

9287 commits

Author SHA1 Message Date
GGabriele
eb31af5a47 Fixing error handling 2016-09-14 08:42:53 +02:00
GGabriele
6a5ab25264 Fixing docstring 2016-09-14 08:36:09 +02:00
GGabriele
12a63c0717 Adding nxos_snmp_community 2016-09-14 08:32:14 +02:00
Christopher Kotfila
2632aa630f Unpack AWS reservations while waiting to terminate (#4012)
Previously calculation of the number of instances that have been
terminated assumed all instances were in the first reservation returned
by AWS.  If this is not the case the calculated number of instances
terminated never reaches the number of instances and the module always
times out. By unpacking the instances we get an accurate number and the
module correctly exits.
2016-09-13 15:07:14 -04:00
Ryan Brown
ae6992bf8c Handle EC2 instances with multiple network interfaces (#4766)
Currently instances with multiple ENI's can't be started or stopped
because sourceDestCheck is a per-interface attribute, but we use the
boto global access to it (which only works when there's a single ENI).

This patch handles multiple ENI's and applies the sourcedestcheck across
all interfaces the same way.

Fixes #3234
2016-09-12 18:26:13 -04:00
Peter Sprygada
6a93255ffa Merge pull request #4753 from skg-net/dnos9_command
dnos9_command (New Module)
2016-09-12 17:20:34 -04:00
Peter Sprygada
fddb7715a8 Merge pull request #4769 from skg-net/dnos6_command
dnos6_command (New Module)
2016-09-12 17:20:07 -04:00
Peter Sprygada
a2dbd92930 Merge pull request #4804 from privateip/eos_template
fixes error when calling load_config() with session keyword
2016-09-12 16:54:00 -04:00
Peter Sprygada
cbcb90e112 fixes error when calling load_config() with session keyword
The session keyword is no longer needed or supported in the load_config()
method for eos.  This fixes an issue in eos_template where the session
keyword was still being sent.
2016-09-12 16:29:51 -04:00
Toshio Kuratomi
432ee70da1 Fix syntax 2016-09-12 11:54:58 -07:00
Senthil Kumar Ganesan
7136bbe74c Addressed review comments from @privateip 2016-09-12 11:31:46 -07:00
Robin Roth
e4f40d1cdd Speedup git module on clone and pull (#4562)
* remove redundant if submodules_updated

* speed up git by reducing remote commands

* run fetch only once
* run ls-remote less
  * don't run ls-remote if one would run fetch anyhow
* remove unnecessary remote_branch check in clone
  * kept if depth and version given

* fix fetch on old git versions
2016-09-12 13:36:14 -04:00
Brian Coca
da0dac3841 removed chdir / as it breaks tasks
fixes #17466
2016-09-12 12:39:33 -04:00
Brian Coca
067167a9b3 switched to use built in function for validation 2016-09-12 12:39:10 -04:00
Monty Taylor
6ba5dc3188 Don't change to root dir in async_wrapper (#4779)
The daemonizing code here is taken from an ActiveState recipe, which
includes changing to / as a general best practice. While that is
normally true to allow for deleting the directory that the daemon
process started in, in this case it is not relevant as this is not
intended to be an actual long-running daemon.

Issue ansible/ansible#17466
2016-09-12 12:31:40 -04:00
Antonio Murdaca
dc7ba8f3c9 system/systemd: enable systemctl --user (#4208)
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
2016-09-12 11:08:27 -04:00
glovenglaven
9bb0c498df Added Solaris support to core mount module (#4771)
* Added Solaris support to the mount module.

* Added checking so that if a non-standard fstab file is specified it will
still work in Solaris without breaking existing functionality.

* Added a check to avoid writing duplicate vfstab entries on Solaris

* Added "version_added" to new boot option
2016-09-12 08:45:32 -04:00
Dag Wieers
c776932ca3 Don't add included files as arguments on the command line (#4626)
This means we will have to unarchive the complete archive if a single change is found.
Unfortunately we cannot fix this for `unzip`, the only hope is a pure-python reimplementation.

This fixes problems reported in the comments of #3810
2016-09-12 07:47:45 +02:00
Martin Matuška
f07e3d297f Force download if checksums do not match (#4262) 2016-09-12 07:45:46 +02:00
Gregor Giesen
2f3fdc4975 cron: replacement for os.getlogin() (#4777)
os.getlogin() returns the user logged in on the controlling terminal. However
'crontab' only looks for the login name of the process' real user id which
pwd.getpwuid(os.getuid())[0] does provide.

While in most cases there is no difference, the former might fail under certain
circumstances (e.g. a lxc container connected by attachment without login),
throwing the error 'OSError: [Errno 25] Inappropriate ioctl for device'.
2016-09-12 07:39:12 +02:00
Peter Sprygada
987d9b2b4a Merge pull request #4785 from privateip/nxos_config
roll up updates to nxos_config module
2016-09-11 23:47:31 -04:00
Peter Sprygada
61f9fde886 Merge pull request #4788 from privateip/sros_config
roll up updates to sros_config module
2016-09-11 23:47:18 -04:00
Peter Sprygada
3f5e9ee526 Merge pull request #4786 from privateip/iosxr_config
roll up of updates to iosxr_config module
2016-09-11 23:47:04 -04:00
Peter Sprygada
e722ecc3b4 Merge pull request #4784 from privateip/junos_config
roll up updates to junos_config module
2016-09-11 23:46:53 -04:00
Peter Sprygada
739cc715df Merge pull request #4787 from privateip/vyos_config
roll up of updates to vyos_config module
2016-09-11 23:46:38 -04:00
Peter Sprygada
bb66f10b44 Merge pull request #4789 from privateip/ios_config
roll up of updates to ios_config module
2016-09-11 23:46:26 -04:00
Peter Sprygada
efff96bbdd Merge pull request #4790 from privateip/eos_config
roll up of updates to eos_config module
2016-09-11 23:46:09 -04:00
Peter Sprygada
e5ae9b9eea Merge pull request #4783 from privateip/ops_config
roll up updates to ops_config module
2016-09-11 23:45:58 -04:00
nitzmahone
1a0e15094f Fix win_user issue with disabled accounts/expired passwords
Disabled and password-expired accounts cannot call ValidatePassword successfully

fixed #4369
2016-09-11 20:41:54 -07:00
Peter Sprygada
19f1bc07cb roll up updates to nxos_config module
* remote 'updates' argument
* clean up functions
* update doc strings
* add required_if dependencies
2016-09-11 23:25:33 -04:00
Peter Sprygada
42856d9949 roll up updates to junos_config module
* remove 'update' argument
* update doc strings
* reorder functions
2016-09-11 23:23:57 -04:00
Peter Sprygada
f5e64a8953 roll up updates to ops_config module
* 'before' and 'after' now only apply to 'lines' argument
* add required_if dependencies
* update doc strings
* remove 'update' argument
* clean up functions
2016-09-11 23:22:00 -04:00
Peter Sprygada
4f03036428 roll up updates to sros_config module
* update doc strings
* update message if rollback isn't configured
2016-09-11 23:19:23 -04:00
Peter Sprygada
4217adb469 roll up of updates to vyos_config module
* remove 'udpates' argument
* add required_if dependencies
* clean up functions
* update doc strings
2016-09-11 23:17:21 -04:00
Peter Sprygada
e6f1f295f7 roll up of updates to iosxr_config module
* 'before' and 'after' arguments now only apply to 'lines'
* update doc strings
* remove update argument
* clean up warnings
2016-09-11 23:14:28 -04:00
Peter Sprygada
9b5e6bbfa1 roll up of updates to ios_config module
* 'before' and 'after' are now only applied to 'lines'
* remove update argument
* update doc strings
* add path argument when performing config difference
2016-09-11 23:11:59 -04:00
Peter Sprygada
9df9a1dbd4 roll up of updates to eos_config module
* removes update argument
* adds `config` option to replace argument
* moves session management into shared module
* cleans up doc strings
* `before` and `after` args now only apply to lines
2016-09-11 15:31:53 -04:00
Andrew Gaffney
0c05f0dfa4 Fix missing colons in network module examples (#4778) 2016-09-10 14:46:30 +01:00
Peter Sprygada
1ab343a74c Merge pull request #4775 from privateip/sros_rollback
add new module sros_rollback
2016-09-10 02:46:00 -04:00
Peter Sprygada
8e1e8c2cca add new module sros_rollback
Provides a configuration resource for managing the rollback feature on
remote devices running Nokia SROS
2016-09-10 02:43:25 -04:00
Chris Houseknecht
ea9c53e709 Merge pull request #4774 from chouseknecht/devel
Set default log_driver to None
2016-09-10 01:42:13 -04:00
Chris Houseknecht
de0122fdaf
Set default log_driver to None to prevent config comparison when a log_driver is not specified. Fixes #4600. 2016-09-10 01:31:36 -04:00
Chris Houseknecht
01c4d5f99d Merge pull request #4773 from chouseknecht/devel
Purge networks by network name
2016-09-10 00:55:31 -04:00
Chris Houseknecht
0d43a01462 Purge networks using network name rather than ID. Fixes 4596. 2016-09-10 00:51:21 -04:00
Chris Houseknecht
6a9c531bdd Merge pull request #4772 from chouseknecht/devel
Default restart_retries to None rather than 0. Fixes #4534.
2016-09-09 22:33:45 -04:00
Chris Houseknecht
cac4e68090
Default restart_retries to None rather than 0. Fixes #4534. 2016-09-09 22:20:56 -04:00
Ryan Brown
819fe45864 Fix failure when powering on/off EC2 instances by tag only. (#4767)
If you apply `wait=yes` and use `instance_tags` as your filter for
stopping/starting EC2 instances, this stack trace happens:

```
An exception occurred during task execution. The full traceback is:                                                                          │~
Traceback (most recent call last):                                                                                                           │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1540, in <module>                                                            │~
    main()                                                                                                                                   │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1514, in main                                                                │~
    (changed, instance_dict_array, new_instance_ids) = startstop_instances(module, ec2, instance_ids, state, instance_tags)                  │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1343, in startstop_instances                                                 │~
    if len(matched_instances) < len(instance_ids):                                                                                           │~
TypeError: object of type 'NoneType' has no len()                                                                                            │~
                                                                                                                                             │~
fatal: [localhost -> localhost]: FAILED! => {"changed": false, "failed": true, "invocation": {"module_name": "ec2"}, "module_stderr": "Traceb│~
ack (most recent call last):\n  File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1540, in <module>\n    main()\n  File \"/tmp/│~
ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1514, in main\n    (changed, instance_dict_array, new_instance_ids) = startstop_instances│~
(module, ec2, instance_ids, state, instance_tags)\n  File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1343, in startstop_insta│~
nces\n    if len(matched_instances) < len(instance_ids):\nTypeError: object of type 'NoneType' has no len()\n", "module_stdout": "", "msg": "│~
MODULE FAILURE", "parsed": false}
```

That's because the `instance_ids` variable is None if not supplied
in the task. That means the instances that result from the instance_tags
query aren't going to be included in the wait loop. To fix this, a list
needs to be kept of instances with matching tags and that list needs to
be added to `instance_ids` before the wait loop.
2016-09-09 19:38:05 -04:00
Senthil Kumar Ganesan
b5940e1a3e Added Command module to support Dell Networking OS6 2016-09-09 13:50:28 -07:00
Dag Wieers
1cda0b1819 Ensure unicode characters in zip-compressed filenames work correctly (#4702)
* Ensure unicode characters in zip-compressed filenames work correctly

Another corner-case we are fixing hoping it doesn't break anything else.

This fixes:
- The correct encoding of unicode paths internally (so the filenames we scrape from the output and is returned by zipfile match)
- Disable LANG=C for the unzip command (because it breaks the unicode output, unlike on gtar)

* Fix for python3 and other suggestions from @abadger
2016-09-09 09:26:19 -07:00
Peter Sprygada
477c71d985 minor updates to junos_package module for 2.2 (#4761)
* replaces get_module() with NetworkModule()
* removes old call to package_version()
2016-09-09 17:25:21 +01:00