Commit graph

1685 commits

Author SHA1 Message Date
Lorin Hochstein
ec2fc7c983 authorized_key: Set manage_dir default value
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
2013-05-30 16:16:14 -04:00
Michael DeHaan
2a479cca52 Fixup fetch doc formatting. 2013-05-29 10:45:31 -04:00
Michael DeHaan
111f5239b4 Minor style tweak. 2013-05-29 10:14:47 -04:00
Timothy Appnel
e0307445f8 Modified assemble module so the dest file is streamed together rather than built-in memory before writing. 2013-05-29 10:14:47 -04:00
Michael DeHaan
da348cf079 Merge branch 'facter-fix' of git://github.com/flyapen/ansible into devel 2013-05-29 10:00:20 -04:00
Michael DeHaan
738e03f54a Merge pull request #3038 from jsmartin/riak_bugfixes
Riak bugfixes
2013-05-29 06:38:31 -07:00
Guillaume Lasmayous
fe484e5fd7 Implement NetBSD-specific subclass of Hardware in the setup module.
Defines memory and CPU facts:
- memfree_mb
- memtotal_mb
- swapfree_mb
- swaptotal_mb
- processor (a list)
- processor_cores
- processor_count
- devices

As a matter of fact, on NetBSD, it is possible to get memory, swap and
processor facts exactly as on Linux. Tested on NetBSD-5, NetBSD-6 and
NetBSD-6.1 (without Linux emulation).
2013-05-29 09:37:46 -04:00
Michael DeHaan
6864d33dc5 Merge pull request #2867 from cstorey/rabbitmq_user-node-parameter
Allow specification of erlang node name for rabbitmq_user/vhost/parameter actions.
2013-05-29 06:35:09 -07:00
James Martin
8fa7768e91 Now can specify amount of time to wait_for_handoffs or ring ready instead of booleans. 2013-05-27 17:24:10 -04:00
James Martin
9cfcede201 Timeouts implemented for riak stats operation. Removed failback mode
for fetching riak stats.
2013-05-27 17:12:13 -04:00
Lorin Hochstein
4a215203ed Documentation for keystone_user
Updated the module with proper documentation.
2013-05-27 07:35:05 -04:00
Kristof Keppens
f607ba09a4 change fix to lookup path with get_bin_path 2013-05-27 07:38:17 +02:00
Ceri Storey
7b6168aea6 Update rabbitmq_user/vhost/parameter to pass the node to rabbitmqctl using -n flag to rabbitmqctl rather than setting the environment variable. 2013-05-26 14:51:50 +01:00
Michael DeHaan
4105813ebe Lots of formatting fixes 2013-05-24 23:46:23 -04:00
Michael DeHaan
333577c944 Fix tabs and spaces in OpenStack modules. 2013-05-24 23:34:48 -04:00
Michael DeHaan
961b9c1caa Merge pull request #2986 from wbowling/devel
Fixes apt_repository always reporting file uri repos as changed
2013-05-24 20:07:03 -07:00
Michael DeHaan
5836783181 Merge pull request #2976 from stoned/pip-virtualenv_command-pathname
Allow virtualenv_command argument of the pip module to be a pathname
2013-05-24 20:01:12 -07:00
Michael DeHaan
b0f62209c6 Merge pull request #2992 from SirScott/service_pattern
Fixes #2991: Service module pattern argument ignored.
2013-05-24 19:58:42 -07:00
Michael DeHaan
e3f5a26185 Merge pull request #2945 from jsmartin/new_fetch
Fetch destination path can now be overriden.
2013-05-24 19:57:19 -07:00
Michael DeHaan
64779e4a0b Merge pull request #2975 from stoned/doc-pip-fix
Fix pip module documentation (YAML quoting)
2013-05-24 19:55:14 -07:00
Michael DeHaan
65aca6cef6 Merge pull request #2995 from SirScott/pip-sudo-user
pip module -- sudo_user permission problem fix
2013-05-24 19:51:38 -07:00
Michael DeHaan
08024e3d82 Merge pull request #3001 from SirScott/user-always-changing
Fixes #2924: User creation always reports 'changed'
2013-05-24 19:50:48 -07:00
Michael DeHaan
48334d05d7 Merge pull request #2989 from lorin/keystone_user
OpenStack Identity (keystone) user module
2013-05-24 19:39:52 -07:00
Michael DeHaan
a018665188 Merge pull request #2985 from bennojoy/devel
OpenStack Modules
2013-05-24 19:38:19 -07:00
Michael DeHaan
f2a9e3de0b Merge pull request #3016 from bpennypacker/airbrake_deployment
new airbrake_deployment module
2013-05-24 19:37:49 -07:00
Bruce Pennypacker
43b1d36cd8 new airbrake_deployment module 2013-05-24 14:40:37 -04:00
Michael DeHaan
ef4bd4f5b4 Merge pull request #3006 from stoned/doc-fix-npm
Fix typo in npm module documentation preventing it to be processed by an...
2013-05-23 18:08:58 -07:00
Stoned Elipot
a7c5e6246e Fix typo in git module documentation preventing it to be processed by ansible-doc 2013-05-24 01:33:47 +02:00
Stoned Elipot
8a0fc56323 Fix typo in npm module documentation preventing it to be processed by ansible-doc 2013-05-24 01:27:46 +02:00
Scott Sturdivant
ffb50dfb34 Fixes #2924: User creation always reports 'changed' 2013-05-23 13:43:23 -06:00
James Martin
79cd04e689 Initial Commit. 2013-05-23 13:33:36 -04:00
Scott Sturdivant
cc1f1368e4 Chdir to tempdir to prevent permissions problems. 2013-05-23 10:56:52 -06:00
Scott Sturdivant
0110b616cb Fixes #2991: Service module pattern argument ignored. 2013-05-23 09:39:26 -06:00
Lorin Hochstein
869e14c318 OpenStack Identity (keystone) user module
Module for managing users, tenants, and roles within OpenStack.
2013-05-23 10:35:27 -04:00
Kristof Keppens
dc20d63919 fix for facter being installed in a different location 2013-05-23 11:21:01 +02:00
William Bowling
5537358532 Fixes apt_repository always reporting file uri repos as changed 2013-05-23 12:39:22 +10:00
bennojoy
2221c33b15 OpenStack Modules 2013-05-23 07:55:05 +05:30
Stoned Elipot
c6712b35a2 Allow virtualenv_command argument of the pip module to be a pathname 2013-05-22 18:15:21 +02:00
Stoned Elipot
1082ba6c1c Fix pip module documentation (YAML quoting) 2013-05-22 18:09:01 +02:00
Bruce Pennypacker
3926f76644 Fixed handling of urlopen result to work properly under both python 2.4 and python 2.6 2013-05-21 13:59:42 -04:00
John Jarvis
008e18d1d3 fixes case where name is omitted from pip arg list
This code:
```
    if name.endswith('.tar.gz') or name.endswith('.tar.bz2') or
name.endswith('.zip'):
        is_tar = True
```
was not checking whether name is defined since it is an
optional param.
2013-05-18 20:59:21 -04:00
John Jarvis
fc61824591 fixing syntax error 2013-05-18 19:49:25 -04:00
Michael DeHaan
47675caab5 Merge pull request #2948 from jcbagneris/devel
Fixes in apt module doc: typos, examples
2013-05-18 13:33:27 -07:00
Michael DeHaan
ae00f617b0 Merge pull request #2942 from stoned/doc-requirements
Fix empty requirements specifications in modules documentation
2013-05-18 13:26:41 -07:00
Michael DeHaan
3ad9866124 Merge pull request #2941 from bcoca/setup_bin
no uses get_bin_path for 2nd use of ip tool
2013-05-18 13:22:24 -07:00
Michael DeHaan
fc36695e7a Merge pull request #2940 from madema/patch-3
-o and -r option don't exist on AIX
2013-05-18 13:21:48 -07:00
Michael DeHaan
e98e1dfa6c Merge pull request #2934 from j2sol/git-update
Add an update option to the git module
2013-05-18 13:14:04 -07:00
Michael DeHaan
2209f44371 Merge pull request #2932 from bcoca/apt_getbins
apt now uses module function to find bin paths
2013-05-18 13:13:04 -07:00
Michael DeHaan
3a8ee045d1 Merge pull request #2931 from caredotcom/flowdock_nochange
flowdock module returns changed=false on succes
2013-05-18 13:03:00 -07:00
Michael DeHaan
522b809bf1 Merge pull request #2921 from lwade/ec2_fact_doc
Added a helpful example to the ec2_facts doc.
2013-05-18 12:58:33 -07:00