Monty Taylor
c2b695390b
Actually pass in is_public to create_image
...
Fixes #2325
2016-12-08 11:23:43 -05:00
Brian Coca
e0d4d397ff
fixed mispelled description
2016-12-08 11:23:42 -05:00
Etherdaemon
63c8c40a37
Update try statement as pointed out by defionscode
2016-12-08 11:23:42 -05:00
Brian Coca
505467d2ff
clarified ping module purpose
2016-12-08 11:23:42 -05:00
Toshio Kuratomi
a5d95b4047
Another fix for docs
2016-12-08 11:23:42 -05:00
Toshio Kuratomi
ac58ef1404
Correct docs build
2016-12-08 11:23:42 -05:00
Brian Coca
7c0dc323a2
corrected docs for stat's lnk_source fixes #12850
2016-12-08 11:23:42 -05:00
Toshio Kuratomi
80b3bbd55e
Mark a few parameters as no_log
2016-12-08 11:23:42 -05:00
David Shrewsbury
024b8365c2
Clarify password requirement and add return docs.
2016-12-08 11:23:42 -05:00
David Shrewsbury
c66491c076
Add OpenStack Keystone User module
...
This is a replacement for PR #1598 and fixes #283
2016-12-08 11:23:42 -05:00
Constantin Bugneac
55afa7e944
Added documentation for returned structure
2016-12-08 11:23:42 -05:00
Etherdaemon
9fe689eaec
fixes #12831 by updating the boto iam connection method to connect_to_region
2016-12-08 11:23:42 -05:00
Constantin Bugneac
aa887ce49f
Included 'block_device_mapping' in the output of module and other missing attributes
2016-12-08 11:23:42 -05:00
Brian Coca
baeb6d8dc0
fixed bug in spec
2016-12-08 11:23:42 -05:00
Brian Coca
a964754484
added regex support to find, also added 'singular' aliasess to patterns and paths
2016-12-08 11:23:42 -05:00
Brian Coca
9f503540f1
added missing version_added to new accesslogs feature
2016-12-08 11:23:42 -05:00
David Shrewsbury
92e6e2f7ea
Fix os_router to accept internal interfaces
...
Allow the 'interfaces' attribute to represent internal router
interfaces, composed of subnet names, and the 'external_fixed_ips'
attribute to represent external interface subnet/IP.
2016-12-08 11:23:41 -05:00
Toshio Kuratomi
d5f3ac2a1d
Remove debugging
2016-12-08 11:23:41 -05:00
Toshio Kuratomi
931fa9b6b2
xmlcharrefreplace is only for encoding, not for decoding :-(
2016-12-08 11:23:41 -05:00
Brian Coca
721f587e43
made output match multiline, as per posted code from @n0trax fixes #2081
2016-12-08 11:23:41 -05:00
Brian Coca
0540769677
specified that uri must be uppercase
2016-12-08 11:23:41 -05:00
Lars Kellogg-Stedman
fc741057b2
add some unit tests for the os_server module
...
This commit adds some unit tests for the `cloud.openstack.os_server`
module. These tests exercise `_network_args` thoroughly and
`_create_server` lightly.
These tests will **fail** until #2275 lands.
To run the tests:
pip install -r test-requirements.txt
PYTHONPATH=$PWD py.test
2016-12-08 11:23:41 -05:00
Lars Kellogg-Stedman
413a9d0c62
fix handling of nics argument
...
The existing code was receiving a list of strings and erroneously
assuming it was being given a list of dictionaries, leading it to fail
with:
AttributeError: 'str' object has no attribute 'get'
This commit corrects the list handling code to check the type of each
item and handle it appropriately. Also, based on bcoca's comment
in #2253 , thie code removes the special case for a string-only argument.
By transforming string arguments into dicts and then handling them like
any other dict argument, this also permits arguments of the form:
nics: net-name=mynet
Or:
nics: port-name=mynet
Previous versions of this code only supported `net-id` and `port-id` in
string specifications.
2016-12-08 11:23:41 -05:00
Monty Taylor
db59af564e
Make the auto ip parameter auto_ip
...
There was a parameter in the docs called 'public_ip' that didn't
actually exist. Additionally, auto_floating_ip is not consistent with
the underlying parameter which is auto_ip - for no good reason.
Add auto_ip as the real parameter, and then make public_ip and
auto_floating_ip as aliases for it for backwards compatability.
Fixes #2301
2016-12-08 11:23:41 -05:00
Brian Coca
28749a794a
added note on when reboot command became available fixes #2050
2016-12-08 11:23:41 -05:00
Brian Coca
5ecbd6c63a
fixed results docs
2016-12-08 11:23:41 -05:00
Toshio Kuratomi
9c5ce44477
Some docs fixes
2016-12-08 11:23:41 -05:00
Brian Coca
d6f474761d
documented new remote_src option
2016-12-08 11:23:41 -05:00
Gilad Peleg
295a28e128
Docs: remove redundant quotes in ec2_elb docs
2016-12-08 11:23:41 -05:00
Gilad Peleg
c340587bb8
Docs: add state choices to ec2_elb_lb
...
add state options (`present` and `absent`) to `ec2_elb-lb` doc
2016-12-08 11:23:41 -05:00
Val Komarov
0b294d69c5
Remove duplicate logic
2016-12-08 11:23:41 -05:00
dagnello
11f66c0742
Adding string support to metadata argument
...
This patch adds support to setting metadata key/value through a string
argument. Variables can now be used for both the metadata key and
value.
example:
meta: "{{ var1 }}:SomeValue,key:{{ var2 }}"
2016-12-08 11:23:41 -05:00
Tim Barnes
d98683e1c5
fixing issue with subversion module whereby the module was reporting local modifications being present when externals were being used
2016-12-08 11:23:41 -05:00
whiter
9ee13c4e55
Add region to doc and handle missing region parameter
2016-12-08 11:23:40 -05:00
Rob
11c0be06fb
Update ec2_vol.py
...
Changed=true now reported on new volume.
Only detach volume when instance is specified as 'None' or '' rather than whenever instance is not specified at all
Fix regression caused by 6b27cdc
where by no volume is created if id or Name is not supplied
Remove unnecessary empty aliases
Corrected example to use acceptable parameter for ions
Added exception handling to get_all_instances call
Moved the attachment state validation code to attach_volume function rather than create_volume function
Refactored attach_volume and detach_volume so that changed state can be passed back to call
Created get_volume_info function so that state=present and state=list can return the same data. Also added instance_id as a returned value in attachment_set dict
Updated aws connection method so that boto profile can be used
2016-12-08 11:23:40 -05:00
Adam Williamson
83d941da27
fix #2043 : strip empty dict from end of 'pull' stream
...
When pulling an image using Docker 1.8, it seems the output
JSON stream has an empty dict at the very end. This causes
ansible to fail when pulling an image, as it's expecting a
status message in that dict which it uses to determine whether
it had to download the image or not. As a bit of an ugly hack
for that which remains backward compatible, try the last item
in the stream, and if it's an empty dict, take the last-but-one
item instead.
The strip() is needed as the exact value appears to be '{}/r/n';
we could just match that, but it seems like the kind of thing
where maybe it'd happen to just be '{}/n' or '{}' or something
in some cases, so let's just use strip() in case.
2016-12-08 11:23:40 -05:00
Sam Yaple
a4a4b6f423
Catch the second occurance of ExposedPorts as well
2016-12-08 11:23:40 -05:00
Sam Yaple
463fb5a058
Don't assume ExposedPorts exists (bug #2257 )
...
A recent change [1] in docker between v1.8.2 and v1.8.3 changed what
is returned in the json when inspecting an image. Five variables which
could have been expected before will now be omited when empty. Only
one of those variables is being addressed in the docker, ExposedPorts.
Unfortunately there was also no API version change on this so this
can't be easily corrected with pinning the API to the older version.
This does a get() which will return None if the variable is not in the
dict formed from the json that was returned. Everything else works the
same way.
[1] 9098628b29
2016-12-08 11:23:40 -05:00
jhawkesworth@users.noreply.github.com
183430628b
Fix for ansible modules core 2147
2016-12-08 11:23:40 -05:00
Michael Perzel
1fc2c8c324
Added date, year and month attributes
2016-12-08 11:23:40 -05:00
Michael Perzel
7ee0fa3b4b
Add ansible_date_time to windows facts
2016-12-08 11:23:40 -05:00
Constantin Bugneac
7dd5ec5373
Added deleteOnTermination in the output of list option
2016-12-08 11:23:40 -05:00
Abhijit Menon-Sen
e9071c62ba
Add missing variable initializations
...
Without this, «ec2: state=stopped instance_ids=…» would fail with a
traceback like this:
if inst.get_attribute('sourceDestCheck')['sourceDestCheck'] != source_dest_check:
NameError: global name 'source_dest_check' is not defined
2016-12-08 11:23:40 -05:00
Brian Coca
a1484a0e5b
doc fixes
2016-12-08 11:23:40 -05:00
Frank van Tol
5872e0a493
Update ec2_asg.py
2016-12-08 11:23:40 -05:00
Toshio Kuratomi
2c378cc78a
Fix for state=latest with wildcard or virtual provide package names
2016-12-08 11:23:40 -05:00
Achilleas Pipinellis
961082620c
Add missing documentation: cron_file requires user to be set
2016-12-08 11:23:40 -05:00
Rob
ed3d248234
Move import statements for easier debugging (correct line numbers)
2016-12-08 11:23:40 -05:00
Brian Coca
205d607320
added version added to new rax_cdb choices
2016-12-08 11:23:40 -05:00
Brian Coca
2d7b1bd1c4
added comment explaining chdir defaults
2016-12-08 11:23:39 -05:00
Brian Coca
d34f89a6fe
default chdir to tmpdir to avoid virtualenv issues
2016-12-08 11:23:39 -05:00
Brian Coca
68e7945767
make chdir a path so it resolves shell aliases also removed this_dir logic as it is not needed, chdir is None by default and run_command can handle that.
2016-12-08 11:23:39 -05:00
Rob
61af70c087
Set default of dimensions parameter to be empty dict
2016-12-08 11:23:39 -05:00
Andrew Widdersheim
7d174daa77
Fix detached head detection in is_not_a_branch()
...
Detached head detection seems to have broken somewhere a long the way
because git decided to change how that situation looks when doing a 'git
branch -a' which is performed by get_branches().
This is how git 1.7.1 displays this situation (which works):
shell> git branch -a
* (no branch)
master
This is the output from git 1.8.3.1 (which does not work):
shell> git branch -a
* (detached from e132711)
master
It looks like this same wording is used in the most recent version of
git (2.6.1 as of writing this).
2016-12-08 11:23:39 -05:00
gekmihesg
d003fcd662
Support sysctl on OpenBSD
...
Fixes #1233
2016-12-08 11:23:39 -05:00
fperks
11dbd985b6
Fix error on ec2 status change
...
Both `source_dest_check` and `termination_protection` variables are not
available within the scope of the startstopec2 instance method. This just
pulls them from module.params.
2016-12-08 11:23:39 -05:00
James Cammarata
3e6f39dd2b
Adding version file for core modules on devel branch
2016-12-08 11:23:39 -05:00
Adrian Lopez
624e95d718
Fix yaml syntax
2016-12-08 11:23:39 -05:00
fxfitz
61cdc2ae90
Fixed spelling mistake: missing
2016-12-08 11:23:39 -05:00
Brian Coca
5b1a508d6a
restored quotes to checksum description to avoid breaking docs
2016-12-08 11:23:39 -05:00
Gerard Lynch
27f93bef40
minor doc fix
2016-12-08 11:23:39 -05:00
muszynski@so1.net
2e3ad2b80a
description for the get_url module describing checksum verification before file download
2016-12-08 11:23:39 -05:00
Colin Hutchinson
d70c33f932
make a text link into a actual hyperlink
...
the text link doesn't fit on some screen resolutions. Making it into sphinx hyperlink will solve that
2016-12-08 11:23:39 -05:00
Matias De Carli
f2bc0a6d85
keep backwards compatibility
2016-12-08 11:23:39 -05:00
Simon Li
607b7c14bd
Fix incorrect variable in group.py: user -> group
2016-12-08 11:23:39 -05:00
Toshio Kuratomi
99659c8667
Fix docs build
2016-12-08 11:23:38 -05:00
David Shrewsbury
bf9c3e0092
Add author to os_router
2016-12-08 11:23:38 -05:00
David Shrewsbury
78ea0df607
Deprecate older router modules.
...
The quantum_router_gateway.py and quantum_router_interface.py modules
are deprecated with this change.
2016-12-08 11:23:38 -05:00
James Cammarata
395253c581
A few bug fixes and tweaks for the accelerate module
2016-12-08 11:23:38 -05:00
Brian Coca
45907f2ff3
removed typo
2016-12-08 11:23:38 -05:00
Brian Coca
d55ba3ab7c
removed syslog in favor of common module logging functions
2016-12-08 11:23:38 -05:00
Brian Coca
682cb99d45
revert must_exist
2016-12-08 11:23:38 -05:00
Shayne Clausson
92f88a4cb4
Replaces 'old' get_ec2_creds connection method with get_aws_connection_info to support passing in security_token for temporary creds.
2016-12-08 11:23:38 -05:00
David Shrewsbury
f91cc1d3e5
Allow setting external attribute
...
With shade > 0.13.0, networks can be created that are externally
accessible. This adds a parameter for that.
Also, add RETURN documentation and 'if __name__' check around call
to main().
2016-12-08 11:23:38 -05:00
David Shrewsbury
14546fe33c
Allow complete router configuration
...
This change allows one to completely configure a router, including
gateway and interfaces, using the latest shade (>0.13.0).
2016-12-08 11:23:38 -05:00
justnom
b724bf8f1c
Adding additional Docker log drivers.
...
Adding additional `log_driver` choices:
* journald
* gelf
* fluentd
Compatible with Docker version >= 1.8.0
2016-12-08 11:23:38 -05:00
Alex Kessinger
4d227e508d
Fix a argument mismatch in elasticache
...
I think in this commit 720aeffca2
There was bug introduced where the ElastiCacheManager init method has
a number of positional arguments like so.
```py
def __init__(self, module, name, engine, cache_engine_version, node_type,
num_nodes, cache_port, parameter_group, cache_subnet_group,
cache_security_groups, security_group_ids, zone, wait,
hard_modify, region, **aws_connect_kwargs):
```
But then later in the code the positional arguments are passed in
like this.
```py
elasticache_manager = ElastiCacheManager(module, name, engine,
cache_engine_version, node_type,
num_nodes, cache_port,
cache_subnet_group,
cache_security_groups,
security_group_ids, parameter_group, zone, wait,
hard_modify, region, **aws_connect_kwargs)
```
If you count, you can see that cache_subnet_group, is being passed in
where the manager expects to see parameter_group.
2016-12-08 11:23:38 -05:00
Matt Calhoun
52f9c3468c
The variable $uppercase_cert_thumbprint cannot be retrieved because it has not been set.
2016-12-08 11:23:38 -05:00
Matt Calhoun
a9d954b087
The variable $winrm_cert_thumbprint cannot be retrieved because it has not been set.
2016-12-08 11:23:38 -05:00
Matt Calhoun
70f7f144e0
The variable $https_listener cannot be retrieved because it has not been set.
2016-12-08 11:23:38 -05:00
Matt Calhoun
72970ab7a8
The variable $winrm_https_listener_path cannot be retrieved because it has not been set
2016-12-08 11:23:38 -05:00
Jens Carl
00f9dfac34
Change type of parameter 'template' to 'path'.
2016-12-08 11:23:38 -05:00
Gerard Lynch
f85a8ac746
allow use of volume_type in volumes dict
2016-12-08 11:23:37 -05:00
Jens Carl
507111f090
Fix to handle user directory within parameter 'template'.
2016-12-08 11:23:37 -05:00
Toshio Kuratomi
e7a48cfb40
Use is_executable from its new location
2016-12-08 11:23:37 -05:00
Toshio Kuratomi
e7d9d86ec9
No longer check for tmp_path being sent as we don't use it here anyway
2016-12-08 11:23:37 -05:00
Tom Bamford
dbf882a600
Clarify available options for device_mapping parameter of ec2_ami module
2016-12-08 11:23:37 -05:00
varnav
a05df49998
Fixed confusion in the docs
...
As 'path' is actually alias for 'dest', this could be confusing.
2016-12-08 11:23:37 -05:00
Toshio Kuratomi
58573187f8
Change the example of rsync_opts to use a list instead of a string
...
Fixes #9889
2016-12-08 11:23:37 -05:00
Shawn Silva
2962dabeda
Fix for modifying the size of an RDS instance. When attempting to modify the size of an RDS instance Ansible succeeds and returns a "changed" status. However, no changes are applied to the RDS instance. Boto is looking for a keyword parameter of "allocated_storage" to update the size, and this parameter wasn't being included.
2016-12-08 11:23:37 -05:00
Selivanov Pavel
63d2575f9f
ec2_group.py: added ICMP rule example
2016-12-08 11:23:37 -05:00
Greg DeKoenigsberg
c2cc7f17a3
Change author field for os_redhat_subscription.py
2016-12-08 11:23:37 -05:00
Nathaniel Felsen
ec14a5c728
Adding support for access logs in ELB
2016-12-08 11:23:37 -05:00
dagnello
ec1c18e3d5
Adding new os_subnets_facts module
...
There can be instances during an Ansible play where the list of subnets
currently available from OpenStack is required. This update provides
subnet list functionality as a new os_subnets_facts module.
2016-12-08 11:23:37 -05:00
Matias De Carli
d32809cadb
updated dependencies to work with azure.py 1.0.1
2016-12-08 11:23:37 -05:00
dagnello
d46894cf91
Adding new image facts module
2016-12-08 11:23:37 -05:00
dagnello
d76f6cceed
Adding os_port Module to openstack ansible modules
2016-12-08 11:23:36 -05:00
whiter
82c898be5a
Remove 'str' type so that json is properly quoted
2016-12-08 11:23:36 -05:00
Chris Church
7eb7efb737
Fix win_lineinfile to pass integration tests when strict mode is enabled.
2016-12-08 11:23:36 -05:00
dagnello
a4148c50e9
Adding os_networks_facts module
...
There can be instances during an Ansible play where the list of networks
currently available from OpenStack is required. This update provides
network list functionality as a new os_networks_facts module.
2016-12-08 11:23:36 -05:00
Abitha Palaniappan
5047561036
os_server: Adding support to accept 'n' nic args as a string containing list
2016-12-08 11:23:36 -05:00
Mike Boone
dd76088019
Updated link to the FAQ.
2016-12-08 11:23:36 -05:00
evanccnyc@users.noreply.github.com
ff81aa11c0
Fixing ec2_asg termination_policy
...
If this isnt set, it wont launch the instances because it needs to default to "Default" despite what boto docs say.
2016-12-08 11:23:36 -05:00
Chris Church
c56db7920a
Revert "Improvements to win_feature"
2016-12-08 11:23:36 -05:00
James Cammarata
4a4674ca24
Fix syntax error in synchronize docstring
2016-12-08 11:23:36 -05:00
David Shrewsbury
b67fb2bd29
More os_router module cleanup and fixes.
...
Added a RETURN section, corrected version_added value, removed use of
'result' in exit_json() calls.
2016-12-08 11:23:36 -05:00
Frank van Tol
db6c6ec5c9
Update s3.py
...
We are copying from S3, the bucket is the source, not the target.
2016-12-08 11:23:36 -05:00
Rob
08999ecfd1
Update iam_policy.py
...
Fixed doc for policy_name - it is a required field
Removed empty aliases
2016-12-08 11:23:36 -05:00
Chris Church
c35d7304c9
Revert "Rename powershell versions of setup and slurp so they don't shadow the python versions of these modules."
...
This reverts commit d4e16b0c73
.
2016-12-08 11:23:36 -05:00
Gerard Lynch
3339749017
order params, add missing tag param. update examples
2016-12-08 11:23:36 -05:00
Toshio Kuratomi
29cfd80220
Fix improper indentation
2016-12-08 11:23:36 -05:00
skylerbunny
dabf94ab1f
Explanation of privilege escalation in notes
...
An attempt to make clear how privilege escalation works with respect to the src/source host and dest/destination host. One existing note was incorporated into three new ones, iterating each.
2016-12-08 11:23:36 -05:00
Toshio Kuratomi
8ce7348d52
Rename powershell versions of setup and slurp so they don't shadow the python versions of these modules.
...
This change goes along with https://github.com/ansible/ansible/02502c5727753d02819cb32b94dc2035b65d81a7
2016-12-08 11:23:35 -05:00
Evan Carter
5cd3217fc8
fixing termination policies for ec2_asg
2016-12-08 11:23:35 -05:00
Evan Carter
e9c04cfdfd
Fixing bug #2058 and adding some backwards compatibility
2016-12-08 11:23:35 -05:00
Brian Coca
99159b3cdd
changed chmod to 2.4 compat
2016-12-08 11:23:35 -05:00
Rob
4f9bb86e58
Add exception handling to iam
2016-12-08 11:23:35 -05:00
wimnat
540061c9fc
Remove unnecessary json.loads
2016-12-08 11:23:35 -05:00
Tom Fotherby
135e7c60de
Fix #1984 - allow load_balancer_port as a variable
2016-12-08 11:23:35 -05:00
Abitha Palaniappan
d26bff8162
Add support for port-id,port-name to nics in os_server
2016-12-08 11:23:35 -05:00
Sam Mingo
75473c0fd0
Update get_url.py
...
Fixed typo with header parameter to get_url in the documentation.
2016-12-08 11:23:35 -05:00
Victor Costan
8d9768c049
Fix indentation in os_server documentation
2016-12-08 11:23:35 -05:00
Yanchek99
ebbd206e86
Fixed typo for instance_tags documentation
2016-12-08 11:23:35 -05:00
David Dyball
cdff62643b
Updated PR based on comments
2016-12-08 11:23:35 -05:00
Taneli Lepp
fb317c72b6
Added option to set multiple ACLs for S3 objects. Also verifies the selected permissions against Boto's canned ACL strings list.
2016-12-08 11:23:35 -05:00
Bret Martin
b1c5b17155
Use general-purpose parameter mutual exclusion code for network_interfaces
2016-12-08 11:23:35 -05:00
Bret Martin
0afa813324
Add alias network_interface
and accept a string for a single ENI
2016-12-08 11:23:35 -05:00
Bret Martin
df8b2d45bc
Add network_interfaces example
2016-12-08 11:23:35 -05:00
Bret Martin
96d8401fb4
Remove aliases specification from documentation since there are none
2016-12-08 11:23:35 -05:00
Brian Coca
281a92bbdd
corrected whitepace
2016-12-08 11:23:34 -05:00
Toshio Kuratomi
b952dff2c1
correct documentation formatting
2016-12-08 11:23:34 -05:00
Victor Costan
2f11d96d49
os_server: nice error when flavor not found
...
When we can't find the VM flavor that the user requests, this change replaces the non-descript stack trace with a clear error message.
2016-12-08 11:23:34 -05:00
Bret Martin
df713192b4
Add network_interfaces parameter to ec2 module to support launch-time ENIs
2016-12-08 11:23:34 -05:00
Toshio Kuratomi
b3262479e9
Fix read-only usage to depend on the docker-py and docker server version
2016-12-08 11:23:34 -05:00
Toshio Kuratomi
13ab511642
We had two separate methods trying to do the same thing but neither one was complete. This merges them so that all of the options get parsed and applied.
2016-12-08 11:23:34 -05:00
Toshio Kuratomi
33f5afa779
Make sure listener ports are ints.
...
May fix #1984
2016-12-08 11:23:34 -05:00
Brian Coca
917b7071d6
partially reverted previous change to deal with systemctl show status not returning errors on missing service Now it looks for not-found key instead of running status which does return error codes when service is present but in diff states. fixes #12216
2016-12-08 11:23:34 -05:00
James Martin
c90bf9df98
Adds sanity check to make sure nics is a list.
2016-12-08 11:23:34 -05:00
Charles Paul
6011381bf0
vm_floppy 2.0 support
2016-12-08 11:23:34 -05:00
Chrrrles Paul
1ae0427d4e
Revert "Add 2.0 docs - Revert "add virtual floppy to VMware guest""
2016-12-08 11:23:34 -05:00
Chrrrles Paul
e8aaed3bbb
Revert "add virtual floppy to VMware guest"
2016-12-08 11:23:34 -05:00
Brian Coca
fd23120d42
check systemctl status before show as show will not return antyhing other than rc=0 even when it fails.
2016-12-08 11:23:34 -05:00
Colin Hutchinson
9d77cef5be
Remove the sample SHA256
...
putting a full sha256 made the width of the table in the generated docs not fit on some screens
2016-12-08 11:23:34 -05:00
Tony Kinsley
79f98bffcf
Adding start and stop actions to os_server_actions
...
Also making the os_server module allow a server in the possible new
states from the os_server_actions changes
2016-12-08 11:23:34 -05:00
Chris Church
9ed0a5a920
* Update core modules to fix strict mode errors. * Also fix creates parameter issue in win_msi as described in https://github.com/ansible/ansible-modules-core/issues/129 , slightly different fix from https://github.com/ansible/ansible-modules-core/pull/1482 * Fix setup.ps1 module issue described in https://github.com/ansible/ansible-modules-core/issues/1927
2016-12-08 11:23:34 -05:00
Bruno Galindro da Costa
6f36629d13
Added termination_policies option
2016-12-08 11:23:33 -05:00
Jérémie Astori
6695cc5c21
Fix physical walk on acl module for Linux
...
`-h` is for BSD [1] while `-P`/`--physical` is for Linux [2].
This commit fixes that option now that acl module is (temporarily)
only supported for Linux.
I will re-add `-h` when fixing BSD support.
[1]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[2]: http://linuxcommand.org/man_pages/setfacl1.html
2016-12-08 11:23:33 -05:00
Jérémie Astori
186cc7cb17
Make sure entry is not sent when acl state=query
2016-12-08 11:23:33 -05:00
Jérémie Astori
3568f1cd78
Make sure permission-less entries are accepted when state=absent
...
Also, remove that try condition as, at that stage, no permissions with
other than 2 or 3 fields are sent to the function.
2016-12-08 11:23:33 -05:00
Jérémie Astori
a93445c798
Remove support for d[efault]:
in entry permissions
...
It is not documented in [the Ansible doc page][1] nor
[the BSD setfacl man entry][2] (which means it might not be compatible
with BSD) so removing it does not break the API.
On the other hand, it does not conform with POSIX 1003.1e DRAFT
STANDARD 17 according to the [Linux setfacl man entry][3] so safer to
remove.
Finally, the most important reason: in non POSIX 1003.e mode, only ACL
entries without the permissions field are accepted, so having an
optional field here is very much error-prone.
[1]: http://docs.ansible.com/ansible/acl_module.html
[2]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[3]: http://linuxcommand.org/man_pages/setfacl1.html
2016-12-08 11:23:33 -05:00
Toshio Kuratomi
ffbd1efaa7
Remove non-ascii quote char
2016-12-08 11:23:33 -05:00
Rick Mendes
8048c4482a
using single device_id and enabling release on disassociation
2016-12-08 11:23:33 -05:00
Marius Gedminas
b2fc74337a
authorized_key: fix example in documentation
...
'key=' cannot be pointing to a file name; it needs to be the key itself as a string (or a URL).
2016-12-08 11:23:33 -05:00
Tim Rupp
223cac3f39
Add hostname support for Kali linux 2.0
...
This patch allows the hostname module to detect and set the hostname for a
Kali Linux 2.0 installation. Without this patch, the hostname module raises
the following error
hostname module cannot be used on platform Linux (Kali)
Kali is based off of Debian.
2016-12-08 11:23:33 -05:00
Luke
aa9b8b8552
removed hyphens in module name in examples
2016-12-08 11:23:33 -05:00
Timothy Appnel
488749500e
Clarified and cleaned up grammar of error messages.
2016-12-08 11:23:33 -05:00
Timothy Appnel
d811a51744
Fixed call to undefined attribute when RDS module timeouts waiting.
2016-12-08 11:23:33 -05:00
Marius Gedminas
f97d00fbad
user: don't generate SSH keys in check mode
...
Fixes https://github.com/ansible/ansible/issues/11768
Test plan:
- (in a Vagrant VM) created a user 'bob' with no ssh key
- ran the following playbook in check mode:
---
- hosts: trusty
tasks:
- user: name=bob state=present generate_ssh_key=yes
- saw that ansible-playbook reported "changes=1"
- saw that /home/bob/.ssh was still absent
- ran the playbook for real
- saw that /home/bob/.ssh was created
- ran the playbook in check mode again
- saw that ansible-playbook reported no changes
- tried a variation with a different username for a user that didn't
exist: ansible-playbook --check worked correctly (no errors, reported
"changed")
2016-12-08 11:23:33 -05:00
Marius Gedminas
270c2e8bbd
apt: check for "0 upgraded" to be at the beginning of the line
...
Fixes #1678 .
2016-12-08 11:23:33 -05:00
Till Backhaus
e005ef0c36
Delete dead and broken code
2016-12-08 11:23:33 -05:00
Omri Iluz
1c6acc3e8f
No need for .keys on volumes list
...
Since c3f92cca21
changed "volumes" to be a list instead of a dictionary, we don't need (and cannot) .keys when appending to set.
Reported as bug #1957
2016-12-08 11:23:33 -05:00
Simon Li
28c44c554c
Don't fail in check_mode if user exists
...
PR #1651 fixed issue #1515 but the requirement for path to be defined is unecessarily strict. If the user has previously been created a path isn't necessary.
2016-12-08 11:23:33 -05:00
James Cammarata
b9ca912ffe
Fixing region requirement regarding euca clusters
...
Fixes ansible/ansible#11023
2016-12-08 11:23:32 -05:00
nitzmahone
51154a6991
added windows facts ansible_lastboot, ansible_uptime_seconds
...
switched OS object to Get-CimInstance since we need a DateTime object for lastbootuptime
2016-12-08 11:23:32 -05:00
Toshio Kuratomi
1102afed43
Fix for the case where plugins aren't loaded on old RHEL systems
2016-12-08 11:23:32 -05:00
Toshio Kuratomi
77457feda6
Return change results in a dictionary listing the package names.
...
Fix a parsing problem when package names contain a dot.
2016-12-08 11:23:32 -05:00
Brian Richards
c054a058c0
Preventing servers that are deleted and left in the deleted state from being included in the server list
2016-12-08 11:23:32 -05:00
Nithy Renganathan
eb3f28effc
Handle the changed value
2016-12-08 11:23:32 -05:00
Jason Cowley
2c511a9470
Add support for S3 canned permissions. resolves #1939
2016-12-08 11:23:32 -05:00
Sam Yaple
f2c1eeb54c
Actually remove the section we are replacing
2016-12-08 11:23:32 -05:00
Sam Yaple
52d364b74c
Refix bug 1226 after revert
...
This patch properly fixes bug 1226 without introducing a breaking
change to idempotency which was introduced in PR #1358
We can properly assign permissions to databases with a '.' in the name
of the database as well as assign priviliges to all databases as
specified with '*'
2016-12-08 11:23:32 -05:00
Jérémie Astori
1b34f1a7ac
Fix wrong expectation regarding entry format in acl module
2016-12-08 11:23:32 -05:00
Jérémie Astori
6c298e20c0
Fix wrong processing of lines returned by setfacl in test mode
2016-12-08 11:23:32 -05:00
Jérémie Astori
08e8f732c5
Fix minor whitespace issues
2016-12-08 11:23:32 -05:00
Brian Coca
9ad712018c
deal with more failures when apt module fails to instantiate pkg fixes #1499
2016-12-08 11:23:32 -05:00
Mahesh Sawaiker
4b6471d5e7
support creating role only
2016-12-08 11:23:32 -05:00
Ilya Epifanov
cbbf284a74
fixed memory_limit for docker api version >= 1.19
2016-12-08 11:23:32 -05:00
David M. Lee
4cd2fcf917
ec2_vol: Added missing "needs 2.0" doc
...
The ability to find-or-create a volume was added in 2.0. Added note to
the example.
2016-12-08 11:23:32 -05:00
Evan Carter
c1526ff87b
Adding the ability to associate eips with network interfaces
2016-12-08 11:23:31 -05:00
Shobhit Srivastava
316ccb0e65
checking remote_group_id while comparing os_security_group_rule
2016-12-08 11:23:31 -05:00
Sam Yaple
f8bcdffa36
Revert "escapeds changes"
...
While this change doesn't break the creation, it does break
idempotency. This change will convert '*.*' to '`*`.*' which is
functionally the same, however when the user_mod() function looks up
the current privileges with privileges_get() it will read '*.*'
Since '*.*' != '`*`.*' it will go through the process of updating the
privleges always resulting in a 'changed' result.
This reverts commit db9ab9b262
.
2016-12-08 11:23:31 -05:00
Brian Lloyd
e6ffb60855
Windows implementation of lineinfile and related documentation
2016-12-08 11:23:31 -05:00
Jason DeTiberus
3619630972
python 2.4 syntax fix
2016-12-08 11:23:31 -05:00
Jason DeTiberus
8bc90c6a62
Add example for changing consumed subscriptions
2016-12-08 11:23:31 -05:00
Adam Ever-Hadani
8fb52e0a8b
added support for 'collectstatic clear' in django_manage.py
2016-12-08 11:23:31 -05:00
brannon
8691d56f3c
Support creating new VMs by cloning an existing VM. Support setting power state of cloned VMs.
2016-12-08 11:23:31 -05:00
Scot Spinner
0fff871819
one thing missed
2016-12-08 11:23:31 -05:00
Guto Andreollo
81a1579e20
Added the 'hw_interfaces' array, listing the names of all interfaces present on the VM as 'ansible_interfaces' lists the ones seen by the operating system
2016-12-08 11:23:31 -05:00
Andrew Briening
bd531f87bc
Show the exception messages
2016-12-08 11:23:31 -05:00
Matthias Frey
2ed50d5e5b
assemble: add file validation support.
2016-12-08 11:23:31 -05:00
Nikolay Ivanko
33f1da6452
add virtual floppy to VMware guest
2016-12-08 11:23:31 -05:00
Mehul Ved
832f251e90
renamed variables type to cdb_type and version to cdb_version.
2016-12-08 11:23:31 -05:00
HAMSIK Adam
217764ba3c
Rebase start/stop instance pull code
2016-12-08 11:23:31 -05:00
Александр Костырев
ec8a94f748
Fix documentation of authorized_key.py
...
man for sshd http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man8/sshd.8?query=sshd
says there's no "host" option but "from".
2016-12-08 11:23:31 -05:00
Brian Coca
a1992ad890
updated encoding comment and expanded authors field
2016-12-08 11:23:31 -05:00
Jérémie Astori
288a9d8500
Set version number in recursive option description
2016-12-08 11:23:30 -05:00
Jérémie Astori
17170992c3
Ensure Python 2.4 compatibility and Linux-restricted support
...
- Make build_entry compatible with Python 2.4
- Re-add missing warning/comment that was forgotten while refactoring
- Replace `all()` with a good ol' for-loop Python 2.4 compatibility
- Make a condition check more explicit (when `state` is `query`)
- Make sure this module can only be run with on a Linux distribution
- Add a note about Linux-only support in the documentation
- Set the version in which recursive support was added, 2.0
2016-12-08 11:23:30 -05:00
Brian Coca
c341df2231
updated docs for package
2016-12-08 11:23:30 -05:00
Marius Gedminas
9ab2e9c740
Fix obvious copy-paste error in module docs
2016-12-08 11:23:30 -05:00
Brian Coca
34f8eb0f4c
made continue into a pass (there was no loop)
2016-12-08 11:23:30 -05:00
Brian Coca
686026919e
avoid shlex exceptions in rc parsing (happens with multiline entries) fixes #1898
2016-12-08 11:23:30 -05:00
Michael J. Schultz
c7eb08b217
Return an iterable instead of None
...
By default `.get()` will return `None` on a key that doesn't exist. This
causes a `TypeError` in the `for` loop a few lines down. This change simply
returns an iterable type to avoid the error.
2016-12-08 11:23:30 -05:00
Evgeny Vereshchagin
fe840225fb
Fix service.enable on: Debian 8, Ubuntu 15.04
...
Workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751638
See https://github.com/systemd/systemd/issues/937
2016-12-08 11:23:30 -05:00
Austin Hyde
ca512b5def
Always end rc.conf entries with a new line
2016-12-08 11:23:30 -05:00
Brian Coca
a8b24699be
added gpg2 as fallback fixes #1796
2016-12-08 11:23:30 -05:00
Brian Coca
4856f78031
updated win_file version_added fixes #1893
2016-12-08 11:23:30 -05:00
Toshio Kuratomi
a765411284
Another way that the serialization of the boto results can fail
2016-12-08 11:23:30 -05:00
Toshio Kuratomi
1f9580f257
Quote checksum description to fix docs
2016-12-08 11:23:30 -05:00
Toshio Kuratomi
cae0c2741c
Another launchconfig field needs to be explicitly converted for json serialization
...
Fixes #1848
2016-12-08 11:23:30 -05:00
sebi
ce1afd01e0
mem_limit client version check
2016-12-08 11:23:30 -05:00
Toshio Kuratomi
a10b0e6fff
Modify the default for synchronize's dest_port again
2016-12-08 11:23:30 -05:00
Toshio Kuratomi
052320b452
Update docs to reflect precedence for synchronize's dest_port param
2016-12-08 11:23:29 -05:00
Toshio Kuratomi
9ba5a438a8
Allow mode as a synchronize parameter (handled in action plugin)
2016-12-08 11:23:29 -05:00
Toshio Kuratomi
98e600961f
Set a default value for DEFAULT_DOCKER_API_VERSION so we can create the AnsibleModule without docker-py
2016-12-08 11:23:29 -05:00
Ted Timmons
7027de77b7
fix ugly documentation
...
current version dumps a character per line in the docs: http://docs.ansible.com/ansible/cloudformation_module.html
2016-12-08 11:23:29 -05:00
Chris Church
1b6edab87c
Add check mode support for Windows modules that don't modify the remote system.
2016-12-08 11:23:29 -05:00
Mehul Ved
bb6762dffd
Added support for instance types.
...
Added type and version parameters to be passed to rax_cdb module
so users can create Percona and MariaDB instance types.
2016-12-08 11:23:29 -05:00
Benjamin Baumer
d38cd4896d
version_added for switch Parameter changed to 2.0 Add comment to explain check_rc Parameter in _exec Function Optimize code and clean up is_svn_repo Function
2016-12-08 11:23:29 -05:00
queridiculo
92615669c0
yum: improved check_mode handling and package update flow.
2016-12-08 11:23:29 -05:00
Austin Brown
9ffde6c048
Adding version detection
2016-12-08 11:23:29 -05:00
Benjamin Baumer
04add7409e
Fix: Calling svn info to determine if dest is an svn Working Copy, to support updates in Subfolders with Subversion > 1.8 Fix: Ignoring svn:externals on local Modification Check. Add: Added Argument switch to alow skipping the svn switch call.
2016-12-08 11:23:29 -05:00
Kamil Madac
08a2f01a5f
Fixed bug, when MX records pointed to ORIGIN(@) caused unintentional change of random A record.
2016-12-08 11:23:29 -05:00
Evan Kaufman
b3495e238c
Add disabled option to cron module
2016-12-08 11:23:29 -05:00
Andrew Briening
a886690309
Adds basic authentication & skip certificate validation to win_get_url module
2016-12-08 11:23:29 -05:00
Trond Hindenes
1ee2ddcbf4
updated win_feature.ps1 with improvements
2016-12-08 11:23:29 -05:00
Markus Juenemann
47065c2a43
Removed check whether destination directory is writable from files/unarchive.py. This check will prevent extraction of an archive if the archive does not actually write to the destination directory but only writes to any writable sub-directories of it. The underlying tar command will report errors should it try to write to read-only directories.
2016-12-08 11:23:29 -05:00
Monty Taylor
f71446045f
Add OpenStack Group content module
2016-12-08 11:23:29 -05:00
Scot Spinner
bcc57875ed
adding parameter group option
2016-12-08 11:23:29 -05:00
Jamie Hannaford
0eef7cadfa
Add wait and wait_timeout options for provisioning servers
2016-12-08 11:23:28 -05:00
Jason DeTiberus
c2bc5a20fa
bugfixes for redhat_subscription
...
- correctly return pool ids for newer versions of subscription-manager
- allow for managing subscriptions after initial registration.
2016-12-08 11:23:28 -05:00
David Shrewsbury
94ae8bbc9b
Update os_router to the latest version
...
This version uses the latest shade for a cleaner interface,
support for check mode, and updating an existing router.
2016-12-08 11:23:28 -05:00
Monty Taylor
5ca11fa255
Add OpenStack Router module
...
Also deprecate old quantum_router module
2016-12-08 11:23:28 -05:00
Vladimir Mihailenco
de8c453ac6
rackspace: pass full path to the isdir.
2016-12-08 11:23:28 -05:00
Sam Thursfield
cad0adc691
Fix permissions issue with 'cron' module
...
I have a task like this in a playbook. The ansible_ssh_user is 'root'
for this host.
- cron:
hour: 00
job: /home/backup/backup.sh
name: baserock.org data backup
user: backup
Running it gave me the following error:
TASK: [backup cron job, runs every day at midnight] ***************************
failed: [baserock-backup1] => {"failed": true}
msg: crontab: can't open '/tmp/crontabvVjoZe': Permission denied
crontab: user backup cannot read /tmp/crontabvVjoZe
The temporary file created by the 'cron' module is created with the
Python tempfile.mkstemp() function. This creates a file that is readable
only by 'root' (mode 600). The Busybox `crontab` program then checks if
the file is readable by the 'backup' user, and fails if it isn't. So we
need to make sure the file is world-readable before running `crontab`.
2016-12-08 11:23:28 -05:00
Rowan Wookey
7d85477acb
Fixes #542 error when ec2_asg arguments aren't specified
...
If max_size/min_size/desired_capacity are omitted
when updating an autoscaling group use the existing values
2016-12-08 11:23:28 -05:00
Robb Wagoner
aed7d903ee
Include a CFN stack's resources in the result
2016-12-08 11:23:28 -05:00
Jan Inowolski
3d45384aed
update git remote url before ls-remote
...
related to #8177
2016-12-08 11:23:28 -05:00
Matt Ferrante
74b4882415
ec2_ami can update an ami's launch_permissions
2016-12-08 11:23:28 -05:00
Hideki Saito
2cb83fb196
The nova_compute module create a list of un-use floating ip by value of fixed_ip.
...
Fixes #249
2016-12-08 11:23:28 -05:00
Jérémie Astori
edf531efd7
Add recursive support for ACL module ( fix #5053 , fix #5550 , fix #7276 )
2016-12-08 11:23:28 -05:00
muffl0n
6482d1344a
Allow additional hashing algorithms. Directly use hashlib and check if used algorithm is supported.
2016-12-08 11:23:28 -05:00
Robert Jailall
6530e76880
Refactor ec2_snapshot to make it more testable
2016-12-08 11:23:28 -05:00
Hagai Kariti
83aff77c26
made wait
default to True in ec2_snapshot
2016-12-08 11:23:28 -05:00
Hagai Kariti
fcd2b354b2
Add to the ec2_snapshot module the ability to create a snapshot only if one hasn't recently been created
...
- Added snapshot_max_age parameter
- Updated docs
- Made the default value of wait to be false, as it used to be
2016-12-08 11:23:28 -05:00
Toshio Kuratomi
49ee99fe73
result is now a dict and so needs different access syntax
...
Fixes #1848
2016-12-08 11:23:27 -05:00
Toshio Kuratomi
b91684b8ad
Remove unneeded urllib2 import
2016-12-08 11:23:27 -05:00
Brian Coca
ae18b7633c
returned version added
2016-12-08 11:23:27 -05:00
James Cammarata
99075976a8
Fix missing params to download_s3file in s3
2016-12-08 11:23:27 -05:00
James Cammarata
689f13548f
Fixing s3 failures when bucket names contain dots
2016-12-08 11:23:27 -05:00
Brian Coca
9241955076
added missing version_Added to extra_hosts fixes #1843
2016-12-08 11:23:27 -05:00