Commit graph

2130 commits

Author SHA1 Message Date
James Cammarata
f3384374b9 Set result to skipped when vol group is missing and lv state=absent
Fixes issue #3714 - lvol module state=absent fails (with error) if
the volume group doesn't exist
2013-08-02 20:32:56 -05:00
rishid
fea38f44ac Verify groups string is not empty before trying add user to groups 2013-08-01 21:19:11 -04:00
Michael DeHaan
5d6a0f3515 Merge pull request #3651 from nicholaskuechler/rax-update-files-docs
Update docs and example for injecting files.
2013-08-01 17:32:15 -07:00
Michael DeHaan
fab11537b1 Merge pull request #3691 from stoned/mysql_user-doc-fix
module mysql_user: fix 'state' parameter description
2013-08-01 17:25:21 -07:00
Michael DeHaan
87e2f74f07 Merge pull request #3728 from bpennypacker/ec2_elb_updates
Added optional region parameter.  Fail if you specify an ELB that doesn'...
2013-08-01 17:20:45 -07:00
Michael DeHaan
c6c7e2f266 Merge pull request #3722 from bcoca/lvg_gets_bin_path
now uses get_bin_path for lvg executables
2013-08-01 17:17:21 -07:00
Michael DeHaan
064b721498 Merge pull request #3655 from disko/pkgin_search_fix
Fix pkgin search
2013-08-01 17:12:16 -07:00
Michael DeHaan
38055e33c5 Merge pull request #3648 from echohead/glance-image-timeout
Fix 'timeout' parameter of glance-image module.
2013-08-01 17:09:44 -07:00
Michael DeHaan
838acd4877 Merge pull request #3676 from bcoca/debug_doc_update
updated debug module docs to remove outdated -v requirement
2013-08-01 17:05:23 -07:00
Michael DeHaan
5fbb82fd15 Merge pull request #3634 from stintel/mysql-revoke-grant-option
Only revoke GRANT OPTION when user actually has it
2013-08-01 17:04:54 -07:00
Bruce Pennypacker
6d6e0d5ab8 Added optional region parameter. Fail if you specify an ELB that doesn't exist.
Boto blindly assumes the us-east-1 region if you don't hardcode a
region in it's config, so you could end up attempting to modify ELB's
in one region from a totally different region.  If a region isn't
specified then default to the region that the module is being run
within rather than the default us-east-1 region since it's a pretty
safe assumption that you intend to work on the ELB's within your
current region.

Also throw an error if a specified ELB instance doesn't exist.  The old
behavior would be to silently succeed with changed=false, so if you had
so much as a typo in the name of your ELB (or were in the wrong region
like my initial testing) you wouldn't get a clear indication that a
problem had occurred.
2013-08-01 16:50:01 -04:00
Brian Coca
e8e8779dfa fixed bug from prev update
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-08-01 00:24:34 -04:00
Brian Coca
2c06418f6d whitespace updates on new lines
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-31 23:26:28 -04:00
Brian Coca
fe57037f84 now uses get_bin_path for lvg executables
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-31 22:32:41 -04:00
Nicholas Kuechler
50f8a2ffc8 Change equals to colon 2013-07-30 20:08:22 -05:00
Nicholas Kuechler
d49220b830 Fixed a problem on my side. Was doing weird things. 2013-07-30 20:07:20 -05:00
Nicholas Kuechler
b9a67d0adb Remove tailing bracket 2013-07-30 18:01:34 -05:00
Stoned Elipot
a0ce78e6e5 module mysql_user: fix 'state' parameter description 2013-07-29 23:50:17 +02:00
Michael DeHaan
5b80299231 Make exceptions handling python 2.4 compatible. 2013-07-29 13:27:16 -04:00
Michael DeHaan
9fd6de6220 Merge pull request #3666 from bpennypacker/statdoc
doc update for stat module
2013-07-28 06:23:14 -07:00
Nicholas Kuechler
a89007ec8d Update example to be more yaml friendly 2013-07-27 13:33:30 -05:00
Brian Coca
e7e5db8e6c updated debug module docs to remove outdated -v requirement (and
only_if reference)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-26 10:06:57 -04:00
Tim Miller
d56518d9ac Fix 'timeout' parameter of glance-image module.
The timeout parameter of glance-image was not being parsed into a
numeric type, causing the following error when specifying timeout:

    msg: Error in creating image: unsupported operand type(s) for +: 'float' and 'str'
2013-07-25 14:54:21 -07:00
Bruce Pennypacker
bb07c443a4 doc update 2013-07-25 09:59:23 -04:00
Andreas Kaiser
1bf6656f0b Fix pkgin search (yielding wrong results under certain conditions, see inline comments). 2013-07-24 16:18:14 +02:00
Nicholas Kuechler
2eb208cfd9 Add example with multiple files. 2013-07-23 23:09:02 -05:00
Nicholas Kuechler
e76c27d89b Update docs and example for injecting files. 2013-07-23 22:49:17 -05:00
Stijn Tintel
7102503bb2 Only revoke GRANT OPTION when user actually has it
When revoking privileges from a user, the GRANT OPTION is always
revoked, even if the user doesn't have it. If the user exists, this
doesn't give an error, but if the user doesn't exist, it does:

mysql> GRANT ALL ON test.* TO 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE ALL ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
ERROR 1141 (42000): There is no such grant defined for user 'test' on
host 'localhost'

Additionally, in MySQL 5.6 this breaks replication because of
http://bugs.mysql.com/bug.php?id=68892.

Rather than revoking the GRANT OPTION and catching the error, check if
the user actually has it and only revoke it when he does.
2013-07-23 13:00:29 +02:00
Ralph Tice
151f73138f fixed vpc provisioning / clarified group_id usage 2013-07-22 17:00:13 -05:00
Michael DeHaan
2da5dc7886 Merge branch 'devel' of github.com:ansible/ansible into devel 2013-07-22 15:16:47 -04:00
Michael DeHaan
7bfc24706c Fix prev feature commit, Do not require aptitude to use apt commands in the apt module, only needed when upgrading. 2013-07-22 15:15:55 -04:00
Michael DeHaan
ecf074865f Continue on mount errors, don't fail the setup module. 2013-07-22 13:57:35 -04:00
Michael DeHaan
99f1852c6d Merge pull request #3622 from bcoca/fix_the_stat_fix
use global to fail as its not in self
2013-07-22 07:56:49 -07:00
Brian Coca
220fe24d39 use global to fail as its not in self
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-22 10:54:20 -04:00
Michael DeHaan
adda77a42b Merge pull request #3617 from dermute/devel
svr4pkg doesn't work on Sol10
2013-07-22 04:37:10 -07:00
Michael DeHaan
71b3d7043b Remove end of line semicolons. 2013-07-21 11:55:38 -04:00
Michael DeHaan
3b3ff552f2 Remove reference to 'context' since it's not implemented. 2013-07-21 11:52:22 -04:00
Michael DeHaan
8d0a14ae7d Fix route53 module docs version/module name 2013-07-21 11:20:37 -04:00
Michael DeHaan
5c8e5c81de Fix YAML doc errors. 2013-07-21 11:15:06 -04:00
Michael DeHaan
dc7e280d3b Update docs to add version_added attribute. 2013-07-21 11:12:04 -04:00
Michael DeHaan
8065e414d1 Merge pull request #3400 from diko4096/patch-1
Update gem
2013-07-21 08:10:27 -07:00
Michael DeHaan
df0e4666c0 Merge pull request #3413 from evan82/devel
Added module for baking EC2 AMIs
2013-07-21 07:53:54 -07:00
Michael DeHaan
3f4c6affa3 Update CHANGELOG 2013-07-21 10:12:28 -04:00
Michael DeHaan
9ebde16e3a Merge branch 'iss_cron' of git://github.com/dirtyharrycallahan/ansible into dh_cron 2013-07-21 10:00:11 -04:00
Michael DeHaan
e7b6eeefb2 Merge pull request #3574 from bpennypacker/route53
AWS route53 module
2013-07-21 06:54:14 -07:00
Michael DeHaan
81be8ff7d3 Update htpasswd module for various API incompatibilities 2013-07-20 18:22:58 -04:00
Michael DeHaan
be35a035b3 Revert "Fix inconsistent json output"
Breaks recursion parameter on file.

This reverts commit e7226e104e.
2013-07-20 18:08:42 -04:00
Michael DeHaan
6030c1bcaa tweak indentation for 'make pep8' 2013-07-20 12:48:11 -04:00
Michael DeHaan
4281f773bb Merge pull request #3602 from bcoca/fine_tune_stat_exception
narrowed down exception
2013-07-20 09:45:31 -07:00
Michael DeHaan
23e9e5c028 Add version_added information to module parameter. 2013-07-20 12:33:42 -04:00