Commit graph

24 commits

Author SHA1 Message Date
Michael Scherer
f6450e577f Add acl freebsd (#3656)
* FreeBSD do not support --omit-header and --absolute-names

* The option for following symlink wth getfacl is different on FreeBSD

* ZFS on Freebsd use nfsv4 acls, who use a slightly different syntax

* FreeBSD do not have a --test flag, so always return 'True'

* FreeBSD do not have the --omit-headers options, so we have to filter by ourself

* Mark Freebsd as working for the acl module
2016-08-23 11:11:34 -04:00
Michael Scherer
69ea617093 Convert the whole files/ directory to py3 syntax (#3685) 2016-05-18 07:01:53 -07:00
Michael Scherer
de6cdeeba6 Testing the module on freebsd fail, since module is not assigned yet 2016-05-17 00:22:08 +02:00
Michael Scherer
2449267d42 Fix the argument for acl module (#3653) 2016-05-16 14:00:15 -04:00
Toshio Kuratomi
93d02189f6 Remove duplicate documentation fields 2016-01-28 09:24:20 -08:00
quoing
877daf970d Fix: Default ACL parameters are not correctly handled 2015-12-08 11:44:03 -08:00
Brian Coca
db66144386 simplified lowercasing 2015-12-08 11:41:32 -08:00
quoing
c93de2f930 Add "default" entry option back (removed in e95bcae), update will translate entry to standard parameters so compatibility with BDS is kept 2015-12-08 11:41:32 -08:00
Jérémie Astori
72fb7a0a17 Fix physical walk on acl module for Linux
`-h` is for BSD [1] while `-P`/`--physical` is for Linux [2].
This commit fixes that option now that acl module is (temporarily)
only supported for Linux.
I will re-add `-h` when fixing BSD support.

[1]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[2]: http://linuxcommand.org/man_pages/setfacl1.html
2015-08-20 23:35:53 +00:00
Jérémie Astori
8eefd44aef Make sure entry is not sent when acl state=query 2015-08-20 22:59:00 +00:00
Jérémie Astori
0e659ad872 Make sure permission-less entries are accepted when state=absent
Also, remove that try condition as, at that stage, no permissions with
other than 2 or 3 fields are sent to the function.
2015-08-20 22:58:49 +00:00
Jérémie Astori
e95bcaeb8a Remove support for d[efault]: in entry permissions
It is not documented in [the Ansible doc page][1] nor
[the BSD setfacl man entry][2] (which means it might not be compatible
with BSD) so removing it does not break the API.

On the other hand, it does not conform with POSIX 1003.1e DRAFT
STANDARD 17 according to the [Linux setfacl man entry][3] so safer to
remove.

Finally, the most important reason: in non POSIX 1003.e mode, only ACL
entries without the permissions field are accepted, so having an
optional field here is very much error-prone.

[1]: http://docs.ansible.com/ansible/acl_module.html
[2]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[3]: http://linuxcommand.org/man_pages/setfacl1.html
2015-08-20 22:22:28 +00:00
Jérémie Astori
3ac990556d Fix wrong expectation regarding entry format in acl module 2015-08-19 00:26:04 +00:00
Jérémie Astori
421d3f12cf Fix wrong processing of lines returned by setfacl in test mode 2015-08-19 00:25:18 +00:00
Jérémie Astori
50c6425673 Fix minor whitespace issues 2015-08-19 00:24:08 +00:00
Brian Coca
d61fde42ef updated encoding comment and expanded authors field 2015-08-14 22:01:05 -04:00
Jérémie Astori
acfc2166b0 Set version number in recursive option description 2015-08-14 23:40:47 +00:00
Jérémie Astori
f8027a7f0a Ensure Python 2.4 compatibility and Linux-restricted support
- Make build_entry compatible with Python 2.4
- Re-add missing warning/comment that was forgotten while refactoring
- Replace `all()` with a good ol' for-loop Python 2.4 compatibility
- Make a condition check more explicit (when `state` is `query`)
- Make sure this module can only be run with on a Linux distribution
- Add a note about Linux-only support in the documentation
- Set the version in which recursive support was added, 2.0
2015-08-14 22:06:51 +00:00
Jérémie Astori
ae1126c217 Add recursive support for ACL module (fix #5053, fix #5550, fix #7276) 2015-07-04 22:44:10 +02:00
Greg DeKoenigsberg
2a5f0bde87 Proper author info for all remaining modules 2015-06-15 15:53:30 -04:00
Brian Coca
13cdadcc4d removed always for success, as data wont show on fail 2015-02-20 09:57:39 -05:00
Brian Coca
cbf42c95b2 draft for documenting module returns 2015-02-20 09:57:39 -05:00
anatoly techtonik
4f2b99c1e0 acl: Fix X support in ACL permissions
If you try to set rwX permissions, ACL fails to set them at all.

Expected:

    $ sudo setfacl -m 'group::rwX' www
    ...
    drwxrwxr-x  2 root root  4096 Nov 10 17:09 www

With Ansible:

    acl: name=/var/www permissions=rwX etype=group state=present
    ...
    drwxrw-r-x  2 root root  4096 Nov 10 17:30 www

x for group is erased. =/
2014-11-10 20:32:05 +03:00
Michael DeHaan
c8e1a2077e file extensions! 2014-09-26 10:37:56 -04:00
Renamed from files/acl (Browse further)