ansible/docs/docsite/rst/dev_guide/testing/sanity/no-wildcard-import.rst
Matt Clay b4494fa547 Remove redundant "Sanity Tests »" from page title.
The docs now have multi-level breadcrumbs so including "Sanity Tests »" in the title on a sanity test page is redundant.
2019-07-26 09:07:42 -07:00

840 B

orphan

no-wildcard-import

Using import * is a bad habit which pollutes your namespace, hinders debugging, and interferes with static analysis of code. For those reasons, we do want to limit the use of import * in the ansible code. Change our code to import the specific names that you need instead.

Examples of unfixed code:

from ansible.module_utils.six import *
if isinstance(variable, string_types):
    do_something(variable)

from ansible.module_utils.basic import *
module = AnsibleModule()

Examples of fixed code:

from ansible.module_utils import six
if isinstance(variable, six.string_types):
    do_something(variable)

from ansible.module_utils.basic import AnsibleModule
module = AnsibleModule()