cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
No description
7065 commits 47 branches 390 tags 440 MiB
Python 88.4%
PowerShell 7.5%
Shell 2%
C# 1.9%
Makefile 0.1%
Find a file
Andrew Pashkin e96549c95d Harden matching running containers by "command" in the Docker module 
Before this patch:

  - Command was matched if 'Command' field of docker-py
    representation of Docker container ends with 'command' passed
    to Ansible docker module by user.
  - That can give false positives and false negatives.
  - For example:
      a) If 'command' was set up with more than one spaces,
         like 'command=sleep  123', it would be never matched again
         with a container(s) launched by this task.
         Because after launching, command would be normalized and
         appear, in docker-py API call, just as 'sleep 123' - with one
         space. This is false negative case.
      b) If 'entrypoint + command = command', for example
         'sleep + 123 = sleep 123', module would give false positive
         match.

This patch fixes it, by making matching more explicit - against
'Config'->Cmd' field of 'docker inspect' output, provided by docker-py
API and with proper normalization of user input by splitting it to
tokens with 'shlex.split()'.
2015-10-02 12:30:03 +03:00
cloud Harden matching running containers by "command" in the Docker module 2015-10-02 12:30:03 +03:00
commands returned version added 2015-07-30 17:04:41 -04:00
database Actually remove the section we are replacing 2015-08-19 08:52:05 +00:00
files Fixed confusion in the docs 2015-09-23 08:24:16 +03:00
inventory Add missing GPLv3 License header 2015-07-03 22:57:53 -05:00
network Update get_url.py 2015-09-09 17:38:05 -04:00
packaging removed syslog in favor of common module logging functions 2015-10-01 00:13:58 -04:00
source_control Merge pull request #465 from bbaumer/devel 2015-09-11 13:10:33 -04:00
system removed typo 2015-10-01 10:16:34 -04:00
utilities No longer check for tmp_path being sent as we don't use it here anyway 2015-09-24 13:28:28 -07:00
web_infrastructure Use is_executable from its new location 2015-09-25 07:47:06 -07:00
windows The variable $uppercase_cert_thumbprint cannot be retrieved because it has not been set. 2015-09-29 16:40:22 -04:00
.gitignore Add basic top level files. 2014-09-26 09:21:20 -04:00
.travis.yml Disable travis docs checks 2015-07-01 07:24:39 -07:00
__init__.py package files 2014-09-26 11:05:47 -04:00
CONTRIBUTING.md Add new policy guidelines for Core 2015-07-23 14:23:00 -04:00
COPYING Add basic top level files. 2014-09-26 09:21:20 -04:00
README.md updated to keep same info as in extras repo 2015-03-10 10:35:29 -04:00
test-docs.sh Add testing of docs to the core repo 2015-06-29 12:42:50 -07:00

README.md

ansible-modules-core

This repo contains Ansible's most popular modules that are shipped with Ansible.

New module submissions for modules that do not yet exist should be submitted to ansible-modules-extras, rather than this repo.

Take care to submit tickets to the appropriate repo where modules are contained. The docs.ansible.com website indicates this at the bottom of each module documentation page.

Reporting bugs

Take care to submit tickets to the appropriate repo where modules are contained. The repo is mentioned at the bottom of module documentation page at docs.ansible.com.

Testing modules

Ansible module development guide contains the latest info about that.

License

As with Ansible, modules distributed with Ansible are GPLv3 licensed. User generated modules not part of this project can be of any license.

Installation

There should be no need to install this repo separately as it should be included in any Ansible install using the official documented methods.