remove outdated comments

This commit is contained in:
Nathan Shively-Sanders 2020-01-24 11:19:51 -08:00
parent 7109fd8fa9
commit 49639d53e7
8 changed files with 18 additions and 64 deletions

View file

@ -1,9 +1,4 @@
//// [emitStatementsBeforeSuperCall.ts]
// TODO: With false, master is correct for `Test` but incorrect for `Sub`.
// `Test` is correct because classic emit doesn't emit for definition and `Test`
// doesn't need to emit any code for initialisation because it's already
// part of the user code
class Base {
}
class Sub extends Base {
@ -27,10 +22,6 @@ class Test extends Base {
//// [emitStatementsBeforeSuperCall.js]
// TODO: With false, master is correct for `Test` but incorrect for `Sub`.
// `Test` is correct because classic emit doesn't emit for definition and `Test`
// doesn't need to emit any code for initialisation because it's already
// part of the user code
class Base {
}
class Sub extends Base {

View file

@ -1,19 +1,14 @@
=== tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCall.ts ===
// TODO: With false, master is correct for `Test` but incorrect for `Sub`.
// `Test` is correct because classic emit doesn't emit for definition and `Test`
// doesn't need to emit any code for initialisation because it's already
// part of the user code
class Base {
>Base : Symbol(Base, Decl(emitStatementsBeforeSuperCall.ts, 0, 0))
}
class Sub extends Base {
>Sub : Symbol(Sub, Decl(emitStatementsBeforeSuperCall.ts, 6, 1))
>Sub : Symbol(Sub, Decl(emitStatementsBeforeSuperCall.ts, 1, 1))
>Base : Symbol(Base, Decl(emitStatementsBeforeSuperCall.ts, 0, 0))
// @ts-ignore
constructor(public p: number) {
>p : Symbol(Sub.p, Decl(emitStatementsBeforeSuperCall.ts, 9, 16))
>p : Symbol(Sub.p, Decl(emitStatementsBeforeSuperCall.ts, 4, 16))
console.log('hi'); // should emit before super
>console.log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --))
@ -24,28 +19,28 @@ class Sub extends Base {
>super : Symbol(Base, Decl(emitStatementsBeforeSuperCall.ts, 0, 0))
}
field = 0;
>field : Symbol(Sub.field, Decl(emitStatementsBeforeSuperCall.ts, 12, 5))
>field : Symbol(Sub.field, Decl(emitStatementsBeforeSuperCall.ts, 7, 5))
}
class Test extends Base {
>Test : Symbol(Test, Decl(emitStatementsBeforeSuperCall.ts, 14, 1))
>Test : Symbol(Test, Decl(emitStatementsBeforeSuperCall.ts, 9, 1))
>Base : Symbol(Base, Decl(emitStatementsBeforeSuperCall.ts, 0, 0))
prop: number;
>prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCall.ts, 16, 25))
>prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCall.ts, 11, 25))
// @ts-ignore
constructor(public p: number) {
>p : Symbol(Test.p, Decl(emitStatementsBeforeSuperCall.ts, 19, 16))
>p : Symbol(Test.p, Decl(emitStatementsBeforeSuperCall.ts, 14, 16))
1; // should emit before super
super();
>super : Symbol(Base, Decl(emitStatementsBeforeSuperCall.ts, 0, 0))
this.prop = 1;
>this.prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCall.ts, 16, 25))
>this : Symbol(Test, Decl(emitStatementsBeforeSuperCall.ts, 14, 1))
>prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCall.ts, 16, 25))
>this.prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCall.ts, 11, 25))
>this : Symbol(Test, Decl(emitStatementsBeforeSuperCall.ts, 9, 1))
>prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCall.ts, 11, 25))
}
}

View file

@ -1,9 +1,4 @@
=== tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCall.ts ===
// TODO: With false, master is correct for `Test` but incorrect for `Sub`.
// `Test` is correct because classic emit doesn't emit for definition and `Test`
// doesn't need to emit any code for initialisation because it's already
// part of the user code
class Base {
>Base : Base
}

View file

@ -1,9 +1,4 @@
//// [emitStatementsBeforeSuperCallWithDefineFields.ts]
// TODO: With false, master is correct for `Test` but incorrect for `Sub`.
// `Test` is correct because classic emit doesn't emit for definition and `Test`
// doesn't need to emit any code for initialisation because it's already
// part of the user code
class Base {
}
class Sub extends Base {
@ -27,10 +22,6 @@ class Test extends Base {
//// [emitStatementsBeforeSuperCallWithDefineFields.js]
// TODO: With false, master is correct for `Test` but incorrect for `Sub`.
// `Test` is correct because classic emit doesn't emit for definition and `Test`
// doesn't need to emit any code for initialisation because it's already
// part of the user code
class Base {
}
class Sub extends Base {

View file

@ -1,19 +1,14 @@
=== tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCallWithDefineFields.ts ===
// TODO: With false, master is correct for `Test` but incorrect for `Sub`.
// `Test` is correct because classic emit doesn't emit for definition and `Test`
// doesn't need to emit any code for initialisation because it's already
// part of the user code
class Base {
>Base : Symbol(Base, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 0, 0))
}
class Sub extends Base {
>Sub : Symbol(Sub, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 6, 1))
>Sub : Symbol(Sub, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 1, 1))
>Base : Symbol(Base, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 0, 0))
// @ts-ignore
constructor(public p: number) {
>p : Symbol(Sub.p, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 9, 16))
>p : Symbol(Sub.p, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 4, 16))
console.log('hi');
>console.log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --))
@ -24,28 +19,28 @@ class Sub extends Base {
>super : Symbol(Base, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 0, 0))
}
field = 0;
>field : Symbol(Sub.field, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 12, 5))
>field : Symbol(Sub.field, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 7, 5))
}
class Test extends Base {
>Test : Symbol(Test, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 14, 1))
>Test : Symbol(Test, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 9, 1))
>Base : Symbol(Base, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 0, 0))
prop: number;
>prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 16, 25))
>prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 11, 25))
// @ts-ignore
constructor(public p: number) {
>p : Symbol(Test.p, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 19, 16))
>p : Symbol(Test.p, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 14, 16))
1;
super();
>super : Symbol(Base, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 0, 0))
this.prop = 1;
>this.prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 16, 25))
>this : Symbol(Test, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 14, 1))
>prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 16, 25))
>this.prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 11, 25))
>this : Symbol(Test, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 9, 1))
>prop : Symbol(Test.prop, Decl(emitStatementsBeforeSuperCallWithDefineFields.ts, 11, 25))
}
}

View file

@ -1,9 +1,4 @@
=== tests/cases/conformance/classes/constructorDeclarations/superCalls/emitStatementsBeforeSuperCallWithDefineFields.ts ===
// TODO: With false, master is correct for `Test` but incorrect for `Sub`.
// `Test` is correct because classic emit doesn't emit for definition and `Test`
// doesn't need to emit any code for initialisation because it's already
// part of the user code
class Base {
>Base : Base
}

View file

@ -1,9 +1,5 @@
// @useDefineForClassFields: false
// @target: es2015
// TODO: With false, master is correct for `Test` but incorrect for `Sub`.
// `Test` is correct because classic emit doesn't emit for definition and `Test`
// doesn't need to emit any code for initialisation because it's already
// part of the user code
class Base {
}

View file

@ -1,9 +1,5 @@
// @useDefineForClassFields: true
// @target: es2015
// TODO: With false, master is correct for `Test` but incorrect for `Sub`.
// `Test` is correct because classic emit doesn't emit for definition and `Test`
// doesn't need to emit any code for initialisation because it's already
// part of the user code
class Base {
}