maxmustermann/TypeScript
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Cherry-pick PR #45484 into release-4.4 (#45564)

Browse source 
Component commits:
33829fa4a4 Fix and updated tests

2249d6c83e Added test

e1a2b9ed19 Revert "Fix and updated tests"
This reverts commit 33829fa4a4.

51881c4ea2 Filter out empty access expression

2253da6ae9 PR feedback

Co-authored-by: Armando Aguirre <armanio123@outlook.com>
This commit is contained in:
TypeScript Bot 2021-08-30 14:18:11 -07:00 committed by GitHub
parent 9eb689e066
commit 782c09d783
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/services/completions.ts
View file

@ -1338,13 +1338,16 @@ namespace ts.Completions {
case SyntaxKind.PropertyAccessExpression:
propertyAccessToConvert = parent as PropertyAccessExpression;
node = propertyAccessToConvert.expression;
if ((isCallExpression(node) || isFunctionLike(node)) &&
node.end === contextToken.pos &&
node.getChildCount(sourceFile) &&
last(node.getChildren(sourceFile)).kind !== SyntaxKind.CloseParenToken) {
const leftmostAccessExpression = getLeftmostAccessExpression(propertyAccessToConvert);
if (nodeIsMissing(leftmostAccessExpression) ||
((isCallExpression(node) || isFunctionLike(node)) &&
node.end === contextToken.pos &&
node.getChildCount(sourceFile) &&
last(node.getChildren(sourceFile)).kind !== SyntaxKind.CloseParenToken)) {
// This is likely dot from incorrectly parsed expression and user is starting to write spread
// eg: Math.min(./**/)
// const x = function (./**/) {}
// ({./**/})
return undefined;
}
break;

12
tests/cases/fourslash/getJavaScriptCompletions22.ts Normal file
View file

@ -0,0 +1,12 @@
/// <reference path="fourslash.ts" />
// Regresion test for GH#45436
// @allowNonTsExtensions: true
// @Filename: file.js
//// const abc = {};
//// ({./*1*/});
goTo.marker('1');
edit.insert('.');
verify.completions({ exact: undefined });