Commit graph

20330 commits

Author SHA1 Message Date
Andy
1a0ec81488
quickInfo: Display info for signature on a separate line from variable info (#18698) 2017-11-08 09:56:50 -08:00
Andy
ef6f9351b5
Fix undefined error for diagnostic for instantiating an abstract class (#19809)
* Fix undefined error for diagnostic for instantiating an abstract class

* Only use the name-less diagnostic
2017-11-08 09:40:53 -08:00
Nathan Shively-Sanders
7a45573311
Merge pull request #19824 from Microsoft/fix-rwc-lib-in-tsconfig
Fix RWC's handling of "lib" from tsconfig
2017-11-08 08:28:32 -08:00
Nathan Shively-Sanders
4e4f7507d0 Fix getDefaultLibraryFile + turn off lib
1. getDefaultLibraryFile should use ts to normalise the file and find
the filename.
2. lib should be turned off at the same time that noLib is turned on to
avoid a pointless error.
2017-11-07 16:08:57 -08:00
Nathan Shively-Sanders
ad18bde92b RWC:Handle lib entries in tsconfig 2017-11-07 15:43:55 -08:00
Mohamed Hegazy
b64944ad17 Merge branch 'ajafff-update-types3' 2017-11-07 15:23:52 -08:00
Mohamed Hegazy
1de3bbac2e Merge branch 'update-types3' of https://github.com/ajafff/TypeScript into ajafff-update-types3 2017-11-07 15:23:38 -08:00
Nathan Shively-Sanders
9b36e1155a
Merge pull request #19039 from Microsoft/guard-name-in-getSuggestionForNonexistentSymbol
In getSuggestionForNonexistentSymbol, guard name against undefined
2017-11-07 15:03:26 -08:00
Nathan Shively-Sanders
c6f343e266 Improve asserts in getSuggestionForNonexistentSymbol 2017-11-07 14:47:08 -08:00
Andrew Casey
62eeb7254c
Merge pull request #19791 from amcasey/ImportLineBreaks
Handle windows linebreaks in getSourceFileImportLocation
2017-11-07 11:34:39 -08:00
Sheetal Nandi
fe40873664
Merge pull request #19786 from Microsoft/directoryRename
Handle the watch when folders are added/removed/renamed in wild card folder
2017-11-07 11:13:47 -08:00
Andrew Casey
2715f890b4 PascalCase -> camelCase 2017-11-07 10:47:36 -08:00
Andrew Casey
3e339d88a1 Handle other linebreak characters and add boundary checks 2017-11-07 10:33:35 -08:00
Andrew Casey
d1fa006a1e Use CharacterCode enum 2017-11-07 10:10:34 -08:00
Andy
57f247eff4
Add hyphen in completionEntryDetails-full (#19808) 2017-11-07 09:46:40 -08:00
Andy
2f2a82b91d
Move "space-before-function-paren" lint rule to list of rules waiting on a formatter (#19807) 2017-11-07 09:45:58 -08:00
Aluan Haddad
b2b54cbf5c Import fix add import require support (#19802)
* import fix: suggest import..require where supported if synthetic defaults are unavailable

* Add tests for import..require fix when targeting CommonJS, AMD, and UMD modules

* fix failing tests
2017-11-07 09:45:30 -08:00
Andy
bd2e97597d
Enable 'no-empty' tslint rule (#19769)
* Enable 'no-empty' tslint rule

* Fix bug
2017-11-07 09:22:28 -08:00
csigs
2a6684fb80
LEGO: Merge pull request 19812
LEGO: Merge pull request 19812
2017-11-07 09:10:41 -08:00
csigs
b50fb3ef3f LEGO: check in for master to temporary branch. 2017-11-07 17:10:19 +00:00
Jing Ma
6a07793332 Fixed minor syntactics error (#19801) 2017-11-07 09:02:26 -08:00
Andy
2fcf8b7068
Fix assertion -- an import may come from a require() call (#19667)
* Fix assertion -- an import may come from a require() call

* Add test for `import("./a")`
2017-11-07 07:41:21 -08:00
Andy
9c8129eeac
Enable 'no-invalid-template-strings' lint rule (#19790) 2017-11-07 06:51:35 -08:00
csigs
d81ea525c4
LEGO: Merge pull request 19805
LEGO: Merge pull request 19805
2017-11-07 03:10:32 -08:00
csigs
9ba9a893cc LEGO: check in for master to temporary branch. 2017-11-07 11:10:13 +00:00
Aluan Haddad
70cabdda41 fix inconsistencies in import UMD code fixes adapting to module format (#19572)
* improve import code fixes for UMD modules
 - use default import under --allowSyntheticDefaultImports
 - import..require support
 - make make quick fix info match resulting import
 - make diagnostics

* Address PR feedback:
 - extract test for synethetic default imports into getAllowSyntheticDefaultImports in core.ts
 - use getAllowSyntheticDefaultImports in checker.ts and importFixes.ts
 - move compilerOptions to top level destructuring

* add tests

* remove `import =` quick fix and supporting code.

* update feature tests

* remove errant whitespace
2017-11-06 22:55:37 -08:00
csigs
5969aefeb3
LEGO: Merge pull request 19794
LEGO: Merge pull request 19794
2017-11-06 21:10:33 -08:00
csigs
ed335a66fa LEGO: check in for master to temporary branch. 2017-11-07 05:10:13 +00:00
Andy
6d273cfb33
Consistently use "JSX Attribute" completion kind (#19781)
* Consistently use "JSX Attribute" completion kind

* Update tests and fix bug

* Fix bug: In a JsxOpeningElement, if at an Identifier we are not at an attribute but at the tag itself.
If at a GreaterThanToken, we are about to fill in an attribute.
2017-11-06 19:14:24 -08:00
Ron Buckton
3f248ecfe1
Merge pull request #19452 from Microsoft/compareStrings
Clean up outdated string comparison logic
2017-11-06 18:48:15 -08:00
Andy
77b24aec83
Apply 'unified-signatures' tslint rule (#19738)
* Apply 'unified-signatures' tslint rule

* Fix new failure
2017-11-06 18:38:03 -08:00
Andrew Casey
2f13222180 Handle windows linebreaks in getSourceFileImportLocation 2017-11-06 18:29:38 -08:00
Andy
40efd1b3bd
Apply 'object-literal-key-quotes' tslint rule (#19737)
* Apply 'object-literal-key-quotes' tslint rule

* Convert to "consistent-as-needed"
2017-11-06 18:13:20 -08:00
Andy
3e7af1cf12
Move "ban-comma-operator" to tslint rules that we won't use (#19780) 2017-11-06 18:10:14 -08:00
Andy
381ca45787
Use an enum for Msg (#19773) 2017-11-06 18:10:02 -08:00
Wesley Wigham
d79c37cd19
Discriminate contextual types (#19733)
* Discriminate contextual types

* Invert conditional

* Update findMatchingDiscriminantType and baselines
2017-11-06 16:09:35 -08:00
Sheetal Nandi
3f34525c81 Handle the folder create/delete in the configured project 2017-11-06 15:22:48 -08:00
csigs
d6436f13e5
LEGO: Merge pull request 19783
LEGO: Merge pull request 19783
2017-11-06 15:11:14 -08:00
csigs
fd64322a63 LEGO: check in for master to temporary branch. 2017-11-06 23:10:47 +00:00
Sheetal Nandi
57be7ff3f6 Add test case when inside wild card watched directory folder is renamed 2017-11-06 14:38:33 -08:00
Sean Barag
a46d2705ef Use documentation comments from inherited properties when @inheritDoc is present (#18804)
* Use documentation comments from inherited properties when @inheritDoc is present

The JSDoc `@ineheritDoc` [tag](http://usejsdoc.org/tags-inheritdoc.html)
"indicates that a symbol should inherit its documentation from its
parent class".  In the case of a TypeScript file, this also includes
implemented interfaces and parent interfaces.

With this change, a class method or property (or an interface property)
with the `@inheritDoc` tag in its JSDoc comment will automatically use
the comments from its nearest ancestor that has no `@inheritDoc` tag.
To prevent breaking backwards compatibility,
`Symbol.getDocumentationComment` now accepts an optional `TypeChecker`
instance to support this feature.

fixes #8912

* Use ts.getJSDocTags as per @andy-ms 's recommendation

* Convert @inheritDoc tests to verify.quickInfoAt

* Concatenate inherited and local docs when @inheritDoc is present

* Make typeChecker param explicitly `TypeChecker | undefined`

* Re-accept baseline after switch to explicit `| undefined`

* Update APISample_jsodc.ts to match new getDocumentationComment signature

* Re-accept baselines after rebasing
2017-11-06 13:18:21 -08:00
falsandtru
28ed9b307b Update DOM iterable interfaces (#19752)
* Make HTMLCollections Iterable

* Sort definitions
2017-11-06 13:12:47 -08:00
Andy
ed38889ca6
Enable 'no-unused-expression' tslint rule (#19734) 2017-11-06 13:01:07 -08:00
Mohamed Hegazy
5c173f4436 Remove test 2017-11-06 13:00:05 -08:00
Eugene Timokhov
5b9905d5a4 Added empty constructors to TypedArrays from es2017 (#19680) 2017-11-06 13:00:05 -08:00
Wesley Wigham
0593ba27d8
Make getContextualTypeOfApparentType mapType over unions (#17668)
* Instantiate contextual types while in an inferrential context

* Limit scope of instantiation to only when likely needed

* Still get aparent type

* Expand test

* Fix nit

* Handle JSX and array

* Tests for the JSX and Array cases

* After much deliberation and inspection, much simpler fix

After much deliberation and inspection, much simpler fix

Undo

Redo
2017-11-06 12:52:33 -08:00
Wesley Wigham
4f48bf80fe
Revised emit for computed property names, including with decorators (#19430)
* Revised emit for computed property names

* Fix downlevel name generation scopes

* Accept slightly more conservative baseline

* First feedback pass

* Reduce number of nonrequired variable declarations and assignments

* Remove side-effect-free identifier references

* skip partially emitted expressions

* Comments, move starsOnNewLine to emitNode

* Put expressions on newlines when inlined in class expressions for consistency

* Update new ref

* Fix typo in comment
2017-11-06 12:51:34 -08:00
Sheetal Nandi
ddbd654ecd
Merge pull request #19730 from Microsoft/fileNotOnDisk
Handles script infos that dont exist on the disk and are opened with non-rooted disk path
2017-11-06 12:21:32 -08:00
Wesley Wigham
c016f5b9b0
Split runner selection from test selection (#19729)
* Split runner selection from test selection

* Continue to support old behavior
2017-11-06 11:24:17 -08:00
Andy
c4bf21b9cb
Improvements to checkUnusedIdentifiers (#19607) 2017-11-06 10:59:39 -08:00