Commit graph

28682 commits

Author SHA1 Message Date
Nathan Fenner 1cad8edfa7 check for SyntaxKind.JSXAttribute instead of located-ness of name prop 2019-09-20 14:00:11 -07:00
Nathan Fenner dbc17229f7 report extraneous jsx attribute error on attribute name instead of entire attribute assignment 2019-09-18 16:31:44 -07:00
Nathan Fenner 940231785e report error on extra jsx prop instead of component name 2019-09-18 16:31:44 -07:00
Wesley Wigham 5e06bea481
getConstraintDeclaration gets the first declaration with a constraint… (#33426)
* getConstraintDeclaration gets the first declaration with a constraint, rather than just the first declaration

* Add type annotation

* Update comment
2019-09-18 13:56:24 -07:00
Wesley Wigham 683e281040
Reintroduce cloneInferredPartOfContext to fix overloaded inferences with returnMappers (#33478) 2019-09-18 13:14:39 -07:00
Jack Williams 1c20aa0b1a Narrow unknown under inequality when assumed false (#33488) 2019-09-18 10:54:42 -07:00
Ron Buckton 344dba8809
Fix incorrect parameter types for AsyncIterator next/return (#33354) 2019-09-17 21:02:12 -07:00
Wesley Wigham 56e2cb31ad
Reverse mapped types should have inferable indexes if their source had an inferable index (#33450) 2019-09-17 15:36:00 -07:00
Daniel Rosenwasser a58b86bcdf
Handle parentless nodes in isParameterPropertyDeclaration (#33472)
Handle parentless nodes in isParameterPropertyDeclaration
2019-09-17 13:56:22 -07:00
Martin Probst 6bb7e5c086 Handle parentless nodes in isParameterPropertyDeclaration
Fixes #33295.

This follows a similar pattern as in #20314 by requiring an explicit
`parent` parameter. Where possible, it uses the appopriate variable at
the call sites.

In several locations there is no context available though (e.g.
inspecting `valueDeclarations`) and we access `.parent` as the code
previously did. From a cursory inspection this seems correct, these
callpaths originate in phases where there must be a `parent` (i.e. in
checker, binder, etc).

Change-Id: I28e4726777b57237bec776e4001e9e69ac591b11
2019-09-17 13:22:30 -07:00
Andrew Casey 2f8832cccc
Merge pull request #33469 from amcasey/gh33332
Make extractSymbol explicitly drop JSDoc nodes
2019-09-17 11:42:26 -07:00
TypeScript Bot 800eaedbfa 🤖 User test baselines have changed 2019-09-17 11:36:09 -07:00
Andrew Casey f10e38fea7 Make extractSymbol explicitly drop JSDoc nodes
Fixes #33332
2019-09-17 10:35:11 -07:00
Orta bf46ded8fd
Merge pull request #33157 from fuafa/convert-const-to-let
Add convert const to let
2019-09-17 07:49:12 -04:00
xiaofa 67aa2b22ac fix conflicts 2019-09-17 19:02:44 +08:00
xiaofa 58e0469252 fix typo 2019-09-17 18:56:19 +08:00
Nathan Shively-Sanders ed152b7b06
Merge pull request #33447 from typescript-bot/user-update-Microsoft-20190801
🤖 User test baselines have changed
2019-09-16 15:59:21 -07:00
typescript-bot f06f32d945 Update user baselines 2019-09-16 14:10:30 +00:00
Orta 09d6cbc152
Merge pull request #33418 from Kingwl/duplicate_async
fix duplicate async modifier codefix
2019-09-16 09:42:13 -04:00
Wesley Wigham 038d95144d
Remove all submodules - just force clone and reset on run instead (#33425) 2019-09-13 16:14:33 -07:00
TypeScript Bot 99229f88dd Update user baselines (#33411) 2019-09-13 15:14:25 -07:00
Andrew Branch 1755db4d81
Add build-eslint-rules to npm prepare script (#33417)
* Add build-eslint-rules to local build

* Switch to prepare script
2019-09-13 14:38:10 -07:00
kingwl 93a250b9a6 fix duplicate async modifier codefix 2019-09-14 02:22:59 +08:00
Nathan Shively-Sanders a4bacf3bfa
Merge pull request #33400 from microsoft/make-perf-count-functions-public
Make perf count functions public
2019-09-12 13:51:26 -07:00
Nathan Shively-Sanders d94d715cdf Make perf count functions public
Previously they were internal
2019-09-12 13:31:11 -07:00
Sheetal Nandi bc7bde3879
Merge pull request #33390 from Swatinem/identifiers-nan
Fix `Identifiers: NaN` diagnostic when having JSON SourceFiles
2019-09-12 12:48:00 -07:00
Arpad Borsos a8d04b2db9 Fix Identifiers: NaN diagnostic when having JSON SourceFiles
This makes sure that the `identifierCount` and `nodeCount` properties
are always initialized for `SourceFile` objects.
2019-09-12 21:10:38 +02:00
Orta 0cf00fab93
Merge pull request #32965 from ajafff/ts-in-js
Detect more TS syntax in JS files
2019-09-12 20:21:51 +02:00
Jesse Trinity fd6fbdf7fe
Show more items in the navbar (#33040)
* show more items in navbar

* fixed missing node kind for property assignments

* updated navBarNestedCommonJsExports test

* updated navigationBarMerging_grandchildren test

* updated navigationBarItemsFunctions test

* updated navigationBarAnonymousClassAndFunctionExpressions test

* updated navigationBarFunctionIndirectlyInVariableDeclaration test

* updated navigationBarInitializerSpans test

* updated navigationBarItemsPropertiesDefinedInConstructors test

* updated tests

* change nav icon for properties with function-like initializers

* add test case for binding element with function-like initializer

* add navigationBarNestedObjectLiterals test

* add navigationBarFunctionLikePropertyAssignments test

* made some silly names less silly (?)

* added SpreadAssignments and ShorthandPropertyAssignments

* new wording for primary menu items
2019-09-11 15:54:27 -07:00
Orta f9cc374d21
Merge pull request #33336 from JoshuaKGoldberg/enum-syntax-error-specifics
Added more helpful syntax error for enum member commas
2019-09-11 23:05:16 +02:00
Orta e8fc62e1a2
Merge pull request #33300 from JoshuaKGoldberg/too-large-integer-bigint-codefix
Added codefix for numeric literals >= 2 ** 53
2019-09-11 22:53:19 +02:00
Sheetal Nandi 6995a907a4
Merge pull request #33358 from microsoft/dtsOnlyEmit
Instead of emitting js as well as d.ts files when only d.ts emit could change, emit only d.ts files since program.emit has that option
2019-09-11 13:09:50 -07:00
Sheetal Nandi c0f0d9f798 Merge branch 'master' into dtsOnlyEmit 2019-09-11 12:42:48 -07:00
Sheetal Nandi 3a868af5f5 Fix typo 2019-09-11 12:34:20 -07:00
Josh Goldberg 4e1768c170 Added '}' to allowed characters in diagnostic message 2019-09-11 15:32:58 -04:00
Orta 2c967c49eb
Merge branch 'master' into ts-in-js 2019-09-11 21:22:01 +02:00
Orta fb9b3fe17d
Merge pull request #32345 from dragomirtitian/GH-32325-improve-const-function-extraction
Improved const extraction for function expressions and arrow functions
2019-09-11 21:19:45 +02:00
Orta 7435425842
Merge pull request #33199 from jack-williams/fix-32809
Fix #32809
2019-09-11 21:07:00 +02:00
Titian Cernicova-Dragomir 1d97ae62b6
Update src/services/refactors/extractSymbol.ts
Fixed typo in comment

Co-Authored-By: Orta <orta.therox+github@gmail.com>
2019-09-11 21:20:55 +03:00
Ben Lichtman d7c83f023e
Merge pull request #31777 from a-tarasyuk/feature/eslint
Migrate the repo to ESLint
2019-09-10 17:07:04 -07:00
Jack Williams 630499eca2 Assume void variables are initialized 2019-09-11 00:02:39 +01:00
Sheetal Nandi 686e9a42db Do not emit .js files if only d.ts file will be impacted. 2019-09-10 12:53:17 -07:00
Alexander T 861f0bec01 update eslint-formatter-autolinkable-stylish 2019-09-10 16:34:20 +03:00
csigs e934a0d170
LEGO: Merge pull request 33343
LEGO: Merge pull request 33343
2019-09-10 01:34:09 -07:00
csigs ddd435d02a LEGO: check in for master to temporary branch. 2019-09-10 08:33:38 +00:00
Josh Goldberg 92dbb65376 Accepted a few more baselines, why not 2019-09-09 22:29:48 -04:00
Josh Goldberg 49be51dcf3 Added more helpful syntax error for enum member commas
Switches the error message emitted by the parser to the more specific _"An enum member name must be followed by a ',' or '='."_ when the expected comma doesn't follow the member.
2019-09-09 22:11:56 -04:00
Sheetal Nandi 11fd654cf9 Separate emitOnlyDtsFiles and forcing dts emit (for builder signature detection where we want it irrespective of settings) 2019-09-09 16:22:50 -07:00
Sheetal Nandi 8521002dff Baseline emitted files that are written even if same file contents 2019-09-09 15:44:43 -07:00
Sheetal Nandi e43d504422 Baseline tsbuild info section files from written files 2019-09-09 15:14:35 -07:00