Commit graph

18826 commits

Author SHA1 Message Date
Arthur Ozga 23ca368020 Use simpler indentation for comments
* When in a multi-line comment, we would have liked to use the start of
the comment as a reference point for the indentation inside the comment,
but determining the number of columns shifted for the comment start
woudl require determining the length w/r/t graphemes, which we do not
currently implement. We would like to avoid taking on a runtime
dependency on a grapheme-parsing library.

Instead, we look at the indentation level on the previoud line or start
of the comment as a reference point, and correct shift for lines
starting with an asterisk.
2017-08-16 17:51:29 -07:00
Arthur Ozga 62f16bee55 add tests 2017-08-16 17:36:50 -07:00
Arthur Ozga 4b9f5a0f8f rename tests 2017-08-16 17:36:39 -07:00
Arthur Ozga 70e4f346bb update test 2017-08-16 17:35:14 -07:00
Arthur Ozga 153b94aeb4 JsxText has no leading comments 2017-08-16 15:28:47 -07:00
Arthur Ozga ad9c29b928 add test 2017-08-15 12:44:21 -07:00
Arthur Ozga a08d18af57 consolidate isInComment and getRangeOfEnclosingComment 2017-08-15 12:09:43 -07:00
Arthur Ozga a209db7bb6 dont compute preceding token twice 2017-08-15 12:09:02 -07:00
Arthur Ozga f3e0cbbd52 findPrecedingToken handles EOF child more gracefully 2017-08-15 12:09:02 -07:00
Arthur Ozga 472ad9d313 findPrevious changes 2017-08-15 12:08:00 -07:00
Arthur Ozga b2188ad66c cleanup 2017-08-15 12:08:00 -07:00
Arthur Ozga de92e98770 fix end-of-file assert failure 2017-08-10 10:01:42 -07:00
Arthur Ozga 7c402d509d Merge branch 'master' into isInMultiLineComment 2017-08-09 10:49:12 -07:00
Wesley Wigham c399230767 Retain comments inside return statements (#17557)
* Retain comments inside return statements by including the return keyword in the parse tree

* Revert "Retain comments inside return statements by including the return keyword in the parse tree"

This reverts commit 5d2142edb1.

* Readd test

* Function for handling printing comments on a token
2017-08-08 19:53:53 -07:00
Ron Buckton 73f941d1c0 Merge pull request #17658 from Knagis/14559-non-polling-watcher
Handle empty directory path as the current directory Fixes #14559
2017-08-08 17:28:58 -07:00
Wesley Wigham 81e1e26a6c TSLint now realizes when you attempt to use a rule which is not present (#17688) 2017-08-08 17:20:25 -07:00
Wesley Wigham 43e758e1a9 Create synthetic default exports for dynamic imports (#17492)
* Create synthetic default exports for dynamic imports

* Slightly better solution

* Actually accept baselines

* Slightly adjust synthetic type

* Cache synthetic type

* Inline variables, remove non-required calls

* Rename function
2017-08-08 17:01:18 -07:00
Nathan Shively-Sanders 847d7fe3c8 Merge pull request #17404 from Microsoft/use-type-param-constraints-for-computed-prop-types
Use type parameter constraints for computed property types
2017-08-08 16:29:28 -07:00
Ron Buckton 75c8ecb2f1 Merge pull request #17517 from tinganho/IgnoredCatchParameter
Ignored catch parameter
2017-08-08 16:15:18 -07:00
Nathan Shively-Sanders fac93a304c Add parentheses:clarify evaluation order of &&/||
in isTypeAssignableToKind
2017-08-08 16:11:42 -07:00
Nathan Shively-Sanders e47df360dc Use isTypeAny instead of checking flags directly 2017-08-08 14:51:06 -07:00
Wesley Wigham d2625678f9 Add test case from #14439 (#17627) 2017-08-08 14:44:41 -07:00
Andy 3deb39bba6 Remove unnecessary check that type is ObjectType (#17418) 2017-08-08 14:01:16 -07:00
Nathan Shively-Sanders e494d73b29 Merge branch 'master' into use-type-param-constraints-for-computed-prop-types 2017-08-08 13:26:24 -07:00
Wesley Wigham a46d6bde97 Add a seperate cache for the all attributes version of the jsx attributes type (#17620) 2017-08-08 13:07:27 -07:00
Wesley Wigham af20adb137 Add tests for #15358 (#17664) 2017-08-08 13:06:12 -07:00
Ron Buckton 83ae8afef8 Merge pull request #17394 from vvakame/openParentFormatting
Add SpaceBetweenOpenParens formatting rule
2017-08-08 13:04:13 -07:00
Nathan Shively-Sanders a2c66c3262 Merge pull request #17660 from Microsoft/weak-type-errors-on-signature-only-types
Weak type errors on signature-only types
2017-08-08 12:40:50 -07:00
Andy 85f59098d3 validateSpecs: Use array helpers (#17275)
* validateSpecs: Use array helpers

* Make filter predicate smaller

* forEach -> for-of
2017-08-08 11:38:41 -07:00
Nathan Shively-Sanders 7ff1d8e797 Add specific weak type error for callable types
"Did you mean to call it?"
2017-08-08 11:25:32 -07:00
Andy d99a492ddd Simplify server logger (#17271)
* Simplify server logger

* Move function printProjects out of inner closure
2017-08-08 11:22:22 -07:00
Andy 94518e8533 Don't count self-reference when setting isReferenced (#17495)
* Don't count self-reference when setting `isReferenced`

* Improve comment
2017-08-08 11:18:20 -07:00
Andy eb8bcd77cb tsserverProjectSystem.ts: Remove unnecessary 'export's (#17201)
* tsserverProjectSystem.ts: Remove unnecessary 'export's

* Export `PostExecAction`
2017-08-08 11:02:53 -07:00
Andy 5141ce751d Deduplicate unresolvedImports (#17248)
* Deduplicate unresolvedImports

* Add `isNonDuplicateInSortedArray` helper
2017-08-08 11:02:10 -07:00
Andy f69ce5c0c8 Convert two arrays to readonly (#17685) 2017-08-08 10:54:18 -07:00
Andy e1802f4966 MultistepOperation: Don't need 'completed', just use requestId === undefined (#17173)
* MultistepOperation: Don't need 'completed', just use `requestId === undefined`

* Check for `requestId !== undefined`
2017-08-08 10:49:49 -07:00
Nathan Shively-Sanders 781da2332d Merge branch 'master' into weak-type-errors-on-signature-only-types 2017-08-08 10:45:52 -07:00
Andy ceae613e4c Add lint rule to check that Debug.assert calls do not eagerly interpolate strings (#17125)
* And lint rule to check that `Debug.assert` calls do not eagerly interpolate strings

* Use more specific 'assert' functions to avoid callbacks

* Respond to PR feedback
2017-08-08 07:56:14 -07:00
Andy a9a30d76fb Fix parsing of globalPlugins and pluginProbeLocations: Don't include empty string (#17143) 2017-08-08 07:55:03 -07:00
Andy 382785a528 Fix logging of module resolution errors (#17144) 2017-08-08 07:54:08 -07:00
Andy 9ea2350a6d Simplify parameters to updateProjectStructure and updateErrorCheck (#17175) 2017-08-08 07:31:21 -07:00
Karlis Gangis 51e9aef2a7 FileWatcher - handle empty directory path as the current directory Fixes #14559 2017-08-08 09:32:37 +03:00
Ron Buckton 5a64556e4b Merge pull request #17604 from Microsoft/implicitlyExcludeNodeModules
exclude node_modules unless explicitly included
2017-08-07 18:39:30 -07:00
Ron Buckton 813aaf40c0 fix lint errors 2017-08-07 18:20:57 -07:00
Ron Buckton cacc3006c7 Merge branch 'master' into implicitlyExcludeNodeModules 2017-08-07 18:17:05 -07:00
Ron Buckton b07aa0d971 fix lint errors 2017-08-07 17:58:32 -07:00
Arthur Ozga 2f5b1d3e18 Merge branch 'master' into isInMultiLineComment 2017-08-07 15:58:46 -07:00
Arthur Ozga 091376f46f supressFormatOnKeyInComments 2017-08-07 15:45:56 -07:00
Ron Buckton 31230b9176 Merge pull request #16953 from charlespierce/destructure_completion_nonpublic
Remove nonpublic members from destructuring completion lists
2017-08-07 14:24:47 -07:00
Anders Hejlsberg aa0fc0b885 Merge pull request #17633 from Microsoft/indexSignatureMappedType
Mapped type and string index signature relations
2017-08-07 14:17:29 -07:00