Commit graph

27279 commits

Author SHA1 Message Date
Ron Buckton
26fd6dafa6 Relate a source type that is sufficiently covered by a target discriminated union 2019-04-29 15:46:37 -07:00
Nathan Shively-Sanders
c3a9429420
Handle JSDoc backticks in the parser, not scanner (#30939)
* Scan backticks in jsdoc as a single token less often

Previously, matching backticks in jsdoc would always be scanned as one
token to aid parsing incorrect jsdoc that uses backticks for parameter
names:

``js
/** @param {string} `nope`
 * @param {number} `not needed`
 */
```

However, this is wrong for code fences, which use triple backticks. This
fix parses a single backtick as a single token if it's immediately
followed by another backtick or by a newline. It retains the
questionable tokenisation of backticks-as-pairs in other cases, however.
A better fix might be to have the parser ignore backticks in jsdoc
instead.

* Add test case

* Handle jsdoc backticks in the parser, not scanner

Previously, the jsdoc scanner had ad-hoc handling of backticks that was
similar in structure to the normal scanner's handling, but much simpler.
This was a smaller code change, but is handled backwards: the special
case of backtick-quoted parameter names was handled in the scanner
instead of in the jsdoc identifier parsing code. That made it overapply
and block correct handling of asterisks across newlines, which was most
obvious in code fences inside jsdoc, as in #23517.

Fixes #23517

* More cleanup
2019-04-18 09:35:40 -07:00
Wesley Wigham
0574c1fae1
Hide the table of perf results from the bot inside an expando element (#31007) 2019-04-18 09:09:22 -07:00
Anders Hejlsberg
33c3ce9cd0
Merge pull request #31002 from Microsoft/fixIsStringIndexSignatureOnlyType
Fix isStringIndexSignatureOnlyType function
2019-04-17 17:19:34 -07:00
Sheetal Nandi
ea2331bcfb
Merge pull request #31005 from Microsoft/tsbuildTestPerf
Improve tsbuild tests perf by not including all built libFiles but dummy lib File
2019-04-17 16:22:35 -07:00
Sheetal Nandi
83941c4655 Fix lateBoundSymbol test case to handle the simple lib file for the test 2019-04-17 16:19:34 -07:00
Sheetal Nandi
b337565747 Merge branch 'master' into tsbuildTestPerf 2019-04-17 16:05:00 -07:00
Sheetal Nandi
058cb91d03
Merge pull request #30970 from Microsoft/incrementalLateSymbol
When adding resolvedMembers ensure lateBoundSymbol is added whether it was previously checked or not
2019-04-17 16:04:12 -07:00
Sheetal Nandi
0c18d032e7 Merge branch 'master' into incrementalLateSymbol 2019-04-17 15:41:53 -07:00
Sheetal Nandi
acbedade42 No need to fix hash of lib files since the content is now fixed 2019-04-17 15:37:56 -07:00
Sheetal Nandi
dc7d77f2c7 Make the tsbuild tests use simple libFile instead of bigger lib file set 2019-04-17 15:35:00 -07:00
Sheetal Nandi
b9145f98e1
Merge pull request #30980 from Microsoft/configChangeForEmit
Make sure to emit again if change in compiler option affects emit
2019-04-17 15:14:12 -07:00
Sheetal Nandi
d919f2c113 Add test for #28334 2019-04-17 15:13:09 -07:00
Anders Hejlsberg
a40b08d1d7
Merge pull request #30944 from Microsoft/fixInferenceToMappedType
Fix inference from enum object type to generic mapped type
2019-04-17 15:10:34 -07:00
Anders Hejlsberg
462caf8d8e Accept new baselines 2019-04-17 15:06:06 -07:00
Anders Hejlsberg
4d0244c798 Add regression test 2019-04-17 15:05:57 -07:00
Anders Hejlsberg
9b3b8e3203 Ignore generic mapped types in isStringIndexSignatureOnlyType 2019-04-17 14:59:28 -07:00
Nathan Shively-Sanders
4420d1083b
Add diagnostics for relation cache size (#30999)
* Add diagnostics for relation cache size

* Move to extendedDiagnostics

* Single method that returns a 3-property object

* Fix double-space lint
2019-04-17 14:32:18 -07:00
Anders Hejlsberg
50fdeccd7f One more iteration 2019-04-17 13:58:05 -07:00
Sheetal Nandi
3af78ae77a Revert and always use merged symbol to get members of late bound symbol
Fixes #30891
2019-04-17 12:58:12 -07:00
Wesley Wigham
169e485d90
Perform excess property checking on intersection and union members (#30853)
* Perform excess property checking on intersection and union members

* Allow partial union props to contain the undefined type

* Add test case from #30771

* Un-terse getPossiblePropertiesOfUnionType side-effecting code

* Fix bug exposed in RWC

* Cache results of getPossiblePropertiesOfUnionType

* Fix whitespace
2019-04-16 21:58:48 -07:00
Anders Hejlsberg
3435451dcc Even more succinct 2019-04-16 18:26:24 -07:00
Anders Hejlsberg
efa16ac11f Address CR feedback 2019-04-16 17:41:33 -07:00
Sheetal Nandi
15ae8a7273 Make sure to emit again if change in compiler option affects emit
Fixes #30736
2019-04-16 16:18:37 -07:00
Sheetal Nandi
3c67608715 When interfaces are merged, always ensure that the parent symbol of the late bound member symbol is declared symbol containing the node.
Ensure that resolvedMembers adds the late bound symbol even when its resolved sunce lateBoundMember may or may not be added to resolved members depending on when its checked
Fixes #30891
2019-04-16 12:36:46 -07:00
Sheetal Nandi
9f5090cec7 Test case for #30891 2019-04-16 12:33:21 -07:00
Anders Hejlsberg
f617d1641b
Merge pull request #30963 from Microsoft/fixObjectFlagsPropagation
Fix object flags propagation
2019-04-16 07:25:41 -10:00
Anders Hejlsberg
4668411464 Accept new baselines 2019-04-16 10:00:56 -07:00
Anders Hejlsberg
dbe71a2ddd Add regression test 2019-04-16 10:00:49 -07:00
Anders Hejlsberg
6ac0dbcaef Propagate ObjectFlags.NonInferrableType through widening 2019-04-16 09:46:45 -07:00
TypeScript Bot
ec70c80960 Update user baselines (#30958) 2019-04-16 07:30:58 -07:00
Wesley Wigham
d405662eb6
Explicitly encode keyof behaviors for never and unknown into getIndexType (#30753)
* Explicitly encode keyof behaviors for never and unknown into getIndexType

* Merge similar cases
2019-04-15 17:52:13 -07:00
Anders Hejlsberg
436f6067ac Accept new baselines 2019-04-15 15:07:15 -07:00
Anders Hejlsberg
83f3d2ee17 Add regression test 2019-04-15 15:06:55 -07:00
Anders Hejlsberg
cc2ea68492 Fix inference from enum object type to generic mapped type 2019-04-15 15:06:44 -07:00
Daniel Rosenwasser
3dc78b6f3b
Merge pull request #30916 from jack-williams/array-elaboration
Elaborate array and tuple relation errors
2019-04-15 14:00:22 -07:00
Andrew
13d9f08976 Gracefully parse 'super' with type arguments (#10677) (#30913) 2019-04-15 13:06:29 -07:00
TypeScript Bot
72f66566d9 Update user baselines (#30937) 2019-04-15 11:25:12 -07:00
Jack Williams
2ea91a0e9c Elaborate array and tuple relation errors 2019-04-15 18:16:38 +01:00
Anders Hejlsberg
3902ef78ae
Merge pull request #30917 from Microsoft/fixIntersectionUnionConstraint
Fix checking of intersection with union constraint
2019-04-14 20:37:41 -10:00
Anders Hejlsberg
f3fd27c0ee Accept new baselines 2019-04-13 08:24:34 -10:00
Anders Hejlsberg
2c951b3ca9 Add regression test 2019-04-13 08:24:27 -10:00
Anders Hejlsberg
b9f805f2f4 Remove incorrect optimization in getUnionConstraintOfIntersection 2019-04-13 08:15:28 -10:00
TypeScript Bot
4fee628447 Update user baselines (#30885) 2019-04-12 14:26:47 -07:00
Adam Postma
e951455215 Update misspelling 'identifer' to 'identifier' (#30894)
* fix typo - identifer to identifier

* fix typo - identifer to identifier
2019-04-12 13:29:00 -07:00
Anders Hejlsberg
4574c7a375
Merge pull request #30877 from Microsoft/fixConditionalTypeSimplification
Fix conditional type simplification
2019-04-12 07:35:19 -10:00
Anders Hejlsberg
6282645e3c
Merge pull request #30857 from Microsoft/fixInferenceToIntersection
Fix inference to intersections
2019-04-12 07:34:40 -10:00
Anders Hejlsberg
6cd229b4b9
Merge pull request #30769 from Microsoft/saferIndexedAccessTypes
Improve soundness of indexed access types
2019-04-12 07:33:50 -10:00
Anders Hejlsberg
06d07b08d9 Accept new baselines 2019-04-11 16:22:09 -10:00
Anders Hejlsberg
e44a52a011 Add regression test 2019-04-11 16:22:01 -10:00