Commit graph

23702 commits

Author SHA1 Message Date
csigs 2d9b30d9a2
LEGO: Merge pull request 24734
LEGO: Merge pull request 24734
2018-06-06 15:11:03 -07:00
csigs 7cd85f3acb LEGO: check in for master to temporary branch. 2018-06-06 22:10:42 +00:00
Mohamed Hegazy 34dd7738c9
Merge pull request #24672 from bakkot/binding-comma
Allow trailing commas after non-rest elements in destructuring
2018-06-06 13:00:17 -07:00
Nathan Shively-Sanders 30994c86e4
Improve valueDeclaration for js module merges (#24707)
Nearly everything in a merge of JS special assignments looks like a
valueDeclaration. This commit ensures that intermediate "module
declarations" are not used when a better valueDeclaration is available:

```js
// File1.js
var X = {}
X.Y.Z = class { }

// File2.js
X.Y = {}
```

In the above example, the `Y` in `X.Y.Z = class { }` was used as the
valueDeclaration for `Y` because it appeared before `X.Y = {}` in the
compilation.

This change exposed a bug in binding, #24703, that required a change in
typeFromPropertyAssignmentOutOfOrder. The test still fails for the
original reason it was created, and the new bug #24703 contains a repro.
2018-06-06 11:11:15 -07:00
Ron Buckton 942c42bf29
Merge pull request #24677 from Microsoft/checkEvaluatorSyntax
Fails test if evaluator source text has errors
2018-06-06 10:42:11 -07:00
Nathan Shively-Sanders d6250c8342
Fix circularity error when extending class in same JSContainer (#24710)
Do this by not widening properties of an object literal that are

1. JS initialisers
2. and not an object literal

These properties have types that will never widen, so the compiler
shouldn't ask for the types earlier than it strictly needs to.
2018-06-06 09:13:38 -07:00
csigs 0db52da564
LEGO: Merge pull request 24727
LEGO: Merge pull request 24727
2018-06-06 09:10:58 -07:00
csigs 16597e5e97 LEGO: check in for master to temporary branch. 2018-06-06 16:10:34 +00:00
csigs 04d7fd3480
LEGO: Merge pull request 24720
LEGO: Merge pull request 24720
2018-06-06 00:56:15 -07:00
csigs 3c8f64ce14 LEGO: check in for master to temporary branch. 2018-06-06 07:55:52 +00:00
Nathan Shively-Sanders 8d737ca959
Simplify parseJSDocIdentifierName (#24660)
* Simplify parseJSDocIdentifierName

It now always creates a missing node. The one place that depended on it
returning undefined, parseJSDocTypeNameWithNamespace, now returns
undefined before calling parseJSDocIdentifierName.

* Remove assert

It is adequately proven at compile time.
2018-06-05 14:30:37 -07:00
Wesley Wigham d9b93903c0
Use more nodelike paths for import types when possible (#24610)
* Use more nodelike paths for import types when possible

* move functionality from services into compiler, fix with propert file/directory conflict handling

* mark suspect cast
2018-06-05 12:54:36 -07:00
Andy 735a46f838
If parsing a function type fails, parseTypeReference() to ensure something is returned (#24567)
* If parsing a function type fails, parseTypeReference() to ensure something is returned

* Avoid tryParse

* Add missing semicolon

* Don't check for undefined, check for missing type

* Don't set parameters undefined, set to missingList and return false

* Update API baselines

* Code review
2018-06-05 10:24:37 -07:00
csigs 9681796785
LEGO: Merge pull request 24692
LEGO: Merge pull request 24692
2018-06-05 09:11:03 -07:00
csigs 54845d2396 LEGO: check in for master to temporary branch. 2018-06-05 16:10:39 +00:00
csigs 4784f5b095
LEGO: Merge pull request 24682
LEGO: Merge pull request 24682
2018-06-05 03:11:05 -07:00
csigs bcd4768699 LEGO: check in for master to temporary branch. 2018-06-05 10:10:41 +00:00
Mohamed Hegazy 7a5dec4d7b
Merge pull request #24669 from Microsoft/updateDom
Port generated lib files
2018-06-04 17:27:08 -07:00
Ron Buckton 6575d930fc Fails test if evaluator source text has errors 2018-06-04 17:05:46 -07:00
Mohamed Hegazy e9ebb3e95c Merge remote-tracking branch 'origin/master' into updateDom 2018-06-04 17:01:34 -07:00
Mohamed Hegazy a14f034100
Merge pull request #24576 from ajafff/fix-syntax-error
fix syntax error in unit test
2018-06-04 16:42:23 -07:00
Ron Buckton fbeb58a147
Merge pull request #23893 from Microsoft/libReference
Adds 'lib' reference directives
2018-06-04 16:14:52 -07:00
csigs c437404763
LEGO: Merge pull request 24673
LEGO: Merge pull request 24673
2018-06-04 15:11:21 -07:00
csigs 8515d65796 LEGO: check in for master to temporary branch. 2018-06-04 22:11:01 +00:00
Kevin Gibbons 87bb5e3cbb Allow trailing commas after-rest elements in destructuring 2018-06-04 14:58:30 -07:00
Ron Buckton 666841264c Merge branch 'master' into libReference 2018-06-04 14:38:56 -07:00
Wesley Wigham 7eaa78846e
Visit the children of an import type/require call/dynamic import when looking for those (#24663) 2018-06-04 14:31:56 -07:00
Mohamed Hegazy 5e57cd4fbf Update baselines 2018-06-04 14:28:19 -07:00
Wesley Wigham cbbf2e4e6f
Resolve aliases before using getTypereferenceType (#24594) 2018-06-04 14:19:41 -07:00
Andy b3a4b72a16
Always include Jsdoc comment in getTouchingPropertyName (#23379) 2018-06-04 14:15:41 -07:00
Mohamed Hegazy 2435213c9d Update Third party notice doc 2018-06-04 14:13:57 -07:00
Andy a641e6f85f
goToDefinition: Put variable definition before signature definition (#24649)
* goToDefinition: Put variable definition before signature definition

* Fix lint
2018-06-04 14:13:27 -07:00
Mohamed Hegazy f960d5c97f Port generated lib files 2018-06-04 14:13:16 -07:00
Mohamed Hegazy 5ba223d7dd Change file name 2018-06-04 14:05:56 -07:00
Mohamed Hegazy 2f73986b44 Update LKG 2018-06-04 14:02:51 -07:00
Ron Buckton fb09aeb23d Remove debugger statement 2018-06-04 13:42:31 -07:00
Sheetal Nandi c3dcc83d4f
Merge pull request #24664 from Microsoft/builderAPIBreak
Fix the issue with createSemanticDiagnosticsBuilderProgram, createEmitAndSemanticDiagnosticsBuilderProgram and createAbstractBuilder not assignable to CreateProgram<T>
2018-06-04 13:35:40 -07:00
Nathan Shively-Sanders 7db4b1cbc7
Fix property assignment on aliases (#24659)
Aliases don't have valueDeclarations, which caused a crash when passed
to isJavascriptContainer before.
2018-06-04 13:34:23 -07:00
Andy f9530d7e8f
Add 'parseOptionalJsdoc' helper (#24650) 2018-06-04 13:28:47 -07:00
Sheetal Nandi e88305173d Fix the issue with createSemanticDiagnosticsBuilderProgram, createEmitAndSemanticDiagnosticsBuilderProgram and createAbstractBuilder not assignable to CreateProgram<T>
Fixes #24625
2018-06-04 13:03:57 -07:00
Sheetal Nandi 8427e95386 Tests to acknowledge the public watch api 2018-06-04 12:59:01 -07:00
Nathan Shively-Sanders 34e68efdae
Template tag allows specification of constraints (#24600)
* Parse (and mostly support) template tag constraints

A bunch of tests hit the asserts I added though.

* Messy version is finished. Need to add a few tests

* Refactor to be smaller

* Small refactor + Add one test

* Another test

* Minor cleanup

* Fix error reporting on type parameters on ctors

* Simplify syntax of `@template` tag

This is a breaking change, but in my sample, nobody except webpack used the
erroneous syntax. I need to improve the error message, so
jsdocTemplateTag3 currently fails to remind me of that.

* Better error message for template tag

* Fix fourslash baselines

* Another fourslash update

* Address PR comments

* Simplify getEffectiveTypeParameterDeclarations

Make checkGrammarConstructorTypeParameters do a little more work
2018-06-04 11:42:46 -07:00
Andy 2ce7e5f0cd
Add 'unknown' to type keywords (#24606) 2018-06-04 11:31:48 -07:00
Andy d8cea359f7
moveToNewFile: Update namespace imports (#24612) 2018-06-04 11:30:14 -07:00
Anders Hejlsberg 75d0852d3e
Merge pull request #24637 from Microsoft/fixIndexedAccessSimplification
Fix indexed access simplification
2018-06-04 10:58:23 -07:00
Sheetal Nandi d64608dc97
Merge pull request #24615 from Microsoft/jsonSourceMaps
Disable source maps and declaration emit for the json module
2018-06-04 10:48:43 -07:00
Andy 046c5ea6c1
moveToNewFile: Ignore reference to global (#24651) 2018-06-04 10:35:23 -07:00
Wesley Wigham 779fa98475
Fix merge lexical environment to *always* respect prologue statements (#24602) 2018-06-04 10:34:38 -07:00
Andy 886377f8d3
Add autoCloseTag language service (#24543)
* Add autoCloseTag language service

* Change name to getJsxClosingTagAtPosition and return an object
2018-06-04 10:08:15 -07:00
Benjamin Lichtman 7b8426d81c
Merge pull request #24596 from uniqueiniquity/handleMissingRegistryEntries
Handle missing registry entries
2018-06-04 09:47:10 -07:00