Arthur Ozga
487ba21c14
Merge pull request #17903 from Microsoft/revert-17870-fix-getConstraintOfIndexedAccess
...
Revert "Fix getConstraintOfIndexedAccess"
2017-08-18 11:33:27 -07:00
Arthur Ozga
6b68da1185
Revert "Fix getConstraintOfIndexedAccess"
2017-08-18 11:32:53 -07:00
Arthur Ozga
439cdca52f
Merge pull request #17870 from Microsoft/fix-getConstraintOfIndexedAccess
...
Fix getConstraintOfIndexedAccess
2017-08-18 11:32:48 -07:00
Andy
ade3b565ae
Revert public API changes to logger ( #17899 )
2017-08-18 11:20:07 -07:00
Andy
eef7d8bd3d
Treat explicit imports from node_modules
as external library imports ( #16364 )
...
* Treat explicit imports from `node_modules` as external library imports
* Update baselines
2017-08-17 13:26:38 -07:00
Nathan Shively-Sanders
a187b17e97
Simplify mapped-type handling in computeBaseConstraint
2017-08-17 13:09:21 -07:00
Nathan Shively-Sanders
1b4f90705f
Test getConstraintOfIndexedAccess fixes and update baselines
2017-08-17 12:45:20 -07:00
Nathan Shively-Sanders
b8e0dedac0
Fix #17069 and #15371
...
1. `T[K]` now correctly produces `number` when
`K extends string, T extends Record<K, number>`.
2. `T[K]` no longer allows any type to be assigned to it when
`T extends object, K extends keyof T`.
Previously both of these cases failed in
getConstraintOfIndexedAccessType because both bases followed `K`'s base
constraint to `string` and then incorrectly produced `any` for types
(like `object`) with no string index signature. In (1), this produced an
error in checkBinaryLikeExpression`. In (2), this failed to produce an
error in `checkTypeRelatedTo`.
2017-08-17 12:40:10 -07:00
Andy
babb88a0aa
Remove duplicate function ( #17807 )
2017-08-17 06:52:15 -07:00
Daniel Rosenwasser
2729281a14
Merge pull request #17631 from Microsoft/synthesizedNamespaces
...
Always emit leading 'var' declarations for synthesized namespaces
2017-08-16 23:56:07 -07:00
Daniel Rosenwasser
a38da8af70
Merge pull request #17838 from Microsoft/rev2.6.0
...
Bump version to 2.6.0.
2017-08-16 23:50:50 -07:00
Arthur Ozga
0d94d497df
Merge pull request #16621 from aozgaa/formattingAfterParseError
...
Formatting after parse error
2017-08-16 20:49:29 -07:00
Arthur Ozga
bc0c9a440e
Merge branch 'master' into formattingAfterParseError
2017-08-16 20:27:06 -07:00
Daniel Rosenwasser
b7020628c1
Addressed code review feedback.
2017-08-16 15:06:51 -07:00
Daniel Rosenwasser
3f50f20d0a
Updated version in 'src' as well.
2017-08-16 14:49:44 -07:00
Andy
d4fecd4e46
Have grammarErrorAtPos
take the source file of its argument ( #17834 )
2017-08-16 14:48:58 -07:00
Andy
9bcbc97e14
Replace 'isSourceFileJavaScript(getSourceFileOfNode())' with 'NodeFlags.JavaScriptFile' ( #17835 )
2017-08-16 14:48:46 -07:00
Andy
54af8aa945
Array arguments to concat
should be ReadonlyArray
s ( #17806 )
2017-08-16 14:32:14 -07:00
Tycho Grouwstra
76fb6545a5
fix some copy-pasting error ( #17766 )
...
* fix some copy-pasting error
* update to reflect @ahejlsberg's feedback
2017-08-16 11:49:24 -07:00
Nathan Shively-Sanders
146f828919
Merge pull request #17710 from Microsoft/add-readonly-check-to-property-access-of-index-signature
...
Add readonly check to property access of index signature
2017-08-16 11:16:54 -07:00
Daniel Rosenwasser
afdd77f1f6
Bump version to 2.6.0.
2017-08-16 10:41:49 -07:00
Nathan Shively-Sanders
7809398ad4
Indexed-assignment readonly err is not unknownType
...
Now, in an assignment to an indexed access of a readonly property, the
resulting type is still the property's type. Previously it was
unknownType. This improves error reporting slightly by reporting some
errors that were previously missed.
2017-08-16 10:06:01 -07:00
Andy
34a55899be
Remove unnecessary call to getApparentType
( #17788 )
2017-08-16 10:04:51 -07:00
Anders Hejlsberg
ce2ac1751e
Merge pull request #17771 from Microsoft/fixCircularContextualType
...
Fix circular contextual return type error
2017-08-16 09:17:15 +02:00
Andy
93abebc04a
Change function name to camelCase ( #17751 )
2017-08-15 12:26:00 -07:00
Daniel Rosenwasser
281d821fe8
Fix lint errors.
2017-08-15 12:16:54 -07:00
Ryan Cavanaugh
eb8f7bddc2
Merge pull request #17796 from basarat/patch-1
...
Fix build 🌹
2017-08-15 11:06:33 -07:00
Andy
7409648416
Remove unused UseTypeAliasValue
flag ( #17779 )
2017-08-15 10:24:15 -07:00
Andy
10c8d5effa
In services, show the aliasSymbol for a type even if it's not accessible in the current scope ( #17433 )
...
* In services, show the aliasSymbol for a type even if it's not accessible in the current scope
* Rename flag
2017-08-15 10:23:45 -07:00
Basarat Ali Syed
c4dd820564
export interfaces used by exported functions 🌹
2017-08-15 15:19:40 +10:00
Basarat Ali Syed
e7ddaa7d49
export ScopeUsages 🌹
2017-08-15 15:17:19 +10:00
Daniel Rosenwasser
6e60a017bb
Accepted baselines.
2017-08-14 21:24:51 -04:00
Daniel Rosenwasser
a51397e339
Just track the local names of identifiers instead of ever using symbols.
2017-08-14 21:24:30 -04:00
Andy
80a7ed9a42
Fixes to session's handling of empty results ( #17728 )
...
* Fixes to session's handling of empty results
* Fix emptyArray -> undefined
2017-08-14 13:42:15 -07:00
Wesley Wigham
e2f35ecead
Accept missing baseline updates for #13721
2017-08-14 13:23:22 -07:00
Anders Hejlsberg
a1cbeb2eca
Merge pull request #17767 from tycho01/15768-generic-numeric-index-error
...
loosen number index check, fixes #15768
2017-08-14 19:02:06 +02:00
Andy
543e0affff
Make exportSymbol public ( #17457 )
...
* Make exportSymbol public
* Add a `getExportSymbolOfSymbol` method
* Use own implementation instead of delegating to `getExportSymbolOfValueSymbolIfExported`
2017-08-14 09:20:48 -07:00
Daniel Rosenwasser
ea7c7d3467
Merge pull request #16631 from Microsoft/fix13721
...
Emit class annotation comment on downlevel classes
2017-08-14 10:33:41 -04:00
Tycho Grouwstra
4268e13cde
simplify fix as suggested by @ahejlsberg
2017-08-14 17:45:18 +08:00
Anders Hejlsberg
57705fc4e0
Add regression test
2017-08-14 09:08:11 +02:00
Anders Hejlsberg
dacc851434
No contextual return type when type is circular
2017-08-14 09:01:50 +02:00
Tycho Grouwstra
1d6863ab0b
loosen number index check, fixes #15768
2017-08-14 02:18:47 +08:00
Wesley Wigham
d03d1074ee
Make compiler options which map to a flag case-insensitive again ( #17755 )
2017-08-11 19:59:43 -07:00
Ron Buckton
360dc914c3
Merge pull request #17602 from Microsoft/multiInferredProjects
...
Adds support for inferred project isolation by projectRootPath
2017-08-11 16:06:49 -07:00
Ron Buckton
c272c3c5cd
Comment update
2017-08-11 16:06:24 -07:00
Ron Buckton
95ee9aef0f
Merge pull request #17750 from Microsoft/importFixInferQuote
...
Add support to infer the quote style for import code fix
2017-08-11 15:52:38 -07:00
Daniel Rosenwasser
33a036b679
Accepted baselines.
2017-08-11 18:47:21 -04:00
Daniel Rosenwasser
18cced9abd
Added test.
2017-08-11 18:44:37 -04:00
Ron Buckton
09487b8a1d
Added tests, pr feedback
2017-08-11 15:31:09 -07:00
Ron Buckton
e3b6df64b3
Add support to infer the quote style for import quick fixes
2017-08-11 14:26:25 -07:00