Andy
d1d69602ae
getJSDocParameterTags: Always return defined result ( #22523 )
...
* getJSDocParameterTags: Always return defined result
* Make line shorter
* Simplify remaining use
2018-03-13 17:56:00 -07:00
Sheetal Nandi
60501c8b49
Merge pull request #22526 from Microsoft/testModifiedTime
...
Instead of using current time, use predefined time for modification to ensure we can detect changes correctly and arent timing dependent
2018-03-13 17:06:22 -07:00
Sheetal Nandi
d8fe6ed01a
Instead of using current time, use predefined time for modification to ensure we can detect changes correctly and arent timing dependent
...
Fixes #22455
2018-03-13 17:05:16 -07:00
Nathan Shively-Sanders
0fa838a3ef
Brackets and postfix= in @param
add undefined ( #22514 )
...
* Brackets and postfix= in `@param` add undefined
Previously they only added optionality.
Note that, unlike Typescript, when a parameter initializer is specified
in jsdoc, it does not remove undefined in the *body* of the function.
That's because TS will generate initialisation code, but JS won't, so
the author will have to manually write code to remove undefined from the
type.
```js
/** @param {number} [a=101] */
function f(a) {
// a: number | undefined here
if (!a) {
a = 101
}
// a: number here
}
```
Note that we don't check that
1. the initializer value is actually assigned to the parameter.
2. the initializer's type matches the declared type of the parameter.
Pretty much we just parse it and leave it alone.
* Address PR comments
2018-03-13 15:56:38 -07:00
Andy
23a64fe804
Remove redundant call to checkNodeDeferred
( #22516 )
...
* Remove redundant call to `checkNodeDeferred`
* Use a set to speed up `contains` checks
2018-03-13 15:46:25 -07:00
csigs
e41feab3bd
LEGO: Merge pull request 22521
...
LEGO: Merge pull request 22521
2018-03-13 15:11:08 -07:00
csigs
472a7f4d5b
LEGO: check in for master to temporary branch.
2018-03-13 22:10:47 +00:00
Sheetal Nandi
4046bb15ac
Do not send first missing file event as well.
2018-03-13 15:09:13 -07:00
Andy
0c6ef348ce
Simplify parseJsxChildren ( #22511 )
2018-03-13 12:28:21 -07:00
Mohamed Hegazy
85df31cde4
Merge pull request #22512 from Microsoft/fixUseOfProcess
...
Do not use unguarded process in tsc.ts
2018-03-13 11:24:31 -07:00
Sheetal Nandi
32018f66bb
Merge pull request #22496 from Microsoft/suppressMultipleDelete
...
Do not send delete event every poll for missing folder
2018-03-13 11:11:51 -07:00
Mohamed Hegazy
708caf9a72
Do not use unguarded process in tsc.ts
2018-03-13 11:03:12 -07:00
Nathan Shively-Sanders
25f7e0b735
Fix crash after var = require('x')
type resolution ( #22452 )
...
* Harden var x=require name resolution+update chrome baseline
Chrome-devtools crashed after the new `var = require('x')` resolution
because it forgot to check whether the declaration had an initializer.
* Update chrome-devtools-frontend baseline
2018-03-13 10:44:02 -07:00
csigs
58bb30a64b
LEGO: Merge pull request 22505
...
LEGO: Merge pull request 22505
2018-03-13 09:10:40 -07:00
csigs
b01da6d65e
LEGO: check in for master to temporary branch.
2018-03-13 16:10:20 +00:00
csigs
8e8e879fc2
LEGO: Merge pull request 22502
...
LEGO: Merge pull request 22502
2018-03-13 03:10:39 -07:00
csigs
6c85649fa4
LEGO: check in for master to temporary branch.
2018-03-13 10:10:20 +00:00
csigs
8d5aa2452e
LEGO: Merge pull request 22501
...
LEGO: Merge pull request 22501
2018-03-12 21:10:41 -07:00
csigs
f13db055ce
LEGO: check in for master to temporary branch.
2018-03-13 04:10:21 +00:00
Andy
83b438ffa6
fixUnusedIdentifier: Don't remove setter parameter ( #22488 )
2018-03-12 16:07:20 -07:00
csigs
d3ede7b907
LEGO: Merge pull request 22498
...
LEGO: Merge pull request 22498
2018-03-12 15:11:50 -07:00
csigs
a7e8c3868b
LEGO: check in for master to temporary branch.
2018-03-12 22:11:32 +00:00
Sheetal Nandi
3f2ff0125a
Merge pull request #22450 from Microsoft/reenableTest
...
Enable the commented out test and convert folder entries to sorted list
2018-03-12 14:47:02 -07:00
Andy
ac5a39c709
Fix bug: Don't skip emitting JSX attributes ( #21777 )
2018-03-12 14:03:25 -07:00
Sheetal Nandi
88c5e2295b
Do not send delete event every poll for missing folder
...
Fixes #22494
2018-03-12 13:52:15 -07:00
csigs
9d6386c248
LEGO: Merge pull request 22489
...
LEGO: Merge pull request 22489
2018-03-12 09:10:45 -07:00
csigs
f80d0a064a
LEGO: check in for master to temporary branch.
2018-03-12 16:10:20 +00:00
Sheetal Nandi
a0cd8d3f7d
Ensure our readonly emptyArray stays non modified.
2018-03-09 16:56:14 -08:00
Nathan Shively-Sanders
be1c11581e
Add js user tests ( #22449 )
...
* Add some new user tests to test salsa
* Use current latest, not "latest"
* Add other js user tests
* Add new baselines
* Fix new user tests' typeroot. Move github to octokit/rest
2018-03-09 15:59:46 -08:00
Wesley Wigham
2204fb3fe7
Add submodule update step to circle ( #22451 )
...
* Add submodule update step to circle
* Move to post checkout
* Consolidate repetitive settings
2018-03-09 14:50:34 -08:00
Mohamed Hegazy
3dc754aa7d
Merge pull request #22448 from Microsoft/portGeneratedLibFiles3-9-2
...
Port generated lib files
2018-03-09 14:42:37 -08:00
Sheetal Nandi
fa2b7ff6b3
Merge pull request #22421 from Microsoft/typesInTypeArguments
...
Allow types as well as values in possibly type argument location
2018-03-09 14:36:45 -08:00
Mohamed Hegazy
b6e83cd1a1
accept baselines
2018-03-09 14:22:00 -08:00
Mohamed Hegazy
88fc88120c
Port generated lib files
2018-03-09 14:06:14 -08:00
Sheetal Nandi
ef64cde621
Merge pull request #22409 from Microsoft/symbolKind
...
Symbol kind needs to use location before falling back to flags
2018-03-09 13:59:38 -08:00
Sheetal Nandi
a20a00e222
Enable the commented out test and convert folder entries to sorted list
2018-03-09 13:59:12 -08:00
Sheetal Nandi
73947f8990
Add comments and make some nit changes based on PR feedback
2018-03-09 13:57:57 -08:00
Mohamed Hegazy
4b6adb8a10
Merge pull request #22444 from obany/master
...
Fix typo in emitDeclarationOnly error message for declaration required
2018-03-09 13:42:41 -08:00
Martyn Janes
bcf6e342f1
Fix typo in emitDeclarationOnly error message for declaration required
2018-03-09 22:37:10 +03:00
Mohamed Hegazy
6959bda3c9
Disable test
2018-03-09 09:58:38 -08:00
Mohamed Hegazy
4ae8764ffc
update branch list
2018-03-09 09:45:25 -08:00
Mohamed Hegazy
3480bf2eb9
Port generated lib files ( #22437 )
...
* Port generated lib files
* Update line breaks
2018-03-09 09:05:28 -08:00
Mohamed Hegazy
c335c3803c
Fix #22133 : Expose getOutliningSpans on the server protocol ( #22400 )
...
* Fix #22133 : Expose getOutliningSpans on the server protocol
* Remove debugger statement from test
2018-03-09 08:50:47 -08:00
Mohamed Hegazy
1fc3aebc20
Port changes from #22172 , provide a callback to fs.close ( #22405 )
2018-03-09 08:30:09 -08:00
Andy
0f47c8a205
annotateWithTypeFromJSDoc: Do less special-casing for arrow functions ( #22407 )
...
* annotateWithTypeFromJSDoc: Do less special-casing for arrow functions
* Code review
2018-03-08 16:32:32 -08:00
Andy
2170f6e1f8
FunctionLike = SignatureDeclaration ( #22365 )
2018-03-08 16:31:42 -08:00
Sheetal Nandi
e1a89e7011
Allow types as well as values in possibly type argument location
...
Fixes #22369
2018-03-08 16:06:26 -08:00
Andy
e48bcd60ba
Treat 'yield;' as 'yield undefined;' ( #22297 )
...
* Treat 'yield;' as 'yield undefined;'
* Use undefinedWideningType
2018-03-08 15:41:04 -08:00
Andy
28e8c4f3b8
Factor out a getYieldedTypeOfYieldExpression helper ( #22416 )
2018-03-08 15:06:29 -08:00
Wesley Wigham
87d88e2ba3
Handle resolving and unknown symbols in getLiteralTypeFromPropertyName ( #22406 )
2018-03-08 13:35:55 -08:00