Commit graph

22298 commits

Author SHA1 Message Date
Sheetal Nandi 17b10dc2a9
Merge pull request #21243 from Microsoft/watchOptions
Different watchFile and watchDirectory options through environment variable
2018-03-08 12:44:53 -08:00
Nathan Shively-Sanders a81f264d70
Call process.stdout._handle.setBlocking(true) (#22389)
* Call process.stdout._handle.setBlocking(true)

This prevents output from being truncated when the compiler can output
errors to stdout faster than it can receive them. This may slow down
performance for compilations for many errors, but those were already
quite slow.

* Disable tslint no-unnnecessary-type-assertion-2

It is wrong. It *is* necessary.
2018-03-08 12:38:30 -08:00
Sheetal Nandi 8378f692c7 Directly assign values for watchFile and watchDirectory in node System 2018-03-08 12:18:04 -08:00
Sheetal Nandi ea37c37e88 Symbol kind needs to use location before falling back to flags
Fixes #22366
2018-03-08 11:50:52 -08:00
Andy a49e83ffa7
annotateWithTypeFromJSDoc: Use changes.insertTypeAnnotation instead of replaceNode (#22404) 2018-03-08 11:47:30 -08:00
Nathan Shively-Sanders e4610e3418
Import types in JS with var x = require('./mod') (#22161) 2018-03-08 11:11:51 -08:00
Nathan Shively-Sanders 99d866de4a
Merge pull request #21974 from Microsoft/js-object-literal-assignments-as-declarations
More special declaration types in JS
2018-03-08 10:51:42 -08:00
Nathan Shively-Sanders f8134d0b45 Merge branch 'master' into js-object-literal-assignments-as-declarations 2018-03-08 10:40:55 -08:00
Nathan Shively-Sanders 35730f2879 Improve error span:duplicate symbols cross-js/ts
when the JS symbol is a JS initializer
2018-03-08 10:33:38 -08:00
Nathan Shively-Sanders 04ceb3d9bd Disallow JS/non-JS merge without crashing
Note that the error location is misleading because it's reported inside
the merge step for the js initializer.
2018-03-08 09:49:23 -08:00
Wesley Wigham 95862880fb
Filter symbol property names out of index signature assignability checks (#22398) 2018-03-08 09:30:25 -08:00
Andy 55bffba5fd
Use getTextOfNode over getTextOfNodeFromSourceText(getSourceFileOfNode(node)) (#22387) 2018-03-08 07:52:35 -08:00
Andy 0605424852
fixJSDocTypes: Use ChangeTracker (#22391) 2018-03-08 07:52:03 -08:00
Andy 2676786e7f
Add 'isNamedDeclaration' helper to reduce casts (#22089)
* Add 'isNamedDeclaration' helper to reduce casts

* Add assertion

* Remove assertion
2018-03-08 07:50:25 -08:00
Wesley Wigham 88ba1ef2de
Platform independent wildcard file include ordering (#22393)
* Resolve config wildcards result order in a platform independent manner

* Accept affected user test baseline

* Per reccomendation, just change matchFiles

* Add test asserting the same order on differing case sensitive platforms
2018-03-07 19:54:19 -08:00
Wesley Wigham 45eaf42006
Use single replacer for string escaping (#22335) 2018-03-07 17:36:31 -08:00
Mohamed Hegazy a826c787f6 Accept user baseline changes 2018-03-07 16:52:33 -08:00
Nathan Shively-Sanders 239f214b1c Address PR comments
1. Add documentation
2. Better organisation of concerns in utility functions
3. Better handling of module.exports and exports in the binder's new
code.
2018-03-07 16:26:29 -08:00
Nathan Shively-Sanders d86440f94f Merge branch 'master' into js-object-literal-assignments-as-declarations 2018-03-07 14:51:55 -08:00
Andy 1f7a5097fa
When every import is unused, error on the entire import declaration (#22386)
* When every import is unused, error on the entire import declaration

* Code review

* Store key in map value
2018-03-07 14:42:09 -08:00
Mohamed Hegazy 963acb3c02
Port generated lib files (#22381)
* Port generated lib files

* Accept baselines
2018-03-07 14:41:32 -08:00
Andy e5804aefde
inferFromUsage: use ChangeTracker and typeToTypeNode (#22379)
* inferFromUsage: use ChangeTracker and typeToTypeNode

* Use typeToTypeNode with SymbolTracker

* Add comment
2018-03-07 14:40:50 -08:00
Andy 0be9ee2871
Increase size of span for unused declaration (#22388) 2018-03-07 14:14:11 -08:00
Andy c0ac687a8f
Mark SymbolTracker as deprecated publicly (#22384) 2018-03-07 11:25:29 -08:00
Wesley Wigham 1e06637652
Set circle timeout to 5 minutes (#22363)
This way when resources are in use (eg, at midnight when many cron jobs get run) the CI server is less likely to timeout due to resource starvation.

This is pretty much an analogue to the recent travis PR; it just doesn't happen as often on circle (seems like it's only happened while executing `user` tests during `cron`).
2018-03-06 13:02:33 -08:00
Sheetal Nandi 36b45e3f13
Merge pull request #22343 from Microsoft/codeFixActionNotUndefined
Create the action only if the text change creation is successful.
2018-03-06 12:31:04 -08:00
Mohamed Hegazy b2dd610e92
Fix ignore message indentation (#22340)
* Update baselines for user tests

* Add explicit indentation

* Fix https://github.com/Microsoft/TypeScript/issues/21355: Format `// @ts-ignore` added by quick fix

* Extract check to a separate function

* Consolidate checking for valid insert location

* Code review comments

* Do not return makeChange
2018-03-06 12:19:19 -08:00
Andy 2fb7e643f4
Simplify suppressLeadingAndTrailingTrivia (#22356) 2018-03-06 11:34:33 -08:00
Sheetal Nandi 70944428a1 Create the action only if the text change creation is successful. …
Make change for the infer type from usage could return undefined even if type is present if the type cannot be named
Fixes #22184
2018-03-06 11:03:20 -08:00
Sheetal Nandi 6f6c40186f Add test for undefined action returned
Test for #22343
2018-03-06 11:00:41 -08:00
Andy a138985448
isValidMethodAccess: Instantiate signature this type if necessary (#21722) 2018-03-06 10:18:06 -08:00
Andy e5f91f5948
Convert annotateWithTypeFromJSDoc refactor to a codefix (#22336)
* Convert annotateWithTypeFromJSDoc refactor to a codefix

* Compute isJsFile once at top
2018-03-06 07:49:21 -08:00
Josh Goldberg 7826b38426 Apply 'no-unnecessary-initializer' lint rule (#22014)
* Apply 'no-unnecessary-initializer' lint rule

Forbids `let`/`const` statements to be initialized to `undefined`, since that's the initial value by default anyway.
The auto-fixer also happened to remove two unnecessary `as number` casts in `src/harness/parallel/worker.ts`.

For historical data: to run with `--fix`, I modified the line in `Jakefile.js` that declared the `cmd` for running TSLint.

* Moved worker.ts type assertions to parameters
2018-03-06 07:30:40 -08:00
Andy 5e593acad9
Avoid cast by providing type predicate to isExternalModuleAugmentation (#22119)
* Avoid cast by providing type predicate to isExternalModuleAugmentation

* Break into isExternalModuleAugmentation and isModuleAugmentationExternal
2018-03-06 07:27:36 -08:00
csigs bb6bd4512d
LEGO: Merge pull request 22351
LEGO: Merge pull request 22351
2018-03-05 21:10:39 -08:00
csigs 449e2aaaf7 LEGO: check in for master to temporary branch. 2018-03-06 05:10:16 +00:00
Priyantha Lankapura ed1c5d9688 update test for #20577 (#22310) 2018-03-05 16:15:08 -08:00
Wesley Wigham 48b63187c6
Remove TypeFacts.Discriminatable (#22346) 2018-03-05 15:51:47 -08:00
Wesley Wigham 2f0a13c7c3
Use global NonNullable type for nonnull types (#22096)
* Use NonNullable type for nonnull types

* Add noLib test

* Remove conditional type fallback for when lib is not present
2018-03-05 14:52:06 -08:00
Andy 4ddf045d6a
For <div a= >, after =, do not try to parse an expression (#21373) 2018-03-05 14:38:55 -08:00
Wesley Wigham f41555ce89
Make test timeout on travis huge (#22344)
* Make test timeout on travis huge

Specifically, 10 minutes, which is the duration it can go before travis itself will time out (if there is not output). This is needed because we set `workerCount=3` to improve our runtime, however travis doesn't _always_ have that much compute available; so when travis is resource-starved and we're running on one real thread, two test runners sit idle (due to resource starvation) and get timed-out by the watchdog process during test running. This timeout should be long enough that such that timeouts no longer occur on travis.

* Update .travis.yml
2018-03-05 14:34:46 -08:00
Wesley Wigham 16bf02991d
Allow indexing generics with unique symbols (#22339)
* Allow indexing generics with unique symbols

* Move condition to assert
2018-03-05 13:58:19 -08:00
Wesley Wigham 53ae507545
Add inference priority for mapped type keys (#22246)
* Add inference priority for mapped type keys

The new priority causes union inference, similarly to return type

* Rename priority

* Fix comment typo
2018-03-05 13:19:00 -08:00
Andy 2ac2291b84
Convert use-default-import refactor to a codefix (#22334) 2018-03-05 12:43:01 -08:00
Klaus Meinhardt 3bcfed61b6 Update .npmignore (#22318)
* Update .npmignore

* add yarn.lock
2018-03-05 12:19:56 -08:00
Anders Hejlsberg 1192a1808b
Merge pull request #22323 from Microsoft/checkInferredConstraints
Check inferred constraints for 'infer X' type variables
2018-03-05 10:18:13 -08:00
Anders Hejlsberg 07ed899b46 Merge branch 'master' into checkInferredConstraints 2018-03-05 06:32:11 -08:00
Anders Hejlsberg 70818ae716
Merge pull request #22313 from Microsoft/fixDistributiveConditionalTypes
Fix distributive conditional types
2018-03-05 06:23:45 -08:00
Anders Hejlsberg f97ab4d3ef Accept new baselines 2018-03-04 16:49:13 -08:00
Anders Hejlsberg 19e07eaea6 Add tests 2018-03-04 16:49:06 -08:00