Commit graph

28083 commits

Author SHA1 Message Date
Andrew Branch
60a1b1dc1a
Proposal: If there’s a package.json, only auto-import things in it, more or less (#31893)
* Move package.json related utils to utilities

* Add failing test

* Make first test pass

* Don’t filter when there’s no package.json, fix scoped package imports

* Use type acquisition as a heuristic for whether a JS project is using node core

* Make same fix in getCompletionDetails

* Fix re-exporting

* Change JS node core module heuristic to same-file utilization

* Remove unused method

* Remove other unused method

* Remove unused triple-slash ref

* Update comment

* Refactor findAlias to forEachAlias to reduce iterations

* Really fix re-exporting

* Use getModuleSpecifier instead of custom hack

* Fix offering auto imports to paths within node modules

* Rename things and make comments better

* Add another reexport test

* Inline `symbolHasBeenSeen`

* Simplify forEachAlias to findAlias

* Add note that symbols is mutated

* Symbol order doesn’t matter here

* Style nits

* Add test with nested package.jsons

* Fix and add tests for export * re-exports
2019-07-12 10:08:55 -07:00
Andrew Branch
71bec5b698
Add quick fix to add missing 'await' (#32356)
* Start prototyping addMissingAwait codefix

* Filter by diagnostics that have missing-await related info

* Start writing tests and checking precedence

* Implement codeFixAll, add test for binary expressions

* Add test for iterables

* Add test for passing argument

* Add test for call/construct signatures

* Add test for awaiting initializer

* Improve assertion error

* Replace specific property access error with general one and add await related info

* Add test for property access

* Require code to be inside a function body to offer await

* Accept suggestion

Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* Add explicit test for code fix being not available unless something is a Promise

* Skip looking for function body if already in AwaitContext flags

* Inline getCodeActions function for symmetry
2019-07-12 10:07:55 -07:00
csigs
d4b214901c
LEGO: Merge pull request 32379
LEGO: Merge pull request 32379
2019-07-12 09:10:43 -07:00
csigs
4e49706c72 LEGO: check in for master to temporary branch. 2019-07-12 16:10:19 +00:00
Andrew Branch
8516127a05
Fix regression of generic T assignability to Partial<T> (#32354) 2019-07-12 07:57:55 -07:00
Sheetal Nandi
ea730939d7
Merge pull request #32360 from microsoft/incrementalPaths
Ensure that the filePaths in compiler options are absolute before getting relative path to buildInfo directory
2019-07-11 13:45:39 -07:00
Sheetal Nandi
fd4f4fe5a2 Ensure that the filePaths in compiler options are absolute before getting relative path to buildInfo directory
Fixes #32353
2019-07-11 13:18:35 -07:00
Nathan Shively-Sanders
f209995a01
Update DOM: Remove carriage returns from comments (#32352) 2019-07-11 10:16:46 -07:00
Titian Cernicova-Dragomir
d2c9d6cc1b Improved parameter names for call signatures resulting from unions when only one parameter name is available. (#32056) 2019-07-11 10:06:49 -07:00
TypeScript Bot
fbdbb141a2 Update user baselines (#32346) 2019-07-11 09:46:37 -07:00
csigs
c6b28690db
LEGO: Merge pull request 32343
LEGO: Merge pull request 32343
2019-07-11 03:10:49 -07:00
csigs
6b89c72b5e LEGO: check in for master to temporary branch. 2019-07-11 10:10:20 +00:00
Andrew Branch
8eb3822ae0
Merge pull request #28290 from rflorian/add-codefix-cannot-find-name-in-for-loop
Add codefix for 'Cannot find name' diagnostic
2019-07-10 21:47:36 -07:00
Wesley Wigham
6839973bf7
Generate a unique type parameter name for each nested type parameter (#31544)
* Generate a unique type parameter name for each nested type parameter

* Add testcase from 31605

* Fix typo

* Liiiiiine eeeendingggggss
2019-07-10 17:12:20 -07:00
Wesley Wigham
daf0a73346
Fix lookup of optional methods in declaration emit (#32094) 2019-07-10 16:39:07 -07:00
Nathan Shively-Sanders
5289f2ede9
Update DOM from TSJS-lib-generator (#32335)
* Update DOM from TSJS-lib-generator

1. Update Navigator and other small updates.
2. Make ProgressEvent generic.
3. Make `window: Window & typeof globalThis`.
4. Add types:
  * CSS Overflow
  * CSS Masking
  * Web Authentication
  * WebGL 2

The big change is that `window` now includes globals in its type via
`typeof globalThis`. This helps some codebases a lot, such as
chrome-devtools-frontend.

* Update baselines
2019-07-10 16:36:50 -07:00
Andrew Branch
00e7d9cb1a
Merge pull request #32334 from andrewbranch/no-missing-await-on-unary-arithmetic-expressions
Remove "Did you forget to use await" for unary arithmetic expressions
2019-07-10 14:21:29 -07:00
Andrew Branch
f41c9b2c20
Rename parameter 2019-07-10 13:34:58 -07:00
Andrew Branch
ab9e583e45
Remove "Did you forget to use await" for unary arithmetic expressions 2019-07-10 13:18:37 -07:00
TypeScript Bot
34ffefb922 Update user baselines (#32324) 2019-07-10 13:00:30 -07:00
Florian Regensburger
196db5bbcb Fixed lint error 2019-07-10 02:35:40 +02:00
Florian Regensburger
f273448925 Added addMissingConst codefix for comma separated initializers 2019-07-10 02:11:02 +02:00
Andrew Branch
a4cddd4647
Merge pull request #32239 from andrewbranch/enhancement/missing-await-errors
Improve error messages for potentially missing 'await'
2019-07-09 16:28:54 -07:00
Nathan Shively-Sanders
949956b586
Improve multiple overloads error span (#32315)
* Improve multiple overloads error span

When all errors for a multiple-overload error refer to the same span,
use that span instead of the one for the entire call.

This situation is quite common for 2-overload sets in React.

* Update baselines

* Fix lint
2019-07-09 15:39:42 -07:00
Anders Hejlsberg
b0f050f4ee
Merge pull request #32260 from microsoft/fix32169
Include conditional types in top-level type parameter check
2019-07-09 10:30:44 -07:00
Florian Regensburger
1de7881141 Add negative test case for addMissingConst codeFix with unexpected array elements 2019-07-09 02:07:54 +02:00
Florian Regensburger
384669a1ce Finish addMissingConst codefix for single variable and array literal assignments 2019-07-09 01:56:50 +02:00
Andrew Branch
bdd8a3e878
Only add "Did you forget await" for function args when the parameter type is not promise-like 2019-07-08 16:32:53 -07:00
Andrew Branch
64501996cc
Update error code 2019-07-08 14:52:23 -07:00
Andrew Branch
6626a99f11
Fix bad rebase 2019-07-08 14:44:57 -07:00
Andrew Branch
eb6b87aa26
Refactor to use related info everywhere 2019-07-08 14:37:45 -07:00
Andrew Branch
094a001982
Did you forget to use await? on arguments of function calls 2019-07-08 14:33:25 -07:00
Andrew Branch
e89a2c4571
Update baselines 2019-07-08 14:03:59 -07:00
Andrew Branch
a3a076d79f
Did you forget to use await? for call and construct signatures 2019-07-08 14:01:25 -07:00
Andrew Branch
48fc6b8b17
Did you forget to use await? on iterables 2019-07-08 13:59:59 -07:00
Andrew Branch
c48e34ef91
Did you forget to use await? for operators 2019-07-08 13:50:56 -07:00
Nathan Shively-Sanders
fb50920a67
Merge pull request #32092 from microsoft/report-multiple-overload-errors
Report multiple overload errors
2019-07-08 13:25:38 -07:00
Nathan Shively-Sanders
05a4e8f29e Update more baselines (?) 2019-07-08 13:04:59 -07:00
Nathan Shively-Sanders
2233ebadea Update baselines 2019-07-08 09:52:12 -07:00
Nathan Shively-Sanders
834a476a96 Merge branch 'master' into report-multiple-overload-errors 2019-07-08 09:33:24 -07:00
Florian Regensburger
7d08f172d8 Added fourslash tests for standalone and array initialization cases and started implementing them 2019-07-07 13:56:34 +02:00
Anders Hejlsberg
0d992921d5 Accept new baselines 2019-07-04 16:27:19 -10:00
Anders Hejlsberg
de2fb9584e Add regression test 2019-07-04 16:27:03 -10:00
Anders Hejlsberg
d7f8f0072e Include conditional types in top-level type parameter check 2019-07-04 16:26:54 -10:00
Ron Buckton
e8bf9584aa
Improve type checking and inference for Generators and Async Generators (#30790)
* Improve typing for Generators and Async Generators

* Add TReturn and TNext to Iterator, IterableIterator, etc.

* Update ts internal Iterator to be assignable from global Iterator

* Make 'done' optional in IteratorYieldResult

* Revert Iterable and IterableIterator to simpler versions plus other fixes

* Add additional inference tests

* Added additional tests

* PR cleanup and minor async iteration type fix

* Updated diagnostics message and added non-strict tests

* Fix expected arity of Iterator/AsyncIterator
2019-07-03 21:55:59 -07:00
Wesley Wigham
0bea4bd3c9
Widen object literal this types (#32240) 2019-07-03 15:58:21 -07:00
Nathan Shively-Sanders
19b593ee4e Merge branch 'master' into report-multiple-overload-errors 2019-07-03 14:55:06 -07:00
Nathan Shively-Sanders
68cb3ae136
Merge pull request #32232 from typescript-bot/user-update-Microsoft-20190603
🤖 User test baselines have changed
2019-07-03 11:22:56 -07:00
Nathan Shively-Sanders
6f0baa3ae1
Merge pull request #29717 from petersandor/jsdoc-tag-author-email-support
Support email in author JSDoc tag
2019-07-03 10:42:02 -07:00
Andrew Branch
16bbb4d002
Merge pull request #32077 from andrewbranch/bug/31114
Fix incorrect noImplicitAny error on contextual union function signature
2019-07-03 10:10:10 -07:00