Ron Buckton
b9db6413bf
Allow assignments to a narrowable reference to be considered narrowable
2020-07-29 16:37:25 -07:00
Nathan Shively-Sanders
9b2d487392
Fix this-parameter emit for JSDocFunction types ( #39814 )
...
* Fix this parameter emit for JSDocFunction types
Previously, parameters with names that were not `new` were treated like
rest parameters. This is incorrect: parameters with the name `this`
should emit a `this` parameter.
Fixes #38550
* ❤️ quote style
2020-07-29 14:11:59 -07:00
Eli Barzilay
f2d1531768
Fix location for duplicate function implementation errors
...
Use only the relevant declarations (by collecting them in the for loop),
and use `declaration` if `getNameOfDeclaration` didn't work (useful for
`export default` with anonymous functions).
Fixes #39804 .
Also, use `nodeIsPresent` once, and a random `?.`.
2020-07-29 16:07:00 -04:00
Nathan Shively-Sanders
03b658035d
Make @enum,@this tag construction stricter ( #39791 )
...
The type expression is required, so the type should reflect that.
2020-07-28 13:49:42 -07:00
Andrew Branch
8f04f91ef5
Add diagnostic info to getNameForExportedSymbol crash ( #39790 )
...
* Add diagnostic info to getNameForExportedSymbol crash
* Add JS indicator
2020-07-28 12:53:56 -07:00
Andrew Casey
79e2ed2e77
Merge pull request #39776 from amcasey/OverloadErrors
...
Reduce unnecessary error computation
2020-07-28 10:35:22 -07:00
Andrew Branch
1f1521c2f1
Undo accidental change from #39772 ( #39779 )
...
* Undo accidental change
* Delete test
2020-07-27 16:55:59 -07:00
Andrew Branch
68ba670467
Add contextual type for generator return type ( #39772 )
...
* WIP
* Add contextual type for generator return type
2020-07-27 15:14:47 -07:00
Andrew Casey
5b2b70b2a5
Merge pull request #39774 from amcasey/Mocha
...
Move off deprecated mocha types
2020-07-27 14:54:14 -07:00
Andrew Casey
6318cc6d88
Move off deprecated mocha types
2020-07-27 14:29:19 -07:00
Andrew Casey
195fad23a5
Reduce unnecessary error computation
...
...during overload resolution. Based on a trace that was spending 30%
of a (very slow) overload resolution elaborating errors that were then
dropped.
2020-07-27 14:11:24 -07:00
Sheetal Nandi
48e58f44db
Handle unresolved baseType when trying to get completions for static member ( #39731 )
...
* Handle unresolved baseType when trying to get completions for static member
Fixes #38067
* Update src/services/completions.ts
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
* correct the condition
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2020-07-24 16:37:28 -07:00
Anders Hejlsberg
c5d21e7987
Lower priority for speculative variadic tuple inferences ( #39723 )
...
* Inference to [...T, X?] has lower priority than inference to [...T, X]
* Update tests
* Accept new API baselines
2020-07-24 15:00:53 -07:00
Sheetal Nandi
823b69acb3
Fixes slow nav to issue by keeping project with result. ( #39721 )
...
Also cache the result of config file name for open files
Fixes #38491
2020-07-24 13:33:25 -07:00
Wesley Wigham
73b268ec5b
Use new octokit API method in review request script ( #39719 )
2020-07-23 15:43:48 -07:00
csigs
2fb0436f53
LEGO: Merge pull request 39706
...
LEGO: Merge pull request 39706
2020-07-22 15:11:58 -07:00
csigs
7c5ed71ef8
LEGO: check in for master to temporary branch.
2020-07-22 22:10:54 +00:00
Andrew Branch
ec33814616
Make AutoImportProviderProject work with symlinked monorepos ( #39679 )
...
* Hack everything together
* Add test
* Remove realpath from program
* Ensure symlinked directories are directories
* Revert unnecessary change
* Update baselines
* Use host program realpath on AutoImportProviderProject files before program creation
* Which fixes hasRoots() too
* Apply suggestions from code review
Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
* Lint
Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
2020-07-22 13:53:30 -07:00
Wesley Wigham
312a6f0efb
Add a fastpath for comparing common mapped types like Pick which avoids manufacturing intermediate type identities ( #39696 )
2020-07-22 11:59:16 -07:00
Andrew Branch
b834096998
Fix emit/formatting issues in refactors ( #39506 )
...
* Fix #37948
* Fix formatter skipping tab/space fixup on comments, handle trailing commas in list closing line count.
Fixes #37944
* Add newline between imports and main body of new file in moveToNewFile
Fixes #37941
* Update baseline (probably broken before?)
2020-07-22 10:31:42 -07:00
Song
e76d17257a
Fix 38219: signature helper works for optional function condition. ( #39672 )
...
* fix optional fuction condition.
* Adds a test
Co-authored-by: Orta <git@orta.io>
2020-07-22 12:30:21 -04:00
Song
8a05707559
Fix 31995: make cached key more precise to avoid returning wrong cached value. ( #39670 )
...
* fix 31995
* revert useless change only for debug.
* add test
2020-07-22 12:26:17 -04:00
Song
294a0406e3
not escape unicode char for import path string. ( #39463 )
...
* not escape unicode char for import path string.
* fix test.
2020-07-22 11:28:29 -04:00
Sheetal Nandi
34adaaf6aa
Support loading of child project if found project is not pure solution has some of its own files and project references ( #39613 )
...
* Use disableReferencedProjectLoad to stop loading child projects to allow users to disable loading large solutions
Fixes #39144
* Handle indirect references
* Support loading of child project if found project is not pure solution has some of its own files and project references
Fixes #38605
* Fix grammar
2020-07-21 15:02:10 -07:00
Sheetal Nandi
e92afacc44
Add disableReferencedProjectLoad to stop loading child projects to allow users to disable loading large solutions ( #39593 )
...
* Use disableReferencedProjectLoad to stop loading child projects to allow users to disable loading large solutions
Fixes #39144
* Handle indirect references
* PR feedback
2020-07-21 14:24:15 -07:00
Song
5484687384
switch typeof any could be checked for unreachable ( #39389 )
...
* switch typeof any could be checked for unreachable
* fix stupid error
* support unknown
* remvoe use less code.
* fix spelling.
2020-07-21 13:51:27 -04:00
Song
d897646a4a
fix 39453 ( #39579 )
...
* fix 39453
* add restriction.
* add tests
* comment.
* fix as suggestion.
2020-07-21 09:40:25 -07:00
csigs
56865f722d
LEGO: Merge pull request 39682
...
LEGO: Merge pull request 39682
2020-07-20 21:11:42 -07:00
csigs
ea75b00c46
LEGO: check in for master to temporary branch.
2020-07-21 04:10:47 +00:00
Anders Hejlsberg
94d6b4507e
Consistent errors on circular base types ( #39675 )
...
* Properly track and report errors on circular base types
* Accept new baselines
* Add regression test
2020-07-20 20:35:47 -07:00
Anders Hejlsberg
5ae4b5d715
Properly preserve numeric string named properties in declaration files ( #39658 )
...
* Properly preserve names of properties with numeric literal strings
* Accept new baselines
2020-07-20 10:36:46 -07:00
Sheetal Nandi
3b22339df8
Triple slash references must resolve against the resolved file name (.d.ts and not original source file) since they are rewritten in the .d.ts emit ( #39645 )
...
* Add tests corresponding to repro from #37928
* Triple slash references must resolve against the resolved file name (.d.ts and not original source file) since they are rewritten in the .d.ts emit
* Remove the scenario not fixed in this PR
2020-07-17 16:25:32 -07:00
Alexander T
92f41c81fb
tests(39373): add addition tests ( #39631 )
2020-07-17 13:30:57 -07:00
Orta Therox
f19c610d91
Adds latest version of TypeScript to the repro code ( #39641 )
2020-07-17 15:15:49 -04:00
Wesley Wigham
191f4f63ab
Explicitly add dependency on node to compiler tsconfig, remove es6+ string method usage ( #39636 )
2020-07-17 07:02:05 -07:00
Wesley Wigham
5519027600
Minor fixes to consmetic build issues in user test PR script
2020-07-17 06:43:50 -07:00
Alexander T
4e24b1b00d
fix(39373): add diagnostic message about using a private name for class declarations without name ( #39567 )
2020-07-16 17:05:33 -07:00
Orta Therox
1d671c3588
Add twoslash repros to the compiler ( #39628 )
2020-07-16 18:39:49 -04:00
Sheetal Nandi
667ba74c93
Resolve only relative references in open files on syntax server ( #39476 )
...
* Resolve only relative references in open files on syntax server
* Support resolving tripleslash references only in the open file
* Apply suggestions from code review
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
2020-07-16 14:31:24 -07:00
Alexander T
c07c885151
fix(39515): fix getting a position for an element before the line break CRLF/LF on the line that contains 'after' element ( #39554 )
2020-07-16 13:56:30 -07:00
Alexander T
6430211f8f
fix(38868): add separator for type parameters ( #39621 )
2020-07-16 10:58:16 -07:00
Anders Hejlsberg
db79030410
Support variadic tuple inference from trailing optional to non-optional ( #39614 )
...
* Permit variadic tuple inference from trailing optional to non-optional
* Add tests
2020-07-15 17:46:48 -07:00
uhyo
b6f09ccf06
Better error message for unparenthesized function/constructor type notation in union/intersection types ( #39570 )
...
* add graceful error message for unparenthesized function types in union and intersection
* add unparenthesizedFunctionTypeInUnionOrIntersection test
* add unparenthesizedConstructorTypeInUnionOrIntersection test
* Update src/compiler/parser.ts
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
* pass isInUnionType to parseFunctionOrConstructorTypeToError
* Apply suggestions from code review
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
* syntax fix
* refactor isStartOfFunctionType into isStartOfFunctionTypeOrConstructorType
* Update src/compiler/parser.ts
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
* hoist isUnionType
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2020-07-15 14:43:56 -07:00
Sheetal Nandi
37e6e2761c
Do not resolve require calls in typescript files even if it contains dynamic import ( #39617 )
...
* Existing tests showing require in ts file is not used for module resolution
* Do not resolve require calls in typescript files even if it contains dynamic import
Fixes #38611
2020-07-15 14:31:55 -07:00
Wesley Wigham
f2c5643056
Flag mapped types with circular property types and do not attempt to print them structurally ( #39552 )
2020-07-15 11:19:43 -07:00
Wenlu Wang
fcd4fcb3d7
Use combined node flags ( #39403 )
2020-07-15 09:22:12 -07:00
Wenlu Wang
7b728754c0
Fix incorrect deprecated mark ( #39611 )
...
* Fix incorrect deprecated mark
* improve test
2020-07-15 08:47:25 -07:00
Andrew Branch
dd2fc86f2b
Don’t give all instantiated signatures in JS strict arity ( #39606 )
2020-07-14 18:56:50 -07:00
Wesley Wigham
ef9affe2f6
Use jsxFragmentFactory entity name for factory name lookup from checking fragments ( #39475 )
2020-07-14 17:25:45 -07:00
Alexander T
ececf3b0a7
fix(33511): show jsx namespace default import quick fix if it does not exists in the current scope ( #38419 )
2020-07-14 15:43:18 -07:00