Commit graph

30947 commits

Author SHA1 Message Date
Wesley Wigham 62a1b357c2
Unignore the package-lock.json in the root Dockerignore, fixing docker suite tests 2020-09-02 14:31:51 -07:00
Andrew Branch 838a5e6044
Fix call hierarchy item serialization and server tests (#40348) 2020-09-02 11:34:14 -07:00
Nathan Shively-Sanders b0011feee1
Checkjs implies allowjs (#40275)
* Passing --checkJs always sets --allowJS

Even if you have `"allowJs": false`. This is not a useful combination.

Changing this makes the compiler more friendly and easier to describe.

* only set allowjs if not explicitly set

* remove stray newline

* restore bad config error

* use an accessor function instead
2020-09-01 10:16:08 -07:00
Nathan Shively-Sanders d572dcb272
Fix crash intersecting dynamic import w/esModuleInterop (#40249)
* Fix crash intersecting dynamic import w/esModuleInterop

The dynamic import shim creates a symbol without some properties that
the intersection-creating code assumes are present as of #38673.

This PR adds the smallest possible set of properties to avoid the crash.
I'm not sure what others would be good to add.

* Use symbol's declarations instead

* Fix getResolvedMembersOrExportsOfSymbol instead

* comment from code review
2020-09-01 09:10:36 -07:00
Nathan Shively-Sanders 378083fcec
Nested assignment to a require alias isn't a declaration (#40186)
This is not something we can type correctly, and doesn't work in
Typescript either. Better to ignore it in JS.
2020-09-01 08:20:56 -07:00
csigs 5fd5a758a3
LEGO: Merge pull request 40339
LEGO: Merge pull request 40339
2020-08-31 23:12:15 -07:00
csigs 42164e91d9 LEGO: check in for master to temporary branch. 2020-09-01 06:11:11 +00:00
Andrew Branch 7a0f603b11
Fix extract symbol crash on unterminated literals; don’t offer to extract export = ... (#40272)
* Don’t offer to extract export assignment

* Terminate unterminated literals when extracting them

* Add test with regular expression ending in backslash

* Add test for string literal ending in backslash

* Remove unused parameter default
2020-08-31 14:17:09 -07:00
Vincent Boivin 21df16d385
Add missing description to CONTRIBUTING.md (#40329) 2020-08-31 14:16:52 -04:00
Andrew Branch bfb00eb164
Fix misplaced comma in auto imported specifier (#40273) 2020-08-31 10:54:53 -07:00
TypeScript Bot 97f8b87e34 Update package-lock.json 2020-08-31 06:12:41 +00:00
csigs d75894d85b
LEGO: Merge pull request 40318
LEGO: Merge pull request 40318
2020-08-29 11:12:13 -07:00
csigs 2faf505cfd LEGO: check in for master to temporary branch. 2020-08-29 18:11:10 +00:00
Alexander T 01362a3ac1
feat(part of 40169): add spelling suggestion/quick fix for module/namespace exported members (#40211) 2020-08-29 01:01:06 -07:00
TypeScript Bot b78c722199 Update package-lock.json 2020-08-29 06:12:57 +00:00
Ron Buckton 10fb9c9381
Treat trailing 'void' as optional for assignability (#40231) 2020-08-28 09:12:09 -07:00
Ryan Cavanaugh b969b58399
Use a correct Object.entries polyfill (#40268)
* Use a correct Object.entries polyfill

Fixes #40243

* Update src/compiler/core.ts

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

* Added parentheses, DANIEL.

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
2020-08-28 09:09:55 -07:00
TypeScript Bot 4463194dda Update package-lock.json 2020-08-28 06:22:43 +00:00
Alexander T fa5e9807e8
fix(40010): add outlining for comments before variables statements (#40016) 2020-08-27 16:29:05 -07:00
csigs 27eb8628e5
LEGO: Merge pull request 40289
LEGO: Merge pull request 40289
2020-08-27 11:11:58 -07:00
csigs 3002d694d2 LEGO: check in for master to temporary branch. 2020-08-27 18:11:06 +00:00
Josh Goldberg 0298033db7
Specified error diagnostic for invalid variable names (#40105)
* Specified error diagnostic for invalid variable names

* Use callback directly, and isKeyword
2020-08-27 10:58:12 -07:00
Wesley Wigham 4dd9f69866
Disable diagnostic consistency checking for large tests (#40280) 2020-08-27 00:44:18 -07:00
TypeScript Bot 1b404ae18e Update package-lock.json 2020-08-27 06:18:27 +00:00
csigs 60117fe4a9
LEGO: Merge pull request 40282
LEGO: Merge pull request 40282
2020-08-26 23:11:59 -07:00
csigs 67d7ece526 LEGO: check in for master to temporary branch. 2020-08-27 06:11:07 +00:00
csigs 1b6e18ce7a
LEGO: Merge pull request 40277
LEGO: Merge pull request 40277
2020-08-26 17:12:27 -07:00
csigs 5ee2d52cb3 LEGO: check in for master to temporary branch. 2020-08-27 00:11:33 +00:00
Eli Barzilay 746bdb7946 Fix getContextualTypeForBindingElement for arrays
When handling an array type, the lookup should use the position index
instead of the identifier name.

Also uncomment the tests in the `staticFieldWithInterfaceContext.ts`
test which failed because of this bug.

Fixes #40158.
2020-08-26 16:28:50 -04:00
csigs 7e86b3ed65
LEGO: Merge pull request 40271
LEGO: Merge pull request 40271
2020-08-26 11:12:02 -07:00
csigs 669c4153c0 LEGO: check in for master to temporary branch. 2020-08-26 18:11:08 +00:00
TypeScript Bot a9175704ee Update package-lock.json 2020-08-26 06:19:26 +00:00
csigs c8ce9d3560
LEGO: Merge pull request 40255
LEGO: Merge pull request 40255
2020-08-25 17:12:48 -07:00
csigs 4170007ed3 LEGO: check in for master to temporary branch. 2020-08-26 00:11:49 +00:00
Kyℓe Hensel c5446d1a47
don't emit "unused @ts-expect-error" in unchecked js files (#40046)
* don't emit unused ts-expect-error in unchecked js files

* simplify code
2020-08-25 11:04:23 -07:00
Andrew Casey 2ff70f0b09
Merge pull request #40244 from amcasey/EmptyCommit
Swallow empty-commit error
2020-08-25 10:28:28 -07:00
Andrew Casey d6dda230bc Swallow empty-commit error 2020-08-25 10:16:58 -07:00
Nathan Shively-Sanders d45c0590f7
Update CONTRIBUTING.md for code contributors (#40230)
* Update CONTRIBUTING.md

1. Add basic step-by-step startup instructions.
2. Remove/simplify some outdated instructions.
3. Rewrite some instructions to sound less like manuals from the 60s.

* add link to help wanted bugs in step-by-step startup

* Update CONTRIBUTING.md

Co-authored-by: Orta Therox <ortam@microsoft.com>

* Update CONTRIBUTING.md

Co-authored-by: Orta Therox <ortam@microsoft.com>

* from PR feedback

Co-authored-by: Orta Therox <ortam@microsoft.com>
2020-08-25 09:23:43 -07:00
csigs bfa69b7bb7
LEGO: Merge pull request 40236
LEGO: Merge pull request 40236
2020-08-24 23:12:15 -07:00
csigs 41349977ea LEGO: check in for master to temporary branch. 2020-08-25 06:11:11 +00:00
Nathan Shively-Sanders 4aadd5af41
Fix commonjs require of ES export (#40221)
The commonjs-specific code for resolving access expressions on `require`
assumes a fake commonjs export. For real exports, it needs to call
resolveSymbol since it's outside the normal alias-resolving
infrastructure.
2020-08-24 12:37:25 -07:00
TypeScript Bot 31fab0fb1e Update package-lock.json 2020-08-24 06:22:15 +00:00
TypeScript Bot e83102134e Update package-lock.json 2020-08-23 06:17:43 +00:00
Alexander T 2dd7a4bf93
fix(31046): add new diagnostic message for incompatible constructor signature (#40073) 2020-08-22 13:26:13 -07:00
Alexander T 9569198df6
fix(25770): add diagnostic message for the possible mapped type used as an index (#39973) 2020-08-21 10:42:48 -07:00
Alexander T 6ec3629ef4
fix(26325): use a unique name for reserved words in 'constructor like' function name (#39684) 2020-08-21 09:47:37 -07:00
cherryblossom000 e8dbc2dd07
Fix typo in (Readonly)Set.keys comment (fixes #40164) (#40176) 2020-08-21 09:15:29 -07:00
Neil Kistner 585603e934
Add compactDisplay and signDisplay to NumberFormatOptions (#40039) 2020-08-21 00:49:22 -07:00
TypeScript Bot 8429ddd4f0 Update package-lock.json 2020-08-21 06:17:39 +00:00
Andrew Casey 54bc0ed93f
Merge pull request #40161 from amcasey/NoNpmUpdate
Delete extra npm update
2020-08-20 18:39:24 -07:00