Commit graph

24393 commits

Author SHA1 Message Date
rflorian 66e9aaac18 Issue 19220 function parameter arity (#24031)
* Added reference test case and diagnostics message

* Adjusted arity checks to account for non-contiguous overloads

* Code cleanup, baseline not yet commited

* Accepted test baselines and minor implementation changes

* Cleaned up baseline tracking the now renamed arity check test

* Add range response when range contains only 2 values

* Added recent baseline

* Refined arity error messages when available overloads can be grouped

* Rolled back code formatting

* WIP cleanup needed in a few edge cases

* Finished adding new more descriptive error messages

* Code cleanup

* Added simplified version of bugfix for #19220

* Rebased onto master

* Removed whitespace after type assertion

* Code review simplifications

* Use correct diagnostic name

* Code review changes and simplification of diagnostic message

* Revert formatting changes
2018-07-11 17:19:56 -07:00
Andy 5f4a03c408
Ensure TypeChecker#getTypeAtLocation returns a defined result (#25583)
* Ensure TypeChecker#getTypeAtLocation returns a defined result

* Update additional baseline
2018-07-11 16:33:56 -07:00
Mohamed Hegazy 2d0d655fea
Merge pull request #25561 from ajafff/multiple-prologue-directives
handle multiple prologue directives
2018-07-11 11:38:01 -07:00
Nathan Shively-Sanders 42a2d9e568
Excess property understands conditional types (#25584)
Previously it did not, causing misleading excess property errors. Note
that assignability errors with conditional types are still usually
confusing. This PR doesn't address that.

Also, make sure that exact matches in getSpellingSuggestion are skipped.
2018-07-11 11:24:40 -07:00
Andy 52486ae362
Improve isPossiblyTypeArgumentPosition (#25043)
* Improve isPossiblyTypeArgumentPosition

* Update API (#24966)

* Handle new Type<Type<

* Add test for `new C < C<`
2018-07-11 11:15:04 -07:00
Mohamed Hegazy 97f10bc3a2
Merge pull request #25576 from typescript-bot/user-update-20180603
🤖 User test baselines have changed
2018-07-11 11:03:28 -07:00
Andy 19993a5408
When import("foo") has module resolution error, error span should be "foo" (#25569)
* When `import("foo")` has module resolution error, error span should be "foo"

* Update more tests
2018-07-11 10:06:08 -07:00
Klaus Meinhardt 2a960011d7 Merge branch 'master' of github.com:Microsoft/TypeScript into multiple-prologue-directives 2018-07-11 18:47:23 +02:00
Klaus Meinhardt 626480df20 accept baseline 2018-07-11 18:46:22 +02:00
Klaus Meinhardt 0de903ea17 rename function 2018-07-11 18:43:58 +02:00
Andy 8a3090bc35
Improve test for 'symbol.exports' (#25523)
* Improve test for 'symbol.exports'

* Remove SymbolFlags.HasExports and SymbolFlags.HasMembers

* Update baseline
2018-07-11 09:37:32 -07:00
Andy 990d445bb6
In services, when overload resolution fails, create a union signature (2) (#25100) 2018-07-11 08:54:47 -07:00
typescript-bot 3a67ea8332 Update user baselines 2018-07-11 13:29:33 +00:00
Mohamed Hegazy f66c7dbba2 Add release-3.0 to supported branches 2018-07-10 23:41:09 -07:00
Mohamed Hegazy e3b764c914 Update authors for release 3.0 2018-07-10 23:40:23 -07:00
Andy 8a559e4630
Improve isNewFile assert (#25419) 2018-07-10 16:57:01 -07:00
Andy 5e2102799b
Reduce non-null assertions in getPropertySymbolsFromContextualType (#24675) 2018-07-10 16:53:08 -07:00
Andy 7a79a45aab
JSX closing tag completion: Include '>' if not already present (#25551)
* JSX closing tag completion: Include '>' if not already present

* Expand comment
2018-07-10 16:14:57 -07:00
Sheetal Nandi 527093c758
Merge pull request #25566 from Microsoft/nonCommonJsResolveJsonIsError
Report errors for module generation other than "commonjs" with --resolveJsonModule
2018-07-10 15:30:23 -07:00
Sheetal Nandi c50407e01f
Merge pull request #25464 from Microsoft/cacheRecursiveDirectoryWatchers
Caches the recursive directory watchers so we do not have to traverse and recreate more children watches
2018-07-10 15:30:03 -07:00
Sheetal Nandi 4dc3cd3773 Use getEmitModuleKind to check module generation kind 2018-07-10 15:28:21 -07:00
Sheetal Nandi 821ebcb529 Merge branch 'master' into cacheRecursiveDirectoryWatchers 2018-07-10 15:08:14 -07:00
Sheetal Nandi 3866a5048b Report errors for module generation other than "commonjs" with --resolveJsonModule
Fixes #25517
2018-07-10 15:00:46 -07:00
Ron Buckton a9771e3940
Merge pull request #25556 from Microsoft/buildScriptUpdates
Build script updates
2018-07-10 14:45:16 -07:00
Andy b6640e9c5d
getJsxClosingTagAtPosition: Return a result if parent has same name and is unclosed (#25557) 2018-07-10 14:31:18 -07:00
Daniel Rosenwasser 3dd1d25e07
Merge pull request #25520 from Microsoft/internalizeNonexistentHelpers
Make getSuggestion APIs internal.
2018-07-10 13:47:05 -07:00
Klaus Meinhardt f9eb976319 handle multiple prologue directives
Fixes: #24689
2018-07-10 22:42:21 +02:00
Ron Buckton 0713e754e7 Build script updates 2018-07-10 12:13:27 -07:00
Andy 1fc1495863
Increase span of unreachable code error (#25388)
* Increase span of unreachable code error

* Add a new diagnostic for each range of unreachable statements

* Update baselines
2018-07-10 11:45:16 -07:00
Ryan Cavanaugh d7ce0eae3a
Merge pull request #25524 from RyanCavanaugh/useGetEmitDeclarations
Use getEmitDeclarations instead of .declarations
2018-07-10 10:59:06 -07:00
Andy 72be7156d2
Support completions for unique symbol exported from module (#25537) 2018-07-10 10:47:43 -07:00
Mohamed Hegazy 4bf42fd1c4
Merge pull request #25535 from Microsoft/fixAsserts
Fix assert and check for module symbol
2018-07-10 10:28:17 -07:00
Nathan Shively-Sanders c344a3ea5b
Fix bogus use before def in jsdoc (#25532)
Block scoped variables, classes and enums would issue a bogus
use-before-def error in jsdoc because name resolution always adds Value,
even when resolving a type.

Fixes #25097
2018-07-10 08:33:19 -07:00
Nathan Shively-Sanders 60c0dfeb25
Fix crash in JS when checking destructuring shorthand assignment (#25529) 2018-07-10 08:32:56 -07:00
Pi Lanningham b3b6c3bdbc Pass sourceFile to getChildren in getTokenAtPositionWorker (#25505) (#25538)
For performance reasons, we should always pass sourceFile to getChildren
if available.
2018-07-09 18:15:40 -07:00
Andy e9e5ebee73
getEditsForFileRename: Handle all projects and source-mapped files (#25522)
* getEditsForFileRename: Handle all projects and source-mapped files

* Update API (#24966)

* Use areEqual
2018-07-09 17:58:02 -07:00
Ryan Cavanaugh e532f53189
Merge pull request #25531 from RyanCavanaugh/fix25527
Don't crash when an implicit rootDir constraint is violated under composite: true
2018-07-09 17:51:17 -07:00
Mohamed Hegazy 2c70030c8a Compare normalized fileNames 2018-07-09 17:28:10 -07:00
Mohamed Hegazy 68cd382d8f Check for a module sysmbol existing before calling getReferencedSymbolsForModule 2018-07-09 17:26:35 -07:00
Sheetal Nandi 357f0d6fbd
Merge pull request #25521 from Microsoft/dontWatchAmbientModules
Do not watch modules that get resolved by ambient modules
2018-07-09 17:02:33 -07:00
Wesley Wigham 3d64b9d7ac
Handle intersection types when looking up base types for visibility (#25418)
* Handle intersection types when looking up base types for visibility

* Extract protected constructor check to function and recur on intersections

* Remove unneeded cast
2018-07-09 16:58:55 -07:00
Ryan Cavanaugh 72f0789908 Don't crash when an implicit rootDir constraint is violated under composite:true
Fixes #25527
2018-07-09 15:41:15 -07:00
Mohamed Hegazy 6b4a3b2bbb
Merge pull request #25500 from mattmccutchen/issue-25498
Fix crash in elaborateElementwise when the target property is known but it doesn't have a declaration (e.g., in a mapped type).
2018-07-09 15:35:35 -07:00
Ryan Cavanaugh 1b1ffe952b Use getEmitDeclarations instead of .declarations 2018-07-09 14:51:40 -07:00
Sheetal Nandi f941226011 Do not watch modules that get resolved by ambient modules 2018-07-09 12:05:29 -07:00
Daniel Rosenwasser d62717b281 Make getSuggestion APIs internal. 2018-07-09 11:42:38 -07:00
Benjamin Lichtman b5f5513e4a
Merge pull request #25329 from uniqueiniquity/jsxFolding
Add outlining spans for JSX elements
2018-07-09 12:36:23 -04:00
Benjamin Lichtman 5c7b47e6e3 Pass sourceFile as appropriate 2018-07-09 08:54:57 -07:00
Daniel Rosenwasser fe2baac33f
Merge pull request #25422 from Microsoft/actualSignatureHelpTriggers
Actual signature help trigger filtering
2018-07-08 22:09:35 -07:00
Matt McCutchen d5fd17bf0b Fix crash in elaborateElementwise when the target property is known but
it doesn't have a declaration (e.g., in a mapped type).

Fixes #25498.
2018-07-07 16:27:23 -04:00