Commit graph

22614 commits

Author SHA1 Message Date
Nathan Shively-Sanders
941777848f
Switch webpack to submodule (#23372)
* Prepare for adding webpack submodule

* Actually switch webpack to submodule

I'm sure this will work with no problems!

* Add ignore=all to webpack gitmodule entry

The other submodules do this, although I'm not sure why.

* Add newline at end of .gitmodules
2018-04-12 14:09:07 -07:00
Ryan Cavanaugh
0ef0b7adea
Merge pull request #23354 from RyanCavanaugh/referencesDogfood_1
Project references transitional: Remove reference comments
2018-04-12 13:56:47 -07:00
Ryan Cavanaugh
8e36afa5bd Remove reference emit from diagnostics 2018-04-12 12:41:00 -07:00
Ryan Cavanaugh
bbcf00c040 Remove ref comments from processDiagnosticMessages 2018-04-12 12:35:56 -07:00
Ryan Cavanaugh
ff60520460 Merge branch 'master' into referencesDogfood_1 2018-04-12 12:26:10 -07:00
Ryan Cavanaugh
f24d57f1ac Update diagnostic tasks in jakefile 2018-04-12 12:20:27 -07:00
Andy
abbb79f972
Combine getTouchingWord and getTouchingPropertyName (#22127) 2018-04-12 11:56:40 -07:00
Andy
afcced6839
Simplify tryGetImportOrExportClauseCompletionSymbols (#22961)
* Simplify tryGetImportOrExportClauseCompletionSymbols

* Handle undefined key in arrayToSet
2018-04-12 11:55:21 -07:00
Andy
d2dc2e6d48
Don't copy trivia when implementing an interface (#23343)
* Don't copy trivia when implementing an interface

* Use an `includeTrivia` flag instead of a separate function
2018-04-12 11:47:42 -07:00
Andy
05c746b547
generateGetAccessorAndSetAccessor: Share modifier-creating code (#23311) 2018-04-12 11:13:25 -07:00
Nathan Shively-Sanders
5d23cb49d0
Exclude generated files from user tests (#23371)
* Exclude generated files from user tests

The top 3 offenders, at least: bcryptjs, bluebird and lodash.

* Clean url-search-params too

Only need to build the commonjs original, not the browserified ones.
2018-04-12 10:25:53 -07:00
Andy
b363240d05
Simplify registerCodeFIx (#23349) 2018-04-12 09:19:01 -07:00
csigs
a04e747569
LEGO: Merge pull request 23369
LEGO: Merge pull request 23369
2018-04-12 09:10:51 -07:00
csigs
2a10ef0016 LEGO: check in for master to temporary branch. 2018-04-12 16:10:29 +00:00
Andy
ff7ef4a25a
Add fixName property to CodeFixAction (#23350) 2018-04-12 09:05:30 -07:00
csigs
d4a166dad3
LEGO: Merge pull request 23360
LEGO: Merge pull request 23360
2018-04-12 03:10:58 -07:00
csigs
29dc3d2a66 LEGO: check in for master to temporary branch. 2018-04-12 10:10:32 +00:00
Andy
edcf087145
Fix bug: isSymbolReferencedInFile should return true for shorthand property assignment (#23314)
* Fix bug: isSymbolReferencedInFile should return true for shorthand property assignment

* Also test for export specifier
2018-04-11 19:01:30 -07:00
Ryan Cavanaugh
0e07d775a1 You have to do this everywhere now! 2018-04-11 16:59:53 -07:00
Andy
d36f83a98d
Remove TODO: GH#18795 comments (#23337) 2018-04-11 16:23:04 -07:00
Andy
b0552b089d
Don't include "/index" in import from @types even with classic resolution (#23347) 2018-04-11 16:22:10 -07:00
Ryan Cavanaugh
df95de3231 Merge branch 'master' into referencesDogfood_1 2018-04-11 16:17:38 -07:00
Nathan Shively-Sanders
79ad7df7e1
Improve user test tsconfig (#23325)
* Improve user test tsconfigs

Also incorporate updates from the packages themselves (they fixed
some of the bugs the compiler noticed).

* Fix enhanced-resolve module resolution

* Update baselines after merge w/master
2018-04-11 15:59:19 -07:00
Ryan Cavanaugh
e1a50366e3 .d.ts changed order 2018-04-11 15:55:29 -07:00
Ryan Cavanaugh
9a5a5b10a3 Remove all reference comments from services 2018-04-11 15:39:12 -07:00
Ryan Cavanaugh
501d7be7ba Add explicit file lists to server tsconfig files 2018-04-11 15:39:12 -07:00
Ryan Cavanaugh
bb8fd41793 Fix harness file listing 2018-04-11 15:39:12 -07:00
Ryan Cavanaugh
034b8eee14 Remove explicit harness file list from Jakefile 2018-04-11 15:39:10 -07:00
Ryan Cavanaugh
21d16693da Explicitly list server source files in their current emitted order 2018-04-11 15:38:27 -07:00
Ryan Cavanaugh
3ca1d2d7e3 Remove all reference comments from server/ 2018-04-11 15:38:26 -07:00
Ryan Cavanaugh
5b3254957c Explicitly list compiler source files in their current emitted order 2018-04-11 15:38:26 -07:00
Ryan Cavanaugh
8294259ec2 Remove all reference comments from compiler/ 2018-04-11 15:38:26 -07:00
Andy
28455c65b3
patternMatcher: Return single best match instead of list (#23166) 2018-04-11 15:35:22 -07:00
Andy
f6b206a75a
When testing references, also test documentHighlights respects filesToSearch (#23306)
* When testing references, also test documentHighlights respects filesToSearch

* Fix handling for redirects and move assertion inside getDocumentHighlights

* Add another assert
2018-04-11 14:07:22 -07:00
Andy
fef28665f7
generateGetAccessorAndSetAccessor: Fix typos and use type predicate (#23310) 2018-04-11 13:21:47 -07:00
Andy
a004571d3e
Update outdated comments (#23320) 2018-04-11 07:56:42 -07:00
Nathan Shively-Sanders
9ceb113ec5
Allow exports assignments (#23319)
1. Allow assignment to `exports`.
2. The type of the rhs is not checked against the type of `exports`
since they are aliased declarations.

To support more complex patterns like `exports = c.name = c`, we may
have to treat `c.name` as a declaration. That will be more complicated
than this PR.
2018-04-11 06:49:58 -07:00
Daniel Rosenwasser
01b22ff37e
Merge pull request #23331 from aboveyou00/master
Fix typeo: rename udpateReportDiagnostic to updateReportDiagnostic
2018-04-11 01:40:49 -07:00
csigs
1fb2a12b0f
LEGO: Merge pull request 23332
LEGO: Merge pull request 23332
2018-04-10 21:11:04 -07:00
csigs
f458e9007d LEGO: check in for master to temporary branch. 2018-04-11 04:10:41 +00:00
Brandon Slade
82e8bcf3b2 Fix typeo: rename udpateReportDiagnostic to updateReportDiagnostic 2018-04-10 21:58:18 -06:00
Wesley Wigham
8a2b4646f0
Include guards on comment kind in pragma extraction (#23313) 2018-04-10 20:50:31 -07:00
Wesley Wigham
b2e0c4bea6
Add support for destructuring well-known and late-bound names (#23297)
* Add support for destructuring well-known and late-bound names

* Add test of not present late bound prop
2018-04-10 18:21:24 -07:00
Wesley Wigham
1243d1a9ba
handle any'd method signature types (ie, from special property declarations) (#23316) 2018-04-10 18:17:57 -07:00
csigs
0c06f2f44c
LEGO: Merge pull request 23322
LEGO: Merge pull request 23322
2018-04-10 15:11:13 -07:00
csigs
cb6d4d1ff6 LEGO: check in for master to temporary branch. 2018-04-10 22:10:52 +00:00
Andy
dcc4b8854b
In getWidenedTypeFromJSSpecialPropertyDeclarations, parent of PropertyAccessExpression must be a BinaryExpression (#22727) 2018-04-10 14:46:26 -07:00
Andy
f479de6d02
patternMatcher: Just return 'undefined' for an invalid pattern (#23237)
* patternMatcher: Just return 'undefined' for an invalid pattern

* Fix tests
2018-04-10 14:38:16 -07:00
Nathan Shively-Sanders
22919d57fe
JSDoc:positional matching of destructured params (#23307)
* JSDoc:positional matching of destructured params

1. When looking up tags for a parameter whose name is a binding pattern, use
the index of the parameter to get the type.
2. When reporting errors for `@param` tags with no matching parameter
name, do not report the error for tags whose index in the `@param` tag list
matches the index of a parameter whose name is a binding pattern.

* Change to an assert

* Improve comment text
2018-04-10 12:48:35 -07:00
Andy
4b706fc479
Add 'disableSuggestions' to UserPreferences (#23283)
* Add 'disableSuggestions' to UserPreferences

* Make mergeMapLikes return a new object

* Avoid additional clone

* mergeMapLikes -> object spread
2018-04-10 11:53:24 -07:00