Nathan Shively-Sanders
95f5bc1ee0
Add unknown property to test of contextual this type
2017-07-18 10:01:22 -07:00
Nathan Shively-Sanders
08ae02263a
Contextually type this in object literals in JS
...
Previously, `this` would only get a contextual type inside object
literals with `--noImplicitThis` turned on in Typescript files.
2017-07-17 15:59:18 -07:00
Andy
de9a67f2f3
Issue template: Recommend to run tsc
directly ( #17246 )
...
* Issue template: Recommand to run `tsc` directly
* List some common build tools
2017-07-17 14:45:21 -07:00
Sheetal Nandi
54dfdd77fb
Merge pull request #17210 from Microsoft/readfile
...
`readFile` may return undefined
2017-07-17 14:39:57 -07:00
Andy
5d46ca7118
Reuse stored types for any[] and Promise<any> instead of creating new ones ( #17179 )
...
* Reuse stored types for any[] and Promise<any> instead of creating new ones
* Don't store anyPromiseType
2017-07-17 12:56:58 -07:00
Andy
2a219af308
convertFunctionToEs6Class: Bail if this is not a JavaScript file ( #17149 )
2017-07-17 12:56:16 -07:00
Andy Hanson
2ce23909b2
Fix error message
2017-07-17 12:39:01 -07:00
Andy
6cf30fbccf
Fix bug in importTracker: getExportNode
must verify that we are on the LHS of a VariableDeclaration ( #17205 )
2017-07-17 12:29:29 -07:00
Andy
555776eb3c
Minor cleanups in builder ( #17208 )
...
* Minor cleanups in builder
* Use enumerateInsertsAndDeletes
2017-07-17 12:24:56 -07:00
Nathan Shively-Sanders
240f1f1be4
Merge pull request #17176 from Microsoft/parse-jsdoc-with-ts-type-parser
...
Parse jsdoc with normal TS type parser
2017-07-17 08:41:06 -07:00
Nathan Shively-Sanders
3f60364a64
Improve test of jsdoc literal type parsing
2017-07-17 08:29:40 -07:00
Andy Hanson
96d537bc54
readFile
may return undefined
2017-07-14 15:57:23 -07:00
Nathan Shively-Sanders
61c9f98eef
Merge branch 'master' into parse-jsdoc-with-ts-type-parser
2017-07-14 15:04:06 -07:00
Nathan Shively-Sanders
172db13306
Parse more types in JSDoc function() syntax
...
Also some cleanup from PR comments
2017-07-14 14:34:32 -07:00
Nathan Shively-Sanders
bdc3f1f3f7
Address more PR comments
2017-07-14 13:29:44 -07:00
Daniel Rosenwasser
e8421827e0
Merge pull request #16600 from alexeagle/pretty2
...
Add missing newline in --pretty diagnostics formatter
2017-07-14 12:22:05 -07:00
Nathan Shively-Sanders
b2e892f0b9
Update baselines
2017-07-14 11:08:06 -07:00
Nathan Shively-Sanders
40ae42221e
Better JSDoc generic errors and faster isInJSDoc
2017-07-14 11:07:20 -07:00
Nathan Shively-Sanders
f1145c35ca
Improve JSDoc function checking
...
1. Remove checkJSDocFunctionType in favour of checkSignature.
2. Check that 'new', in addition to 'this', must be the first parameter.
3. Remove prematurely added JSDoc-quickfix test.
2017-07-14 10:15:30 -07:00
Nathan Shively-Sanders
6e861fd3e6
Remove JSDocConstructor/ThisType and just use named parameters
2017-07-14 09:36:12 -07:00
Nathan Shively-Sanders
da5285e979
Update baselines
2017-07-14 09:34:35 -07:00
Nathan Shively-Sanders
d24b3a3cba
Add fourslash tests for function(new/this:T) syntax
2017-07-13 14:49:50 -07:00
Andy
680bfbb705
Combine moduleHasNonRelativeName with isExternalModuleNameRelative ( #16564 )
2017-07-13 13:46:04 -07:00
Nathan Shively-Sanders
ac478a9720
Add missing word in error message
2017-07-13 13:37:35 -07:00
Andy
d2ec45f354
Remove unnecessary 'ts.' qualifications ( #17163 )
2017-07-13 13:08:59 -07:00
Nathan Shively-Sanders
48d9012989
Update baselines
2017-07-13 11:34:56 -07:00
Nathan Shively-Sanders
91633cde5f
Test JSDoc parsing using TS parser
2017-07-13 11:33:12 -07:00
Nathan Shively-Sanders
bc69c7e6d1
Parse JSDoc types using the normal TS parser
...
This means that JSDoc types can include the full range of Typescript
types now. It also means that Typescript annotations can include JSDoc
types. This is disallowed with a new error, however. But Typescript can
still give the correct types to JSDoc that shows up in .ts files by
mistake. This can easily happen, for example with types like
```ts
var x: number? = null;
var y: ?string = null;
var z: function(string,string): string = (s,t) => s + t;
// less likely to show up, but still understood.
var ka: ? = 1;
```
In the future, I will add a quick fix to convert these into the correct
types.
Fixes #16550
2017-07-13 11:27:50 -07:00
Mine Starks
fd2dd2edc0
Merge pull request #17078 from minestarks/removeimportfix
...
Code fix to remove unused named import should preserve default import
2017-07-13 10:53:35 -07:00
Andy
7b5e1e9c49
Use array helpers instead of 'reduce' ( #17172 )
2017-07-13 10:43:01 -07:00
Andy
c6a6467073
Remove unneeded ExportType and ExportNamespace flags ( #16766 )
2017-07-13 09:21:13 -07:00
Andy
69d3ca774a
When adding completions for a module, don't get the type of the module if not necessary. ( #16768 )
...
* When adding completions for a module, don't get the type of the module if not necessary.
* Use SymbolFlags.Module alias
2017-07-13 09:20:40 -07:00
Andy
6880ee33a3
displayPartWriter: Use try-finally to clear ( #16807 )
2017-07-13 08:14:02 -07:00
Andy
9a3847feac
getSingleLineStringWriter: Use try-finally, and only one stringWriter ( #16751 )
...
* getSingleLineStringWriter: Use try-finally, and only one stringWriter
* Use a `usingSingleLineStringWriter` helper function
* Add assert
2017-07-13 08:13:49 -07:00
Andy
79b10081a9
getApplicableRefactors: Don't return undefined response ( #16773 )
2017-07-13 07:32:41 -07:00
Andy
efc861c76d
Add logging to discoverTypings ( #16652 )
2017-07-13 07:10:35 -07:00
Andy
33836f891c
Clean up getJavaScriptCompletionEntries ( #16750 )
...
* Clean up getJavaScriptCompletionEntries
* Move each parameter to its own line
2017-07-13 06:54:04 -07:00
Andy
dbbf051886
Add assertion to computePositionOfLineAndCharacter ( #17121 )
2017-07-13 06:49:28 -07:00
Yui
1c93531f0f
Merge pull request #17025 from Microsoft/master-16763
...
[Master] Fix 16763
2017-07-12 16:36:04 -07:00
Mine Starks
abb229e91b
Add a bit more validation around comments
2017-07-12 11:14:48 -07:00
Andy
2368847f6b
Indent filesToString ( #17130 )
2017-07-12 10:42:05 -07:00
Andy
a0c672ac02
Add assertion that module / type reference names are defined ( #17124 )
2017-07-12 10:13:33 -07:00
Andy
38db79d666
buildTreeFromBottom: Really simplify loop ( #17105 )
2017-07-12 09:59:29 -07:00
Andy
815af7da17
getSwitchClauseTypes: exit early if getTypeOfSwitchClause is undefined ( #16865 )
2017-07-12 07:45:02 -07:00
Nathan Shively-Sanders
50f39102aa
Merge pull request #17096 from Microsoft/improve-return-type-parse-error
...
Improve return type parse error
2017-07-12 07:18:23 -07:00
Daniel Rosenwasser
38f6db52ac
Merge pull request #17079 from Microsoft/noTypeArgsSum
...
Declare 'sum' so that it doesn't require type arguments.
2017-07-12 00:09:58 -07:00
Andy
08030c7d02
Convert most of core.ts to accept ReadonlyArray ( #17092 )
...
* Convert most of core.ts to accept ReadonlyArray
* Fix lint
* Fix isArray
2017-07-11 17:39:33 -07:00
Yui
25f4e46638
Merge pull request #17082 from Microsoft/master-16201
...
[Master] Fix 16201: fix cannot find "object"
2017-07-11 17:13:01 -07:00
Mine Starks
0694a38728
Use platform agnostic newline
2017-07-11 16:05:10 -07:00
Daniel Rosenwasser
325f4b84cf
Addressed feedback.
2017-07-11 15:32:31 -07:00