Commit graph

20295 commits

Author SHA1 Message Date
Andy 9c8129eeac
Enable 'no-invalid-template-strings' lint rule (#19790) 2017-11-07 06:51:35 -08:00
csigs d81ea525c4
LEGO: Merge pull request 19805
LEGO: Merge pull request 19805
2017-11-07 03:10:32 -08:00
csigs 9ba9a893cc LEGO: check in for master to temporary branch. 2017-11-07 11:10:13 +00:00
Aluan Haddad 70cabdda41 fix inconsistencies in import UMD code fixes adapting to module format (#19572)
* improve import code fixes for UMD modules
 - use default import under --allowSyntheticDefaultImports
 - import..require support
 - make make quick fix info match resulting import
 - make diagnostics

* Address PR feedback:
 - extract test for synethetic default imports into getAllowSyntheticDefaultImports in core.ts
 - use getAllowSyntheticDefaultImports in checker.ts and importFixes.ts
 - move compilerOptions to top level destructuring

* add tests

* remove `import =` quick fix and supporting code.

* update feature tests

* remove errant whitespace
2017-11-06 22:55:37 -08:00
csigs 5969aefeb3
LEGO: Merge pull request 19794
LEGO: Merge pull request 19794
2017-11-06 21:10:33 -08:00
csigs ed335a66fa LEGO: check in for master to temporary branch. 2017-11-07 05:10:13 +00:00
Andy 6d273cfb33
Consistently use "JSX Attribute" completion kind (#19781)
* Consistently use "JSX Attribute" completion kind

* Update tests and fix bug

* Fix bug: In a JsxOpeningElement, if at an Identifier we are not at an attribute but at the tag itself.
If at a GreaterThanToken, we are about to fill in an attribute.
2017-11-06 19:14:24 -08:00
Ron Buckton 3f248ecfe1
Merge pull request #19452 from Microsoft/compareStrings
Clean up outdated string comparison logic
2017-11-06 18:48:15 -08:00
Andy 77b24aec83
Apply 'unified-signatures' tslint rule (#19738)
* Apply 'unified-signatures' tslint rule

* Fix new failure
2017-11-06 18:38:03 -08:00
Andy 40efd1b3bd
Apply 'object-literal-key-quotes' tslint rule (#19737)
* Apply 'object-literal-key-quotes' tslint rule

* Convert to "consistent-as-needed"
2017-11-06 18:13:20 -08:00
Andy 3e7af1cf12
Move "ban-comma-operator" to tslint rules that we won't use (#19780) 2017-11-06 18:10:14 -08:00
Andy 381ca45787
Use an enum for Msg (#19773) 2017-11-06 18:10:02 -08:00
Wesley Wigham d79c37cd19
Discriminate contextual types (#19733)
* Discriminate contextual types

* Invert conditional

* Update findMatchingDiscriminantType and baselines
2017-11-06 16:09:35 -08:00
csigs d6436f13e5
LEGO: Merge pull request 19783
LEGO: Merge pull request 19783
2017-11-06 15:11:14 -08:00
csigs fd64322a63 LEGO: check in for master to temporary branch. 2017-11-06 23:10:47 +00:00
Sean Barag a46d2705ef Use documentation comments from inherited properties when @inheritDoc is present (#18804)
* Use documentation comments from inherited properties when @inheritDoc is present

The JSDoc `@ineheritDoc` [tag](http://usejsdoc.org/tags-inheritdoc.html)
"indicates that a symbol should inherit its documentation from its
parent class".  In the case of a TypeScript file, this also includes
implemented interfaces and parent interfaces.

With this change, a class method or property (or an interface property)
with the `@inheritDoc` tag in its JSDoc comment will automatically use
the comments from its nearest ancestor that has no `@inheritDoc` tag.
To prevent breaking backwards compatibility,
`Symbol.getDocumentationComment` now accepts an optional `TypeChecker`
instance to support this feature.

fixes #8912

* Use ts.getJSDocTags as per @andy-ms 's recommendation

* Convert @inheritDoc tests to verify.quickInfoAt

* Concatenate inherited and local docs when @inheritDoc is present

* Make typeChecker param explicitly `TypeChecker | undefined`

* Re-accept baseline after switch to explicit `| undefined`

* Update APISample_jsodc.ts to match new getDocumentationComment signature

* Re-accept baselines after rebasing
2017-11-06 13:18:21 -08:00
falsandtru 28ed9b307b Update DOM iterable interfaces (#19752)
* Make HTMLCollections Iterable

* Sort definitions
2017-11-06 13:12:47 -08:00
Andy ed38889ca6
Enable 'no-unused-expression' tslint rule (#19734) 2017-11-06 13:01:07 -08:00
Mohamed Hegazy 5c173f4436 Remove test 2017-11-06 13:00:05 -08:00
Eugene Timokhov 5b9905d5a4 Added empty constructors to TypedArrays from es2017 (#19680) 2017-11-06 13:00:05 -08:00
Wesley Wigham 0593ba27d8
Make getContextualTypeOfApparentType mapType over unions (#17668)
* Instantiate contextual types while in an inferrential context

* Limit scope of instantiation to only when likely needed

* Still get aparent type

* Expand test

* Fix nit

* Handle JSX and array

* Tests for the JSX and Array cases

* After much deliberation and inspection, much simpler fix

After much deliberation and inspection, much simpler fix

Undo

Redo
2017-11-06 12:52:33 -08:00
Wesley Wigham 4f48bf80fe
Revised emit for computed property names, including with decorators (#19430)
* Revised emit for computed property names

* Fix downlevel name generation scopes

* Accept slightly more conservative baseline

* First feedback pass

* Reduce number of nonrequired variable declarations and assignments

* Remove side-effect-free identifier references

* skip partially emitted expressions

* Comments, move starsOnNewLine to emitNode

* Put expressions on newlines when inlined in class expressions for consistency

* Update new ref

* Fix typo in comment
2017-11-06 12:51:34 -08:00
Sheetal Nandi ddbd654ecd
Merge pull request #19730 from Microsoft/fileNotOnDisk
Handles script infos that dont exist on the disk and are opened with non-rooted disk path
2017-11-06 12:21:32 -08:00
Wesley Wigham c016f5b9b0
Split runner selection from test selection (#19729)
* Split runner selection from test selection

* Continue to support old behavior
2017-11-06 11:24:17 -08:00
Andy c4bf21b9cb
Improvements to checkUnusedIdentifiers (#19607) 2017-11-06 10:59:39 -08:00
Sheetal Nandi 163e40cde6 Add testcase for non existent file without absolute path when opened with/without projectRoot 2017-11-06 10:56:52 -08:00
Anders Hejlsberg b5f4a83365
Merge pull request #19745 from Microsoft/emptyArrayInference
No inference from empty array literals
2017-11-06 10:45:45 -08:00
Anders Hejlsberg 7a4808a89e
Merge pull request #19774 from Microsoft/fixInvariantGenericErrors
Fix invariant generic error elaboration logic
2017-11-06 10:42:32 -08:00
Mohamed Hegazy 445001e171
Port generated lib files (#19772) 2017-11-06 10:24:21 -08:00
Nathan Shively-Sanders 868d36d51d
Merge pull request #19770 from Microsoft/remove-readonly-from-spread-index-sigs
Remove readonly from index signatures of a spread
2017-11-06 10:20:57 -08:00
Benjamin Lichtman 4977bf4328
Merge pull request #19544 from uniqueiniquity/interfaceJsDoc
Insert JsDoc comment templates for additional nodes
2017-11-06 09:49:59 -08:00
micbou d97335e4e7 Silence NPM warnings when installing typings (#19749) 2017-11-06 09:45:52 -08:00
Anders Hejlsberg 8d991f70b3
Merge pull request #19741 from Microsoft/fixMappedTypeModifiers
Check combined mapped type modifiers
2017-11-06 09:35:28 -08:00
Anders Hejlsberg baafe5157e Add regression test 2017-11-06 09:25:51 -08:00
Anders Hejlsberg a287ddc93b Fix invariant generic error elaboration logic 2017-11-06 09:25:41 -08:00
Andy 0a7b7e07ee
Apply 'variable-name' tslint rule (#19743) 2017-11-06 09:23:47 -08:00
Nathan Shively-Sanders 7788d293c4 Test:spread removes readonly from index signatures 2017-11-06 08:16:15 -08:00
Nathan Shively-Sanders db9ed00a0f Remove readonly from index signatures of a spread 2017-11-06 08:14:43 -08:00
Anders Hejlsberg 0a4f60e87b Add tests 2017-11-04 17:26:12 -07:00
Anders Hejlsberg a8160de49c Empty array literal has a non-inferrable element type 2017-11-04 17:26:02 -07:00
Anders Hejlsberg 9619dc14f9 Add tests 2017-11-04 08:08:28 -07:00
Anders Hejlsberg 45c53e0dcc Check combined modifiers in mappedTypeRelatedTo 2017-11-04 08:08:05 -07:00
Ron Buckton ed914a8d47 Fix new lint error 2017-11-03 23:53:13 -07:00
Ron Buckton 31c3d444f1 Merge branch 'master' into compareStrings 2017-11-03 23:01:51 -07:00
Andy 8d5b0529b2
Add localizable diagnostic for "Install '{0}'" (#19651) 2017-11-03 18:14:21 -07:00
Andy 845c066923
Check for unused locals in commonjs modules (#19612) 2017-11-03 17:46:19 -07:00
uniqueiniquity d2114e1b9e Rename offsets in tests 2017-11-03 16:14:47 -07:00
Andy bb7fb7dda9
For getCompletionsAtPosition, require a flag to provide completions with code actions (#19687)
* For getCompletionsAtPosition, require a flag to provide completions with code actions

* Change name

* Increase API version

* Update API baselines

* Add comment

* Update API baseline
2017-11-03 15:55:31 -07:00
Anders Hejlsberg f75a1dce88
Merge pull request #19726 from Microsoft/fixNeverTypeCall
Disallow calls on never type
2017-11-03 15:39:19 -07:00
Sheetal Nandi 373510c4d9 Handle the script infos that are opened with non rooted disk path
Fixes #19588
2017-11-03 15:38:58 -07:00