Andrew Casey
ad148dbc88
Use deep cloning, rather than thunking for repeated substitution
...
Replaces b244cd4fb4
2017-10-05 15:46:14 -07:00
Andrew Casey
380b8df13f
Introduce getSynthesizedDeepClone
2017-10-05 15:38:02 -07:00
Andrew Casey
a5e1841180
Handle undefined in getSynthesizedClone
2017-10-05 15:37:47 -07:00
Andrew Casey
d03d237b3b
Merge pull request #18929 from amcasey/ExtractVoidNever
...
Stop extracting void and never constants
2017-10-04 10:33:05 -07:00
Andy
6617819bf3
In getModifierOccurrences, support additional container kinds ( #18947 )
2017-10-04 09:52:51 -07:00
Andy
fe9129b1ab
Support contextual type for property assignments in JS that are not declarations ( #18820 )
2017-10-04 09:32:09 -07:00
Sheetal Nandi
a3853d0774
Merge pull request #18934 from Microsoft/throttledCancellation
...
Wrap the cancellation token in throttled cancellation token from server
2017-10-03 17:10:38 -07:00
Wesley Wigham
37723f17d6
Latest mocha uses fullPath instead of titlePath ( #18933 )
2017-10-03 17:02:39 -07:00
Andy
d384a6adb6
Fix location of generateLocalizedDiagnosticMessages.js ( #18923 )
2017-10-03 16:38:47 -07:00
Sheetal Nandi
c2427f22d0
Wrap the cancellation token in throttled cancellation token from server
2017-10-03 16:34:46 -07:00
Andrew Casey
443812a045
Stop extracting void and never constants
2017-10-03 15:07:39 -07:00
Andrew Casey
1507547020
Merge pull request #18927 from amcasey/ExtractBaselineShowRange
...
Include range markers in Extract Constant/Function baselines
2017-10-03 14:29:14 -07:00
Andrew Casey
d1015bff06
Merge pull request #18926 from amcasey/ExtractConstantArrow
...
Disallow constant extraction into expression-bodied arrow functions
2017-10-03 14:29:01 -07:00
Andrew Casey
a10274a867
Include range markers in Extract Constant/Function baselines
2017-10-03 13:50:17 -07:00
Andy
46e135b098
Fix parsing of qualified name in @augments ( #18914 )
2017-10-03 13:47:01 -07:00
Andrew Casey
2cb965c268
Disallow constant extraction into expression-bodied arrow functions
...
...until https://github.com/Microsoft/TypeScript/issues/18924 is fixed.
2017-10-03 13:34:20 -07:00
Andy
d4cbdc4985
Fix gulp lint
( #18921 )
2017-10-03 13:28:20 -07:00
Andrew Casey
b9fb1733ef
Merge pull request #18919 from amcasey/ExtractLocalRefinements
...
Improve Extract Constant's handling of expression statements
2017-10-03 13:19:39 -07:00
Andrew Casey
7b1147fbce
Stop inadvertently exempting expression statements from check
2017-10-03 12:23:32 -07:00
Daniel Rosenwasser
301c90ccff
Merge pull request #18300 from Microsoft/correctlyCacheTaggedTemplates
...
Correctly cache tagged template objects in modules
2017-10-03 12:06:57 -07:00
Andrew Casey
2a4ab08655
Refine extraction of expression statements
...
1) Replace range, rather than node, to leave trivia intact.
2) Only replace node in the innermost scope - otherwise insert as usual
and delete the original statement.
2017-10-03 11:18:40 -07:00
Wesley Wigham
5c7a3d050d
Keep comments in production tsserverlibrary builds ( #18913 )
2017-10-03 11:18:22 -07:00
Andy
b111493276
Remove unnecessary *OrUndefined calls ( #18889 )
...
* Remove unnecessary *OrUndefined calls
* Add 'first'
2017-10-03 10:24:39 -07:00
Andrew Casey
b21d8a4742
Merge pull request #18900 from amcasey/ReduceDup
...
Refactor to reduce property duplication
2017-10-03 10:04:03 -07:00
Nathan Shively-Sanders
4d8663c378
Merge pull request #18117 from Microsoft/jsdoc-dotdotdot-binds-tighter-than-postfix
...
Jsdoc ... binds tighter than postfix ?!
2017-10-03 08:45:26 -07:00
Daniel Rosenwasser
8fd638c7a8
Accepted baselines.
2017-10-03 00:37:28 -07:00
Daniel Rosenwasser
babe3cb931
Flatten the '__makeTemplateObject' helper to use less vertical screen real estate.
2017-10-03 00:36:02 -07:00
Mohamed Hegazy
ae3f29ade6
Accept baselines ( #18903 )
2017-10-02 19:08:13 -07:00
Sheetal Nandi
6997e9b731
Merge pull request #17269 from Microsoft/watchImprovements
...
Watch improvements in tsserver
2017-10-02 17:38:22 -07:00
Wesley Wigham
7f7d0c6c7b
Baseline public API ( #18897 )
...
* Add unit test which tracks public API changes
* Accept strict function types updates
* 100% Linefeeds, no carriage returns
* How were these missing?
* That would be why they were there
* Extract and comment
* Accept comment changes
2017-10-02 17:37:40 -07:00
Sheetal Nandi
8ac01d76f5
Separate namespace declarations in builder of intenal and exported interfaces and functions
2017-10-02 17:16:49 -07:00
Mohamed Hegazy
a8b7f7d1e5
Include localized diagnostics ( #18702 )
...
* Add lcl files
* Add loclalization script
* Add localization build targets
* use async exists, and add assert
* Generate lcg file
* Add localize task to gulpFile
* Only run loclaize if the generated files neededs update. Also run localize as part of local
* Fix lint errors
* Linter love
* Respond to code review comments
2017-10-02 17:16:08 -07:00
Andy
3a2c723a69
Allow parsing a qualified type name containing a reserved word ( #18888 )
2017-10-02 17:04:28 -07:00
Andrew Casey
b244cd4fb4
Merge pull request #18864 from amcasey/GH18857
...
Handle repeated substitution of the same symbol during extraction
2017-10-02 17:03:03 -07:00
Andy
d620129d4a
Ensure getResolvedSignature never returns undefined
( #18883 )
2017-10-02 17:02:27 -07:00
Andrew Casey
3b4cbebee0
Handle repeated substitution of the same symbol during extraction
...
Old: Insert the same Node for every occurrence. The position was
repeatedly mutated during printing.
New: Thunk the Node so that a new one is constructed for every
occurrence.
Fixes #18857
2017-10-02 16:51:13 -07:00
Andrew Casey
e1380a866e
Refactor to reduce property duplication
2017-10-02 16:41:40 -07:00
Andrew Casey
2df7058af7
Merge pull request #18861 from amcasey/ConstantInsertionPosition
...
Improve insertion positions of extracted constants
2017-10-02 16:39:32 -07:00
Sheetal Nandi
4bb4711eff
Merge branch 'master' into watchImprovements
2017-10-02 16:34:43 -07:00
Sheetal Nandi
7f969e8138
Making APIs as internal so that we can enable them after we have figured out final details
2017-10-02 16:27:26 -07:00
Andrew Casey
724f71cae1
Describe the innermost scope as "enclosing scope" for constants
...
Using the same description as for functions was confusing because the
extracted constant was inserted below the top-level of that scope.
2017-10-02 15:57:36 -07:00
Andrew Casey
ba5f09b66d
Localize 'in' in extraction description
2017-10-02 15:30:52 -07:00
Anders Hejlsberg
884c72efb4
Merge pull request #18654 from Microsoft/strictFunctionTypes
...
Strict function types
2017-10-02 23:09:17 +01:00
Anders Hejlsberg
c2344e07a4
Add error elaboration test
2017-10-02 13:40:26 -07:00
Anders Hejlsberg
bff843a9c9
Improve error elaboration for invariant generic types
2017-10-02 13:39:55 -07:00
Andy
eefe5c9706
Fix acquiring format options for getEditsForRefactor ( #18848 )
...
* Fix acquiring format options for getEditsForRefactor
* Add test
* Fix test description
* Use `executeCommandSeq`
2017-10-02 13:26:35 -07:00
Daniel Rosenwasser
b80b2eeaa3
Move first/last shortcuts closer to the end of the helper flags.
2017-10-02 13:23:57 -07:00
Anders Hejlsberg
bf75a3f4ac
Emit .d.ts file in test
2017-10-02 12:54:04 -07:00
Sheetal Nandi
898559b4e5
Merge branch 'master' into watchImprovements
2017-10-02 12:34:34 -07:00
Sheetal Nandi
835153ba50
PR feedback
2017-10-02 12:22:05 -07:00