maxmustermann/TypeScript
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
31969 commits 490 branches 166 tags 2.2 GiB
Commit graph

31969 commits

This branch
This branch
All branches
Author SHA1 Message Date
Wenlu Wang b0c2860a68
ignore static and declared member if checking override (#43569) 
* ignore static member if checking override

* Ignore declared member when check override

* Check static override too

* Add more tests
 2021-04-09 10:43:33 -07:00
Sang a354a77030
Improve rendering of JSDoc comment text with displayparts (#43390) 
* feat(services): jsdoc use custom name for display parts

* fix(services): jsdoc typo

* feat(services): revert jsDoc changes

* feat(services): jsdoc improve displayparts with more comment kinds

Improve rendering of JSDoc comment text with displayparts for:

- `@typedef`
- `@callback`
- `@param`
- `@property`

* feat(services): jsdoc improve displayparts for template

* test: accept baseline

* test: update jsdoc parameterName

* feat: resolve pr comments

* test: add fourslash tests for jsdoc callback, typedef

* test: accept baselines

* test: revert changes for api baselines

* refactor: naming

* refactor: code quality

* refactor: clean up code as to pr comments
 2021-04-09 09:44:44 -07:00
Sheetal Nandi 75e9c94e50
While writing tsbuildinfo sort the properties of compiler options to make sure they stay same if nothing changes. (#43601) 
Fixes #43571
 2021-04-08 16:32:09 -07:00
TypeScript Bot 970554733a Update package-lock.json 2021-04-08 08:47:47 +00:00
Josh Goldberg fe4a6709da
Specified diagnostic for CLI flags mismatched with/out --build (#43199) 
* Specified diagnostic for CLI flags missing a required --build

* Switched to an alternateMode member

* Added --build-incompatible flags too

* Small fixups to remove a hardcoding

* Switched to ||= factories

* Not a function

* I think I get it now
 2021-04-07 16:03:17 -07:00
Armando Aguirre 2f82d02361
Fix Add all missing imports when ordered alphabetically (#43453) 
* Refactored insertNodeInlistAfter to use next elements position

* Consider trivia on insertNodeInListAfter
 2021-04-07 16:02:26 -07:00
Anders Hejlsberg d41943eb4e
Properly handle tagged primitives in control flow analysis (#43538) 
* Ignore object types in intersections with primitive types

* Add regression test

* Also handle instantiable types constrained to object types

* Add another test

* Add ignoreObjects optional parameter to getTypeFacts
 2021-04-07 11:29:46 -10:00
Josh Goldberg a4c683be12
Again: Improve error messages for empty DOM interface property access (#43007) 
* Again: Improve error messages for empty DOM interface property access

* containerSeemsToBeEmptyDomElement

Co-authored-by: Daniel Rosenwasser <drosenwasser@microsoft.com>

* isEmptyObjectType; unescapeLeadingUnderscores

* Single tick quotes for now

* Undo accidental diagnostic change

* Correct new baseline

Co-authored-by: Daniel Rosenwasser <drosenwasser@microsoft.com>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2021-04-07 12:54:27 -07:00
Josh Goldberg 905a1fea39
Corrected parsing for decorators on 'this' parameters (#43175) 
* Corrected parsing for decorators on 'this' parameters

* Moved checking to parser and added a specific test

* Remove unrelated checker.ts blank line

* Missed some baseeline updates...
 2021-04-07 11:21:28 -07:00
Titian Cernicova-Dragomir 2484210a00
Gh 41788 incorrect output for esprivate with nested class in esnext (#42663) 
* If target:esnext,then useDefineForClassFields: true will now be the default.

* Added error if a private identifier is used in a static a initializer if target:ESNext and useDefineForClassFields:false.

* Added test for new useDefineForClassFields default and error message.

* Fixed tests after changing the default of useDefineForClassFields to true for target esnext

* Fixed code review suggestions.

* Updated error message.

* Added missing static check for the containing property. Fixed other code review issues.
 2021-04-07 08:23:16 -07:00
Nathan Shively-Sanders 2bb54dc11a
Fix getTypeFromJSDocVariadicType in callback tag (#43562) 
* Fix getTypeFromJSDocVariadicType in @callback

Variadics have never worked there, I think.

* add test + fix lint

* remove outdated comment
 2021-04-07 08:12:05 -07:00
TypeScript Bot c1923e9cd1 Update package-lock.json 2021-04-07 06:08:06 +00:00
Nathan Shively-Sanders dd1ef88d01
Use control flow to type CommonJS exports (#42751) 
* Allow redeclaring CommonJS alias with initial undefined

This allows us to read our own output, plus the times when people
manually write exactly the same pattern.

Fixes #40555

* Use control flow to type commonjs exports

1. Could probably use a *lot* more tests.
2. getTypeOfAlias redoes some work from resolveAlias because it needs to
not resolve the alias completely, just to its export.

* fix lint, improve jsdoc

* Add tests, improve+fix control flow

1. Update the module.exports test to match the exports ones.
2. Add a test of evolving commonjs type.
3. Add a test of assignment as last statement.

(1) exposed a bug that required a better synthetic reference. (3)
exposed a bug that was most easily fixed by giving source files a
`endFlowNode` like functions and setting it in the binder.

* fix lint
 2021-04-06 17:07:35 -07:00
Oleksandr T eebb89533b
fix(43495): insert Override keyword after accessibility modifier (#43504) 2021-04-06 12:03:41 -07:00
Oleksandr T 3a22b3e701
fix(43535): preserves 'override' modifier in JavaScript output (#43536) 2021-04-06 11:31:54 -07:00
TypeScript Bot a56baa7394
Update user baselines +cc @sandersn (#42842) 
Co-authored-by: typescript-bot <typescript@microsoft.com>
 2021-04-06 08:58:43 -07:00
Pig Fang fb87079994
Enforce override precedes readonly (#43545) 2021-04-06 08:48:44 -07:00
Oleksandr T 8581a592bb
fix(43347): fix crash occurred when export type to existing commonJs imported name (#43369) 2021-04-06 08:46:22 -07:00
Wenlu Wang f526a38856
Always grammar checker for override (#43544) 2021-04-06 07:29:57 -07:00
Zen 3cf26e44ee
fix(43160): improve error location for functions without explicit return (#43367) 
* fix(43160): improve error location for functions without explicit return

* handle functions returning never
 2021-04-06 07:21:02 -07:00
Michael サイトー 中村 Bashurov 3b06ef1a73
Add asserts to type only symbols meaning exclusion (#43382) 
Fixes #42180
 2021-04-05 15:29:51 -07:00
Andrew Branch ffe925ddd5
Go to definition: pass unverified through server (#43483) 
* Pass `unverified` through server

* Update protocol baseline

* Fix unit tests

* Fix other tests
 2021-04-05 13:42:25 -07:00
Sheetal Nandi 4b556e37db
Handle document Registry to distinguish between files with same name and document registry key(compiler options affecting source file) but different ScriptKind (#43474) 
* Test that fails because of change in scriptKind of untitled file

* buckets are keyed with DocumentRegistryBucketKey

* Use scriptKind in document Registry to distinguish between files
Fixes #42613
 2021-04-05 13:27:34 -07:00
Song Gao 2d66517312
fix quickinfo of narrowed private filed (#43356) 
* fix quickinfo of narrowed private filed

* add test case.

* adapt review.
 2021-04-05 13:24:19 -07:00
Anders Hejlsberg a7a010a994
Fix getRecursionIdentity function to always return some identity (#43527) 
* Fix getRecursionIdentity, undo changes from #43435 (but keep tests)

* Remove test that takes excessively long to run

* Accept new baselines

* Fix formatting

* Add regression tests

* Reinstate test
 2021-04-05 09:53:38 -10:00
Zuckjet f621d67467
fix(42605): support refactoring for export default assignment without equal (#42936) 2021-04-05 11:59:45 -07:00
Wesley Wigham cf8798d977
Make origin union cache key unique for key lists still under construction (#43339) 2021-04-05 11:47:49 -07:00
Wesley Wigham d1b43429c2
Allow nested reverse mapped type printback (#42485) 
* Optimize interning of reverse mapped types

* Style feedback

* Whitespace

* Update baseline
 2021-04-05 11:37:51 -07:00
Wesley Wigham 1f1dcd60b5
When reusing input type nodes, only instantiate the type for comparison if it is a this type (#42584) 2021-04-05 11:10:47 -07:00
Oleksandr T 5268264e64
fix(43316): omit to suggest converting to async function if a void is explicitly returned (#43358) 2021-04-05 11:09:33 -07:00
Wesley Wigham f03e59ecc9
Do not covariantly mix in constraints from contravarrying positions (#43439) 
* Do not covariantly mix in constraints from contravarrying positions

* Exclude keyof from constraint variance tracking

* Extra test case

* Always subtitute on type parameter types
 2021-04-05 11:05:33 -07:00
Nathan Shively-Sanders 2f36065588
Add grunt user test (#43510) 
* Add grunt user test

* remove unneeded submodule
 2021-04-05 09:22:41 -07:00
TypeScript Bot 889a103681 Update package-lock.json 2021-04-05 06:08:00 +00:00
TypeScript Bot 61a9a883a1 Update package-lock.json 2021-04-04 06:07:40 +00:00
TypeScript Bot dfc380aeea Update package-lock.json 2021-04-03 06:07:38 +00:00
Josh Goldberg 38da7c600c
Disabled 'used before initialization' error for optional properties (#43100) 
* Disabled 'used before initialization' error for optional properties

* Expanded tests to include code snippet from issue
 2021-04-02 10:08:10 -07:00
Sang f9b35cd302
Add @link jsdoc auto-complete (#43475) 
* feat(services): jsdoc add link tag name

* test: add jsdoc inline test
 2021-04-01 17:02:50 -07:00
Nathan Shively-Sanders c6a2e45768
Add @deprecated to tree walk (#43473) 
So various things don't crash. Fixes #43472
 2021-04-01 08:42:00 -07:00
Armando Aguirre 8f8a579eee
Added BindingElement to isSomeImportDeclaration (#43387) 
* Added BindingElement to isSomeImportDeclaration

* Added tests

* Refactores to use getDeclarationOfAlias
 2021-03-31 18:18:16 -07:00
Wenlu Wang 62f3ccd9c0
Error if assignment after block (#41115) 
* Error if assignment after block

* Update src/compiler/diagnosticMessages.json

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

* Fix diags

* Error after block

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2021-03-31 15:57:25 -07:00
Nathan Shively-Sanders 76a2ae3d69
Only issue matching token errors on non-dupe locations (#43460) 
* Only issue matching token errors on non-dupe locations

Intead of unconditionally retrieving the last error and attaching a
related span, `parseErrorAt` and friends now return the last error and
return `false` when there is none.

Also make one more place use parseExpectedMatchingBrackets that I missed
last time.

* Inline parseTokenForError, return undefined not false

* skip redundant undefined assignment

* address PR comments
 2021-03-31 13:54:53 -07:00
TypeScript Bot 5b7838e6fa Update package-lock.json 2021-03-31 06:08:04 +00:00
Sheetal Nandi d51b8cff6a
Do not delete output file names that are same as input file name (#43448) 
* Add failing test case

* Do not delete output file names that are same as input file name
Fixes #43116
 2021-03-30 16:04:25 -07:00
Anders Hejlsberg 3dd68b878a
Fix template literal type relations (#43440) 
* Fix template literal relationships

* Accept new baselines

* Add regression test
 2021-03-30 12:53:15 -10:00
Oleksandr T 819651eb5f
fix(43313): add parentheses to a type assertions (#43315) 2021-03-30 15:29:02 -07:00
Sang a8ee22f73d
"fix(services): convert to es6 module generate invalid code with .default" (#43309) 2021-03-30 15:24:31 -07:00
Andrew Branch b549467368
Consider base types in isArrayLikeType (#43435) 
* Types that extend Array or ReadonlyArray are automatically array-like

* Add React repro to test
 2021-03-30 13:18:38 -07:00
keerthana1212 555ef73da8
Adding Diagnostic message for missing ']' and ')' in Array literal and conditional statements (#40884) 
* Adding Diagnostic message for missing ']' in Array literal

* revert change on parseArrayBindingPattern

* Adding diagnostic message for if, while, do and with statements

* Extract parseExpectMatchingBrackets

Co-authored-by: Keerthana Kanakaraju <kekanaka@microsoft.com>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2021-03-30 13:13:57 -07:00
Ryan Cavanaugh 294a5a7d78
Remote duplicated assignment (#43399) 2021-03-29 21:30:45 -07:00
Oleksandr T 6fd676b8ef
fix(43215): disallow using never as an interface name (#43217) 2021-03-29 17:22:41 -07:00