Cyrus Najmabadi
b86ef44e59
Add assert that clients do not try to call updateSourceFile multiple times on a source file.
2015-02-09 17:24:01 -08:00
Cyrus Najmabadi
11d19e3019
Fix issue with cancellation corrupting LS state.
...
The problem here was as follows:
1) Host calls into the LS to do some sort of operation.
2) LS tries to synchronize with the host.
3) During synchronization we attempt to create a new program.
4) Creating the new program causes us to incrementally update some source files.
5) Incrementally updating a source file produces a new source file, and invalidates the old one.
6) *Then* the host asks to cancel this operation.
7) THe synchronization process cancels itself, leaving the LS in an inconsistent state where some
of its source files have had their trees updated, but the information about the source file still
thinks that we have the previous version.
The fix is to not allow cancellation during host synchronization. Once we start, we have to go
all the way to completion.
2015-02-09 17:15:29 -08:00
CyrusNajmabadi
b277695a54
Merge pull request #1992 from Microsoft/additionalParserChecks
...
Additional parser checks
2015-02-09 18:43:22 -05:00
Cyrus Najmabadi
2eb1a213c7
Prevent index out of bounds exception.
2015-02-09 14:55:54 -08:00
Cyrus Najmabadi
17dd6c2de0
Be more conservative about reusing parameters.
2015-02-09 14:40:03 -08:00
Cyrus Najmabadi
a79e8e928b
Remove code duplication in isModuleElement.
2015-02-09 14:34:47 -08:00
Cyrus Najmabadi
e417f3016b
Add additional asserts, and make code more unified.
2015-02-09 14:23:55 -08:00
Cyrus Najmabadi
d37fdfe213
Add additional asserts.
2015-02-09 14:12:32 -08:00
Cyrus Najmabadi
318aa8ce7a
Don't use dynamic type checks while incrementally parsing.
2015-02-09 14:07:09 -08:00
Mohamed Hegazy
a710902a5f
Merge pull request #1937 from Microsoft/fourslashCleanup
...
Fourslash cleanup
2015-02-09 10:37:14 -08:00
Mohamed Hegazy
9207d9dd22
Merge remote-tracking branch 'origin/master' into fourslashCleanup
...
Conflicts:
src/harness/harnessLanguageService.ts
2015-02-09 09:31:19 -08:00
Mohamed Hegazy
08f51b9070
Respond to code review comments
2015-02-09 09:19:50 -08:00
CyrusNajmabadi
6453811d96
Merge pull request #1981 from Microsoft/incrementalChecks.ts
...
Add additional aggressive checks during incremental parsing.
2015-02-09 01:40:19 -05:00
Cyrus Najmabadi
d0aa7891de
Add additional incremental assert.
2015-02-08 18:02:13 -08:00
Cyrus Najmabadi
9d6b6b422a
Rename a few members and clean up comments.
2015-02-08 17:48:56 -08:00
Cyrus Najmabadi
ad7c77ea08
Check the text change range before and after we expand it.
2015-02-08 17:35:54 -08:00
Cyrus Najmabadi
1a17fd1daf
Move assertions into the parsing layer.
2015-02-08 17:30:27 -08:00
Cyrus Najmabadi
a82c57c4b9
Make sure positions of child elements are consistent.
2015-02-08 16:40:04 -08:00
Cyrus Najmabadi
f1cb97b692
Add additional aggressive checks during incremental parsing.
2015-02-08 16:10:16 -08:00
Cyrus Najmabadi
ff31b96533
Update test baseline.
2015-02-06 19:06:16 -08:00
CyrusNajmabadi
911a705e8d
Merge pull request #1974 from Microsoft/multiLineEmitting
...
Preserve single line blocks when emitting.
2015-02-06 22:00:41 -05:00
CyrusNajmabadi
5a1c740ca8
Merge pull request #1973 from Microsoft/objectLiteralSemicolons
...
Have better error recovery for whne a user uses semicolons instead of commas to delimit an object literal.
2015-02-06 21:52:05 -05:00
Cyrus Najmabadi
36b6f4e1b7
Preserve single line blocks when emitting.
2015-02-06 18:45:09 -08:00
Cyrus Najmabadi
449f4a4f37
Have better error recovery for whne a user uses semicolons instead of commas to delimit an object literal.
2015-02-06 17:30:29 -08:00
Mohamed Hegazy
55aa240ade
Merge branch 'master' into LSAPICleanup
...
Conflicts:
src/services/services.ts
2015-02-06 17:17:23 -08:00
Mohamed Hegazy
340828e445
Update LKG
2015-02-06 16:37:41 -08:00
CyrusNajmabadi
b5715bfe40
Merge pull request #1968 from Microsoft/sourceFileTestInvariants
...
Check source file invariants after creating/updating them in our tests.
2015-02-06 18:13:28 -05:00
Cyrus Najmabadi
02c1b8978b
Check source file invariants after creating/updating them in our tests.
2015-02-06 14:54:19 -08:00
Mohamed Hegazy
759ced35eb
Merge pull request #1966 from Microsoft/shimAPIChanges
...
Shim API changes to enable existing installations of VS to use the latest master builds
2015-02-06 14:22:56 -08:00
Mohamed Hegazy
0f3f2bcb56
add comment
2015-02-06 14:22:32 -08:00
Mohamed Hegazy
68fd9f8d40
Shim API changes to enable existing installations of VS to use the latest master builds
2015-02-06 14:20:29 -08:00
CyrusNajmabadi
369f784cfa
Merge pull request #1939 from Microsoft/diagnosticsOrganization
...
Compiler API cleanup.
2015-02-05 21:43:30 -05:00
Cyrus Najmabadi
d20d20aa9c
Remove "debugger;" calls.
2015-02-05 18:43:02 -08:00
Cyrus Najmabadi
5c0b38b203
Remove getEnumMemberValue, it is now subsumed into getConstantValue.
2015-02-05 18:26:56 -08:00
Cyrus Najmabadi
6ed9741a7a
Extract common function.
2015-02-05 18:11:21 -08:00
Mohamed Hegazy
b14a46bd85
Merge pull request #1951 from csnover/intl-hour12
...
Fix error in intl.d.ts
2015-02-05 17:32:37 -08:00
Cyrus Najmabadi
acbcd6c77f
Merge branch 'master' into diagnosticsOrganization
2015-02-05 17:30:27 -08:00
Cyrus Najmabadi
c77f732762
CR feedback.
2015-02-05 17:24:46 -08:00
jramsay
dc06b2f6de
Merge pull request #1952 from Microsoft/jasonra-disallowRenameForStandardTSLib
...
Disallow rename for elements that are defined in the standard TypeScript...
2015-02-05 17:21:22 -08:00
Cyrus Najmabadi
f9d3b489f2
Put curly on the right line.
2015-02-05 17:11:06 -08:00
Jason Ramsay
987dab9c9e
addressing CR comments
2015-02-05 16:05:54 -08:00
Cyrus Najmabadi
66a363f449
Simplify the API for emitting and reporting exit statuses to callers.
2015-02-05 15:50:18 -08:00
Colin Snover
9e4d5dacc5
All options should be optional
2015-02-05 22:59:17 +00:00
Cyrus Najmabadi
e7f6693eda
Move code for emitting above helper functions.
2015-02-05 14:46:50 -08:00
Cyrus Najmabadi
b0061c1420
Emit both javascript and declarations in the presence of errors (*unless* -noEmitOnError is specified).
2015-02-05 14:41:04 -08:00
Cyrus Najmabadi
ea4e3de91c
Remove unnecessary diagnostics split on SourceFile.
2015-02-05 13:38:11 -08:00
Jason Ramsay
953e568d9e
Disallow rename for elements that are defined in the standard TypeScript library.
2015-02-05 13:32:33 -08:00
Cyrus Najmabadi
f20fbb9726
Remove what looks like copy/paste errors in the parser.
2015-02-05 13:14:41 -08:00
Cyrus Najmabadi
c1dfdaa436
Simplify code for getting diagnostics in the Program.
2015-02-05 02:15:38 -08:00
Cyrus Najmabadi
493327af34
Fix language service handling of diagnostics.
2015-02-05 02:10:36 -08:00