Commit graph

24417 commits

Author SHA1 Message Date
Alexander T
bf567b8a40 Change getModifiedTime type 2018-07-16 11:10:09 +03:00
Daniel Rosenwasser
60986adee5
Merge pull request #25507 from ajafff/leftmost-expr-tagged-template
getLeftmostExpression: handle TaggedTemplateExpression
2018-07-13 23:56:32 -07:00
Andy
e25a23bb3c
Fix Buffer.from uses to handle node 5.4.1 bug (#25659) 2018-07-13 17:08:25 -07:00
Sheetal Nandi
7ad4fcf121
Merge pull request #25649 from Microsoft/jsonFilesOnCommandLine
Support resolveJsonModule option when files contain the json file
2018-07-13 16:24:42 -07:00
Sheetal Nandi
49ac60f286 Support resolveJsonModule option when files contain the json file
Fixes #25636
2018-07-13 12:21:51 -07:00
Sheetal Nandi
47e513e151
Merge pull request #25627 from Microsoft/preserveOutputInConfig
Fix incorrect handling of preserveWatchOutput flag is in config file
2018-07-13 10:56:53 -07:00
Andy
3f4412b173
getContainingList: Handle TypeAliasDeclaration (#25614)
* getContainingList: Handle TypeAliasDeclaration

* Handle ClassExpression and InterfaceDeclaration
2018-07-13 10:30:22 -07:00
Andy
27da9eab8d
fixUnreachableCode: Don't delete whole block when non-first line is unreachable (#25625) 2018-07-13 09:57:04 -07:00
Andy
88c6ced3c6
indentMultilineCommentOrJsxText: Fix bug when 'parts' is empty (#25645) 2018-07-13 09:56:21 -07:00
Sheetal Nandi
ca083809a4 Fix incorrect handling of preserveWatchOutput flag is in config file
Fixes #25620
2018-07-12 18:29:02 -07:00
Andy
1fb050bcca
Don't report unused diagnostics when the unused node has a parse error (#25598)
* Don't report unused diagnostics when the unused node has a parse error

* Update test
2018-07-12 17:24:59 -07:00
Nathan Shively-Sanders
32e60a9647
Explicitly typed special assignments are context sensitive (#25619)
* Explicitly typed js assignments: context sensitive

Explicitly typed special assignments should be context sensitive if they
have an explicit type tag. Previously no special assignments were
context sensitive because they are declarations, and in the common,
untyped, case we inspect the right side of the assignment to get the
type of the left side, and inspect the right side of the assignment to
get the type of the left side, etc etc.

Note that some special assignments still return `any` from
checkExpression, so still don't get the right type.

Fixes #25571

* Change prototype property handling+update bselines

* Fix indentation in test

* Update baselines
2018-07-12 15:28:53 -07:00
Andy
f500289a44
Stricter test that JSDoc @type tag matches function signature (#25615) 2018-07-12 14:02:02 -07:00
Ryan Cavanaugh
6a2ffec53d
Merge pull request #25610 from RyanCavanaugh/buildOnWatchStartup
When running with -w, do an initial compilation
2018-07-12 12:51:16 -07:00
Anders Hejlsberg
0f8b6fcd27
Merge pull request #25608 from Microsoft/genericRestArityCheck
Fix generic rest parameter arity checks
2018-07-12 09:09:31 -10:00
Andy
af412e39cf
mapTextChangesToCodeEditsUsingScriptInfo: Handle tsconfig.json text change (#25586)
*  mapTextChangesToCodeEditsUsingScriptInfo: Handle tsconfig.json text change

* Can't use `program.getSourceFile()` to determine file existence when multiple projects exist

* Use direct union instead of discriminated union
2018-07-12 12:09:04 -07:00
Andy
f9764d17f0
fixUnusedIdentifier: Support deleting @template tag (#25597)
* fixUnusedIdentifier: Support deleting @template tag

* Just return createTextRangeFromNode instead of adjusting range
2018-07-12 11:26:17 -07:00
Anders Hejlsberg
5822a8c923 Merge branch 'master' into genericRestArityCheck
# Conflicts:
#	src/compiler/checker.ts
2018-07-12 08:20:48 -10:00
Nathan Shively-Sanders
bd7b97ce61
Get return type from @type tag (#25580)
* Get return type from `@type` tag

This only happens in the checker, where the type is easily accessible.
The syntax-based check in getEffectiveReturnTypeNode as a fast path, and
for other uses that don't want to make a call to getTypeFromTypeNode.

Fixes #25525

* Implement PR suggestions

* Error when type tag isn't callable

* Fix lint
2018-07-12 10:49:41 -07:00
Ryan Cavanaugh
08d7b8fd10 When running with -w, do an initial compilation 2018-07-12 10:36:58 -07:00
Anders Hejlsberg
e88f63295b Accept new baselines 2018-07-12 07:07:23 -10:00
Anders Hejlsberg
55180f7725 Add tests 2018-07-12 07:07:13 -10:00
Anders Hejlsberg
87ad612e70 Additional arity check following instantiation of generic rest parameter 2018-07-11 17:26:35 -10:00
rflorian
66e9aaac18 Issue 19220 function parameter arity (#24031)
* Added reference test case and diagnostics message

* Adjusted arity checks to account for non-contiguous overloads

* Code cleanup, baseline not yet commited

* Accepted test baselines and minor implementation changes

* Cleaned up baseline tracking the now renamed arity check test

* Add range response when range contains only 2 values

* Added recent baseline

* Refined arity error messages when available overloads can be grouped

* Rolled back code formatting

* WIP cleanup needed in a few edge cases

* Finished adding new more descriptive error messages

* Code cleanup

* Added simplified version of bugfix for #19220

* Rebased onto master

* Removed whitespace after type assertion

* Code review simplifications

* Use correct diagnostic name

* Code review changes and simplification of diagnostic message

* Revert formatting changes
2018-07-11 17:19:56 -07:00
Andy
5f4a03c408
Ensure TypeChecker#getTypeAtLocation returns a defined result (#25583)
* Ensure TypeChecker#getTypeAtLocation returns a defined result

* Update additional baseline
2018-07-11 16:33:56 -07:00
Mohamed Hegazy
2d0d655fea
Merge pull request #25561 from ajafff/multiple-prologue-directives
handle multiple prologue directives
2018-07-11 11:38:01 -07:00
Nathan Shively-Sanders
42a2d9e568
Excess property understands conditional types (#25584)
Previously it did not, causing misleading excess property errors. Note
that assignability errors with conditional types are still usually
confusing. This PR doesn't address that.

Also, make sure that exact matches in getSpellingSuggestion are skipped.
2018-07-11 11:24:40 -07:00
Andy
52486ae362
Improve isPossiblyTypeArgumentPosition (#25043)
* Improve isPossiblyTypeArgumentPosition

* Update API (#24966)

* Handle new Type<Type<

* Add test for `new C < C<`
2018-07-11 11:15:04 -07:00
Mohamed Hegazy
97f10bc3a2
Merge pull request #25576 from typescript-bot/user-update-20180603
🤖 User test baselines have changed
2018-07-11 11:03:28 -07:00
Andy
19993a5408
When import("foo") has module resolution error, error span should be "foo" (#25569)
* When `import("foo")` has module resolution error, error span should be "foo"

* Update more tests
2018-07-11 10:06:08 -07:00
Klaus Meinhardt
2a960011d7 Merge branch 'master' of github.com:Microsoft/TypeScript into multiple-prologue-directives 2018-07-11 18:47:23 +02:00
Klaus Meinhardt
626480df20 accept baseline 2018-07-11 18:46:22 +02:00
Klaus Meinhardt
0de903ea17 rename function 2018-07-11 18:43:58 +02:00
Andy
8a3090bc35
Improve test for 'symbol.exports' (#25523)
* Improve test for 'symbol.exports'

* Remove SymbolFlags.HasExports and SymbolFlags.HasMembers

* Update baseline
2018-07-11 09:37:32 -07:00
Andy
990d445bb6
In services, when overload resolution fails, create a union signature (2) (#25100) 2018-07-11 08:54:47 -07:00
typescript-bot
3a67ea8332 Update user baselines 2018-07-11 13:29:33 +00:00
Mohamed Hegazy
f66c7dbba2 Add release-3.0 to supported branches 2018-07-10 23:41:09 -07:00
Mohamed Hegazy
e3b764c914 Update authors for release 3.0 2018-07-10 23:40:23 -07:00
Andy
8a559e4630
Improve isNewFile assert (#25419) 2018-07-10 16:57:01 -07:00
Andy
5e2102799b
Reduce non-null assertions in getPropertySymbolsFromContextualType (#24675) 2018-07-10 16:53:08 -07:00
Andy
7a79a45aab
JSX closing tag completion: Include '>' if not already present (#25551)
* JSX closing tag completion: Include '>' if not already present

* Expand comment
2018-07-10 16:14:57 -07:00
Sheetal Nandi
527093c758
Merge pull request #25566 from Microsoft/nonCommonJsResolveJsonIsError
Report errors for module generation other than "commonjs" with --resolveJsonModule
2018-07-10 15:30:23 -07:00
Sheetal Nandi
c50407e01f
Merge pull request #25464 from Microsoft/cacheRecursiveDirectoryWatchers
Caches the recursive directory watchers so we do not have to traverse and recreate more children watches
2018-07-10 15:30:03 -07:00
Sheetal Nandi
4dc3cd3773 Use getEmitModuleKind to check module generation kind 2018-07-10 15:28:21 -07:00
Sheetal Nandi
821ebcb529 Merge branch 'master' into cacheRecursiveDirectoryWatchers 2018-07-10 15:08:14 -07:00
Sheetal Nandi
3866a5048b Report errors for module generation other than "commonjs" with --resolveJsonModule
Fixes #25517
2018-07-10 15:00:46 -07:00
Ron Buckton
a9771e3940
Merge pull request #25556 from Microsoft/buildScriptUpdates
Build script updates
2018-07-10 14:45:16 -07:00
Andy
b6640e9c5d
getJsxClosingTagAtPosition: Return a result if parent has same name and is unclosed (#25557) 2018-07-10 14:31:18 -07:00
Daniel Rosenwasser
3dd1d25e07
Merge pull request #25520 from Microsoft/internalizeNonexistentHelpers
Make getSuggestion APIs internal.
2018-07-10 13:47:05 -07:00
Klaus Meinhardt
f9eb976319 handle multiple prologue directives
Fixes: #24689
2018-07-10 22:42:21 +02:00