Commit graph

18888 commits

Author SHA1 Message Date
Sheetal Nandi c425128075 When getting default project from session, get it only if the script info is not orphan
Since the closed script info's that are orphan arent removed immediately but on next open request, treat the orphan script infos as if they are not present in the session
2017-08-18 13:13:12 -07:00
Sheetal Nandi da0d374b30 Made updates to not expose methods/types that arent needed. 2017-08-18 11:55:47 -07:00
Sheetal Nandi 594482d2c9 Merge branch 'master' into watchImprovements 2017-08-11 20:13:15 -07:00
Sheetal Nandi 8db05c2d85 More work on PR feedback update 2017-08-11 16:37:47 -07:00
Sheetal Nandi b071a8610c More work on feedback from PR 2017-08-11 16:10:56 -07:00
Ron Buckton 360dc914c3 Merge pull request #17602 from Microsoft/multiInferredProjects
Adds support for inferred project isolation by projectRootPath
2017-08-11 16:06:49 -07:00
Ron Buckton c272c3c5cd Comment update 2017-08-11 16:06:24 -07:00
Ron Buckton 95ee9aef0f Merge pull request #17750 from Microsoft/importFixInferQuote
Add support to infer the quote style for import code fix
2017-08-11 15:52:38 -07:00
Ron Buckton 09487b8a1d Added tests, pr feedback 2017-08-11 15:31:09 -07:00
Sheetal Nandi f723beb244 More updates per PR feedback 2017-08-11 15:06:26 -07:00
Ron Buckton e3b6df64b3 Add support to infer the quote style for import quick fixes 2017-08-11 14:26:25 -07:00
Yui d352e3b03f [Master] fix 16407 - LS in binding element of object binding pattern (#16534)
* wip-try get symbol of bindingelement in objectBindingPattern first

* Add fourslash tests

* Update .types baselines

* Update .symbols baselines

* Revert checker changes

* Actually lookup type for binding property name definition

* More succinct check, clarify yui's comment
2017-08-11 11:14:59 -07:00
Wesley Wigham c92deef6ec Fix runtests-browser with latest node (#17735)
* Fixes for running tests in the browser with the latest node

* Make memoize safe

* Integrate PR feedback, require key func on memoize
2017-08-11 10:58:38 -07:00
Ryan Cavanaugh c110ecb870 Merge pull request #17625 from RyanCavanaugh/extract-method-2
Extract Method
2017-08-11 10:54:48 -07:00
Andy f64b8ad902 Add "preserveSymlinks" option (#16661)
* Add "preserveSymlinks" option

* Respond to PR comments
2017-08-11 10:03:21 -07:00
Andy b3f3f336ad Use hasModifier and hasModifiers helper functions (#17724) 2017-08-11 07:15:15 -07:00
Ron Buckton b031777566 PR Feedback 2017-08-10 17:43:22 -07:00
Ryan Cavanaugh 8a92315171 Merge 2017-08-10 17:05:45 -07:00
Ryan Cavanaugh c27ee81341 Merge branch 'master' into extract-method-2 2017-08-10 17:02:14 -07:00
Ryan Cavanaugh 24de14a9be Use isReadonlyArray 2017-08-10 16:40:08 -07:00
Ryan Cavanaugh db37cea0b6 Use the function stack! 2017-08-10 16:38:24 -07:00
Ryan Cavanaugh a04633c22c Style fixes 2017-08-10 16:35:32 -07:00
Ryan Cavanaugh f957429efd Style fixups 2017-08-10 16:23:17 -07:00
Wesley Wigham a6a27ab661 Do not inline sourcemaps in jake - source-map-support can't handle it (#17732)
* Do not inline sourcemaps - sourcemap support cant handle it

* Run gulp silently
2017-08-10 14:34:04 -07:00
Ryan Cavanaugh 1ad411e13e Various fixes 2017-08-10 13:13:18 -07:00
Ryan Cavanaugh 12403d9f70 Various fixes 2017-08-10 13:07:42 -07:00
Andy 08fbcd8b80 Fix many no-object-literal-type-assertion lint errors (#17278)
* Fix many no-object-literal-type-assertion lint errors

* Simple fixes

* Use a union for FlowNode

* PR feedback and remove remaining `id()` uses

* Use a union for CodeBlock

* Discriminate CodeBlock by CodeBlockKind
2017-08-10 12:52:15 -07:00
Sheetal Nandi 02b8a7de65 More work on PR feedback 2017-08-10 12:40:31 -07:00
Sheetal Nandi 27988bf33a More updates based on PR feedback 2017-08-10 11:19:15 -07:00
Andy fe3a05e89a A function should be context-sensitive if its return expression is (#17697)
* A function should be context-sensitive if its return expression is

* Remove outdated comment

* Fix typo
2017-08-10 07:08:24 -07:00
Andy 4c824505ad Treat NoSubstitutionTemplateLiteral same as a StringLiteral (#17704) 2017-08-10 06:53:48 -07:00
Andy 2c4361aadf Simplify assignTypeToParameterAndFixTypeParameters (#17706) 2017-08-10 06:51:50 -07:00
Wesley Wigham 8fde483393 Add test for #16144 (#17712) 2017-08-10 00:10:36 -07:00
Wesley Wigham 4828c7a62b Lower RWC Harness Memory Overhead (#17692)
* Allow original compilation to be freed before checking declarations

* Use string concatenation in error baseline

* Fix lints

* No ternary
2017-08-09 16:16:16 -07:00
Nathan Shively-Sanders 9be0f1b034 Merge pull request #17708 from Microsoft/fix-type-predicate-index-in-errors
Fix type predicate index in error reporting
2017-08-09 16:12:46 -07:00
Nathan Shively-Sanders a59f77ffb4 Test:type predicate uses correct index to report errors 2017-08-09 15:45:28 -07:00
Nathan Shively-Sanders 8ae7c6c227 Fix type predicate index in error reporting
Previously type predicate error checking didn't take the `this`
parameter into account when checking for errors. This led to spurious
errors. Note that it's not feasible to change the initial value of
`parameterIndex` because several checks refer to the original
declaration, for example to make sure that a type predicate doesn't
refer to a rest parameter.
2017-08-09 15:43:47 -07:00
Andy e1ba65ae64 Add simple version of chooseOverload for common case of single non-generic signature (#17589)
* Add simple version of `chooseOverload` for common case of single non-generic signature

* Use a single function
2017-08-09 14:41:38 -07:00
Andy 37b20ee670 For duplicate source files of the same package, make one redirect to the other (#16274)
* For duplicate source files of the same package, make one redirect to the other

* Add reuseProgramStructure tests

* Copy `sourceFileToPackageId` and `isSourceFileTargetOfRedirect` only if we completely reuse old structure

* Use fallthrough instead of early exit from loop

* Use a set to efficiently detect duplicate package names

* Move map setting outside of createRedirectSourceFile

* Correctly handle seenPackageNames set

* sourceFileToPackageId -> sourceFileToPackageName

* Renames

* Respond to PR comments

* Fix bug where `oldSourceFile !== newSourceFile` because oldSourceFile was a redirect

* Clean up redirectInfo

* Respond to PR comments
2017-08-09 14:39:06 -07:00
Andy 17a6f7b56a Remove unused internal utilities (#17380)
* Remove unused internal utilities

* Handle undefined input to `mapDefined`
2017-08-09 14:37:59 -07:00
Wesley Wigham a6f37f55e4 Add a leading space on binary operator token trailing comments (#17691)
* Add a leading space on token trailing comments

* Demystify comment
2017-08-09 14:27:37 -07:00
Andy f28f5fd041 Don't check function expression grammar if this is SkipContextSensitive (#17698) 2017-08-09 14:09:52 -07:00
Wesley Wigham 6221d7089e Fix import addition location (#17327)
* Add test with bug

* Fix for import placement

* Consolidate comment recognition functions into utilities

* Add another test with all 3 kinds

* Recognize path directives as part of triple slash directives

* Also handle no-default-lib triple-slash comments

* Test for all the triple-slash kinds

* Keep import-placement logic in the quickfix, since its not really a node start; accept new baselines

* Work in not-ES6, use a real no-lib comment

* Remove no default lib triple slash comment, it disables checking and thereby quick fixes

* Copy regex rather than have a regex copy
2017-08-09 14:03:37 -07:00
Nathan Shively-Sanders 445cc8df79 Merge pull request #17261 from unional/patch-2
Update es5.d.ts
2017-08-09 14:02:32 -07:00
Andy e73d58e21c findAllReferences: Type parameter is not globally visible (#16419)
* findAllReferences: Type parameter is not globally visible

* Add test for merged interface

* Clean up comment
2017-08-09 13:53:54 -07:00
Yui 39e0cc61a7 Fix 16628: "undefined" exception when name of binding element in binding pattern is empty (#17132)
* Handle the case where binding pattern name element is empty

* Update tests and baselines

* Feedback from PR

* Handle empty binding patterns more generally in emitter

* Dont simply handling fo empty binding patterns and stay spec compliant

* PR feedback
2017-08-09 13:47:44 -07:00
Andy f124e19971 Session: don't return undefined if a response is required (#17165)
* Session: don't return undefined if a response is required

* Use ReadonlyArray and emptyArray

* Remove inferred return type
2017-08-09 13:46:47 -07:00
Andy b8c37bb50c Inline childFromLineNumber and childFromCharOffset (#17018)
* Inline childFromLineNumber and childFromCharOffset

* Handle empty document -- root node with 0 children

* Fix test
2017-08-09 13:43:25 -07:00
Andy bd68122821 scriptVersionCache: Export less (#17202)
* scriptVersionCache: Export less

* Remove LineIndexForTest, use LineIndex

* Add /* @internal */ to class LineIndex

* Make CharRangeSelection a const enum
2017-08-09 10:59:10 -07:00
Wesley Wigham c399230767 Retain comments inside return statements (#17557)
* Retain comments inside return statements by including the return keyword in the parse tree

* Revert "Retain comments inside return statements by including the return keyword in the parse tree"

This reverts commit 5d2142edb1.

* Readd test

* Function for handling printing comments on a token
2017-08-08 19:53:53 -07:00