Commit graph

23301 commits

Author SHA1 Message Date
csigs ea2bc4c014
LEGO: Merge pull request 24157
LEGO: Merge pull request 24157
2018-05-15 23:39:14 -07:00
csigs c52b069922 LEGO: check in for master to temporary branch. 2018-05-16 06:38:51 +00:00
Andy b4ca23d8f9
Fix bug: Converting 'module.exports = {...}' to ES6 doesn't introduce a default export (#24141) 2018-05-15 16:22:58 -07:00
Andy 2200c94a43
Fix unused diagnostic for rename-destructuring { a: b } (#24145) 2018-05-15 16:22:13 -07:00
Andy d4a3c9c61a
Fix placement of indent for @ts-ignore comment (#24143) 2018-05-15 16:21:15 -07:00
Nathan Shively-Sanders 339a56fbf0
Avoid duplicates when finding jsdoc (#24086)
* Avoid duplicates when finding jsdoc

1. Add a cheap assert for detecting duplicates. getJSDocTags must find
either [1] 0 or 1 comments or [2] the first two comments must not be
identical. This does not always find duplicates for nodes with 3 or more
comments, but these nodes are exceptionally rare.

This assert fired for over 20 of the around 250 tests we have that
retrieve JSDoc at all. So I fixed the asserts in [2] and [3].

2. There were overlapping cases from calls to getSourceOfAssignment and
getSpecialPropertyAssignment. getSpecialPropertyAssignment is too
restrictive, but was in the correct location (parent vs parent.parent),
so I removed the getSourceOfAssignment call and replaced the
getSpecialPropertyAssignment calls with a less restrictive check.

3. When a node's parent is a PropertyDeclaration,
getJSDocCOmmentsAndTags would check the parent for jsdoc. But when the
*node* is a PropertyDeclaration, getJSDocCommentsAndTags would use the
jsdoc from the initializer. This second case is useful to make sure that
property declarations get all their jsdoc, but results in duplicates for
their initializers. I couldn't think of a better fix than tracking the
previous node in the recursive lookup of getJSDocCommentsAndTags, which
is a little clunky.

* Fix lint; remove new context parameter

* Update importJsNodeModule3 with fix
2018-05-15 15:12:29 -07:00
Sheetal Nandi 77168e5d50
Merge pull request #24112 from Microsoft/packageJsonWithMainInSubDirectory
Resolve using package json's "main" field when resolving typescript extensions
2018-05-15 14:18:27 -07:00
Andy cbbe34b35e
Fix conversion of TextChanges to FileCodeEdits for new file (#24126) 2018-05-15 13:55:26 -07:00
Wesley Wigham 86dce41ec0
Move synthetic comments from arrow body expressions to return statement (#24135) 2018-05-15 13:11:38 -07:00
Mohamed Hegazy 9484653657
Merge pull request #24114 from Microsoft/inspectorToModules
Inspector to modules
2018-05-15 12:59:42 -07:00
Nathan Shively-Sanders 0ba8998c82
Fix stack overflow in merge symbol (#24134)
* JS initializers use original valueDecl, not mutated

target's valueDeclaration is set to the source's if it is not present.
This makes it incorrect to use getJSInitializerSymbol because it relies
on the symbol's valueDeclaration.

This fix just saves the original valueDeclaration before mutating and
uses that.

* Compare merged targetInitializer to target

Instead of the unmerged one

* Add test of stack overflow
2018-05-15 12:49:54 -07:00
Andy 7e515af240
Copy allowTextChangesInNewFiles property to protocol.ts (#24127) 2018-05-15 12:35:08 -07:00
Andy e1f22ac568
Combine signatureHelp testing methods (#24132) 2018-05-15 12:34:53 -07:00
Wesley Wigham 5756ae1fd8
External runner fixes (#24115)
* Add missing @types/node dep to so many projects, rename parent node_modules dirs so they dont participate in tests, sort errors

* Accept new baselines

* Satisfy linter
2018-05-15 11:15:08 -07:00
Ryan Cavanaugh 2ca0792976
Merge pull request #24074 from RyanCavanaugh/splitTransparentGoToDef
Return mapped locations in alternate fields
2018-05-16 05:39:51 +12:00
Ryan Cavanaugh f01338fa33 Comments/naming 2018-05-14 18:27:21 -07:00
Mohamed Hegazy b8c2eca8b3 Reorder, add "http2", "async-hooks" and "perf_hooks" 2018-05-14 15:37:11 -07:00
Mohamed Hegazy 6baaddc4f0 Add 'inspector' to known node modules 2018-05-14 15:22:24 -07:00
Sheetal Nandi dc50fe5e40 Apart from typing, use main field in package json to resolve typescript files
Fixes #23502
2018-05-14 14:52:11 -07:00
Sheetal Nandi 22d5b0e19f Do not remove extension js or jsx from the subModuleName if the subModule doesnt have js or jsx extension 2018-05-14 14:21:08 -07:00
Sheetal Nandi 7be85958a1 Add test for module resolution with package json containing main field referencing js file in sub directory 2018-05-14 13:06:34 -07:00
Wesley Wigham ba4bf21ead
Cache simplified indexed accesses to better handle circularly constrained indexed acceses (#24072) 2018-05-14 12:54:26 -07:00
Andy 7e3af08a09
Don't add a suggestion to convert to an es6 module if no commonjs import/export appears at top-level. (#24101) 2018-05-14 12:00:40 -07:00
Andy 9b6378b938
Use SHA256 hash for project info telemetry (#24099)
* Use SHA256 hash for project info telemetry

* Update API baselines
2018-05-14 11:32:16 -07:00
Wesley Wigham b58e4e1fa1
Reduce aggression of parenthesis removal in ts transform (#24073) 2018-05-14 11:20:04 -07:00
Ryan Cavanaugh 64b1c23a9b Push through original mapping location 2018-05-14 10:54:40 -07:00
Wesley Wigham 560371d7a0
Alter basic auth strategy 2018-05-14 10:27:13 -07:00
Ryan Cavanaugh 86145eedb1 Update API baselines 2018-05-14 09:58:32 -07:00
Ron Buckton 672d8e5e9d
Merge pull request #24076 from Microsoft/fix24006
Cut back on more 'caught exceptions' from vfs
2018-05-14 09:24:26 -07:00
Ron Buckton dd520f9a16
Merge pull request #24078 from Microsoft/fix24014
Fix async generator rejection handling
2018-05-14 09:23:43 -07:00
csigs 6148e73112
LEGO: Merge pull request 24097
LEGO: Merge pull request 24097
2018-05-14 09:10:49 -07:00
csigs d470b0228a LEGO: check in for master to temporary branch. 2018-05-14 16:10:27 +00:00
Wesley Wigham 8a0aa99327
Inject token into push like vsts does 2018-05-14 08:39:32 -07:00
Ron Buckton f5281d62cc Fix async generator rejection handling 2018-05-12 02:07:31 -07:00
csigs d990f294f8
LEGO: Merge pull request 24077
LEGO: Merge pull request 24077
2018-05-11 21:10:49 -07:00
csigs 8a63a8caa4 LEGO: check in for master to temporary branch. 2018-05-12 04:10:28 +00:00
Ron Buckton 70b6bd95c3 Cut back on more 'caught exceptions' from vfs 2018-05-11 20:44:21 -07:00
Ryan Cavanaugh 69f73eba16 Return mapped locations in alternate fields 2018-05-11 17:22:10 -07:00
Nathan Shively-Sanders dfef2fa9a2
Add another test of js special assignment merging (#24070) 2018-05-11 16:24:42 -07:00
Armando Aguirre 5cc833a5f5
Merge pull request #24049 from armanio123/AddDeferredToProjectTelemetry
Add deferred to project telemetry
2018-05-11 13:07:32 -07:00
Mohamed Hegazy b0c67fd023
Merge pull request #24056 from a-tarasyuk/bug/23891-declarationDir-needs-to-be-handled-in-excludeSpecs
Add declarationDir to excludeSpec
2018-05-11 12:56:15 -07:00
Alexader 60d39d7f18 add tests 2018-05-11 21:27:40 +03:00
Mohamed Hegazy cc36cfc834
Merge pull request #24050 from Microsoft/fix-js-initializer-merging
Fix js initializer merging
2018-05-11 10:45:20 -07:00
Nathan Shively-Sanders 2792ff97dd Add fourslash test case 2018-05-11 09:51:12 -07:00
Nathan Shively-Sanders de9ff1b004 Assert:only merge into transient symbols 2018-05-11 09:12:25 -07:00
csigs bdc0a3e3cd
LEGO: Merge pull request 24061
LEGO: Merge pull request 24061
2018-05-11 09:11:36 -07:00
csigs d75d6426d0 LEGO: check in for master to temporary branch. 2018-05-11 16:10:55 +00:00
Alexander T bb615ac3f9 Add declarationDir to excludeSpec 2018-05-11 13:47:44 +03:00
csigs 3f6a8e5fb7
LEGO: Merge pull request 24055
LEGO: Merge pull request 24055
2018-05-11 03:11:02 -07:00
csigs 82fd6b6cfa LEGO: check in for master to temporary branch. 2018-05-11 10:10:42 +00:00