Commit graph

19191 commits

Author SHA1 Message Date
Wesley Wigham eb80799ef0 Care about esnext where we look for es2015 (#18331)
* Care about esnext where we look for es2015

* Update diagnostic message to be more agnostic
2017-09-09 16:30:06 -07:00
Wesley Wigham dc8d47c51d Remove bisect.cmd, remove reference to missing dts, update usage (#18353) 2017-09-09 15:56:11 -07:00
Andy e51e91dd2c Change wording of scope description (#18342) 2017-09-09 05:52:52 -07:00
Andy 018c645913 In import code fix, don't treat a re-export as an import (#18341) 2017-09-09 05:52:08 -07:00
Andy 409d6597eb Add never helper function (#18287)
* Add `never` helper function

* Move to Debug.assertNever, keep old messages
2017-09-08 14:22:44 -07:00
Andrew Casey deefb01c9d Merge pull request #18165 from amcasey/GH18144
Simplify and correct PermittedJumps computation
2017-09-08 10:50:05 -07:00
Nathan Shively-Sanders d4e3e19763 Merge pull request #18333 from Microsoft/fix-forEachChild-JSDocTypedefTag
Fix forEachChild jsdoc `@typedef` tag
2017-09-08 08:52:46 -07:00
Nathan Shively-Sanders cab05ddd3f Inline variable to aid control flow 2017-09-08 08:33:17 -07:00
Andy 4ee7d3aeb2 Remove unnecessary check in emitNodeList (#18327) 2017-09-08 07:18:37 -07:00
Nathan Shively-Sanders 7d5b5e957e Update baselines 2017-09-07 16:38:17 -07:00
Nathan Shively-Sanders fb5e8c6110 Fix forEachChild's visit of JSDocTypedefTag
Also remove JSDocTypeLiteral.jsdocTypeTag, which made no sense since it
was only useful when storing information for its parent `@typedef` tag.
2017-09-07 16:37:13 -07:00
Andrew Casey 02cfb81ac0 Merge pull request #18164 from amcasey/GH18140
Handle the combination of a write and a void return
2017-09-07 16:32:55 -07:00
Nathan Shively-Sanders 7aac67b9b4 Test: parsing of two-line @typedef jsdoc 2017-09-07 16:22:16 -07:00
Andrew Casey baefdd2ccb Revert "Make permittedJumps a parameter to eliminate save-restore pattern"
This reverts commit 57906fe90e8efd2fb285fcb67f018c0438ba06dd.
2017-09-07 16:22:12 -07:00
Andrew Casey 73bc0c9796 Correct copied comment 2017-09-07 16:22:09 -07:00
Andrew Casey e3808b65d4 Simplify and correct PermittedJumps computation
1. It was looking at the parent which wasn't guaranteed to be in the
extracted range.
2. It was checking direct, rather than indirect containment - apparently
to avoid applying the rules to certain expressions (which can't contain
jumps anyway, unless they're in anonymous functions, in which case
they're fine).

Fixes #18144
2017-09-07 16:21:20 -07:00
Andrew Casey a81fa7a801 Make permittedJumps a parameter to eliminate save-restore pattern 2017-09-07 16:13:27 -07:00
Andrew Casey 9d11fbb9b9 Correct permitted jumps check 2017-09-07 16:13:26 -07:00
Wesley Wigham 27f9cdb1ae Explicitly avoid canonicalizing paths during configuration handling (#18316)
* Explicitly avoid canonicalizing paths during configuration handling

* Extract usage of identity in commandLineParser into single function, use identity in checker
2017-09-07 15:54:24 -07:00
Andrew Casey 0e50da62c4 Handle the combination of a write and a void return
When the return type is void, there's no `returnValueProperty`, but that
doesn't mean we don't need a `return` at the call site.

Fixes #18140.
2017-09-07 14:43:02 -07:00
Andy 2e02778960 When loading a module from node_modules, get packageId even in the loadModuleFromFile case (#18185)
* When loading a module from node_modules, get packageId even in the `loadModuleFromFile` case

* Support packageId for <reference types> too
2017-09-07 14:31:20 -07:00
Andy ed4e2e6e3b Ensure that emitter calls callbacks (#18284)
* Ensure that emitter calls calbacks

* Move new parameter to end of parameters

* Fix for ConditionalExpression

* Make suggested changes to emitter

* Fix parameter ordering

* Respond to minor comments

* Remove potentially expensive assertion

* More emitter cleanup
2017-09-07 14:30:19 -07:00
Anders Hejlsberg 8c64937888 Merge pull request #18153 from Microsoft/optimizeArrays
Optimize array operations to reduce memory footprint
2017-09-07 22:26:48 +01:00
Andrew Casey 9e30642127 Merge pull request #18315 from amcasey/TIDisabledProjects
Don't get typings for projects with disabled language services
2017-09-07 14:19:25 -07:00
Nathan Shively-Sanders 2bc9ecb4fd Merge pull request #18296 from Microsoft/disable-lookahead-isStartOfParameter
Disable isStartOfType's lookahead when called from isStartOfParameter
2017-09-07 13:57:28 -07:00
Nathan Shively-Sanders 397ff84f1a Merge pull request #18317 from Microsoft/object-literal-enum-property-names
Object literals computed property names allow literal-typed expressions
2017-09-07 13:56:10 -07:00
Wesley Wigham 1b5a0aed93 Update pretty baseline changed by #17675 (#18320) 2017-09-07 12:47:09 -07:00
Andy 508cde0ea1 Document assignment to aliasSymbol in getUnionTypeFromSortedList (#17434)
* Document assignment to aliasSymbol in getUnionTypeFromSortedList

* Update wording
2017-09-07 12:39:13 -07:00
Daniel Rosenwasser 448d75c08f Merge pull request #17675 from HerringtonDarkholme/master
fix #16567: better coloring on light theme terminal
2017-09-07 12:33:12 -07:00
Wesley Wigham 6695255d86 Allow trailing newline to have fake position (#18298)
* Actually support baselining pretty in the harness

* Test case from 18216

* Use host newline in formatDiagnosticsWithColorAndContext

* Merge statements
2017-09-07 12:26:23 -07:00
Mohamed Hegazy b29e0c9e3a Update README.md 2017-09-07 12:21:33 -07:00
Zeeshan Ahmed de940af23b Update README.md (#17714) 2017-09-07 12:20:56 -07:00
Stas Vilchik 727facb55c fix initialization of shouldCreateNewSourceFiles (#17686) 2017-09-07 12:15:28 -07:00
Nathan Shively-Sanders 3c5b2a5e9d Test Literal-typed computed property names in obj literals 2017-09-07 11:41:13 -07:00
Nathan Shively-Sanders ac58751b62 Object literals computed property names allow literal-typed expressions 2017-09-07 11:30:38 -07:00
Andrew Casey 097b094082 Don't get typings for projects with disabled language services 2017-09-07 11:10:12 -07:00
Andrew Casey 8d1eb29fb1 Merge pull request #18265 from amcasey/ThrottledOperations
Limit the number of unanswered Typings Installer requests
2017-09-07 11:01:27 -07:00
Alex Chugaev de313ff1bd Object.getOwnPropertyDescriptor() returns 'undefined' if property descriptor not found. (#18148) 2017-09-07 10:58:05 -07:00
Wesley Wigham c1f2afd645 Add typedef declaration space, unify typedef name gathering (#18172)
* Add typedef declaration space, unify typedef name gathering, strengthen errorUnusedLocal

* Bonus round: make jsdoc presence way mroe typesafe

* Be exhaustive in nameForNamelessJSDocTypedef

* Remove nonrequired casts

* Replace more casts with guards

* Cannot be internal

* Debug.fail returns never, assert never no longer needs unreachable throw to satisfy checker

* Rename type

* Add replacement message as in 18287
2017-09-07 10:28:58 -07:00
Wesley Wigham 39d0590869
Adds comment 2017-09-07 09:54:50 -07:00
Klaus Meinhardt 69933bd4d1 expose isExternalModuleNameRelative and moduleHasNonRelativeName (#17971)
* expose isExternalModuleNameRelative and moduleHasNonRelativeName

Fixes: #17890

* only expose isExternalModuleNameRelative
2017-09-07 09:46:58 -07:00
Mohamed Hegazy c82881f36e Fix build break 2017-09-07 09:36:31 -07:00
Klaus Meinhardt a8dfdf2fa1 Add and fix some AST Node parent types (#18200) 2017-09-07 09:22:26 -07:00
Adrian Leonhard 7b12b79558 ts.server.ProjectService.closeConfiguredProject returns true on success. (#18180)
Fixes #17892
The if condition around the return value of that method in closeExternalProject indicates that this was the expected behavior.
2017-09-07 09:17:47 -07:00
Taras Mankovski 59aa29b854 Added only the source file (#18175) 2017-09-07 09:15:07 -07:00
Andy 193f4be355 Enable interface-over-type-literal lint rule (#17733) 2017-09-07 09:14:59 -07:00
Andy be0633825c Don't provide string literal completions for string enums (#18288)
* Don't provide string literal completions for string enums

* Rename test
2017-09-07 09:13:46 -07:00
Nathan Shively-Sanders 90d9f3d4ba Rename isStartOfType parameter used by isStartOfParameter 2017-09-07 09:07:59 -07:00
Nathan Shively-Sanders b84e6bc188 Merge pull request #18096 from Microsoft/fix-codefix-jsdoc-variablelike-decls
Fix the jsdoc codefix for VariableLike declarations
2017-09-07 08:11:19 -07:00
Andy 7541c705bf Support navTo for special assignment kinds (#18154)
* Support navTo for special assignment kinds

* Return ScriptElementKind.unknown
2017-09-07 07:45:11 -07:00