Armando Aguirre
fd50f1e3c9
Merge pull request #41543 from a-tarasyuk/fix/41534
...
fix(41534): Maximum call stack error while computing document symbol file
2020-12-01 18:03:11 -08:00
Ron Buckton
e012417471
Merge pull request #37283 from JoshuaKGoldberg/extends-constructor-typeerror
...
Added runtime TypeError for non-function, non-null __extends
2020-12-01 17:43:25 -08:00
Josh Goldberg
943b350f8d
Used String on base class per suggestion
2020-12-01 19:03:49 -05:00
Josh Goldberg
5bc0002450
...except for the small master merge slipups
2020-12-01 18:53:54 -05:00
Josh Goldberg
f55ba77297
Merge branch 'master'
2020-12-01 18:51:46 -05:00
Wenlu Wang
55810095f4
Allow qualified name for convert namespace import ( #41592 )
2020-12-01 15:23:57 -08:00
Wesley Wigham
0da5a7e4ba
Add missing BinaryExpression source side cases to isMatchingReference ( #41765 )
2020-12-01 14:47:14 -08:00
Anders Hejlsberg
4d6947ae14
Check nested conditional types for non-distributiveness in mapped types with 'as' clauses ( #41713 )
...
* Check nested conditional types for non-distributiveness
* Rename to maybeNonDistributiveNameType
* Add regression test
2020-12-01 12:07:47 -10:00
Anders Hejlsberg
4782c74b75
Propagate wildcard types in non-homomorphic mapped types ( #41622 )
...
* Propagate wildcard types in non-homomorphic mapped types
* Add regression test
* Accept new baselines
* Accept new baselines
2020-12-01 11:57:00 -10:00
inokawa
d57954345b
Fix typos ( #41723 )
2020-12-01 13:46:41 -08:00
Wesley Wigham
2a3f5508ec
addImplementationSuccessElaboration admits declarations with no symbol ( #41758 )
2020-12-01 12:19:12 -08:00
TypeScript Bot
d0c28ab0c2
Update package-lock.json
2020-12-01 06:22:02 +00:00
Keen Yee Liau
cf4df4e472
fix(41736): tsserver should not crash if external file does not exist ( #41737 )
...
If a file does not exist, `projectService.getOrCreateScriptInfoNotOpenedByClient()`
will return `undefined`, but tsserver does not handle this case.
Fix https://github.com/microsoft/TypeScript/issues/41736
2020-11-30 16:37:40 -08:00
Toan Nguyen
0c76803854
Fix typos in comments ( #41307 )
...
* Fix typo fuction -> function
* Fix typo assignement -> assignment
2020-11-30 15:02:07 -08:00
Andrew Branch
5a8186f86d
Produce source maps for local typescriptServices build ( #41589 )
...
* Enable source maps for typescriptServices local builds
* Alias gulp lkg -> gulp LKG
2020-11-30 14:28:13 -08:00
Nathan Shively-Sanders
06fb724cd1
Improve uncalled function checks ( #41599 )
...
Fixes #41586
Fixes #41588
1. For binary expressions, if the immediate parent is an IfStatement,
then check the body of the if statement. I didn't walk upward to find an
IfStatement because in my experimentation I found that binary expression
uncalled-function errors are only issued when the expression is on the left of the
top-most binary expression.
2. For property accesses with interspersed calls, I added a
CallExpression case. In fact, any expression could appear here, but I
only want to fix calls for now since that's all we've observed in
Definitely Typed, and we didn't see anything else in the user tests or RWC
tests. I also didn't examine parameters of the intermediate call
expressions, but I don't think it's needed since the intent is to avoid
false positives.
2020-11-30 14:27:19 -08:00
Oleksandr T
23b3eb685f
fix(41621): fixUnusedIdentifier - allow deleting prefix/postfix unary operators ( #41624 )
2020-11-30 13:58:47 -08:00
Oleksandr T
1bd8e388ae
fix(41688): completions with infer keyword ( #41704 )
2020-11-30 11:56:12 -08:00
TypeScript Bot
ee57040276
Update package-lock.json
2020-11-27 06:21:31 +00:00
Anders Hejlsberg
411c6d04c6
Fix getTypeFacts for pattern template literal types ( #41693 )
...
* Normalize `${string}` to just string, fix getTypeFacts
* Add tests
* Accept new baselines
2020-11-26 06:55:01 -10:00
TypeScript Bot
d616d8fc11
Update package-lock.json
2020-11-26 06:21:13 +00:00
Anders Hejlsberg
ec1490fb44
Properly cache types for shared control flow nodes ( #41665 )
...
* Properly cache shared flow node types
* Add test
2020-11-25 14:51:38 -10:00
Song Gao
d5779c75d3
replace whole path if directory separator appears for import completion. ( #41412 )
...
* replace whole path if directory separator appears.
* Fix.
* revert change.
* Fix test case.
* add test.
* fix as suggested.
* revert useless change
* adapt to code change.
* fix baseline for test file.
2020-11-25 09:37:08 -08:00
Oleksandr T
242e0202cf
fix(41216): update baseline ( #41687 )
2020-11-25 09:11:42 -08:00
Andrew Branch
3fa30f4826
Remove obsolete go-to-definition code after CommonJS alias changes ( #41522 )
...
* Remove obsolete code
* Revert package-lock change
2020-11-25 09:01:56 -08:00
csigs
86429aae33
LEGO: Merge pull request 41678
...
LEGO: Merge pull request 41678
2020-11-24 16:11:30 -08:00
csigs
dbcbe9369d
LEGO: check in for master to temporary branch.
2020-11-25 00:11:00 +00:00
Oleksandr T
5adb55eb18
feat(41216): show JSDoc for aliases ( #41452 )
2020-11-24 14:40:51 -08:00
Andrew Casey
a6ebf5d79a
Trace checkDeferredNode to cover JSX elements ( #41572 )
2020-11-24 14:33:15 -08:00
Andrew Casey
4c8418ee19
Use stricter types for tracing event arguments ( #41217 )
...
* Use stricter types for tracing event arguments
In local development, I've routinely passed the wrong local and ended up
having JSON.stringify throw.
* Make the type recursive
Courtesy of @rbuckton
* Fix lint error
2020-11-24 14:33:00 -08:00
Oleksandr T
03877260f8
fix(41194): ignore jsxFrag identifier in import declarations ( #41441 )
2020-11-24 14:29:47 -08:00
csigs
d070acf29d
LEGO: Merge pull request 41673
...
LEGO: Merge pull request 41673
2020-11-24 10:11:17 -08:00
csigs
64702dee11
LEGO: check in for master to temporary branch.
2020-11-24 18:10:46 +00:00
csigs
72bb0eb0e6
LEGO: Merge pull request 41670
...
LEGO: Merge pull request 41670
2020-11-24 04:11:15 -08:00
csigs
0e2d8b4a5a
LEGO: check in for master to temporary branch.
2020-11-24 12:10:42 +00:00
Guerric Phalippou
d338c20c15
Add a comment to clarify the #private field ( #41547 )
...
* add a comment to clarify the #private field
* small fix
2020-11-23 22:34:27 -08:00
Oleksandr T
d163ab67c8
fix(41240): allow emitting numeric with underscored separators as-is in esnext target ( #41435 )
2020-11-23 17:01:42 -08:00
csigs
e60753339f
LEGO: Merge pull request 41661
...
LEGO: Merge pull request 41661
2020-11-23 16:11:22 -08:00
csigs
3328fda2ff
LEGO: check in for master to temporary branch.
2020-11-24 00:10:50 +00:00
Jean Pierre
71559a5c0c
Fix show deprecated suggestion for alias ( #41128 )
...
* Fix show deprecated suggestion for alias
* Fix failing tests
* Avoid duplicated kind modifiers
2020-11-23 15:50:12 -08:00
Andrew Casey
669305b914
Pass throwIfNoEntry to fs.statSync ( #41604 )
...
Future versions of node will be able to return undefined, rather than
allocating and throwing an exception, when a file is not found.
See https://github.com/nodejs/node/pull/33716
2020-11-23 12:43:00 -08:00
TypeScript Bot
54f8d38535
Update package-lock.json
2020-11-23 06:20:23 +00:00
Nathan Shively-Sanders
d057f7a992
Remove-unused-identifiers codefix skips assigned identifiers ( #41168 )
...
* Remove-all-unused-identifiers skips assigned identifiers
Previously, fixUnusedIdentifier worked the same in fix-all mode as for a
single fix: identifiers with assignments would be deleted:
```ts
function f(a) { }
f(1)
```
becomes
```ts
function f() { }
f()
```
But any kind of argument will be deleted, even one with side effects.
For a single codefix invocation, this is probably OK.
But for fix-all, this could lead to multiple changes
spread throughout a large file.
Now fix-all will only delete parameters and variable declarations with
no assignments:
```ts
function f(a) { }
function g(a) { }
f(1)
g
let x = 1
let y
```
becomes
```
function f(a) { }
function g() { }
f(1)
g
let x = 1
```
* Don't remove assigned parameters for single codefix either
* add optional parameter test case
* Skip initialised params and binding elements
Based on PR feedback from @amcasey
* fixAll removes unused binding patterns completely
* Fixes from comments
Thanks @amcasey for the thorough review
* fix trailing space lint
* correctly remove-all array binding
2020-11-21 09:57:17 -08:00
Daniel Rosenwasser
f4157b41db
Add an action to update baselines/fix lints ( #39898 )
...
* Add an action to update baselines/fix lints
* Change email
2020-11-20 16:03:58 -08:00
Andrew Casey
68925b66f4
Split line and node counts by file extension ( #39720 )
...
* Split line and node counts by file extension
Continue to show only a summary for --diagnostics.
* Use SourceFile.isDeclarationFile
2020-11-20 15:03:11 -08:00
Oleksandr T
9bcbca4e6c
fix(41534): fix children circular references
2020-11-20 22:41:12 +02:00
TypeScript Bot
eac0f6dc30
Update package-lock.json
2020-11-20 06:19:39 +00:00
Andrew Branch
308814f6fa
Update JSX test errors ( #41602 )
2020-11-19 16:38:08 -08:00
Martin Probst
6b04f50394
Do not parse template arguments in JavaScript files. ( #36673 )
...
Fixes #36662 .
2020-11-19 11:41:35 -08:00
Sheetal Nandi
2cc67ec0a6
If there are no open files, do not schedule ensureProjectForOpenFiles ( #41537 )
2020-11-18 16:10:11 -08:00