CFeeRate and CTxMemPoolEntry have explicitly defined copy ctors which has
the same functionality as the implicit default copy ctors which would
have been generated otherwise.
Besides being redundant, it violates the rule of three
(see https://en.wikipedia.org/wiki/Rule_of_three_(C%2B%2B_programming) ).
(Of course, the rule of three doesn't -really- cause a resource
management issue here, but the reason for that is exactly that there is
no need for an explicit copy ctor in the first place since no resources
are being managed).
CFeeRate has an explicitly defined copy ctor which has the same
functionality as the implicit default copy ctor which would have been
generated otherwise.
-----------------------------
Cherry-picked from: b426e2467
Note:
Solved conflict where upstream moved CFeeRate into ./policy/
whereas we still have it in amount.h/cpp on 1.14.
- Revert moving of ports and branching strategy because those are
actively preventing questions and PR difficulty
- Remove travis badge because we no longer use travis
- Fix formulation throughout the document
- Rewrite the contribution section
- Switch from Dogecoin devs twitter to Dogecoin twitter under
communities
- Add Q&A board to FAQ section
- Fix document language selector
- Bring tables back to "mining information"
Author: AbcSxyZ <rossi.sim@outlook.com>
Cherry-picked and squashed from:
20480d33b README: change social media position
39a209b98 README: Change section order
bdb727981 README: reorganize social medias, split dev specific
& and more community related in 2 sections
bbc6c921c Add emote to titles
e39256825 Install.md : Improve first title
ebef882c5 Fix typo
1cec6b16b Extract FAQ and INSTALL into respective files
314b6f8e2 Add developement & contribution information directly
on readme
a7e556924 Remove original block reward schedule
8cb73041a Move licence section at README bottom
without partially backporting a new testframework.
- Adds a condition to NodeConn that when asyncore calls handle_read
without any data, this must be a disconnect and closes the socket
- Adds a little loop in the p2p-acceptblock client that waits for
the socket to be in a closed state
- Makes expected disconnects non-optional in p2p-acceptblock
- Syncs the test descriptions and outputs with reality
