maxmustermann/godot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #52808 from AnilBK/simplify-logic

Browse source
This commit is contained in:
Rémi Verschelde 2021-09-22 14:08:19 +02:00 committed by GitHub
parent 08e455a1f6 c63d51408f
commit 0f48599ada
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
editor/editor_properties.cpp
View file

@ -901,7 +901,7 @@ public:
if (layer_index >= layer_count) { if (layer_index >= layer_count) {
if (!flag_rects.is_empty() && (expansion_rows == 0)) { if (!flag_rects.is_empty() && (expansion_rows == 0)) {
const Rect2 &last_rect = flag_rects[flag_rects.size() - 1]; const Rect2 &last_rect = flag_rects[flag_rects.size() - 1];
arrow_pos = last_rect.position + last_rect.size; arrow_pos = last_rect.get_end();
} }
break; break;
} }
@ -913,7 +913,7 @@ public:
// Keep last valid cell position for the expansion icon. // Keep last valid cell position for the expansion icon.
if (!flag_rects.is_empty() && (expansion_rows == 0)) { if (!flag_rects.is_empty() && (expansion_rows == 0)) {
const Rect2 &last_rect = flag_rects[flag_rects.size() - 1]; const Rect2 &last_rect = flag_rects[flag_rects.size() - 1];
arrow_pos = last_rect.position + last_rect.size; arrow_pos = last_rect.get_end();
} }
++expansion_rows; ++expansion_rows;

4
editor/editor_properties_array_dict.cpp
View file

@ -176,7 +176,7 @@ void EditorPropertyArray::_change_type(Object *p_button, int p_index) {
changing_type_index = p_index; changing_type_index = p_index;
Rect2 rect = button->get_screen_rect(); Rect2 rect = button->get_screen_rect();
change_type->set_as_minsize(); change_type->set_as_minsize();
change_type->set_position(rect.position + rect.size - Vector2(change_type->get_contents_minimum_size().x, 0)); change_type->set_position(rect.get_end() - Vector2(change_type->get_contents_minimum_size().x, 0));
change_type->popup(); change_type->popup();
} }
@ -726,7 +726,7 @@ void EditorPropertyDictionary::_change_type(Object *p_button, int p_index) {
Rect2 rect = button->get_screen_rect(); Rect2 rect = button->get_screen_rect();
change_type->set_as_minsize(); change_type->set_as_minsize();
change_type->set_position(rect.position + rect.size - Vector2(change_type->get_contents_minimum_size().x, 0)); change_type->set_position(rect.get_end() - Vector2(change_type->get_contents_minimum_size().x, 0));
change_type->popup(); change_type->popup();
changing_type_index = p_index; changing_type_index = p_index;
} }

2
editor/editor_resource_picker.cpp
View file

@ -145,7 +145,7 @@ void EditorResourcePicker::_update_menu() {
Rect2 gt = edit_button->get_screen_rect(); Rect2 gt = edit_button->get_screen_rect();
edit_menu->set_as_minsize(); edit_menu->set_as_minsize();
int ms = edit_menu->get_contents_minimum_size().width; int ms = edit_menu->get_contents_minimum_size().width;
Vector2 popup_pos = gt.position + gt.size - Vector2(ms, 0); Vector2 popup_pos = gt.get_end() - Vector2(ms, 0);
edit_menu->set_position(popup_pos); edit_menu->set_position(popup_pos);
edit_menu->popup(); edit_menu->popup();
} }

4
editor/plugins/texture_region_editor_plugin.cpp
View file

@ -344,7 +344,7 @@ void TextureRegionEditor::_region_input(const Ref<InputEvent> &p_input) {
r = obj_styleBox->get_region_rect(); r = obj_styleBox->get_region_rect();
} }
rect.expand_to(r.position); rect.expand_to(r.position);
rect.expand_to(r.position + r.size); rect.expand_to(r.get_end());
} }
undo_redo->create_action(TTR("Set Region Rect")); undo_redo->create_action(TTR("Set Region Rect"));
if (atlas_tex.is_valid()) { if (atlas_tex.is_valid()) {
@ -544,7 +544,7 @@ void TextureRegionEditor::_region_input(const Ref<InputEvent> &p_input) {
switch (drag_index) { switch (drag_index) {
case 0: { case 0: {
Vector2 p = rect_prev.position + rect_prev.size; Vector2 p = rect_prev.get_end();
rect = Rect2(p, Size2()); rect = Rect2(p, Size2());
rect.expand_to(new_pos); rect.expand_to(new_pos);
apply_rect(rect); apply_rect(rect);