maxmustermann/godot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #41662 from YeldhamDev/scriptdiag_invalid_path_enter

Browse source 
Fix being able to create invalid scripts by pressing enter inside "Path"
This commit is contained in:
Rémi Verschelde 2020-09-01 08:31:42 +02:00 committed by GitHub
parent 2cfc5b8680 fb17743ecc
commit 18b3bfec6b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
editor/script_create_dialog.cpp
View file

@ -722,6 +722,15 @@ void ScriptCreateDialog::_update_dialog() {
}
get_ok()->set_disabled(!script_ok);
Callable entered_call = callable_mp(this, &ScriptCreateDialog::_path_entered);
if (script_ok) {
if (!file_path->is_connected("text_entered", entered_call)) {
file_path->connect("text_entered", entered_call);
}
} else if (file_path->is_connected("text_entered", entered_call)) {
file_path->disconnect("text_entered", entered_call);
}
}
void ScriptCreateDialog::_bind_methods() {
@ -849,7 +858,6 @@ ScriptCreateDialog::ScriptCreateDialog() {
hb->connect("sort_children", callable_mp(this, &ScriptCreateDialog::_path_hbox_sorted));
file_path = memnew(LineEdit);
file_path->connect("text_changed", callable_mp(this, &ScriptCreateDialog::_path_changed));
file_path->connect("text_entered", callable_mp(this, &ScriptCreateDialog::_path_entered));
file_path->set_h_size_flags(Control::SIZE_EXPAND_FILL);
hb->add_child(file_path);
path_button = memnew(Button);