maxmustermann/godot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #44184 from madmiraal/xrcontroller-button_released

Browse source 
Rename XRController signal button_release to button_released
This commit is contained in:
Rémi Verschelde 2020-12-08 12:25:41 +01:00 committed by GitHub
parent d94bf9f7b6 58c38d957b
commit 1cf53ca90b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
doc/classes/XRController3D.xml
View file

@ -86,7 +86,7 @@
Emitted when a button on this controller is pressed.
</description>
</signal>
<signal name="button_release">
<signal name="button_released">
<argument index="0" name="button" type="int">
</argument>
<description>

4
scene/3d/xr_nodes.cpp
View file

@ -211,7 +211,7 @@ void XRController3D::_notification(int p_what) {
emit_signal("button_pressed", i);
button_states += mask;
} else if (was_pressed && !is_pressed) {
emit_signal("button_release", i);
emit_signal("button_released", i);
button_states -= mask;
};
@ -257,7 +257,7 @@ void XRController3D::_bind_methods() {
ClassDB::bind_method(D_METHOD("get_mesh"), &XRController3D::get_mesh);
ADD_SIGNAL(MethodInfo("button_pressed", PropertyInfo(Variant::INT, "button")));
ADD_SIGNAL(MethodInfo("button_release", PropertyInfo(Variant::INT, "button")));
ADD_SIGNAL(MethodInfo("button_released", PropertyInfo(Variant::INT, "button")));
ADD_SIGNAL(MethodInfo("mesh_updated", PropertyInfo(Variant::OBJECT, "mesh", PROPERTY_HINT_RESOURCE_TYPE, "Mesh")));
};