Merge pull request #53732 from Paulb23/text-file-save

Fix TextFiles not saving when closing the tab
This commit is contained in:
Rémi Verschelde 2021-10-12 22:12:44 +02:00 committed by GitHub
commit 322d2b2373
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -763,20 +763,24 @@ void ScriptEditor::_close_tab(int p_idx, bool p_save, bool p_history_back) {
ScriptEditorBase *current = Object::cast_to<ScriptEditorBase>(tselected);
if (current) {
Ref<Script> script = current->get_edited_resource();
if (p_save && script.is_valid()) {
RES file = current->get_edited_resource();
if (p_save && file.is_valid()) {
// Do not try to save internal scripts, but prompt to save in-memory
// scripts which are not saved to disk yet (have empty path).
if (script->get_path().find("local://") == -1 && script->get_path().find("::") == -1) {
if (file->get_path().find("local://") == -1 && file->get_path().find("::") == -1) {
save_current_script();
}
}
if (script.is_valid()) {
if (!script->get_path().is_empty()) {
if (file.is_valid()) {
if (!file->get_path().is_empty()) {
// Only saved scripts can be restored.
previous_scripts.push_back(script->get_path());
previous_scripts.push_back(file->get_path());
}
Ref<Script> script = file;
if (script.is_valid()) {
notify_script_close(script);
}
notify_script_close(script);
}
}