Merge pull request #21053 from akien-mga/doc-dialog_hide_on_ok

Doc: Clarify usage of dialog_hide_on_ok and caveat for FileDialog
This commit is contained in:
Rémi Verschelde 2018-08-15 20:29:56 +02:00 committed by GitHub
commit 3a6711f8d6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -60,7 +60,8 @@
</methods>
<members>
<member name="dialog_hide_on_ok" type="bool" setter="set_hide_on_ok" getter="get_hide_on_ok">
If [code]true[/code] the dialog is hidden when accepted. Default value: [code]true[/code].
If [code]true[/code] the dialog is hidden when the OK button is pressed. You can set it to [code]false[/code] if you want to do e.g. input validation when receiving the [signal confirmed] signal, and handle hiding the dialog in your own logic. Default value: [code]true[/code].
Note: Some nodes derived from this class can have a different default value, and potentially their own built-in logic overriding this setting. For example [FileDialog] defaults to [code]false[/code], and has its own input validation code that is called when you press OK, which eventually hides the dialog if the input is valid. As such this property can't be used in [FileDialog] to disable hiding the dialog when pressing OK.
</member>
<member name="dialog_text" type="String" setter="set_text" getter="get_text">
The text displayed by this dialog.
@ -69,7 +70,7 @@
<signals>
<signal name="confirmed">
<description>
Emitted when the dialog is accepted.
Emitted when the dialog is accepted, i.e. the OK button is pressed.
</description>
</signal>
<signal name="custom_action">