maxmustermann/godot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #27868 from marxin/add-more-warnings

Browse source 
Add more warnings on top of -Wall and -Wextra.
This commit is contained in:
Hein-Pieter van Braam 2019-04-23 06:00:49 +03:00 committed by GitHub
parent 05ef1f4998 4134f9e161
commit 4068e79a32
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
SConstruct
View file

@ -347,11 +347,18 @@ if selected_platform in platform_list:
if (env["warnings"] == 'extra'):
# FIXME: enable -Wclobbered once #26351 is fixed
# FIXME: enable -Wlogical-op and -Wduplicated-branches once #27594 is merged
# Note: enable -Wimplicit-fallthrough for Clang (already part of -Wextra for GCC)
# once we switch to C++11 or later (necessary for our FALLTHROUGH macro).
env.Append(CCFLAGS=['-Wall', '-Wextra', '-Wno-unused-parameter'] + all_plus_warnings + shadow_local_warning)
env.Append(CCFLAGS=['-Wall', '-Wextra', '-Wno-unused-parameter',
'-Wctor-dtor-privacy', '-Wnon-virtual-dtor']
+ all_plus_warnings + shadow_local_warning)
if methods.using_gcc(env):
env['CCFLAGS'] += ['-Wno-clobbered']
env['CCFLAGS'] += ['-Wno-clobbered', '-Walloc-zero', '-Wnoexcept',
'-Wduplicated-cond', '-Wplacement-new=1', '-Wstringop-overflow=4']
version = methods.get_compiler_version(env)
if version != None and version[0] >= '9':
env['CCFLAGS'] += ['-Wattribute-alias=2']
elif (env["warnings"] == 'all'):
env.Append(CCFLAGS=['-Wall'] + shadow_local_warning)
elif (env["warnings"] == 'moderate'):