maxmustermann/godot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #30404 from Calinou/add-spotlight-configuration-warning

Browse source 
Add a configuration warning when using ultrawide SpotLight with shadows
This commit is contained in:
Rémi Verschelde 2019-07-09 08:28:47 +02:00 committed by GitHub
parent c2cf640753 cdd41d446f
commit 675b9cb4c2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
scene/3d/light.cpp
View file

@ -51,6 +51,7 @@ void Light::set_param(Param p_param, float p_value) {
if (p_param == PARAM_SPOT_ANGLE) {
_change_notify("spot_angle");
update_configuration_warning();
} else if (p_param == PARAM_RANGE) {
_change_notify("omni_range");
_change_notify("spot_range");
@ -68,6 +69,10 @@ void Light::set_shadow(bool p_enable) {
shadow = p_enable;
VS::get_singleton()->light_set_shadow(light, p_enable);
if (type == VisualServer::LIGHT_SPOT) {
update_configuration_warning();
}
}
bool Light::has_shadow() const {
@ -465,6 +470,20 @@ OmniLight::OmniLight() :
set_shadow_detail(SHADOW_DETAIL_HORIZONTAL);
}
String SpotLight::get_configuration_warning() const {
String warning = Light::get_configuration_warning();
if (has_shadow() && get_param(PARAM_SPOT_ANGLE) >= 90.0) {
if (warning != String()) {
warning += "\n\n";
}
warning += TTR("A SpotLight with an angle wider than 90 degrees cannot cast shadows.");
}
return warning;
}
void SpotLight::_bind_methods() {
ADD_GROUP("Spot", "spot_");

2
scene/3d/light.h
View file

@ -221,6 +221,8 @@ protected:
static void _bind_methods();
public:
virtual String get_configuration_warning() const;
SpotLight() :
Light(VisualServer::LIGHT_SPOT) {}
};